Re: [Freedreno] [PATCH v1 2/3] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-06-02 Thread Dmitry Baryshkov
Generic note: please use reply-to-all instead of any other options to answer the email. You have dropped all recipients (except the freedreno@) in the message (and it was left unnoticed). On Fri, 2 Jun 2023 at 20:00, Kuogee Hsieh wrote: > >> There is one option which is keep current > >> > >> 1

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-06-02 Thread Kuogee Hsieh
There is one option which is keep current 1) keep struct drm_dsc_config *msm_dsi_get_dsc_config(struct msm_dsi *msm_dsi) at dsi.c 2) use struct msm_display_info *disp_info saved at dpu_enc to locate struct msm_dsi from priv->dsi[] list (see item #3) 3) info.dsc = msm_dsi_get_dsc_config(pr

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-06-01 Thread Dmitry Baryshkov
On Thu, 1 Jun 2023 at 20:37, Kuogee Hsieh wrote: > > > On 5/31/2023 10:53 AM, Dmitry Baryshkov wrote: > > On Wed, 31 May 2023 at 20:29, Kuogee Hsieh wrote: > >> > >> On 5/31/2023 10:12 AM, Dmitry Baryshkov wrote: > >>> On Wed, 31 May 2023 at 18:41, Kuogee Hsieh > >>> wrote: > > >>

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-06-01 Thread Kuogee Hsieh
On 5/31/2023 10:53 AM, Dmitry Baryshkov wrote: On Wed, 31 May 2023 at 20:29, Kuogee Hsieh wrote: On 5/31/2023 10:12 AM, Dmitry Baryshkov wrote: On Wed, 31 May 2023 at 18:41, Kuogee Hsieh wrote: +if (dpu_enc->disp_info.intf_type == DRM_MODE_ENCODER_DSI) { INTF_DSI +str

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-05-31 Thread Dmitry Baryshkov
On Wed, 31 May 2023 at 20:29, Kuogee Hsieh wrote: > > > On 5/31/2023 10:12 AM, Dmitry Baryshkov wrote: > > On Wed, 31 May 2023 at 18:41, Kuogee Hsieh wrote: > >> > >> > +if (dpu_enc->disp_info.intf_type == DRM_MODE_ENCODER_DSI) { > >>> INTF_DSI > >>> > +struct drm_bridge

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-05-31 Thread Kuogee Hsieh
On 5/31/2023 10:12 AM, Dmitry Baryshkov wrote: On Wed, 31 May 2023 at 18:41, Kuogee Hsieh wrote: +if (dpu_enc->disp_info.intf_type == DRM_MODE_ENCODER_DSI) { INTF_DSI +struct drm_bridge *bridge; + +if (!dpu_enc->dsc) { This condition is not correct. We should be

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-05-31 Thread Dmitry Baryshkov
On Wed, 31 May 2023 at 18:41, Kuogee Hsieh wrote: > > > > >> +if (dpu_enc->disp_info.intf_type == DRM_MODE_ENCODER_DSI) { > > > > INTF_DSI > > > >> +struct drm_bridge *bridge; > >> + > >> +if (!dpu_enc->dsc) { > > > > This condition is not correct. We should be updating the D

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-05-31 Thread Kuogee Hsieh
  +    if (dpu_enc->disp_info.intf_type == DRM_MODE_ENCODER_DSI) { INTF_DSI +    struct drm_bridge *bridge; + +    if (!dpu_enc->dsc) { This condition is not correct. We should be updating the DSC even if there is one. +    bridge = drm_bridge_chain_get_first_bridge(d

Re: [Freedreno] [PATCH v1 2/3] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-05-30 Thread Dmitry Baryshkov
On 30/05/2023 19:31, Kuogee Hsieh wrote: At current implementation, DSI DSC struct is populated at display setup during system bootup. This mechanism works fine with embedded display. But will run into problem with plugin/unplug oriented external display, such as DP, due to DSC struct will become

[Freedreno] [PATCH v1 2/3] drm/msm/dpu: retrieve DSI DSC struct at atomic_check()

2023-05-30 Thread Kuogee Hsieh
At current implementation, DSI DSC struct is populated at display setup during system bootup. This mechanism works fine with embedded display. But will run into problem with plugin/unplug oriented external display, such as DP, due to DSC struct will become stale once external display unplugged. New