Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2019-01-04 Thread Stephen Boyd
Quoting Rajendra Nayak (2019-01-03 00:45:53) > > On 12/29/2018 6:59 AM, Stephen Boyd wrote: > >> So I am guessing the conclusion is to use a fallback "operating-points-v2" > >> compatible*only* when we do have opp-hz along with qcom,level (as in the > >> case with gpu) and not have a fallback com

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2019-01-03 Thread Rajendra Nayak
On 12/29/2018 6:59 AM, Stephen Boyd wrote: So I am guessing the conclusion is to use a fallback "operating-points-v2" compatible*only* when we do have opp-hz along with qcom,level (as in the case with gpu) and not have a fallback compatible in cases when we don't have opp-hz (as in the case of

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-28 Thread Stephen Boyd
Quoting Rajendra Nayak (2018-12-20 20:52:34) > > On 12/21/2018 2:59 AM, Stephen Boyd wrote: > > Quoting Rob Herring (2018-12-19 15:47:25) > >> On Wed, Dec 19, 2018 at 4:40 PM Doug Anderson > >> wrote: > >>> On Wed, Dec 19, 2018 at 12:40 PM Doug Anderson > >>> wrote: > On Wed, Dec 19, 2018

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-20 Thread Rajendra Nayak
On 12/21/2018 2:59 AM, Stephen Boyd wrote: Quoting Rob Herring (2018-12-19 15:47:25) On Wed, Dec 19, 2018 at 4:40 PM Doug Anderson wrote: On Wed, Dec 19, 2018 at 12:40 PM Doug Anderson wrote: On Wed, Dec 19, 2018 at 12:09 PM Rob Herring wrote: ...but it does have a frequency, doesn't it?

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-20 Thread Stephen Boyd
Quoting Rob Herring (2018-12-19 15:47:25) > On Wed, Dec 19, 2018 at 4:40 PM Doug Anderson wrote: > > On Wed, Dec 19, 2018 at 12:40 PM Doug Anderson > > wrote: > > > On Wed, Dec 19, 2018 at 12:09 PM Rob Herring wrote: > > > ...but it does have a frequency, doesn't it? > > > > > > + compatible

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-19 Thread Rob Herring
On Wed, Dec 19, 2018 at 4:40 PM Doug Anderson wrote: > > Hi, > > On Wed, Dec 19, 2018 at 12:40 PM Doug Anderson wrote: > > > > Hi, > > > > On Wed, Dec 19, 2018 at 12:09 PM Rob Herring wrote: > > > > > > On Tue, Dec 18, 2018 at 10:49 PM Viresh Kumar > > > wrote: > > > > > > > > On 18-12-18, 11:

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-19 Thread Doug Anderson
Hi, On Wed, Dec 19, 2018 at 12:40 PM Doug Anderson wrote: > > Hi, > > On Wed, Dec 19, 2018 at 12:09 PM Rob Herring wrote: > > > > On Tue, Dec 18, 2018 at 10:49 PM Viresh Kumar > > wrote: > > > > > > On 18-12-18, 11:05, Doug Anderson wrote: > > > > OK, it's fine with me to have the fallback, bu

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-19 Thread Doug Anderson
Hi, On Wed, Dec 19, 2018 at 12:09 PM Rob Herring wrote: > > On Tue, Dec 18, 2018 at 10:49 PM Viresh Kumar wrote: > > > > On 18-12-18, 11:05, Doug Anderson wrote: > > > OK, it's fine with me to have the fallback, but if we do we should be > > > consistent about it and make sure it's in all the bi

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-19 Thread Rob Herring
On Tue, Dec 18, 2018 at 10:49 PM Viresh Kumar wrote: > > On 18-12-18, 11:05, Doug Anderson wrote: > > OK, it's fine with me to have the fallback, but if we do we should be > > consistent about it and make sure it's in all the bindings and device > > tree files... > > Sure. > > I am not sure what's

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-18 Thread Viresh Kumar
On 18-12-18, 11:05, Doug Anderson wrote: > OK, it's fine with me to have the fallback, but if we do we should be > consistent about it and make sure it's in all the bindings and device > tree files... Sure. I am not sure what's the right way to do it is, i.e. should we keep the "operating-points-

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-18 Thread Doug Anderson
Hi, On Tue, Dec 18, 2018 at 10:40 AM Stephen Boyd wrote: > > Quoting Doug Anderson (2018-12-17 16:34:31) > > Hi, > > > > On Sun, Dec 16, 2018 at 11:06 PM Viresh Kumar > > wrote: > > > > > > +Rob +Stephen, > > > > > > On 14-12-18, 09:04, Doug Anderson wrote: > > > > Hi, > > > > > > > > On Thu, D

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-18 Thread Stephen Boyd
Quoting Doug Anderson (2018-12-17 16:34:31) > Hi, > > On Sun, Dec 16, 2018 at 11:06 PM Viresh Kumar wrote: > > > > +Rob +Stephen, > > > > On 14-12-18, 09:04, Doug Anderson wrote: > > > Hi, > > > > > > On Thu, Dec 13, 2018 at 8:41 PM Viresh Kumar > > > wrote: > > > > > > > > On 12-12-18, 14:18,

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-17 Thread Doug Anderson
Hi, On Sun, Dec 16, 2018 at 11:06 PM Viresh Kumar wrote: > > +Rob +Stephen, > > On 14-12-18, 09:04, Doug Anderson wrote: > > Hi, > > > > On Thu, Dec 13, 2018 at 8:41 PM Viresh Kumar > > wrote: > > > > > > On 12-12-18, 14:18, Jordan Crouse wrote: > > > > + gpu_opp_table: opp-

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-16 Thread Viresh Kumar
+Rob +Stephen, On 14-12-18, 09:04, Doug Anderson wrote: > Hi, > > On Thu, Dec 13, 2018 at 8:41 PM Viresh Kumar wrote: > > > > On 12-12-18, 14:18, Jordan Crouse wrote: > > > + gpu_opp_table: opp-table { > > > + compatible = > > > "operating-points-

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-14 Thread Doug Anderson
Hi, On Thu, Dec 13, 2018 at 8:41 PM Viresh Kumar wrote: > > On 12-12-18, 14:18, Jordan Crouse wrote: > > + gpu_opp_table: opp-table { > > + compatible = "operating-points-v2-qcom-level"; > > I think you need to mention "operating-points-v2" as well

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-13 Thread Viresh Kumar
On 12-12-18, 14:18, Jordan Crouse wrote: > + gpu_opp_table: opp-table { > + compatible = "operating-points-v2-qcom-level"; I think you need to mention "operating-points-v2" as well here. -- viresh ___ Fre

Re: [Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-13 Thread Doug Anderson
Hi, On Wed, Dec 12, 2018 at 1:18 PM Jordan Crouse wrote: > > Add the nodes to describe the Adreno GPU and GMU devices. > > Signed-off-by: Jordan Crouse > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 123 +++ > 1 file changed, 123 insertions(+) > > diff --git a/arch/arm64

[Freedreno] [PATCH v6 2/2] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-12-12 Thread Jordan Crouse
Add the nodes to describe the Adreno GPU and GMU devices. Signed-off-by: Jordan Crouse --- arch/arm64/boot/dts/qcom/sdm845.dtsi | 123 +++ 1 file changed, 123 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi index 23