Re: [Freedreno] [PATCH v7 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-14 Thread Doug Anderson
Hi, On Thu, Apr 14, 2022 at 2:16 PM Dmitry Baryshkov wrote: > > > Hmm, interesting. Probably for DRM_BRIDGE_OP_MODES that will work? > > It's definitely worth confirming but from my reading of the code it > > _probably_ wouldn't hurt. > > > > One thing someone would want to confirm would be what

Re: [Freedreno] [PATCH v7 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-14 Thread Dmitry Baryshkov
On 14/04/2022 23:09, Doug Anderson wrote: Hi, On Thu, Apr 14, 2022 at 12:40 PM Stephen Boyd wrote: Quoting Dmitry Baryshkov (2022-04-14 12:16:14) I think it's too verbose and a bit incorrect. Not sure which part you're asserting is incorrect, but shorter is OK w/ me too. I was referring

Re: [Freedreno] [PATCH v7 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-14 Thread Doug Anderson
Hi, On Thu, Apr 14, 2022 at 12:40 PM Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-04-14 12:16:14) > > > > I think it's too verbose and a bit incorrect. Not sure which part you're asserting is incorrect, but shorter is OK w/ me too. > > This is a bit saner: > > /* > > * These ops do

Re: [Freedreno] [PATCH v7 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-14 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-04-14 12:16:14) > > I think it's too verbose and a bit incorrect. > This is a bit saner: > /* > * These ops do not make sense for eDP, since they are provided > * by the panel-bridge corresponding to the attached eDP panel. > */ > > My question was whether we re

Re: [Freedreno] [PATCH v7 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-14 Thread Dmitry Baryshkov
On 14/04/2022 19:39, Doug Anderson wrote: Hi, On Thu, Apr 14, 2022 at 5:20 AM Sankeerth Billakanti wrote: @@ -1530,6 +1532,60 @@ void msm_dp_debugfs_init(struct msm_dp *dp_display, struct drm_minor *minor) } } +static int dp_display_get_next_bridge(struct msm_dp *dp) +{ + i

Re: [Freedreno] [PATCH v7 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-14 Thread Doug Anderson
Hi, On Thu, Apr 14, 2022 at 5:20 AM Sankeerth Billakanti wrote: > > @@ -1530,6 +1532,60 @@ void msm_dp_debugfs_init(struct msm_dp *dp_display, > struct drm_minor *minor) > } > } > > +static int dp_display_get_next_bridge(struct msm_dp *dp) > +{ > + int rc; > + struct dp_disp

[Freedreno] [PATCH v7 1/4] drm/msm/dp: Add eDP support via aux_bus

2022-04-14 Thread Sankeerth Billakanti
This patch adds support for generic eDP sink through aux_bus. The eDP/DP controller driver should support aux transactions originating from the panel-edp driver and hence should be initialized and ready. The panel bridge supporting the panel should be ready before the bridge connector is initializ