Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-26 Thread Dmitry Baryshkov
On Fri, 27 Oct 2023 at 01:56, Bjorn Andersson wrote: > > On Wed, Oct 04, 2023 at 03:31:24AM +0300, Dmitry Baryshkov wrote: > > clk_rcg2_shared_ops implements support for the case of the RCG which > > must not be completely turned off. However its design has one major > > drawback: it doesn't allow

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-26 Thread Bjorn Andersson
On Wed, Oct 04, 2023 at 03:31:24AM +0300, Dmitry Baryshkov wrote: > clk_rcg2_shared_ops implements support for the case of the RCG which > must not be completely turned off. However its design has one major > drawback: it doesn't allow us to properly implement the is_enabled > callback, which cause

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-26 Thread Dmitry Baryshkov
On Thu, 26 Oct 2023 at 23:49, Konrad Dybcio wrote: > > > > On 10/26/23 22:47, Dmitry Baryshkov wrote: > > On Thu, 26 Oct 2023 at 21:57, Konrad Dybcio > > wrote: > >> > >> > >> > >> On 10/7/23 01:43, Konrad Dybcio wrote: > >>> On 4.10.2023 02:31, Dmitry Baryshkov wrote: > clk_rcg2_shared_ops

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-26 Thread Konrad Dybcio
On 10/26/23 22:47, Dmitry Baryshkov wrote: On Thu, 26 Oct 2023 at 21:57, Konrad Dybcio wrote: On 10/7/23 01:43, Konrad Dybcio wrote: On 4.10.2023 02:31, Dmitry Baryshkov wrote: clk_rcg2_shared_ops implements support for the case of the RCG which must not be completely turned off. Howeve

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-26 Thread Dmitry Baryshkov
On Thu, 26 Oct 2023 at 21:57, Konrad Dybcio wrote: > > > > On 10/7/23 01:43, Konrad Dybcio wrote: > > On 4.10.2023 02:31, Dmitry Baryshkov wrote: > >> clk_rcg2_shared_ops implements support for the case of the RCG which > >> must not be completely turned off. However its design has one major > >>

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-26 Thread Konrad Dybcio
On 10/7/23 01:43, Konrad Dybcio wrote: On 4.10.2023 02:31, Dmitry Baryshkov wrote: clk_rcg2_shared_ops implements support for the case of the RCG which must not be completely turned off. However its design has one major drawback: it doesn't allow us to properly implement the is_enabled callba

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-25 Thread Dmitry Baryshkov
On 07/10/2023 13:08, Bryan O'Donoghue wrote: On 07/10/2023 00:45, Konrad Dybcio wrote: On 4.10.2023 14:52, Bryan O'Donoghue wrote: On 04/10/2023 13:08, Dmitry Baryshkov wrote: On Wed, 4 Oct 2023 at 12:27, Bryan O'Donoghue wrote: On 04/10/2023 01:31, Dmitry Baryshkov wrote: clk_rcg2_shared_

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-07 Thread Bryan O'Donoghue
On 07/10/2023 00:45, Konrad Dybcio wrote: On 4.10.2023 14:52, Bryan O'Donoghue wrote: On 04/10/2023 13:08, Dmitry Baryshkov wrote: On Wed, 4 Oct 2023 at 12:27, Bryan O'Donoghue wrote: On 04/10/2023 01:31, Dmitry Baryshkov wrote: clk_rcg2_shared_ops implements support for the case of the RCG

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-06 Thread Konrad Dybcio
On 4.10.2023 14:52, Bryan O'Donoghue wrote: > On 04/10/2023 13:08, Dmitry Baryshkov wrote: >> On Wed, 4 Oct 2023 at 12:27, Bryan O'Donoghue >> wrote: >>> >>> On 04/10/2023 01:31, Dmitry Baryshkov wrote: clk_rcg2_shared_ops implements support for the case of the RCG which must not be comp

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-06 Thread Konrad Dybcio
On 4.10.2023 02:31, Dmitry Baryshkov wrote: > clk_rcg2_shared_ops implements support for the case of the RCG which > must not be completely turned off. However its design has one major > drawback: it doesn't allow us to properly implement the is_enabled > callback, which causes different kinds of m

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-04 Thread Dmitry Baryshkov
On 04/10/2023 15:52, Bryan O'Donoghue wrote: On 04/10/2023 13:08, Dmitry Baryshkov wrote: On Wed, 4 Oct 2023 at 12:27, Bryan O'Donoghue wrote: On 04/10/2023 01:31, Dmitry Baryshkov wrote: clk_rcg2_shared_ops implements support for the case of the RCG which must not be completely turned off.

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-04 Thread Bryan O'Donoghue
On 04/10/2023 13:08, Dmitry Baryshkov wrote: On Wed, 4 Oct 2023 at 12:27, Bryan O'Donoghue wrote: On 04/10/2023 01:31, Dmitry Baryshkov wrote: clk_rcg2_shared_ops implements support for the case of the RCG which must not be completely turned off. However its design has one major drawback: it

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-04 Thread Dmitry Baryshkov
On Wed, 4 Oct 2023 at 12:27, Bryan O'Donoghue wrote: > > On 04/10/2023 01:31, Dmitry Baryshkov wrote: > > clk_rcg2_shared_ops implements support for the case of the RCG which > > must not be completely turned off. However its design has one major > > drawback: it doesn't allow us to properly imple

Re: [Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-04 Thread Bryan O'Donoghue
On 04/10/2023 01:31, Dmitry Baryshkov wrote: clk_rcg2_shared_ops implements support for the case of the RCG which must not be completely turned off. However its design has one major drawback: it doesn't allow us to properly implement the is_enabled callback, which causes different kinds of misbeh

[Freedreno] [RFC PATCH 1/2] clk: qcom: implement RCG2 'parked' clock support

2023-10-03 Thread Dmitry Baryshkov
clk_rcg2_shared_ops implements support for the case of the RCG which must not be completely turned off. However its design has one major drawback: it doesn't allow us to properly implement the is_enabled callback, which causes different kinds of misbehaviour from the CCF. Follow the idea behind cl