Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-06 Thread Neil Armstrong
On 06/07/2023 09:59, Maxime Ripard wrote: On Thu, Jul 06, 2023 at 09:33:15AM +0200, Neil Armstrong wrote: On 06/07/2023 09:24, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 11:09:40PM +0300, Dmitry Baryshkov wrote: On 05/07/2023 19:53, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 06:20:13PM +0

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-06 Thread Maxime Ripard
On Thu, Jul 06, 2023 at 09:33:15AM +0200, Neil Armstrong wrote: > On 06/07/2023 09:24, Maxime Ripard wrote: > > On Wed, Jul 05, 2023 at 11:09:40PM +0300, Dmitry Baryshkov wrote: > > > On 05/07/2023 19:53, Maxime Ripard wrote: > > > > On Wed, Jul 05, 2023 at 06:20:13PM +0300, Dmitry Baryshkov wrote:

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-06 Thread Neil Armstrong
On 06/07/2023 09:24, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 11:09:40PM +0300, Dmitry Baryshkov wrote: On 05/07/2023 19:53, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 06:20:13PM +0300, Dmitry Baryshkov wrote: On Wed, 5 Jul 2023 at 17:24, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 0

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-06 Thread Maxime Ripard
On Wed, Jul 05, 2023 at 11:09:40PM +0300, Dmitry Baryshkov wrote: > On 05/07/2023 19:53, Maxime Ripard wrote: > > On Wed, Jul 05, 2023 at 06:20:13PM +0300, Dmitry Baryshkov wrote: > > > On Wed, 5 Jul 2023 at 17:24, Maxime Ripard wrote: > > > > > > > > On Wed, Jul 05, 2023 at 04:37:57PM +0300, Dmi

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Dmitry Baryshkov
On 05/07/2023 19:53, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 06:20:13PM +0300, Dmitry Baryshkov wrote: On Wed, 5 Jul 2023 at 17:24, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 04:37:57PM +0300, Dmitry Baryshkov wrote: Either way, I'm not really sure it's a good idea to multiply the ca

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Maxime Ripard
On Wed, Jul 05, 2023 at 06:20:13PM +0300, Dmitry Baryshkov wrote: > On Wed, 5 Jul 2023 at 17:24, Maxime Ripard wrote: > > > > On Wed, Jul 05, 2023 at 04:37:57PM +0300, Dmitry Baryshkov wrote: > > > > > > > > > > > > Either way, I'm not really sure it's a good idea to multiply the > > > > > > capab

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Neil Armstrong
On 05/07/2023 16:24, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 04:37:57PM +0300, Dmitry Baryshkov wrote: Either way, I'm not really sure it's a good idea to multiply the capabilities flags of the DSI host, and we should just stick to the spec. If the spec says that we have to support DSC whi

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Dmitry Baryshkov
On Wed, 5 Jul 2023 at 17:24, Maxime Ripard wrote: > > On Wed, Jul 05, 2023 at 04:37:57PM +0300, Dmitry Baryshkov wrote: > > > > > > > > > > Either way, I'm not really sure it's a good idea to multiply the > > > > > capabilities flags of the DSI host, and we should just stick to the > > > > > spec.

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Maxime Ripard
On Wed, Jul 05, 2023 at 04:37:57PM +0300, Dmitry Baryshkov wrote: > > > > > > > > Either way, I'm not really sure it's a good idea to multiply the > > > > capabilities flags of the DSI host, and we should just stick to the > > > > spec. If the spec says that we have to support DSC while video is >

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Dmitry Baryshkov
On 05/07/2023 16:29, Maxime Ripard wrote: On Wed, Jul 05, 2023 at 03:05:33PM +0200, Neil Armstrong wrote: On 05/07/2023 14:04, Maxime Ripard wrote: Hi, On Tue, May 30, 2023 at 03:36:04PM +0300, Dmitry Baryshkov wrote: On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: Il 30/05/23 13:44,

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Maxime Ripard
On Wed, Jul 05, 2023 at 03:05:33PM +0200, Neil Armstrong wrote: > On 05/07/2023 14:04, Maxime Ripard wrote: > > Hi, > > > > On Tue, May 30, 2023 at 03:36:04PM +0300, Dmitry Baryshkov wrote: > > > On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: > > > > Il 30/05/23 13:44, Dmitry Baryshkov ha

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Neil Armstrong
On 05/07/2023 14:04, Maxime Ripard wrote: Hi, On Tue, May 30, 2023 at 03:36:04PM +0300, Dmitry Baryshkov wrote: On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: Hi Marijn, Dmitry, Cale

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-07-05 Thread Maxime Ripard
Hi, On Tue, May 30, 2023 at 03:36:04PM +0300, Dmitry Baryshkov wrote: > On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: > > Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: > > > On Tue, 30 May 2023 at 10:24, Neil Armstrong > > > wrote: > > > > > > > > Hi Marijn, Dmitry, Caleb, Jessica, >

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-05-31 Thread AngeloGioacchino Del Regno
Il 30/05/23 17:44, Neil Armstrong ha scritto: On 30/05/2023 14:36, Dmitry Baryshkov wrote: On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: Hi Marijn, Dmitry, Caleb, Jessica, On 29/05/

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-05-30 Thread Neil Armstrong
On 30/05/2023 14:36, Dmitry Baryshkov wrote: On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: Hi Marijn, Dmitry, Caleb, Jessica, On 29/05/2023 23:11, Marijn Suijten wrote: On 2023-05-2

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-05-30 Thread Dmitry Baryshkov
On 30/05/2023 15:15, AngeloGioacchino Del Regno wrote: Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: Hi Marijn, Dmitry, Caleb, Jessica, On 29/05/2023 23:11, Marijn Suijten wrote: On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: +   if (

Re: [Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-05-30 Thread AngeloGioacchino Del Regno
Il 30/05/23 13:44, Dmitry Baryshkov ha scritto: On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: Hi Marijn, Dmitry, Caleb, Jessica, On 29/05/2023 23:11, Marijn Suijten wrote: On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: + if (ctx->dsi->dsc) { dsi->dsc is always set, thus this con

[Freedreno] RFC: DSI host capabilities (was: [PATCH RFC 03/10] drm/panel: Add LGD panel driver for Sony Xperia XZ3)

2023-05-30 Thread Dmitry Baryshkov
On Tue, 30 May 2023 at 10:24, Neil Armstrong wrote: > > Hi Marijn, Dmitry, Caleb, Jessica, > > On 29/05/2023 23:11, Marijn Suijten wrote: > > On 2023-05-22 04:16:20, Dmitry Baryshkov wrote: > > > >>> + if (ctx->dsi->dsc) { > >> > >> dsi->dsc is always set, thus this condition can be dropped. >