Re: [PATCH] drm/msm/dp: fix the max supported bpp logic

2024-07-30 Thread Abhinav Kumar
On 7/29/2024 1:08 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2024-07-29 11:28:35) Thanks for the feedback. Your change looks valid. We can use this and drop the max_t usage. Let me push this with your Suggested-by credits. You can take my Signed-off-by: Stephen Boyd and either squ

Re: [PATCH] drm/msm/dp: fix the max supported bpp logic

2024-07-29 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-07-29 11:28:35) > > Thanks for the feedback. > > Your change looks valid. We can use this and drop the max_t usage. > > Let me push this with your Suggested-by credits. You can take my Signed-off-by: Stephen Boyd and either squash it in or make a follow-up.

Re: [PATCH] drm/msm/dp: fix the max supported bpp logic

2024-07-29 Thread Abhinav Kumar
On 7/27/2024 5:51 AM, Dmitry Baryshkov wrote: On Fri, 26 Jul 2024 at 01:04, Abhinav Kumar wrote: Currently the DP driver hard-codes the max supported bpp to 30. This is incorrect because the number of lanes and max data rate supported by the lanes need to be taken into account. Replace the

Re: [PATCH] drm/msm/dp: fix the max supported bpp logic

2024-07-29 Thread Abhinav Kumar
Hi Stephen On 7/26/2024 5:24 PM, Stephen Boyd wrote: Quoting Abhinav Kumar (2024-07-25 15:03:19) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index a916b5f3b317..56ce5e4008f8 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.c +++ b/drivers/gpu/drm/msm/dp/dp_pa

Re: [PATCH] drm/msm/dp: fix the max supported bpp logic

2024-07-27 Thread Dmitry Baryshkov
On Fri, 26 Jul 2024 at 01:04, Abhinav Kumar wrote: > > Currently the DP driver hard-codes the max supported bpp to 30. > This is incorrect because the number of lanes and max data rate > supported by the lanes need to be taken into account. > > Replace the hardcoded limit with the appropriate math

Re: [PATCH] drm/msm/dp: fix the max supported bpp logic

2024-07-26 Thread Stephen Boyd
Quoting Abhinav Kumar (2024-07-25 15:03:19) > diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c > b/drivers/gpu/drm/msm/dp/dp_panel.c > index a916b5f3b317..56ce5e4008f8 100644 > --- a/drivers/gpu/drm/msm/dp/dp_panel.c > +++ b/drivers/gpu/drm/msm/dp/dp_panel.c > @@ -423,8 +424,10 @@ int dp_panel_init_

[PATCH] drm/msm/dp: fix the max supported bpp logic

2024-07-25 Thread Abhinav Kumar
Currently the DP driver hard-codes the max supported bpp to 30. This is incorrect because the number of lanes and max data rate supported by the lanes need to be taken into account. Replace the hardcoded limit with the appropriate math which accounts for the accurate number of lanes and max data r