Re: [Freedreno] [RFC 1/4] drm/msm/dpu: introduce a wb_idx to be used for writeback interfaces

2022-04-22 Thread Dmitry Baryshkov
On Fri, 22 Apr 2022 at 21:18, Abhinav Kumar wrote: > > Hi Dmitry > > On 4/22/2022 3:37 AM, Dmitry Baryshkov wrote: > > On Fri, 22 Apr 2022 at 04:59, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 4/21/2022 5:22 PM, Dmitry Baryshkov wrote: > >>> On Fri, 22 Apr 2022 at 02:07, Abhinav Kumar > >>

Re: [Freedreno] [RFC 1/4] drm/msm/dpu: introduce a wb_idx to be used for writeback interfaces

2022-04-22 Thread Abhinav Kumar
Hi Dmitry On 4/22/2022 3:37 AM, Dmitry Baryshkov wrote: On Fri, 22 Apr 2022 at 04:59, Abhinav Kumar wrote: On 4/21/2022 5:22 PM, Dmitry Baryshkov wrote: On Fri, 22 Apr 2022 at 02:07, Abhinav Kumar wrote: Hi Dmitry Thanks for the review. One question below. On 4/21/2022 3:40 PM, Dmitr

Re: [Freedreno] [RFC 1/4] drm/msm/dpu: introduce a wb_idx to be used for writeback interfaces

2022-04-22 Thread Dmitry Baryshkov
On Fri, 22 Apr 2022 at 04:59, Abhinav Kumar wrote: > > > > On 4/21/2022 5:22 PM, Dmitry Baryshkov wrote: > > On Fri, 22 Apr 2022 at 02:07, Abhinav Kumar > > wrote: > >> > >> Hi Dmitry > >> > >> Thanks for the review. > >> > >> One question below. > >> > >> On 4/21/2022 3:40 PM, Dmitry Baryshkov

Re: [Freedreno] [RFC 1/4] drm/msm/dpu: introduce a wb_idx to be used for writeback interfaces

2022-04-21 Thread Abhinav Kumar
On 4/21/2022 5:22 PM, Dmitry Baryshkov wrote: On Fri, 22 Apr 2022 at 02:07, Abhinav Kumar wrote: Hi Dmitry Thanks for the review. One question below. On 4/21/2022 3:40 PM, Dmitry Baryshkov wrote: On 21/04/2022 23:48, Abhinav Kumar wrote: Using intf_idx even for writeback interfaces is

Re: [Freedreno] [RFC 1/4] drm/msm/dpu: introduce a wb_idx to be used for writeback interfaces

2022-04-21 Thread Dmitry Baryshkov
On Fri, 22 Apr 2022 at 02:07, Abhinav Kumar wrote: > > Hi Dmitry > > Thanks for the review. > > One question below. > > On 4/21/2022 3:40 PM, Dmitry Baryshkov wrote: > > On 21/04/2022 23:48, Abhinav Kumar wrote: > >> Using intf_idx even for writeback interfaces is confusing > >> because intf_idx i

Re: [Freedreno] [RFC 1/4] drm/msm/dpu: introduce a wb_idx to be used for writeback interfaces

2022-04-21 Thread Abhinav Kumar
Hi Dmitry Thanks for the review. One question below. On 4/21/2022 3:40 PM, Dmitry Baryshkov wrote: On 21/04/2022 23:48, Abhinav Kumar wrote: Using intf_idx even for writeback interfaces is confusing because intf_idx is of type enum dpu_intf but the index used for writeback is of type enum dpu

Re: [Freedreno] [RFC 1/4] drm/msm/dpu: introduce a wb_idx to be used for writeback interfaces

2022-04-21 Thread Dmitry Baryshkov
On 21/04/2022 23:48, Abhinav Kumar wrote: Using intf_idx even for writeback interfaces is confusing because intf_idx is of type enum dpu_intf but the index used for writeback is of type enum dpu_wb. In addition, this makes it easier to separately check the availability of the two as its possible