URL: https://github.com/freeipa/freeipa/pull/6119 Author: flo-renaud Title: #6119: ipatests: fix TestOTPToken::test_check_otpd_after_idle_timeout Action: opened
PR body: """ The test sets 389-ds nsslapd-idletimeout to 60s, then does a kinit with an otp token (which makes ipa-otpd create a LDAP connection), then sleeps for 60s. The expectation is that ns-slapd will detect that the LDAP conn from ipa-otpd is idle and close the connection. According to 389ds doc, the idle timeout is enforced when the connection table is walked. By doing a ldapsearch, the test "wakes up" ns-slapd and forces the detection of ipa-otpd idle connection. Fixes: https://pagure.io/freeipa/issue/9044 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/6119/head:pr6119 git checkout pr6119
From cb919567e1326f9826ddc319e54c5d360f98a288 Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud <f...@redhat.com> Date: Sun, 5 Dec 2021 17:38:58 +0100 Subject: [PATCH 1/2] ipatests: fix TestOTPToken::test_check_otpd_after_idle_timeout The test sets 389-ds nsslapd-idletimeout to 60s, then does a kinit with an otp token (which makes ipa-otpd create a LDAP connection), then sleeps for 60s. The expectation is that ns-slapd will detect that the LDAP conn from ipa-otpd is idle and close the connection. According to 389ds doc, the idle timeout is enforced when the connection table is walked. By doing a ldapsearch, the test "wakes up" ns-slapd and forces the detection of ipa-otpd idle connection. Fixes: https://pagure.io/freeipa/issue/9044 Signed-off-by: Florence Blanc-Renaud <f...@redhat.com> --- ipatests/test_integration/test_otp.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ipatests/test_integration/test_otp.py b/ipatests/test_integration/test_otp.py index 35347089796..d8ce527ca08 100644 --- a/ipatests/test_integration/test_otp.py +++ b/ipatests/test_integration/test_otp.py @@ -354,6 +354,9 @@ def test_check_otpd_after_idle_timeout(self, setup_otp_nsslapd): otpvalue = totp.generate(int(time.time())).decode("ascii") kinit_otp(self.master, USER, password=PASSWORD, otp=otpvalue) time.sleep(60) + # ldapsearch will wake up slapd and force walking through + # the connection list, in order to spot the idle connections + tasks.ldapsearch_dm(self.master, "", ldap_args=[], scope="base") def test_cb(cmd_jornalctl): # check if LDAP connection is timed out From 4f69429b67e11078fbc80000c0b2fa759ae6b36f Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud <f...@redhat.com> Date: Sun, 5 Dec 2021 17:44:10 +0100 Subject: [PATCH 2/2] Temp commit --- .freeipa-pr-ci.yaml | 2 +- ipatests/prci_definitions/temp_commit.yaml | 33 ++++++++++++++++++++-- 2 files changed, 31 insertions(+), 4 deletions(-) diff --git a/.freeipa-pr-ci.yaml b/.freeipa-pr-ci.yaml index abcf8c5b634..80656690080 120000 --- a/.freeipa-pr-ci.yaml +++ b/.freeipa-pr-ci.yaml @@ -1 +1 @@ -ipatests/prci_definitions/gating.yaml \ No newline at end of file +ipatests/prci_definitions/temp_commit.yaml \ No newline at end of file diff --git a/ipatests/prci_definitions/temp_commit.yaml b/ipatests/prci_definitions/temp_commit.yaml index 31935bf044a..211c53bf945 100644 --- a/ipatests/prci_definitions/temp_commit.yaml +++ b/ipatests/prci_definitions/temp_commit.yaml @@ -61,14 +61,41 @@ jobs: timeout: 1800 topology: *build - fedora-latest/temp_commit: + fedora-latest/test_otp: requires: [fedora-latest/build] priority: 50 job: class: RunPytest args: build_url: '{fedora-latest/build_url}' - test_suite: test_integration/test_REPLACEME.py + test_suite: test_integration/test_otp.py template: *ci-master-latest timeout: 3600 - topology: *master_1repl_1client + topology: *master_1repl + + fedora-rawhide/build: + requires: [] + priority: 100 + job: + class: Build + args: + git_repo: '{git_repo}' + git_refspec: '{git_refspec}' + template: &ci-master-frawhide + name: freeipa/ci-master-frawhide + version: 0.5.2 + timeout: 1800 + topology: *build + + fedora-rawhide/test_otp: + requires: [fedora-rawhide/build] + priority: 50 + job: + class: RunPytest + args: + build_url: '{fedora-rawhide/build_url}' + update_packages: True + test_suite: test_integration/test_otp.py + template: *ci-master-frawhide + timeout: 3600 + topology: *master_1repl
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
