URL: https://github.com/freeipa/freeipa/pull/3201 Author: mrizwan93 Title: #3201: [Backport][ipa-4-6] ipatest : Test if ipactl restart restarts the pki-tomcatd Action: opened
PR body: """ Wrong logic was triggering the start instead of restart for pki-tomcatd. This test validates that restart called on pki-tomcat properly. related ticket : https://pagure.io/freeipa/issue/7927 Signed-off-by: Mohammad Rizwan Yusuf <myu...@redhat.com> Reviewed-By: Rob Crittenden <rcrit...@redhat.com> Reviewed-By: Florence Blanc-Renaud <f...@redhat.com> Reviewed-By: Tibor Dudlak <tdud...@redhat.com> """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/3201/head:pr3201 git checkout pr3201
From 53ad8c99c2982249ea61fa89c55933ca8d1eec18 Mon Sep 17 00:00:00 2001 From: Mohammad Rizwan Yusuf <myu...@redhat.com> Date: Tue, 21 May 2019 11:45:20 +0530 Subject: [PATCH] Test if ipactl restart restarts the pki-tomcatd Wrong logic was triggering the start instead of restart for pki-tomcatd. This test validates that restart called on pki-tomcat properly. related ticket : https://pagure.io/freeipa/issue/7927 Signed-off-by: Mohammad Rizwan Yusuf <myu...@redhat.com> Reviewed-By: Rob Crittenden <rcrit...@redhat.com> Reviewed-By: Florence Blanc-Renaud <f...@redhat.com> Reviewed-By: Tibor Dudlak <tdud...@redhat.com> --- .../test_integration/test_installation.py | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/ipatests/test_integration/test_installation.py b/ipatests/test_integration/test_installation.py index e09e9f2a40..1fae00003c 100644 --- a/ipatests/test_integration/test_installation.py +++ b/ipatests/test_integration/test_installation.py @@ -353,6 +353,16 @@ def test_replica1_all_components_adtrust(self): self.install_replica(self.replicas[1], setup_ca=True, setup_kra=True) +def get_pki_tomcatd_pid(host): + pid = '' + cmd = host.run_command(['systemctl', 'status', 'pki-tomcatd@pki-tomcat']) + for line in cmd.stdout_text.split('\n'): + if "Main PID" in line: + pid = line.split()[2] + break + return(pid) + + ## # Rest of master installation tests ## @@ -374,6 +384,34 @@ def test_install_kra(self): def test_install_dns(self): tasks.install_dns(self.master) + def test_ipactl_restart_pki_tomcat(self): + """ Test if ipactl restart restarts the pki-tomcatd + + Wrong logic was triggering the start instead of restart + for pki-tomcatd. This test validates that restart + called on pki-tomcat properly. + + related ticket : https://pagure.io/freeipa/issue/7927 + """ + # get process id of pki-tomcatd + pki_pid = get_pki_tomcatd_pid(self.master) + + # check if pki-tomcad restarted + cmd = self.master.run_command(['ipactl', 'restart']) + assert "Restarting pki-tomcatd Service" in cmd.stdout_text + + # check if pid for pki-tomcad changed + pki_pid_after_restart = get_pki_tomcatd_pid(self.master) + assert pki_pid != pki_pid_after_restart + + # check if pki-tomcad restarted + cmd = self.master.run_command(['ipactl', 'restart']) + assert "Restarting pki-tomcatd Service" in cmd.stdout_text + + # check if pid for pki-tomcad changed + pki_pid_after_restart_2 = get_pki_tomcatd_pid(self.master) + assert pki_pid_after_restart != pki_pid_after_restart_2 + def test_WSGI_worker_process(self): """ Test if WSGI worker process count is set to 4
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org
