URL: https://github.com/freeipa/freeipa/pull/3915 Author: mrizwan93 Title: #3915: [Backport][ipa-4-6] Tests for autounmembership feature Action: opened
PR body: """ New feature of autounmembership added in 389-ds-base https://pagure.io/389-ds-base/issue/50077 Tests for autounmembership feature has been added in this PR Signed-off-by: Kaleemullah Siddiqui <ksidd...@redhat.com> Reviewed-By: Florence Blanc-Renaud <f...@redhat.com> Reviewed-By: Sergey Orlov <sor...@redhat.com> """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/3915/head:pr3915 git checkout pr3915
From 7f87c4f58e513a00b1cbefb88ccdfb69e88d69bb Mon Sep 17 00:00:00 2001 From: Kaleemullah Siddiqui <ksidd...@redhat.com> Date: Mon, 20 May 2019 13:03:12 +0530 Subject: [PATCH] Tests for autounmembership feature New feature of autounmembership added in 389-ds-base https://pagure.io/389-ds-base/issue/50077 Tests for autounmembership feature has been added in this PR Signed-off-by: Kaleemullah Siddiqui <ksidd...@redhat.com> Reviewed-By: Florence Blanc-Renaud <f...@redhat.com> Reviewed-By: Sergey Orlov <sor...@redhat.com> --- .../prci_definitions/nightly_ipa-4-6.yaml | 12 + ipatests/test_integration/test_automember.py | 253 ++++++++++++++++++ 2 files changed, 265 insertions(+) create mode 100644 ipatests/test_integration/test_automember.py diff --git a/ipatests/prci_definitions/nightly_ipa-4-6.yaml b/ipatests/prci_definitions/nightly_ipa-4-6.yaml index 82e717e9e5..2006bf0d36 100644 --- a/ipatests/prci_definitions/nightly_ipa-4-6.yaml +++ b/ipatests/prci_definitions/nightly_ipa-4-6.yaml @@ -1050,3 +1050,15 @@ jobs: template: *ci-master-f27 timeout: 7200 topology: *master_1repl + + fedora-27/automember: + requires: [fedora-27/build] + priority: 50 + job: + class: RunPytest + args: + build_url: '{fedora-27/build_url}' + test_suite: test_integration/test_automember.py + template: *ci-master-f27 + timeout: 7200 + topology: *master_1repl diff --git a/ipatests/test_integration/test_automember.py b/ipatests/test_integration/test_automember.py new file mode 100644 index 0000000000..517ab3712c --- /dev/null +++ b/ipatests/test_integration/test_automember.py @@ -0,0 +1,253 @@ +# +# Copyright (C) 2019 FreeIPA Contributors see COPYING for license +# +"""This covers tests for automemberfeature.""" + +from __future__ import absolute_import + +from ipapython.dn import DN + +from ipatests.pytest_ipa.integration import tasks +from ipatests.test_integration.base import IntegrationTest + + +class TestAutounmembership(IntegrationTest): + """Tests for autounmembership feature. + + This test class covers the tests for this feature described in + https://pagure.io/389-ds-base/issue/50077 . + """ + topology = 'line' + dn = DN( + ('cn', 'Auto Membership Plugin'), ('cn', 'plugins'), + ('cn', 'config') + ) + + def automember_group_add(self, group): + """Add group/automember entry.""" + cmdlist = [['ipa', 'group-add', '--desc=%s' % group, group], + ['ipa', 'automember-add', '--type=group', group], + ['ipa', 'automember-add-condition', + '--key=destinationindicator', '--type=group', + '--inclusive-regex=%s' % group, group]] + for cmd in cmdlist: + self.master.run_command(cmd) + + def user_automember_setup(self, group, user, first, last): + """Add user entry.""" + self.master.run_command(['ipa', 'user-add', '--first=%s' % first, + '--last=%s' % last, user, + '--setattr=destinationindicator=%s' % group]) + + def user_automember_mod(self, group, user): + """Modify user entry.""" + self.master.run_command(['ipa', 'user-mod', user, + '--setattr=destinationindicator=%s' % group]) + + def remove_user_automember(self, user, raiseonerr=True): + """Delete user entry.""" + self.master.run_command(['ipa', 'user-del', user], + raiseonerr=raiseonerr) + + def automember_group_cleanup(self, group): + """Cleanup of automember/group entry.""" + cmdlist = [['ipa', 'automember-del', '--type=group', group], + ['ipa', 'group-del', group]] + for cmd in cmdlist: + self.master.run_command(cmd, raiseonerr=False) + + def is_user_member_of_group(self, user, group): + """Check membership of user in the group.""" + result = self.master.run_command(['ipa', 'group-show', group]) + return user in result.stdout_text + + def automember_hostgroup_add(self, hostgroup): + """Add hostgroup/automember entry.""" + cmdlist = [['ipa', 'hostgroup-add', '--desc=%s' % hostgroup, + hostgroup], + ['ipa', 'automember-add', '--type=hostgroup', hostgroup], + ['ipa', 'automember-add-condition', + '--key=nshostlocation', '--type=hostgroup', + '--inclusive-regex=%s' % hostgroup, hostgroup]] + for cmd in cmdlist: + self.master.run_command(cmd) + + def host_automember_setup(self, hostgroup, host): + """Add host entry.""" + self.master.run_command(['ipa', 'host-add', host, '--location=%s' + % hostgroup, '--force']) + + def host_automember_mod(self, hostgroup, host): + """Modify host entry.""" + self.master.run_command(['ipa', 'host-mod', host, '--location=%s' + % hostgroup]) + + def remove_host_automember(self, host, raiseonerr=True): + """Delete host entry.""" + self.master.run_command(['ipa', 'host-del', host], + raiseonerr=raiseonerr) + + def automember_hostgroup_cleanup(self, hostgroup): + """Cleanup of automember/hostgroup entry.""" + cmdlist = [['ipa', 'automember-del', '--type=hostgroup', hostgroup], + ['ipa', 'hostgroup-del', hostgroup]] + for cmd in cmdlist: + self.master.run_command(cmd, raiseonerr=False) + + def is_host_member_of_hostgroup(self, host, hostgroup): + """Check membership of host in the hostgroup.""" + result = self.master.run_command(['ipa', 'hostgroup-show', hostgroup]) + return host in result.stdout_text + + def check_autounmembership_in_ldap(self, state='on'): + """Check autounmembership state.""" + conn = self.master.ldap_connect() + entry = conn.get_entry(self.dn) # pylint: disable=no-member + assert state == entry.single_value['automemberprocessmodifyops'] + + def disable_autounmembership_in_ldap(self): + """Disable autounmembership.""" + conn = self.master.ldap_connect() + entry = conn.get_entry(self.dn) # pylint: disable=no-member + entry.single_value['automemberprocessmodifyops'] = 'off' + conn.update_entry(entry) # pylint: disable=no-member + self.master.run_command(['ipactl', 'restart']) + + def test_modify_user_entry_unmembership(self): + """Test when autounmembership feature is enabled. + + Test that an update on a user entry triggers a re-evaluation of the + user's automember groups when auto-unmembership is active. + """ + try: + # testcase setup + tasks.kinit_admin(self.master) + self.check_autounmembership_in_ldap(state='on') + group1 = 'DallasUsers' + group2 = 'HoustonUsers' + user1 = 'user1' + first = 'first' + last = 'user' + self.automember_group_add(group1) + self.automember_group_add(group2) + self.user_automember_setup(group1, user1, first, last) + assert self.is_user_member_of_group(user1, group1) + + # Modifying the user group so that it becomes part of new group + self.user_automember_mod(group2, user1) + assert self.is_user_member_of_group(user1, group2) + assert not self.is_user_member_of_group(user1, group1) + + # Deleting the user entry and checking its not part of group now + self.remove_user_automember(user1) + assert not self.is_user_member_of_group(user1, group2) + + finally: + # testcase cleanup + self.remove_user_automember(user1, raiseonerr=False) + self.automember_group_cleanup(group1) + self.automember_group_cleanup(group2) + + def test_modify_host_entry_unmembership(self): + """Test when autounmembership feature is enabled. + + Test that an update on a host entry triggers a re-evaluation of the + host's automember groups when auto-unmembership is active. + """ + try: + # testcase setup + self.check_autounmembership_in_ldap(state='on') + hostgroup1 = 'Brno' + hostgroup2 = 'Boston' + host1 = 'host1.example.com' + self.automember_hostgroup_add(hostgroup1) + self.automember_hostgroup_add(hostgroup2) + self.host_automember_setup(hostgroup1, host1) + assert self.is_host_member_of_hostgroup(host1, hostgroup1) + + # Modifying the user group so that it becomes part of new group + self.host_automember_mod(hostgroup2, host1) + assert self.is_host_member_of_hostgroup(host1, hostgroup2) + assert not self.is_host_member_of_hostgroup(host1, hostgroup1) + + # Deleting the user entry and checking its not part of group now + self.remove_host_automember(host1) + assert not self.is_host_member_of_hostgroup(host1, hostgroup2) + + finally: + # testcase cleanup + self.remove_host_automember(host1, raiseonerr=False) + self.automember_hostgroup_cleanup(hostgroup1) + self.automember_hostgroup_cleanup(hostgroup2) + + def test_modify_user_entry_unmembership_disabled(self): + """Test when autounmembership feature is disabled. + + Test that an update on a user entry does not triggers re-evaluation of + the user's automember groups when auto-unmembership is disabled. + """ + try: + # testcase setup + self.disable_autounmembership_in_ldap() + self.check_autounmembership_in_ldap(state='off') + group1 = 'PuneUsers' + group2 = 'BrnoUsers' + user2 = 'user2' + first = 'second' + last = 'user' + self.automember_group_add(group1) + self.automember_group_add(group2) + self.user_automember_setup(group1, user2, first, last) + assert self.is_user_member_of_group(user2, group1) + + # Modifying the user group so that it becomes part of new group + self.user_automember_mod(group2, user2) + assert not self.is_user_member_of_group(user2, group2) + assert self.is_user_member_of_group(user2, group1) + + # Running automember-build so that user is part of correct group + self.master.run_command(['ipa', 'automember-rebuild', + '--users=%s' % user2]) + assert self.is_user_member_of_group(user2, group2) + assert not self.is_user_member_of_group(user2, group1) + + finally: + # testcase cleanup + self.remove_user_automember(user2, raiseonerr=False) + self.automember_group_cleanup(group1) + self.automember_group_cleanup(group2) + + def test_modify_host_entry_unmembership_disabled(self): + """Test when autounmembership feature is disabled. + + Test that an update on a host entry does not triggers re-evaluation of + the host's automember groups when auto-unmembership is disabled. + """ + try: + # testcase setup + self.check_autounmembership_in_ldap(state='off') + hostgroup1 = 'Pune' + hostgroup2 = 'Raleigh' + host2 = 'host2.example.com' + self.automember_hostgroup_add(hostgroup1) + self.automember_hostgroup_add(hostgroup2) + self.host_automember_setup(hostgroup1, host2) + assert self.is_host_member_of_hostgroup(host2, hostgroup1) + + # Modifying the user group so that it becomes part of new group + self.host_automember_mod(hostgroup2, host2) + assert not self.is_host_member_of_hostgroup(host2, hostgroup2) + assert self.is_host_member_of_hostgroup(host2, hostgroup1) + + # Running the automember-build so host is part of correct hostgroup + self.master.run_command( + ['ipa', 'automember-rebuild', '--hosts=%s' % host2] + ) + assert self.is_host_member_of_hostgroup(host2, hostgroup2) + assert not self.is_host_member_of_hostgroup(host2, hostgroup1) + + finally: + # testcase cleanup + self.remove_host_automember(host2, raiseonerr=False) + self.automember_hostgroup_cleanup(hostgroup1) + self.automember_hostgroup_cleanup(hostgroup2)
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org
