URL: https://github.com/freeipa/freeipa/pull/4306 Author: netoarmando Title: #4306: [ipa-4-6] Travis: Enable IPv6 support for Docker Action: opened
PR body: """ Environment variable `TRAVIS` is not accessible inside the container anymore, passing it to the container didn't have the same effect expected by the hack this commit removes. However, enabling IPv6, as described in https://github.com/travis-ci/travis-ci/issues/8891, was effective to execute the tests. Issue: https://pagure.io/freeipa/issue/8213 Signed-off-by: Armando Neto <abiag...@redhat.com> """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/4306/head:pr4306 git checkout pr4306
From 65d6f30b8bba71536f264445ea754180d8972d71 Mon Sep 17 00:00:00 2001 From: Armando Neto <abiag...@redhat.com> Date: Wed, 4 Mar 2020 22:25:34 -0300 Subject: [PATCH] Travis: Enable IPv6 support for Docker Environment variable 'TRAVIS' is not accessible inside the container anymore, passing it to the container didn't have the same effect expected by the hack this commit removes. However, enabling IPv6, as described in https://github.com/travis-ci/travis-ci/issues/8891, was effective to execute the tests. Issue: https://pagure.io/freeipa/issue/8213 Signed-off-by: Armando Neto <abiag...@redhat.com> --- .travis.yml | 4 ++++ ipaplatform/redhat/tasks.py | 6 ------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index e63cc52fe1..4620ace3cd 100644 --- a/.travis.yml +++ b/.travis.yml @@ -59,6 +59,10 @@ before_install: - ip addr show - ls /proc/net - cat /proc/net/if_inet6 + # Enable IPv6 back in Travis CI + # https://github.com/travis-ci/travis-ci/issues/8891 + - echo '{"ipv6":true,"fixed-cidr-v6":"2001:db8:1::/64"}' | sudo tee /etc/docker/daemon.json + - sudo service docker restart # - ip addr show dev lo | grep -q inet6 || (echo "No IPv6 address found"; exit 1) install: diff --git a/ipaplatform/redhat/tasks.py b/ipaplatform/redhat/tasks.py index 8f6dc9a037..51914a78b7 100644 --- a/ipaplatform/redhat/tasks.py +++ b/ipaplatform/redhat/tasks.py @@ -152,12 +152,6 @@ def check_ipv6_stack_enabled(self): "globally, disable it on the specific interfaces in " "sysctl.conf except 'lo' interface.") - # XXX This is a hack to work around an issue with Travis CI by - # skipping IPv6 address test. The Dec 2017 update removed ::1 from - # loopback, see https://github.com/travis-ci/travis-ci/issues/8891. - if os.environ.get('TRAVIS') == 'true': - return - try: localhost6 = ipautil.CheckedIPAddress('::1', allow_loopback=True) if localhost6.get_matching_interface() is None:
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org
