URL: https://github.com/freeipa/freeipa/pull/5006 Author: fcami Title: #5006: IPA-EPN: use entry.get() to retrieve attributes Action: opened
PR body: """ Use entry.get() to retrieve attributes to avoid tripping on missing attrs. Fixes: TBD Signed-off-by: François Cami <fc...@redhat.com> """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/5006/head:pr5006 git checkout pr5006
From b3c69af0013378a96b956a1f995aec266beb3d34 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Cami?= <fc...@redhat.com> Date: Thu, 6 Aug 2020 17:07:36 +0200 Subject: [PATCH] IPA-EPN: use entry.get() to retrieve attributes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use entry.get() to retrieve attributes to avoid tripping on missing attrs. Fixes: TBD Signed-off-by: François Cami <fc...@redhat.com> --- ipaclient/install/ipa_epn.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ipaclient/install/ipa_epn.py b/ipaclient/install/ipa_epn.py index 6e1b001464..c7ce58fdba 100644 --- a/ipaclient/install/ipa_epn.py +++ b/ipaclient/install/ipa_epn.py @@ -131,14 +131,14 @@ def add(self, entry): self._sorted = False self._expiring_password_user_dq.append( dict( - uid=str(entry["uid"].pop(0)), - cn=str(entry["cn"].pop(0)), - givenname=str(entry["givenname"].pop(0)), - sn=str(entry["sn"].pop(0)), + uid=str(entry.get("uid")), + cn=str(entry.get("cn")), + givenname=str(entry.get("givenname")), + sn=str(entry.get("sn")), krbpasswordexpiration=str( - entry["krbpasswordexpiration"].pop(0) + entry.get("krbpasswordexpiration") ), - mail=str(entry["mail"]), + mail=str(entry.get("mail")), ) ) except IndexError as e:
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org