URL: https://github.com/freeipa/freeipa/pull/797 Author: flo-renaud Title: #797: ipa-replica-conncheck: handle ssh not installed Action: opened
PR body: """ When ipa-replica-conncheck is run but ssh is not installed, the tool exits with a stack trace. Properly handle the error by raising an Exception. https://pagure.io/freeipa/issue/6935 """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/797/head:pr797 git checkout pr797
From 49a61da60e33da5af32ce176b83bb2a6b7efe779 Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud <f...@redhat.com> Date: Thu, 18 May 2017 17:01:19 +0200 Subject: [PATCH] ipa-replica-conncheck: handle ssh not installed When ipa-replica-conncheck is run but ssh is not installed, the tool exits with a stack trace. Properly handle the error by raising an Exception. https://pagure.io/freeipa/issue/6935 --- install/tools/ipa-replica-conncheck | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/install/tools/ipa-replica-conncheck b/install/tools/ipa-replica-conncheck index fdbd4f3..9ee2fc0 100755 --- a/install/tools/ipa-replica-conncheck +++ b/install/tools/ipa-replica-conncheck @@ -63,8 +63,7 @@ class SshExec(object): def __call__(self, command, verbose=False): # Bail if ssh is not installed if self.cmd is None: - root_logger.warning("WARNING: ssh not installed, skipping ssh test") - return ('', '', 0) + raise RuntimeError("ssh not installed, skipping ssh test") tmpf = tempfile.NamedTemporaryFile() cmd = [
_______________________________________________ FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
