Re: [Freeipa-devel] [PATCH] 369 fix word usage in installer

2010-02-03 Thread David O'Brien
Rob Crittenden wrote: Proper use of "set up" vs "setup". rob I don't know how pedantic you want to get in these messages, but: 1. "setup" is a noun 2. "set up" is a verb 3. "set-up" is a compound adjective So, for print "on the computer (i.e. a non-root user). The set up procedure" If you'

[Freeipa-devel] [PATCH] 374 don't make assumptions about cwd

2010-02-03 Thread Rob Crittenden
Don't assume that cwd exists or is writable. I had worked on this previously so that we change to a known writable directory when issuing server certs. Enhance that so we change to the NSS db dir when issuing the self-signed CA. certutil wants to write a file to the cwd when generating a key so

[Freeipa-devel] [PATCH] 373 fix ipa-getkeytab man page

2010-02-03 Thread Rob Crittenden
The usage on the man page didn't follow standard conventions. Optional arguments shouldn't be enclosed in brackets []. rob freeipa-373-man.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.

Re: [Freeipa-devel] [PATCH] 370 set default log level

2010-02-03 Thread John Dennis
On 02/03/2010 04:27 PM, Rob Crittenden wrote: The ipa-*-manage programs had the default log level set to NOTSET which was causing copious logging to occur. Setting it to ERROR fixes this. ACK -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___

[Freeipa-devel] [PATCH] 371 add status to ipactl

2010-02-03 Thread Rob Crittenden
We had an RFE for adding status to ipactl, seemed like low-hanging fruit (bug 503437) rob freeipa-371-ipactl.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-d

[Freeipa-devel] [PATCH] 370 set default log level

2010-02-03 Thread Rob Crittenden
The ipa-*-manage programs had the default log level set to NOTSET which was causing copious logging to occur. Setting it to ERROR fixes this. rob freeipa-370-log.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.

Re: [Freeipa-devel] [PATCH] 353 enable sssd and certmonger

2010-02-03 Thread Rob Crittenden
Martin Nagy wrote: On Wed, 2010-01-20 at 17:01 -0500, Rob Crittenden wrote: Configure sssd and certmonger in ipa-client-install This does a number of things under the hood: - Use authconfig to enable sssd in nss and pam - Configure /etc/sssd/sssd.conf to use our IPA provider - Enable the certm

[Freeipa-devel] [PATCH] 369 fix word usage in installer

2010-02-03 Thread Rob Crittenden
Proper use of "set up" vs "setup". rob freeipa-369-setup.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] fix install example error

2010-02-03 Thread Rob Crittenden
I pushed this patch under the 1-line trivial rule. I just changed the command name in the sample we provide at the end of installation: --- a/install/tools/ipa-server-install +++ b/install/tools/ipa-server-install @@ -798,7 +798,7 @@ def main(): print "\t\t * 123: ntp" print ""

Re: [Freeipa-devel] [PATCH] fix error message to be i18n translator friendly

2010-02-03 Thread Rob Crittenden
John Dennis wrote: This error message was producing a warning from xgettext because there were multiple substations in the string. In some languages it may be necessary to reorder the substitutions for a proper translation, this is only possible if the substitutions use named values. --- ipaserv

Re: [Freeipa-devel] [PATCH] 355 allow named to use ldapi

2010-02-03 Thread Rob Crittenden
John Dennis wrote: On 01/27/2010 02:53 PM, Rob Crittenden wrote: Add SELinux rules so named can communicate to the DS over ldapi. This should fix the installation error when --setup-dns is set and SELinux is enforcing. ACK to the patch of selinux/ipa_httpd/ipa_httpd.te which is *not* the subj

Re: [Freeipa-devel] [PATCH] 357 ipa-server-install man updates

2010-02-03 Thread Rob Crittenden
John Dennis wrote: On 01/27/2010 05:27 PM, Rob Crittenden wrote: Bring ipa-server-install man page up-to-date, fix some syntax errors: Remove a bunch of trailing spaces Add the --ca option Add the --no-host-dns option Add the --subject option Fix the one-character option for --no-ntp, should be

Re: [Freeipa-devel] [PATCH 363 find all group pwd policy

2010-02-03 Thread Rob Crittenden
Pavel Zuna wrote: Rob Crittenden wrote: Provide pwpolicy-find command to display all group-specific password policies. find is a bit of a misnomer since you can't provide any terms to limit the search scope, but it's a start. I'm not sure this is the kind of thing we need/want to be able to

Re: [Freeipa-devel] [PATCH] 359 allow cert renewal

2010-02-03 Thread Rob Crittenden
John Dennis wrote: On 01/28/2010 04:16 PM, Rob Crittenden wrote: Rob Crittenden wrote: Be a bit smarter about decoding certificates that might be base64 encoded. First see if it only contains those characters allowed before trying to decode it. This reduces the number of false positives. rob

Re: [Freeipa-devel] [PATCH] 366 don't reset log level

2010-02-03 Thread Rob Crittenden
John Dennis wrote: On 02/02/2010 05:22 PM, Rob Crittenden wrote: Don't let the framework reset the log level of an existing log handler. In the installer we initialize logging and set the log level of the install/uninstall log to DEBUG. When we initialize the framework later it resets the log le

Re: [Freeipa-devel] [PATCH] jderose 038 Fix ipalib doctest

2010-02-03 Thread Rob Crittenden
Jason Gerard DeRose wrote: This patch fixes doctests in ipalib/__init__.py that were broken by Rob's "364 base64-encode binary data..." patch. This patch also removes the unneeded use of textui.encode_binary() in the textui.print_keyval() method. repr('cannot print me') will escape non-ascii ch

Re: [Freeipa-devel] [PATCH] jderose 037 Fix broken unit tests

2010-02-03 Thread Rob Crittenden
Jason Gerard DeRose wrote: This patch gets (almost) all the XML-RPC tests working again under Fedora12. Some may not pass under Fedora11 due to 389 schema changes, but Fedora12 should be our primary test target at this point, IHMO. Does anyone disagree? 3 cert tests still fail, but I'm not fami

Re: [Freeipa-devel] [PATCH] Remove (un)wrap_binary_data cruft from */ipautil.py

2010-02-03 Thread Rob Crittenden
John Dennis wrote: On 02/03/2010 05:07 AM, Jason Gerard DeRose wrote: Could you submit this again? Done, attached. This patch has already been committed. Jason, btw what I did was to copy the entire message, headers and all, and give that to git-am. It was able to grok things ok. The upda

Re: [Freeipa-devel] [PATCH] Remove (un)wrap_binary_data cruft from */ipautil.py

2010-02-03 Thread John Dennis
On 02/03/2010 05:07 AM, Jason Gerard DeRose wrote: Could you submit this again? Done, attached. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From 6d65b8faeb6ec69bfba4e7674ce1fa4379b959c9 Mon Sep 17 00:00:00 2001 From: John Dennis Date: Thu, 28 Jan 2010 11:19:

[Freeipa-devel] [PATCH] jderose 038 Fix ipalib doctest

2010-02-03 Thread Jason Gerard DeRose
This patch fixes doctests in ipalib/__init__.py that were broken by Rob's "364 base64-encode binary data..." patch. This patch also removes the unneeded use of textui.encode_binary() in the textui.print_keyval() method. repr('cannot print me') will escape non-ascii characters using the Python \xH

Re: [Freeipa-devel] [PATCH] Remove (un)wrap_binary_data cruft from */ipautil.py

2010-02-03 Thread Jason Gerard DeRose
On Thu, 2010-01-28 at 12:35 -0500, John Dennis wrote: > Remove SAFE_STRING_PATTERN, safe_string_re, needs_base64(), > wrap_binary_data(), unwrap_binary_data() from both instances > of ipautil.py. This code is no longer in use and the > SAFE_STRING_PATTERN regular expression string was causing xgett