Re: [Freeipa-devel] [PATCH] Splitting service principal into service name and hostname.

2010-09-09 Thread Adam Young
On 09/09/2010 07:00 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! The EntityBuilder has been modified to obtain the pkey value by invoking getPKey(). This function can be overriden for different entities. The addOptionsFunction() has been renamed to getOptions() an

[Freeipa-devel] [PATCH] Splitting service principal into service name and hostname.

2010-09-09 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! The EntityBuilder has been modified to obtain the pkey value by invoking getPKey(). This function can be overriden for different entities. The addOptionsFunction() has been renamed to getOptions() and it can be overriden for different entities. Each

[Freeipa-devel] [PATCH] 524 spec file cleanup

2010-09-09 Thread Rob Crittenden
Clean up the spec file, add Requires for nss-pam-ldapd for F14+ Also do the following: - Remove conflicts on mod_ssl - Remove a lot of version checking for EOL'd Fedora versions - Add a few conditionals for rhel6 - Add Requires of nss-tools on ipa-client tickets 62, 153 rob >From 54798a542589a0

[Freeipa-devel] [PATCH] 523 add 2 missing man pages

2010-09-09 Thread Rob Crittenden
Add missing man pages for ipa-dns-install and ipa-upgradeconfig. tickets 130 and 131 rob >From 725bfc9bbe6ef353d48e01cfdfdd4af20a330bec Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Thu, 9 Sep 2010 17:59:04 -0400 Subject: [PATCH] Add missing man pageas for ipa-dns-install and ipa-upgradec

Re: [Freeipa-devel] [PATCH] 521 fix updater tests

2010-09-09 Thread Adam Young
On 09/09/2010 04:18 PM, Rob Crittenden wrote: Fix the updater tests. These are not normally run, you need to put the DM password into a file in ~/.ipa. We dropped some schema that these tests were using which caused the failure. Should work now. rob __

Re: [Freeipa-devel] Fwd: [Freeipa-users] [PATCH] 512 track server certs with certmonger

2010-09-09 Thread Rob Crittenden
Adam Young wrote: On 09/08/2010 10:13 PM, Rob Crittenden wrote: Adam Young wrote: On 08/16/2010 06:00 PM, Rob Crittenden wrote: Rob Crittenden wrote: I did it again :-( Updated patch that should apply cleanly. rob ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 518 handle errors in uninstall better

2010-09-09 Thread Rob Crittenden
Rob Crittenden wrote: Dmitri Pal wrote: Adam Young wrote: On 08/31/2010 05:27 PM, Rob Crittenden wrote: # Always start certmonger. We can't untrack something if it isn't Is this really necessary? This is the only thing that jumped out at me in the patch. Assuming it really is: Ack I have n

[Freeipa-devel] [PATCH] 522 add some ldap2 Backend tests

2010-09-09 Thread Rob Crittenden
Add some tests for using the ldap2 Backend. Fix a logic problem in ldap2:get_schema() for determining if it can fetch the schema or not. Normally we only want to do this for servers but if you pass in your own connection it will use that. rob >From f5b7d38ebf5b20940adbe4d3b19d86387c71e683 Mon

[Freeipa-devel] [PATCH] 521 fix updater tests

2010-09-09 Thread Rob Crittenden
Fix the updater tests. These are not normally run, you need to put the DM password into a file in ~/.ipa. We dropped some schema that these tests were using which caused the failure. Should work now. rob >From c378195024adc724bbf2d389f84a8748cb0cd81e Mon Sep 17 00:00:00 2001 From: Rob Crittende

Re: [Freeipa-devel] [PATCH] 2. Enabling SUDO support

2010-09-09 Thread Rob Crittenden
Dmitri Pal wrote: See patch comment for more details. ACK with these exceptions: I made a few minor changes in the ldif syntax: - remove blank lines - add missing dn: cn=schema - move SYNTAX to just before X-ORIGIN in hostMask I also fixed the SUDO service group entry, it was missing the ip

[Freeipa-devel] Optimizing for the common case: automount and DNS

2010-09-09 Thread Adam Young
Both Automount and DNS are heirarchical entities. DNS starts with a zone. Usually, a zone is a domain name, like redhat.com. It might be more specific, like devel.redhat.com. A DNS setup is going to have at a minimum one zone, and is likely to only have a single zone. A Zone is pretty mu

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0022-netgroup-associations.patch

2010-09-09 Thread Adam Young
On 09/09/2010 12:36 PM, Endi Sukma Dewata wrote: - "Adam Young" wrote: Netgroup associations: netgroups -> users, groups,hosts,hostgroups https://fedorahosted.org/freeipa/attachment/ticket/96/admiyo-freeipa-0022-netgroup-associations.patch ACK, but there are typos on lines 153

Re: [Freeipa-devel] [PATCH] admiyo-freeipa-0022-netgroup-associations.patch

2010-09-09 Thread Endi Sukma Dewata
- "Adam Young" wrote: > Netgroup associations: > netgroups -> users, groups,hosts,hostgroups > > https://fedorahosted.org/freeipa/attachment/ticket/96/admiyo-freeipa-0022-netgroup-associations.patch ACK, but there are typos on lines 153, 167, 180 in the patch. Thanks! -- Endi S. Dewata __

Re: [Freeipa-devel] Fwd: [Freeipa-users] [PATCH] 512 track server certs with certmonger

2010-09-09 Thread Adam Young
On 09/08/2010 10:13 PM, Rob Crittenden wrote: Adam Young wrote: On 08/16/2010 06:00 PM, Rob Crittenden wrote: Rob Crittenden wrote: I did it again :-( Updated patch that should apply cleanly. rob ___ Freeipa-devel mailing list Freeipa-devel@redh

Re: [Freeipa-devel] [PATCH] 520 fix install with --setup-dns

2010-09-09 Thread Rob Crittenden
Adam Young wrote: On 09/08/2010 09:02 PM, Adam Young wrote: On 09/08/2010 08:50 PM, Adam Young wrote: On 09/08/2010 08:40 PM, Adam Young wrote: On 09/08/2010 05:19 PM, Rob Crittenden wrote: Allow the schema to be set once an ldap connection is locked. When making LDAP calls via api.Backend.l