Re: [Freeipa-devel] [PATCH 59] Modify spec file to add ipa_memcached service Install &, control ipa_memcached instance

2012-02-03 Thread Simo Sorce
On Fri, 2012-02-03 at 20:23 -0500, John Dennis wrote: > On 02/03/2012 07:58 PM, Simo Sorce wrote: > > On Fri, 2012-02-03 at 19:12 -0500, John Dennis wrote: > >> On 01/25/2012 09:12 AM, Rob Crittenden wrote: > >>> John Dennis wrote: > This patch supersedes the previous patch, it corrects two is

Re: [Freeipa-devel] [PATCH 59] Modify spec file to add ipa_memcached service Install &, control ipa_memcached instance

2012-02-03 Thread John Dennis
On 02/03/2012 07:58 PM, Simo Sorce wrote: On Fri, 2012-02-03 at 19:12 -0500, John Dennis wrote: On 01/25/2012 09:12 AM, Rob Crittenden wrote: John Dennis wrote: This patch supersedes the previous patch, it corrects two issue Rob raised in a later patch review The fixed issues are: * spec fil

Re: [Freeipa-devel] [PATCH 59] Modify spec file to add ipa_memcached service Install &, control ipa_memcached instance

2012-02-03 Thread Simo Sorce
On Fri, 2012-02-03 at 19:12 -0500, John Dennis wrote: > On 01/25/2012 09:12 AM, Rob Crittenden wrote: > > John Dennis wrote: > >> This patch supersedes the previous patch, it corrects two issue Rob > >> raised in a later patch review > >> > >> The fixed issues are: > >> > >> * spec file did not ins

Re: [Freeipa-devel] [PATCH] 075 Automember UI - Fixed I18n labels

2012-02-03 Thread Endi Sukma Dewata
On 2/3/2012 4:43 AM, Petr Vobornik wrote: Hard-coded labels in Automember UI have been moved into internal.py to allow translation. Note: should be final patch for #2195 https://fedorahosted.org/freeipa/ticket/2195 This is ACKed but it depends on patch #74. -- Endi S. Dewata ___

Re: [Freeipa-devel] [PATCH] 074 Automember UI - default groups

2012-02-03 Thread Endi Sukma Dewata
On 2/2/2012 11:13 AM, Petr Vobornik wrote: In this patch was implemented and added a control for defining default automember groups. There is a difference from UXD spec. In the spec the control was placed below table in the search facet. This was not working well with the combobox in the contro

Re: [Freeipa-devel] [PATCH 59] Modify spec file to add ipa_memcached service Install &, control ipa_memcached instance

2012-02-03 Thread John Dennis
On 01/25/2012 09:12 AM, Rob Crittenden wrote: John Dennis wrote: This patch supersedes the previous patch, it corrects two issue Rob raised in a later patch review The fixed issues are: * spec file did not install ipa_memcached SysV initscript on SvsV systems. * Typo in the name of the pid fi

[Freeipa-devel] [PATCH] 940 apply some validation to some classes only

2012-02-03 Thread Rob Crittenden
There is some validation that we only need to apply when an entry is being created, namely the key itself. This is to allow us to manage an otherwise illegal entry that finds its way into the system (i.e. migration). Consider this. We migrate a group with a space in it. This isn't allowed in I

Re: [Freeipa-devel] [PATCH] 203 Add argument help to CLI

2012-02-03 Thread Rob Crittenden
Martin Kosek wrote: On Tue, 2012-01-31 at 15:38 +0100, Martin Kosek wrote: On Mon, 2012-01-30 at 11:22 -0500, Rob Crittenden wrote: Martin Kosek wrote: An example of the improved help: # ipa help user-add Purpose: Add a new user. Usage: ipa [global-options] user-add LOGIN [options] Positiona

Re: [Freeipa-devel] [PATCH] 203 Add argument help to CLI

2012-02-03 Thread Martin Kosek
On Tue, 2012-01-31 at 15:38 +0100, Martin Kosek wrote: > On Mon, 2012-01-30 at 11:22 -0500, Rob Crittenden wrote: > > Martin Kosek wrote: > > > An example of the improved help: > > > > > > # ipa help user-add > > > Purpose: Add a new user. > > > Usage: ipa [global-options] user-add LOGIN [options]

Re: [Freeipa-devel] [PATCH] 206 Improve password change error message

2012-02-03 Thread Martin Kosek
On Fri, 2012-02-03 at 10:52 -0500, Rob Crittenden wrote: > Martin Kosek wrote: > > User always receives the same error message if he changes his password > > via "ipa passwd" command and the new password fails configured > > password policy. He then has to investigate on his own the actual > > reas

Re: [Freeipa-devel] [PATCH] 208 Fix raw format for ACI commands

2012-02-03 Thread Martin Kosek
On Fri, 2012-02-03 at 10:45 -0500, Rob Crittenden wrote: > Rob Crittenden wrote: > > Martin Kosek wrote: > >> ACI plugins (permission, selfservice and delegation) were not > >> prepared to serve ACIs in a raw format, i.e. raw "aci" attribute > >> taken from LDAP. This patch fixes all these plugins

Re: [Freeipa-devel] [PATCH] 10 --no-reverse option in ipa-replica-install is not honoured

2012-02-03 Thread Rob Crittenden
Ondrej Hamada wrote: On 01/26/2012 09:24 AM, Jan Cholasta wrote: Dne 25.1.2012 17:50, Ondrej Hamada napsal(a): https://fedorahosted.org/freeipa/ticket/2161 The option '--no-reverse' was not honoured in replica-install because of wrongly placed condition checking. NACK The --no-reverse opti

[Freeipa-devel] [PATCH] 0040-0042 Fedora packages fixes merge

2012-02-03 Thread Alexander Bokovoy
Hi, attached are three patches that differentiate current freeipa-2.1.4 builds in Fedora 16/Rawhide from upstream. These are primarily to adopt to systemd and python-ldap changes. 1. freeipa-abbra-0040-inifiles-support.patch introduces a way to modify sectioned inifiles used by freedesktop.org

Re: [Freeipa-devel] [PATCH] 209 Improve migration help

2012-02-03 Thread Martin Kosek
On Fri, 2012-02-03 at 10:32 -0500, Rob Crittenden wrote: > Martin Kosek wrote: > > Improve migration help topic so that it easier understandable: > >- Add missing list of Topic commands > >- Add one more example to demonstrate migration abilities > >- Add breaks to too long lines to imp

Re: [Freeipa-devel] [PATCH] 206 Improve password change error message

2012-02-03 Thread Rob Crittenden
Martin Kosek wrote: User always receives the same error message if he changes his password via "ipa passwd" command and the new password fails configured password policy. He then has to investigate on his own the actual reason why was the policy violated. This patch improves our SLAPI PWD plugins

Re: [Freeipa-devel] [PATCH] 208 Fix raw format for ACI commands

2012-02-03 Thread Rob Crittenden
Rob Crittenden wrote: Martin Kosek wrote: ACI plugins (permission, selfservice and delegation) were not prepared to serve ACIs in a raw format, i.e. raw "aci" attribute taken from LDAP. This patch fixes all these plugins and their commands to provide provide this format. Few ACI raw format unit

Re: [Freeipa-devel] [PATCH] 207 Improve dnszone-add error message

2012-02-03 Thread Martin Kosek
On Fri, 2012-02-03 at 10:29 -0500, Rob Crittenden wrote: > Martin Kosek wrote: > > On Fri, 2012-02-03 at 10:05 -0500, Rob Crittenden wrote: > >> Martin Kosek wrote: > >>> When a new DNS record is being added to DNS zone via command > >>> ipa dnsrecord-add ZONE @ > >>> and the target ZONE does n

Re: [Freeipa-devel] [PATCH] 209 Improve migration help

2012-02-03 Thread Rob Crittenden
Martin Kosek wrote: Improve migration help topic so that it easier understandable: - Add missing list of Topic commands - Add one more example to demonstrate migration abilities - Add breaks to too long lines to improve readibility https://fedorahosted.org/freeipa/ticket/2174 ACK ___

Re: [Freeipa-devel] [PATCH] 207 Improve dnszone-add error message

2012-02-03 Thread Rob Crittenden
Martin Kosek wrote: On Fri, 2012-02-03 at 10:05 -0500, Rob Crittenden wrote: Martin Kosek wrote: When a new DNS record is being added to DNS zone via command ipa dnsrecord-add ZONE @ and the target ZONE does not exist it returns ObjectclassViolation which may confuse users. Make sure that s

Re: [Freeipa-devel] [PATCH] 210-213 Fix DNS record param issues

2012-02-03 Thread Martin Kosek
On Fri, 2012-02-03 at 17:19 +0200, Alexander Bokovoy wrote: > On Fri, 03 Feb 2012, Martin Kosek wrote: > > Endi found several issues with the new per-type DNS API. This set of > > patches fixes them all. Testing should be quite straightforward, all > > linked tickets contain failing scenarios. > >

Re: [Freeipa-devel] [PATCH] 208 Fix raw format for ACI commands

2012-02-03 Thread Rob Crittenden
Martin Kosek wrote: ACI plugins (permission, selfservice and delegation) were not prepared to serve ACIs in a raw format, i.e. raw "aci" attribute taken from LDAP. This patch fixes all these plugins and their commands to provide provide this format. Few ACI raw format unit tests were added for al

Re: [Freeipa-devel] [PATCH] 210-213 Fix DNS record param issues

2012-02-03 Thread Alexander Bokovoy
On Fri, 03 Feb 2012, Martin Kosek wrote: > Endi found several issues with the new per-type DNS API. This set of > patches fixes them all. Testing should be quite straightforward, all > linked tickets contain failing scenarios. > > Martin > >From 9a4d5f97866cd9c28d5040a88c3e6626a073417c Mon Sep 17

Re: [Freeipa-devel] [PATCH] 207 Improve dnszone-add error message

2012-02-03 Thread Martin Kosek
On Fri, 2012-02-03 at 10:05 -0500, Rob Crittenden wrote: > Martin Kosek wrote: > > When a new DNS record is being added to DNS zone via command > >ipa dnsrecord-add ZONE @ > > and the target ZONE does not exist it returns ObjectclassViolation > > which may confuse users. Make sure that standard

Re: [Freeipa-devel] [PATCH] 204 Improve netgroup-add error messages

2012-02-03 Thread Martin Kosek
On Fri, 2012-02-03 at 09:55 -0500, Rob Crittenden wrote: > Martin Kosek wrote: > > These two situations in netgroup-add need to be distinguished: > > 1) Netgroup cannot be added because a hostgroup with the same name > > created a colliding managed netgroup > > 2) Another native netgroup w

Re: [Freeipa-devel] [PATCH] 207 Improve dnszone-add error message

2012-02-03 Thread Rob Crittenden
Martin Kosek wrote: When a new DNS record is being added to DNS zone via command ipa dnsrecord-add ZONE @ and the target ZONE does not exist it returns ObjectclassViolation which may confuse users. Make sure that standard DNS Zone NotFound exception is returned. https://fedorahosted.org/freei

Re: [Freeipa-devel] [PATCH] 204 Improve netgroup-add error messages

2012-02-03 Thread Rob Crittenden
Martin Kosek wrote: These two situations in netgroup-add need to be distinguished: 1) Netgroup cannot be added because a hostgroup with the same name created a colliding managed netgroup 2) Another native netgroup with the same name exists This patch checks the colliding netgroup and ra

[Freeipa-devel] [PATCH] 210-213 Fix DNS record param issues

2012-02-03 Thread Martin Kosek
Endi found several issues with the new per-type DNS API. This set of patches fixes them all. Testing should be quite straightforward, all linked tickets contain failing scenarios. Martin >From 9a4d5f97866cd9c28d5040a88c3e6626a073417c Mon Sep 17 00:00:00 2001 From: Martin Kosek Date: Fri, 3 Feb 20

[Freeipa-devel] [PATCH] 075 Automember UI - Fixed I18n labels

2012-02-03 Thread Petr Vobornik
Hard-coded labels in Automember UI have been moved into internal.py to allow translation. Note: should be final patch for #2195 https://fedorahosted.org/freeipa/ticket/2195 -- Petr Vobornik From 397d431272b5d76a145fcb31848d9d0180e1edc6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20Voborn=C3=AD

[Freeipa-devel] [PATCH] 209 Improve migration help

2012-02-03 Thread Martin Kosek
Improve migration help topic so that it easier understandable: - Add missing list of Topic commands - Add one more example to demonstrate migration abilities - Add breaks to too long lines to improve readibility https://fedorahosted.org/freeipa/ticket/2174 >From efa96bec7a55ca5eeb06a9243fef