[Freeipa-devel] [PATCH] 133 Action list for user password

2012-05-03 Thread Petr Vobornik
Currently the user password is shown as follows in the details page: Password: Reset Password This is inconsistent with the rest of the page because the 'Reset Password' is an action, not the value of the password. Now password is shown as follows: Password: *** (if set) Pass

[Freeipa-devel] [PATCH 0019] Add proper DN escaping before LDAP library calls

2012-05-03 Thread Petr Spacek
Hello, this patch adds missing DNS->LDAP escaping conversion. It's necessary to prevent (potential) LDAP injection attacks in future. Code isn't very nice, because DNS users decimal escaping \123, LDAP uses hexadecimal escaping \ab and set of escaped characters is smaller in DNS than in LDAP

Re: [Freeipa-devel] [PATCH 0018] Deadlock detection logic

2012-05-03 Thread Adam Tkac
On Tue, Apr 24, 2012 at 03:52:00PM +0200, Petr Spacek wrote: > On 04/24/2012 03:21 PM, Petr Spacek wrote: > >Hello, > > > >this patch adds deadlock detection (based on simple timeout) to current code. > >If (probable) deadlock is detected, current action is stopped with proper > >error. > > > >It

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-03 Thread Petr Vobornik
I found that limitation of maximum pkey length in facet header is not working well. Attaching patch #134 which actually calculates it. On 05/02/2012 03:33 PM, Petr Vobornik wrote: This bunch of patches are implementing ticket #2247. They introduce some new logic and types of internal objects. T

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-03 Thread Petr Vobornik
On 05/03/2012 03:19 PM, Petr Vobornik wrote: I found that limitation of maximum pkey length in facet header is not working well. Attaching patch #134 which actually calculates it. I found useless line in the patch. Corrected version attached. On 05/02/2012 03:33 PM, Petr Vobornik wrote: Thi

Re: [Freeipa-devel] [PATCH 0019] Add proper DN escaping before LDAP library calls

2012-05-03 Thread Petr Spacek
On 05/03/2012 11:25 AM, Petr Spacek wrote: Hello, this patch adds missing DNS->LDAP escaping conversion. It's necessary to prevent (potential) LDAP injection attacks in future. Code isn't very nice, because DNS users decimal escaping \123, LDAP uses hexadecimal escaping \ab and set of escaped c

Re: [Freeipa-devel] [PATCH 0019] Add proper DN escaping before LDAP library calls

2012-05-03 Thread Petr Spacek
On 05/03/2012 11:25 AM, Petr Spacek wrote: Hello, this patch adds missing DNS->LDAP escaping conversion. It's necessary to prevent (potential) LDAP injection attacks in future. Code isn't very nice, because DNS users decimal escaping \123, LDAP uses hexadecimal escaping \ab and set of escaped c

[Freeipa-devel] [PATCH] 0045 Update hostname validator error messages in tests

2012-05-03 Thread Petr Viktorin
A recent patch changed the error message from the hostname validator. Update the tests to reflect this change. -- PetrĀ³ From f5e742206f92bfe896b2989ac4bed2900037fdbb Mon Sep 17 00:00:00 2001 From: Petr Viktorin Date: Thu, 3 May 2012 06:47:17 -0400 Subject: [PATCH] Update hostname validator err

Re: [Freeipa-devel] [PATCH] 0045 Update hostname validator error messages in tests

2012-05-03 Thread Martin Kosek
On Thu, 2012-05-03 at 16:30 +0200, Petr Viktorin wrote: > A recent patch changed the error message from the hostname > validator. Update the tests to reflect this change. > Thanks, this fixes the test failures. All tests are clean. Pushed to master, ipa-2-2. Martin

Re: [Freeipa-devel] [PATCH] 23 Allow one letter net/hostgroups names

2012-05-03 Thread Ondrej Hamada
On 05/02/2012 05:49 PM, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2671 Changed regex validating net/hostgroup names to allow single letter names. Unit-tests added. But the current validation allows weird (host|net)group names like: ".", ".-", "..". I'm just not sure, do we

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-05-03 Thread Martin Kosek
On Thu, 2012-04-26 at 15:18 +0200, Martin Kosek wrote: > On Fri, 2012-04-20 at 08:39 +0200, Martin Kosek wrote: > > On Thu, 2012-04-12 at 17:16 +0200, Martin Kosek wrote: > > > On Thu, 2012-04-12 at 18:08 +0300, Alexander Bokovoy wrote: > > > > Hi Martin! > > > > > > > > On Thu, 12 Apr 2012, Marti

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-05-03 Thread Nathan Kinder
On 05/03/2012 08:18 AM, Martin Kosek wrote: On Thu, 2012-04-26 at 15:18 +0200, Martin Kosek wrote: On Fri, 2012-04-20 at 08:39 +0200, Martin Kosek wrote: On Thu, 2012-04-12 at 17:16 +0200, Martin Kosek wrote: On Thu, 2012-04-12 at 18:08 +0300, Alexander Bokovoy wrote: Hi Martin! On Thu, 12 A

Re: [Freeipa-devel] [PATCH] 23 Allow one letter net/hostgroups names

2012-05-03 Thread Martin Kosek
On Thu, 2012-05-03 at 17:08 +0200, Ondrej Hamada wrote: > On 05/02/2012 05:49 PM, Ondrej Hamada wrote: > > https://fedorahosted.org/freeipa/ticket/2671 > > > > Changed regex validating net/hostgroup names to allow single letter > > names. Unit-tests added. > > > > But the current validation a

[Freeipa-devel] [PATCH] 0046 Don't fail when adding default objectclasses using config-mod

2012-05-03 Thread Petr Viktorin
Fix another setattr internal error that QA found. https://fedorahosted.org/freeipa/ticket/2706 -- PetrĀ³ From df68cf178e0bae0104684c482ac2f2eee8469caf Mon Sep 17 00:00:00 2001 From: Petr Viktorin Date: Wed, 2 May 2012 12:36:15 -0400 Subject: [PATCH] Don't fail when adding default objectclasses u

Re: [Freeipa-devel] More types of replica in FreeIPA

2012-05-03 Thread Ondrej Hamada
On 04/24/2012 10:47 AM, Ondrej Hamada wrote: On 04/23/2012 07:58 PM, Simo Sorce wrote: On Mon, 2012-04-23 at 13:50 -0400, Dmitri Pal wrote: Ah OK. Another semantic difference. Doing it in phases is one thing and delivering is another. Let us say we identified 10 things that needs to be implemen

Re: [Freeipa-devel] More types of replica in FreeIPA

2012-05-03 Thread Simo Sorce
On Thu, 2012-05-03 at 19:37 +0200, Ondrej Hamada wrote: > On 04/24/2012 10:47 AM, Ondrej Hamada wrote: > > On 04/23/2012 07:58 PM, Simo Sorce wrote: > >> On Mon, 2012-04-23 at 13:50 -0400, Dmitri Pal wrote: > >>> Ah OK. Another semantic difference. Doing it in phases is one thing and > >>> deliveri

[Freeipa-devel] Minor error in announcement.

2012-05-03 Thread Michael C Tiernan
Yes I'm new. I thought I'd point out, the document: [Freeipa-interest] Announcing FreeIPA v2.1.90 beta 1 Release Date: Mon, 05 Mar 2012 17:28:12 -0500 The FreeIPA team is proud to announce version 2.1.90 beta 1. This will eventually become FreeIPA v2.2.0. Has in it the link: It can be downloaded

[Freeipa-devel] Announcing FreeIPA v2.2.0 Release

2012-05-03 Thread Rob Crittenden
The FreeIPA team is proud to announce version FreeIPA v2.2.0. It can be downloaded from http://www.freeipa.org/Downloads. A build is on the way to updates-testing for Fedora 17. Fedora 15 and 16 are not supported by FreeIPA 2.2.0 due to missing dependencies. == Highlights in 2.2.0 == * Form

Re: [Freeipa-devel] Announcing FreeIPA v2.2.0 Release

2012-05-03 Thread Dmitri Pal
On 05/03/2012 03:49 PM, Rob Crittenden wrote: > The FreeIPA team is proud to announce version FreeIPA v2.2.0. > > It can be downloaded from http://www.freeipa.org/Downloads. > It can be downloaded from http://www.freeipa.org/downloads. > A build is on the way to updates-testing for Fedora 17. Fedo

Re: [Freeipa-devel] Minor error in announcement.

2012-05-03 Thread Rob Crittenden
Michael C Tiernan wrote: Yes I'm new. I thought I'd point out, the document: [Freeipa-interest] Announcing FreeIPA v2.1.90 beta 1 Release Date: Mon, 05 Mar 2012 17:28:12 -0500 The FreeIPA team is proud to announce version 2.1.90 beta 1. This will eventually become FreeIPA v2.2.0. Has in it the

Re: [Freeipa-devel] [PATCH] 0042-0048 AD trusts support (master)

2012-05-03 Thread Martin Kosek
On Thu, 2012-05-03 at 08:31 -0700, Nathan Kinder wrote: > On 05/03/2012 08:18 AM, Martin Kosek wrote: > > On Thu, 2012-04-26 at 15:18 +0200, Martin Kosek wrote: > >> On Fri, 2012-04-20 at 08:39 +0200, Martin Kosek wrote: > >>> On Thu, 2012-04-12 at 17:16 +0200, Martin Kosek wrote: > On Thu, 20