Re: [Freeipa-devel] [PATCH] 0044 Validate externalhost (when added by --addattr/--setattr)

2012-05-09 Thread Petr Viktorin
On 05/04/2012 01:25 PM, Ondrej Hamada wrote: On 04/30/2012 02:13 PM, Petr Viktorin wrote: Change the externalhost attribute of hbacrule, netgroup and sudorule into a full-fledged Parameter, and attach a validator to it. RFC 1123 specifies that only [-a-z0-9] are allowed, but apparently Windows

Re: [Freeipa-devel] [PATCH] 257 Fix python Requires in Fedora 17 build

2012-05-09 Thread Ondrej Hamada
On 05/04/2012 05:45 PM, Martin Kosek wrote: This one actually took me some time to track it down (details are in a patch description). To check the result, simply build freeipa on Fedora 17 with "make rpms", install rpms on the machine and check Requires of freeipa-admintools package: $ rpm -qR

Re: [Freeipa-devel] [PATCH 0019] Add proper DN escaping before LDAP library calls

2012-05-09 Thread Petr Spacek
On 05/09/2012 02:17 PM, Adam Tkac wrote: On 05/09/2012 02:11 PM, Petr Spacek wrote: On 05/09/2012 01:24 PM, Adam Tkac wrote: On 05/03/2012 03:46 PM, Petr Spacek wrote: On 05/03/2012 11:25 AM, Petr Spacek wrote: Hello, this patch adds missing DNS->LDAP escaping conversion. It's necessary to p

Re: [Freeipa-devel] [PATCH 0019] Add proper DN escaping before LDAP library calls

2012-05-09 Thread Adam Tkac
On 05/09/2012 02:11 PM, Petr Spacek wrote: On 05/09/2012 01:24 PM, Adam Tkac wrote: On 05/03/2012 03:46 PM, Petr Spacek wrote: On 05/03/2012 11:25 AM, Petr Spacek wrote: Hello, this patch adds missing DNS->LDAP escaping conversion. It's necessary to prevent (potential) LDAP injection attack

Re: [Freeipa-devel] [PATCH 0019] Add proper DN escaping before LDAP library calls

2012-05-09 Thread Petr Spacek
On 05/09/2012 01:24 PM, Adam Tkac wrote: On 05/03/2012 03:46 PM, Petr Spacek wrote: On 05/03/2012 11:25 AM, Petr Spacek wrote: Hello, this patch adds missing DNS->LDAP escaping conversion. It's necessary to prevent (potential) LDAP injection attacks in future. Code isn't very nice, because DN

Re: [Freeipa-devel] [PATCH 0019] Add proper DN escaping before LDAP library calls

2012-05-09 Thread Adam Tkac
On 05/03/2012 03:46 PM, Petr Spacek wrote: On 05/03/2012 11:25 AM, Petr Spacek wrote: Hello, this patch adds missing DNS->LDAP escaping conversion. It's necessary to prevent (potential) LDAP injection attacks in future. Code isn't very nice, because DNS users decimal escaping \123, LDAP uses h

Re: [Freeipa-devel] [PATCH] 0039 Remove duplicate and unused utility code

2012-05-09 Thread Martin Kosek
On Thu, 2012-04-19 at 12:33 +0200, Petr Viktorin wrote: > IPA has some unused code from abandoned features (Radius, ipa 1.x user > input, command-line tab completion), as well as some duplicate utilities. > This patch cleans up the utility modules. > > https://fedorahosted.org/freeipa/ticket/2650

Re: [Freeipa-devel] [PATCH] 0046 Don't fail when adding default objectclasses using config-mod

2012-05-09 Thread Martin Kosek
On Thu, 2012-05-03 at 18:25 +0200, Petr Viktorin wrote: > Fix another setattr internal error that QA found. > > https://fedorahosted.org/freeipa/ticket/2706 > ACK. Pushed to master. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

Re: [Freeipa-devel] [PATCH] 78 Redo boolean value encoding

2012-05-09 Thread Martin Kosek
On Mon, 2012-05-07 at 18:49 +0200, Jan Cholasta wrote: > On 7.5.2012 17:59, Martin Kosek wrote: > > On Mon, 2012-05-07 at 14:48 +0200, Jan Cholasta wrote: > >> Hi, > >> > >> this patch changes the way boolean values are encoded to LDAP boolean > >> syntax. The code for encoding boolean values is mo