[Freeipa-devel] [PATCH] 283 Improve address family handling in sockets

2012-07-04 Thread Martin Kosek
I did various tests with IPv4 and IPv6 and everything worked for me. I also tried a mixed IPv4+IPv6 and IPv6-only environment and I was able to install an IPv6-only replica without issues. --- Many functions use low-level socket interface for connection or various checks. However, most of the

Re: [Freeipa-devel] [PATCH] 1031 run cleanallruv task

2012-07-04 Thread Martin Kosek
On 07/03/2012 04:41 PM, Rob Crittenden wrote: Deleting a replica can leave a replication vector (RUV) on the other servers. This can confuse things if the replica is re-added, and it also causes the server to calculate changes against a server that may no longer exist. 389-ds-base provides a

Re: [Freeipa-devel] [PATCH] 165 Display loginas information only after login

2012-07-04 Thread Petr Vobornik
On 07/02/2012 05:49 PM, Endi Sukma Dewata wrote: ACK. Some more comments below. Feel free to fix before push or later separately. Implemented most of the issues, look bellow. Update patch attached. On 7/2/2012 2:55 AM, Petr Vobornik wrote: On 06/28/2012 10:47 PM, Endi Sukma Dewata wrote:

[Freeipa-devel] [PATCH] 166 Moved configuration to last position in navigation

2012-07-04 Thread Petr Vobornik
Configuration was the last navigation item in IPA server tab. Trusts changed it. It was wrong because configuration is like 'other settings' and so it should be last. This patch moves configuration navigation item to the last position again. https://fedorahosted.org/freeipa/ticket/2900 --

Re: [Freeipa-devel] [PATCH] 1032 allow multiple --server in client install, don't always set _srv_

2012-07-04 Thread Martin Kosek
On 07/04/2012 12:12 AM, Rob Crittenden wrote: If you pass in --server and --fixed-primary then don't add _srv_ to ipa_server in sssd.conf. This necessitates the desire to be able to provide multiple servers so make --server accept multiple values. This represents the bulk of the code

[Freeipa-devel] [PATCH] ipasam SASL bind callback fixes

2012-07-04 Thread Alexander Bokovoy
Hi, when chasing what looked like ccache corruption with Sumit, I've found yet another issue: use of local stack variable in long-time living code. This local stack use was absent in the original patch version and was proposed by Sumit on one of reviews. It worked for us by luck, it should not

Re: [Freeipa-devel] [PATCH] ipasam SASL bind callback fixes

2012-07-04 Thread Sumit Bose
On Wed, Jul 04, 2012 at 08:57:44PM +0300, Alexander Bokovoy wrote: Hi, when chasing what looked like ccache corruption with Sumit, I've found yet another issue: use of local stack variable in long-time living code. This local stack use was absent in the original patch version and was

[Freeipa-devel] [PATCH] 32 Only check local ID range during ipa-adtrust-install

2012-07-04 Thread Sumit Bose
Hi, since the default range for the local domain is now created during updates it is not necessary anymore to have duplicated code in adtrustinstance.py. Instead of trying to create a new range the code now only makes some sanity checks. bye, Sumit From 27616076953028a6ad11977c68e86344d7bca665

[Freeipa-devel] [PATCH] 33 Allow silent build if available

2012-07-04 Thread Sumit Bose
Hi, this patch allows to use 'make V=0' to get a less verbose output during the compilation of the freeipa C-code. Since AM_SILENT_RULES is only available with automake 1.11 or later, I used m4_ifdef to check if ti is present. bye, Sumit From 950ff4855415d72154ec7b3386b67a37d4ce3164 Mon Sep 17

[Freeipa-devel] [PATCH] 34-35 ipasam fixes

2012-07-04 Thread Sumit Bose
Hi, the following two patches contain fixes for ipa_sam.c. The first fixes several issues which were found by clang and the second removes some testing stuff I forgot to change. bye, Sumit From 116631a3fd2a50e3c2b5a44ed4cff44fe4f0ab99 Mon Sep 17 00:00:00 2001 From: Sumit Bose sb...@redhat.com