Re: [Freeipa-devel] [PATCH] 0070 Fix updating minimum_connections in ipa-upgradeconfig

2012-07-19 Thread Petr Spacek
On 07/18/2012 09:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: minimum_connections was sometimes not updated properly on install because the script set psearch on but assumed it was still off. Also, the number of connections was not set if the directive was missing. Fix of the patch for htt

Re: [Freeipa-devel] [PATCH] 0070 Fix updating minimum_connections in ipa-upgradeconfig

2012-07-19 Thread Petr Viktorin
On 07/18/2012 09:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: minimum_connections was sometimes not updated properly on install because the script set psearch on but assumed it was still off. Also, the number of connections was not set if the directive was missing. Fix of the patch for htt

Re: [Freeipa-devel] [PATCHES] 495 Fix ipa-replica-manage issues

2012-07-19 Thread Petr Viktorin
On 07/18/2012 08:21 PM, Rob Crittenden wrote: Simo Sorce wrote: These 2 patches fix issues found with ipa-replica-manage and connect/disconnect commands. Fixes ticket #2925 Simo. ACK, pushed both to master. I slightly reformatted the commit messages. rob This fixed https://fedorahosted.

Re: [Freeipa-devel] [PATCH] 1034 more robust cli sessions

2012-07-19 Thread Petr Viktorin
On 07/16/2012 07:54 PM, Rob Crittenden wrote: Rob Crittenden wrote: Make command-line sessions a bit more robust. This patch does two things. Firstly, it wraps all keyring activity in a try/except so if a keyring operation fails it isn't fatal. The user just won't benefit from sessions. The se

Re: [Freeipa-devel] [PATCH 0032-0035]

2012-07-19 Thread Adam Tkac
On Wed, Jul 18, 2012 at 01:32:10PM +0200, Petr Spacek wrote: > Hello, > > attached patch 0032 adds support for MODDN operation to persistent > search implementation. > Related ticket: https://fedorahosted.org/bind-dyndb-ldap/ticket/72 > > Patches 0033-0035 does minor cleanup in old persistent sea

Re: [Freeipa-devel] [PATCH 0036] Raise connection count automatically if serial_autoincrement is enabled

2012-07-19 Thread Adam Tkac
On Wed, Jul 18, 2012 at 01:46:18PM +0200, Petr Spacek wrote: > Hello, > > this patch reflects new demand from serial_autoincrement feature. > > Generally, change in configuration file should by IPA > install/upgrade scripts. This patch prevents deadlock in situation > where scripts failed in thei

Re: [Freeipa-devel] [PATCH 0037] Add missing return value check to new_ldap_instance()

2012-07-19 Thread Adam Tkac
On Wed, Jul 18, 2012 at 02:35:20PM +0200, Petr Spacek wrote: > Hello, > > this patch adds missing return value check to new_ldap_instance(). > > https://fedorahosted.org/bind-dyndb-ldap/ticket/85 > > Bug was reported by Coverity. Ack. > From 85574b9ffe4757b93b6eb9b99ceb1172a5c37002 Mon Sep 17

Re: [Freeipa-devel] [PATCH] 1035 case sensitivity when calculating indirect members

2012-07-19 Thread Petr Viktorin
On 07/17/2012 08:52 PM, Rob Crittenden wrote: When determining whether a member is direct or indirect we were not doing a case-insensitive comparison which led to marking a member as both direct and indirect (in a test case no less). This patch fixes the comparison and the test. rob When com

Re: [Freeipa-devel] [PATCH 0032-0035] Add support for MODDN operation to persistent search implementation

2012-07-19 Thread Petr Spacek
Hello, I have to explain my motivation behind INSIST a bit. Please see comments below. On 07/19/2012 01:43 PM, Adam Tkac wrote: On Wed, Jul 18, 2012 at 01:32:10PM +0200, Petr Spacek wrote: + CHECK(ldap_query(inst, conn, &ldap_qresult_zone, pevent->dn, >+LDAP_SCOPE_BASE

Re: [Freeipa-devel] [PATCH 0032-0035] Add support for MODDN operation to persistent search implementation

2012-07-19 Thread Adam Tkac
On Thu, Jul 19, 2012 at 01:59:01PM +0200, Petr Spacek wrote: > Hello, > > I have to explain my motivation behind INSIST a bit. Please see comments > below. > > On 07/19/2012 01:43 PM, Adam Tkac wrote: > >>On Wed, Jul 18, 2012 at 01:32:10PM +0200, Petr Spacek wrote: > >>+ CHECK(ldap_query(inst,

[Freeipa-devel] [DHCP] tree layout options

2012-07-19 Thread William Brown
Find attached two different ldifs showing how the tree for DHCP services could be layed out. I personally prefer 2 due to the way that sharedNetwork segments can be named uniquely in a location without clashing with another location. The way that ISC-DHCP generates the config is through essentially

Re: [Freeipa-devel] [PATCH] 0070 Fix updating minimum_connections in ipa-upgradeconfig

2012-07-19 Thread Rob Crittenden
Petr Viktorin wrote: On 07/18/2012 09:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: minimum_connections was sometimes not updated properly on install because the script set psearch on but assumed it was still off. Also, the number of connections was not set if the directive was missing. Fi

Re: [Freeipa-devel] [PATCH] 1035 case sensitivity when calculating indirect members

2012-07-19 Thread Rob Crittenden
Petr Viktorin wrote: On 07/17/2012 08:52 PM, Rob Crittenden wrote: When determining whether a member is direct or indirect we were not doing a case-insensitive comparison which led to marking a member as both direct and indirect (in a test case no less). This patch fixes the comparison and the

[Freeipa-devel] [PATCH] 173 IDs and names for dialogs

2012-07-19 Thread Petr Vobornik
It's hard to detect if or which type of dialog is displayed because not all dialogs have IDs. On dialog open, it's id or name (if id is not set) is used for containing element id. Many of dialog types were missing id or name so name was added to each dialog type. In HTML, element's id should

Re: [Freeipa-devel] [DHCP] tree layout options

2012-07-19 Thread William Brown
> does not add any dhcpHost objects not the dhcpFailOverPeer information. I have found why this is. I was setting ldap-method to dynamic, meaning that the contents of this object were only read at lease request time. setting this to static has allowed these objects to be read at dhcpd initilizati

Re: [Freeipa-devel] [PATCH] 1034 more robust cli sessions

2012-07-19 Thread Rob Crittenden
Petr Viktorin wrote: On 07/16/2012 07:54 PM, Rob Crittenden wrote: Rob Crittenden wrote: Make command-line sessions a bit more robust. This patch does two things. Firstly, it wraps all keyring activity in a try/except so if a keyring operation fails it isn't fatal. The user just won't benefit

Re: [Freeipa-devel] [DHCP] tree layout options

2012-07-19 Thread Simo Sorce
On Thu, 2012-07-19 at 22:44 +0930, William Brown wrote: > > does not add any dhcpHost objects not the dhcpFailOverPeer information. > > I have found why this is. I was setting ldap-method to dynamic, meaning > that the contents of this object were only read at lease request time. > setting this t

Re: [Freeipa-devel] [PATCH] 1035 case sensitivity when calculating indirect members

2012-07-19 Thread Petr Viktorin
On 07/19/2012 03:07 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 07/17/2012 08:52 PM, Rob Crittenden wrote: When determining whether a member is direct or indirect we were not doing a case-insensitive comparison which led to marking a member as both direct and indirect (in a test case no l

Re: [Freeipa-devel] [DHCP] tree layout options

2012-07-19 Thread William Brown
On 19/07/12 22:59, Simo Sorce wrote: > On Thu, 2012-07-19 at 22:44 +0930, William Brown wrote: >>> does not add any dhcpHost objects not the dhcpFailOverPeer information. >> >> I have found why this is. I was setting ldap-method to dynamic, meaning >> that the contents of this object were only rea

Re: [Freeipa-devel] [PATCH 0032-0035] Add support for MODDN operation to persistent search implementation

2012-07-19 Thread Petr Spacek
On 07/19/2012 02:09 PM, Adam Tkac wrote: On Thu, Jul 19, 2012 at 01:59:01PM +0200, Petr Spacek wrote: Hello, I have to explain my motivation behind INSIST a bit. Please see comments below. On 07/19/2012 01:43 PM, Adam Tkac wrote: On Wed, Jul 18, 2012 at 01:32:10PM +0200, Petr Spacek wrote: +

Re: [Freeipa-devel] [PATCH 0037] Add missing return value check to new_ldap_instance()

2012-07-19 Thread Petr Spacek
On 07/19/2012 01:46 PM, Adam Tkac wrote: On Wed, Jul 18, 2012 at 02:35:20PM +0200, Petr Spacek wrote: Hello, this patch adds missing return value check to new_ldap_instance(). https://fedorahosted.org/bind-dyndb-ldap/ticket/85 Bug was reported by Coverity. Ack. Pushed to master: ​ http:

Re: [Freeipa-devel] [PATCH 0036] Raise connection count automatically if serial_autoincrement is enabled

2012-07-19 Thread Petr Spacek
On 07/19/2012 01:45 PM, Adam Tkac wrote: On Wed, Jul 18, 2012 at 01:46:18PM +0200, Petr Spacek wrote: Hello, this patch reflects new demand from serial_autoincrement feature. Generally, change in configuration file should by IPA install/upgrade scripts. This patch prevents deadlock in situatio

Re: [Freeipa-devel] [PATCH] 0070 Fix updating minimum_connections in ipa-upgradeconfig

2012-07-19 Thread Petr Viktorin
On 07/19/2012 03:04 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 07/18/2012 09:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: minimum_connections was sometimes not updated properly on install because the script set psearch on but assumed it was still off. Also, the number of connection

Re: [Freeipa-devel] [PATCH] 1035 case sensitivity when calculating indirect members

2012-07-19 Thread Rob Crittenden
Petr Viktorin wrote: On 07/19/2012 03:07 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 07/17/2012 08:52 PM, Rob Crittenden wrote: When determining whether a member is direct or indirect we were not doing a case-insensitive comparison which led to marking a member as both direct and indirec

Re: [Freeipa-devel] [PATCH] 0056 Framework for admin/install tools, with ipa-ldap-updater

2012-07-19 Thread John Dennis
Overall I really like the approach, good work. I have not applied and run the patch, so my comments are based only on code reading. I have just a small things which might need changing. One of the ideas in the log manager is to easily support per class logging (borrowed from Java). This allo

Re: [Freeipa-devel] [PATCH] 0070 Fix updating minimum_connections in ipa-upgradeconfig

2012-07-19 Thread Rob Crittenden
Petr Viktorin wrote: On 07/19/2012 03:04 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 07/18/2012 09:45 PM, Rob Crittenden wrote: Petr Viktorin wrote: minimum_connections was sometimes not updated properly on install because the script set psearch on but assumed it was still off. Also, th

Re: [Freeipa-devel] [PATCH] 0066 Arrange stripping .po files

2012-07-19 Thread John Dennis
On 06/25/2012 07:17 AM, Petr Viktorin wrote: The translation files we currently store in Git are full of redundant information: source strings for untranslated messages, and file locations. The first causes unnecessarily huge files. The second makes diffs unreadable: when code is edited and line

Re: [Freeipa-devel] [PATCH] 1035 case sensitivity when calculating indirect members

2012-07-19 Thread John Dennis
On 07/19/2012 01:35 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 07/19/2012 03:07 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 07/17/2012 08:52 PM, Rob Crittenden wrote: When determining whether a member is direct or indirect we were not doing a case-insensitive comparison which led

[Freeipa-devel] [PATCH] change default answer when installing replica on wrong host

2012-07-19 Thread Rob Crittenden
Pushed this under the one-liner rule. From 78810f906873c261277189b279d4da33dbd05eb2 Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Thu, 19 Jul 2012 00:41:01 -0400 Subject: [PATCH] Default to no when trying trying to install a replica on wrong server. When installing a replica file on the