Re: [Freeipa-devel] [PATCH] 0073 Add trust verification code

2012-09-18 Thread Rob Crittenden
Alexander Bokovoy wrote: On Tue, 18 Sep 2012, Petr Vobornik wrote: On 09/18/2012 05:33 PM, Alexander Bokovoy wrote: On Tue, 18 Sep 2012, Petr Vobornik wrote: On 09/18/2012 03:22 PM, Alexander Bokovoy wrote: On Tue, 18 Sep 2012, Petr Vobornik wrote: On 09/18/2012 02:15 PM, Sumit Bose wrote:

Re: [Freeipa-devel] [PATCH] 212 Fix integer validation when boundary value is empty string

2012-09-18 Thread Endi Sukma Dewata
On 9/18/2012 6:36 AM, Petr Vobornik wrote: Updated patch attached. ACK. 1. Instead of IPA.not_defined() it might be better to call it IPA.defined() to avoid double negations like this: if (!IPA.not_defined(metadata.minvalue, true) ... Function renamed, logic negated. Unit tests for IPA.

Re: [Freeipa-devel] [PATCH] 0073 Add trust verification code

2012-09-18 Thread Alexander Bokovoy
On Tue, 18 Sep 2012, Petr Vobornik wrote: On 09/18/2012 05:33 PM, Alexander Bokovoy wrote: On Tue, 18 Sep 2012, Petr Vobornik wrote: On 09/18/2012 03:22 PM, Alexander Bokovoy wrote: On Tue, 18 Sep 2012, Petr Vobornik wrote: On 09/18/2012 02:15 PM, Sumit Bose wrote: On Tue, Sep 18, 2012 at 12

Re: [Freeipa-devel] [PATCH] 0081 Only stop the main DS instance when upgrading it

2012-09-18 Thread Rob Crittenden
Martin Kosek wrote: On 09/14/2012 04:53 PM, Petr Viktorin wrote: On 09/14/2012 04:12 PM, Petr Viktorin wrote: On 09/14/2012 03:12 PM, Simo Sorce wrote: On Fri, 2012-09-14 at 14:53 +0200, Petr Viktorin wrote: This fixes a 2.2→3.0 upgrade bug found while testing the Dogtag 10 work. See commit o

Re: [Freeipa-devel] [PATCH] 0073 Add trust verification code

2012-09-18 Thread Petr Vobornik
On 09/18/2012 05:33 PM, Alexander Bokovoy wrote: On Tue, 18 Sep 2012, Petr Vobornik wrote: On 09/18/2012 03:22 PM, Alexander Bokovoy wrote: On Tue, 18 Sep 2012, Petr Vobornik wrote: On 09/18/2012 02:15 PM, Sumit Bose wrote: On Tue, Sep 18, 2012 at 12:42:49PM +0200, Sumit Bose wrote: On Mon,

Re: [Freeipa-devel] [PATCH] 0073 Add trust verification code

2012-09-18 Thread Alexander Bokovoy
On Tue, 18 Sep 2012, Petr Vobornik wrote: On 09/18/2012 03:22 PM, Alexander Bokovoy wrote: On Tue, 18 Sep 2012, Petr Vobornik wrote: On 09/18/2012 02:15 PM, Sumit Bose wrote: On Tue, Sep 18, 2012 at 12:42:49PM +0200, Sumit Bose wrote: On Mon, Sep 17, 2012 at 06:44:36PM +0300, Alexander Bokovo

Re: [Freeipa-devel] [PATCH] 0073 Add trust verification code

2012-09-18 Thread Petr Vobornik
On 09/18/2012 03:22 PM, Alexander Bokovoy wrote: On Tue, 18 Sep 2012, Petr Vobornik wrote: On 09/18/2012 02:15 PM, Sumit Bose wrote: On Tue, Sep 18, 2012 at 12:42:49PM +0200, Sumit Bose wrote: On Mon, Sep 17, 2012 at 06:44:36PM +0300, Alexander Bokovoy wrote: Hi, Following patch adds trust v

Re: [Freeipa-devel] [PATCH] 0073 Add trust verification code

2012-09-18 Thread Alexander Bokovoy
On Tue, 18 Sep 2012, Petr Vobornik wrote: On 09/18/2012 02:15 PM, Sumit Bose wrote: On Tue, Sep 18, 2012 at 12:42:49PM +0200, Sumit Bose wrote: On Mon, Sep 17, 2012 at 06:44:36PM +0300, Alexander Bokovoy wrote: Hi, Following patch adds trust verification sequence to the case when we establish

Re: [Freeipa-devel] [PATCH] 0073 Add trust verification code

2012-09-18 Thread Petr Vobornik
On 09/18/2012 02:15 PM, Sumit Bose wrote: On Tue, Sep 18, 2012 at 12:42:49PM +0200, Sumit Bose wrote: On Mon, Sep 17, 2012 at 06:44:36PM +0300, Alexander Bokovoy wrote: Hi, Following patch adds trust verification sequence to the case when we establish trust with knowledge of AD administrative

Re: [Freeipa-devel] [PATCH] 0073 Add trust verification code

2012-09-18 Thread Sumit Bose
On Tue, Sep 18, 2012 at 12:42:49PM +0200, Sumit Bose wrote: > On Mon, Sep 17, 2012 at 06:44:36PM +0300, Alexander Bokovoy wrote: > > Hi, > > > > Following patch adds trust verification sequence to the case when we > > establish trust with knowledge of AD administrative credentials. > > > > As we

Re: [Freeipa-devel] [PATCH] 0079 Update the pot file (translation source)

2012-09-18 Thread Petr Viktorin
On 09/17/2012 07:59 PM, Jérôme Fenal wrote: 2012/9/17 Petr Viktorin mailto:pvikt...@redhat.com>> On 09/14/2012 09:36 PM, Jérôme Fenal wrote: 2012/9/14 Petr Viktorin mailto:pvikt...@redhat.com> >> I pushed

Re: [Freeipa-devel] [PATCH] 214 Fix jquery error when using '??' in a pkey

2012-09-18 Thread Petr Vobornik
On 09/18/2012 04:45 AM, Endi Sukma Dewata wrote: On 9/14/2012 8:00 AM, Petr Vobornik wrote: This patch is only for FreeIPA 2.2. It is already fixed in 3.0. If '??' is used in a adder dialog as a pkey it can cause "jQuery15208158273949015573_1346241267446 was not called" error. Update of jquery

Re: [Freeipa-devel] [PATCH] 212 Fix integer validation when boundary value is empty string

2012-09-18 Thread Petr Vobornik
On 09/18/2012 04:45 AM, Endi Sukma Dewata wrote: On 9/11/2012 10:09 AM, Petr Vobornik wrote: There was an error in number validation check. If boundary value was an empty string, validation of a number always failed. This patch fixes the problem by not performing the check in these cases. Basic

Re: [Freeipa-devel] [PATCH] 0077 Check direct/reverse hostname/address resolution in ipa-replica-install

2012-09-18 Thread Petr Viktorin
On 09/17/2012 08:10 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 09/14/2012 08:46 AM, Martin Kosek wrote: On 09/13/2012 10:35 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 09/11/2012 11:05 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 09/04/2012 07:44 PM, Rob Crittenden wrote:

Re: [Freeipa-devel] [PATCH] 0073 Add trust verification code

2012-09-18 Thread Sumit Bose
On Mon, Sep 17, 2012 at 06:44:36PM +0300, Alexander Bokovoy wrote: > Hi, > > Following patch adds trust verification sequence to the case when we > establish trust with knowledge of AD administrative credentials. > > As we found out, in order to validate/verify trust, one has to have > administra

Re: [Freeipa-devel] [PATCH 0006] Improves sssd.conf handling during ipa-client uninstall

2012-09-18 Thread Tomas Babej
On 09/12/2012 05:29 PM, Martin Kosek wrote: On 08/29/2012 02:54 PM, Tomas Babej wrote: On 08/27/2012 04:55 PM, Martin Kosek wrote: On 08/27/2012 03:37 PM, Jakub Hrozek wrote: On Mon, Aug 27, 2012 at 02:57:44PM +0200, Martin Kosek wrote: I think that the right behavior of SSSD conf uninstall s

[Freeipa-devel] [PATCH] 310 Properly convert DN in ipa-client-install

2012-09-18 Thread Martin Kosek
Pushed to master, ipa-3-0 as a one-liner. --- ipa-client-install crashed when IPA server anonymous access was disabled and base DN was thus generated via realm_to_suffix function which, however, returns a DN object and not string. DN was converted to string, ipa-client-install no longer crashes