Re: [Freeipa-devel] [PATCH 0021] Forbid overlapping rid ranges for the same id range

2012-12-13 Thread Petr Viktorin
On 12/12/2012 04:32 PM, Martin Kosek wrote: [...] 2) I don't like this construct very much: updated_values = dict(zip(rid_range_attributes,[None]*3)) This would look better, IMO: updated_values = dict((attr, None) for attr in rid_range_attributes) Or just `dict.fromkeys(rid_range_attributes)`

Re: [Freeipa-devel] [PATCH 0021] Forbid overlapping rid ranges for the same id range

2012-12-13 Thread Tomas Babej
On 12/12/2012 04:32 PM, Martin Kosek wrote: On 10/26/2012 03:43 PM, Tomas Babej wrote: Hi, creating an id range with overlapping primary and secondary rid range using idrange-add or idrange-mod command now raises ValidationError. Unit tests have been added to test_range_plugin.py. https://fedo

Re: [Freeipa-devel] [PATCH] 1078 own ca_serialno

2012-12-13 Thread Petr Viktorin
On 12/13/2012 06:01 AM, Rob Crittenden wrote: We don't currently include the ca_serialno file in our spec file. This can generate an SELinux warning upon fresh install because we try to set context on a non-existent file. This creates an empty file on rpm install so the file can be owned by the

Re: [Freeipa-devel] [PATCH] 1078 own ca_serialno

2012-12-13 Thread Rob Crittenden
Petr Viktorin wrote: On 12/13/2012 06:01 AM, Rob Crittenden wrote: We don't currently include the ca_serialno file in our spec file. This can generate an SELinux warning upon fresh install because we try to set context on a non-existent file. This creates an empty file on rpm install so the fil

Re: [Freeipa-devel] [PATCH 0021] Forbid overlapping rid ranges for the same id range

2012-12-13 Thread Martin Kosek
On 12/13/2012 11:52 AM, Tomas Babej wrote: > On 12/12/2012 04:32 PM, Martin Kosek wrote: >> On 10/26/2012 03:43 PM, Tomas Babej wrote: >>> Hi, >>> >>> creating an id range with overlapping primary and secondary >>> rid range using idrange-add or idrange-mod command now >>> raises ValidationError. U

Re: [Freeipa-devel] [PATCH 0098] Log failures detected in CHECK() macro

2012-12-13 Thread Adam Tkac
On Tue, Dec 04, 2012 at 01:24:39PM +0100, Petr Spacek wrote: > On 11/22/2012 02:05 PM, Adam Tkac wrote: > >On Tue, Nov 20, 2012 at 02:44:49PM +0100, Petr Spacek wrote: > >>Hello, > >> > >> Log failures detected in CHECK() macro. > >> > >> Function ldap_query() can return ISC_R_NOTFOUND legi

Re: [Freeipa-devel] [PATCH 101] Fix error handling in ldap_entry_create()

2012-12-13 Thread Adam Tkac
On Thu, Nov 22, 2012 at 09:56:12AM +0100, Petr Spacek wrote: > Hello, > > apparently I was very tired yesterday ... Cleaned version of the > patch is attached. > > Petr^2 Spacek > > On 11/21/2012 05:04 PM, Petr Spacek wrote: > >Hello, > > > >fixed fix is attached. Clang found bug in the fix but

Re: [Freeipa-devel] [PATCH 0106] Fix error handling for initial zone refresh in persistent search

2012-12-13 Thread Adam Tkac
On Thu, Nov 22, 2012 at 02:55:51PM +0100, Petr Spacek wrote: > Hello, > > Fix error handling for initial zone refresh in persistent search. > > Old code terminates watcher thread in case of error. Now initial lookup > is restarted after reconnect_interval seconds. Ack > From 99a8207

Re: [Freeipa-devel] [PATCH] 1078 own ca_serialno

2012-12-13 Thread Petr Viktorin
On 12/13/2012 02:47 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 12/13/2012 06:01 AM, Rob Crittenden wrote: We don't currently include the ca_serialno file in our spec file. This can generate an SELinux warning upon fresh install because we try to set context on a non-existent file. This

Re: [Freeipa-devel] [PATCH] 1078 own ca_serialno

2012-12-13 Thread Martin Kosek
On 12/13/2012 03:34 PM, Petr Viktorin wrote: > On 12/13/2012 02:47 PM, Rob Crittenden wrote: >> Petr Viktorin wrote: >>> On 12/13/2012 06:01 AM, Rob Crittenden wrote: We don't currently include the ca_serialno file in our spec file. This can generate an SELinux warning upon fresh install

Re: [Freeipa-devel] [PATCH 0106] Fix error handling for initial zone refresh in persistent search

2012-12-13 Thread Petr Spacek
On 12/13/2012 03:21 PM, Adam Tkac wrote: On Thu, Nov 22, 2012 at 02:55:51PM +0100, Petr Spacek wrote: >Hello, > > Fix error handling for initial zone refresh in persistent search. > > Old code terminates watcher thread in case of error. Now initial lookup > is restarted after reconne

Re: [Freeipa-devel] [PATCH 101] Fix error handling in ldap_entry_create()

2012-12-13 Thread Petr Spacek
On 12/13/2012 03:17 PM, Adam Tkac wrote: On Thu, Nov 22, 2012 at 09:56:12AM +0100, Petr Spacek wrote: >Hello, > >apparently I was very tired yesterday ... Cleaned version of the >patch is attached. > >Petr^2 Spacek > >On 11/21/2012 05:04 PM, Petr Spacek wrote: > >Hello, > > > >fixed fix is att

Re: [Freeipa-devel] [PATCH] 1078 own ca_serialno

2012-12-13 Thread Simo Sorce
On Thu, 2012-12-13 at 15:38 +0100, Martin Kosek wrote: > On 12/13/2012 03:34 PM, Petr Viktorin wrote: > > On 12/13/2012 02:47 PM, Rob Crittenden wrote: > >> Petr Viktorin wrote: > >>> On 12/13/2012 06:01 AM, Rob Crittenden wrote: > We don't currently include the ca_serialno file in our spec fi

Re: [Freeipa-devel] [PATCH 0098] Log failures detected in CHECK() macro

2012-12-13 Thread Petr Spacek
On 12/13/2012 03:07 PM, Adam Tkac wrote: On Tue, Dec 04, 2012 at 01:24:39PM +0100, Petr Spacek wrote: >On 11/22/2012 02:05 PM, Adam Tkac wrote: > >On Tue, Nov 20, 2012 at 02:44:49PM +0100, Petr Spacek wrote: > >>Hello, > >> > >> Log failures detected in CHECK() macro. > >> > >> Functio

[Freeipa-devel] [PATCHES] 0107-0114 Fix Confusing ipa tool online help organization

2012-12-13 Thread Petr Viktorin
https://fedorahosted.org/freeipa/ticket/3060 Here is a collection of smallish fixes to `ipa help` and `ipa --help`. This should address most of Nikolai's proposal. Additionally, it's now possible to run `ipa --help` without a Kerberos ticket. And there are some new tests. I've not included

Re: [Freeipa-devel] [PATCH] 1078 own ca_serialno

2012-12-13 Thread Rob Crittenden
Simo Sorce wrote: On Thu, 2012-12-13 at 15:38 +0100, Martin Kosek wrote: On 12/13/2012 03:34 PM, Petr Viktorin wrote: On 12/13/2012 02:47 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 12/13/2012 06:01 AM, Rob Crittenden wrote: We don't currently include the ca_serialno file in our spec f

Re: [Freeipa-devel] [PATCH] 1078 own ca_serialno

2012-12-13 Thread Simo Sorce
On Thu, 2012-12-13 at 10:28 -0500, Rob Crittenden wrote: > Simo Sorce wrote: > > On Thu, 2012-12-13 at 15:38 +0100, Martin Kosek wrote: > >> On 12/13/2012 03:34 PM, Petr Viktorin wrote: > >>> On 12/13/2012 02:47 PM, Rob Crittenden wrote: > Petr Viktorin wrote: > > On 12/13/2012 06:01 AM, R

Re: [Freeipa-devel] [PATCHES] 0104-0106 Provide means of displaying warning and informational messages on clients

2012-12-13 Thread Martin Kosek
On 12/13/2012 10:59 AM, Petr Viktorin wrote: > It's time to give this to another set of eyes :) > > Design document: http://freeipa.org/page/V3/Messages > Ticket: https://fedorahosted.org/freeipa/ticket/2732 > > More info is in commit messages. > > > Because of https://fedorahosted.org/freeipa/

Re: [Freeipa-devel] [PATCH] 1078 own ca_serialno

2012-12-13 Thread Rob Crittenden
Simo Sorce wrote: On Thu, 2012-12-13 at 10:28 -0500, Rob Crittenden wrote: Simo Sorce wrote: On Thu, 2012-12-13 at 15:38 +0100, Martin Kosek wrote: On 12/13/2012 03:34 PM, Petr Viktorin wrote: On 12/13/2012 02:47 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 12/13/2012 06:01 AM, Rob Cri

Re: [Freeipa-devel] [PATCH] 1078 own ca_serialno

2012-12-13 Thread Simo Sorce
On Thu, 2012-12-13 at 10:44 -0500, Rob Crittenden wrote: > Simo Sorce wrote: > > On Thu, 2012-12-13 at 10:28 -0500, Rob Crittenden wrote: > >> Simo Sorce wrote: > >>> On Thu, 2012-12-13 at 15:38 +0100, Martin Kosek wrote: > On 12/13/2012 03:34 PM, Petr Viktorin wrote: > > On 12/13/2012 02:

Re: [Freeipa-devel] [PATCH 92] Flush whole zone from cache during zone renaming/removal.

2012-12-13 Thread Adam Tkac
On Wed, Dec 05, 2012 at 01:25:56PM +0100, Petr Spacek wrote: > On 12/04/2012 02:36 PM, Adam Tkac wrote: > >On Thu, Nov 15, 2012 at 07:06:37PM +0100, Petr Spacek wrote: > >>>Hello, > >>> > >>>attached patch is preliminary implementation of selective zone flush. > >>> > >>> > >>>Implementation is not

Re: [Freeipa-devel] [PATCH] 1078 own ca_serialno

2012-12-13 Thread Rob Crittenden
Simo Sorce wrote: On Thu, 2012-12-13 at 10:44 -0500, Rob Crittenden wrote: Simo Sorce wrote: On Thu, 2012-12-13 at 10:28 -0500, Rob Crittenden wrote: Simo Sorce wrote: On Thu, 2012-12-13 at 15:38 +0100, Martin Kosek wrote: On 12/13/2012 03:34 PM, Petr Viktorin wrote: On 12/13/2012 02:47 PM,

Re: [Freeipa-devel] [PATCH] 1078 own ca_serialno

2012-12-13 Thread Rob Crittenden
Rob Crittenden wrote: Simo Sorce wrote: On Thu, 2012-12-13 at 10:44 -0500, Rob Crittenden wrote: Simo Sorce wrote: On Thu, 2012-12-13 at 10:28 -0500, Rob Crittenden wrote: Simo Sorce wrote: On Thu, 2012-12-13 at 15:38 +0100, Martin Kosek wrote: On 12/13/2012 03:34 PM, Petr Viktorin wrote:

Re: [Freeipa-devel] [PATCHES] 0104-0106 Provide means of displaying warning and informational messages on clients

2012-12-13 Thread Petr Viktorin
On 12/13/2012 04:43 PM, Martin Kosek wrote: On 12/13/2012 10:59 AM, Petr Viktorin wrote: It's time to give this to another set of eyes :) Design document: http://freeipa.org/page/V3/Messages Ticket: https://fedorahosted.org/freeipa/ticket/2732 More info is in commit messages. Because of http

Re: [Freeipa-devel] [PATCHES] 0107-0114 Fix Confusing ipa tool online help organization

2012-12-13 Thread Dmitri Pal
On 12/13/2012 10:21 AM, Petr Viktorin wrote: > https://fedorahosted.org/freeipa/ticket/3060 > > Here is a collection of smallish fixes to `ipa help` and `ipa > --help`. > This should address most of Nikolai's proposal. > Additionally, it's now possible to run `ipa --help` without > a Kerberos tic