Re: [Freeipa-devel] [PATCH] 1106 IPA REST smart proxy

2014-02-21 Thread Rob Crittenden
Dmitri Pal wrote: On 02/21/2014 11:09 AM, Martin Kosek wrote: On 02/21/2014 04:37 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/17/2014 04:57 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/17/2014 04:13 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/17/2014 02:33 PM, Rob Crittend

Re: [Freeipa-devel] [freeipa] #4185: Index plugin namespaces by classes

2014-02-21 Thread Dmitri Pal
On 02/21/2014 06:31 AM, Petr Viktorin wrote: On 02/20/2014 08:00 PM, Dmitri Pal wrote: On 02/20/2014 12:57 PM, Petr Viktorin wrote: On 02/20/2014 06:47 PM, Dmitri Pal wrote: On 02/20/2014 12:39 PM, freeipa wrote: #4185: Index plugin namespaces by classes -+

Re: [Freeipa-devel] [PATCH] 1106 IPA REST smart proxy

2014-02-21 Thread Dmitri Pal
On 02/21/2014 11:09 AM, Martin Kosek wrote: On 02/21/2014 04:37 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/17/2014 04:57 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/17/2014 04:13 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/17/2014 02:33 PM, Rob Crittenden wrote: Dmitri P

Re: [Freeipa-devel] [PATCH] 531-541 OTP UI

2014-02-21 Thread Nathaniel McCallum
Is it possible to do something more intelligent for the key and date fields in the add-token UI? Date fields are currently just a text box. Is there any sort of calendar we could use here? If not, I'm still unsure of what the format should be for this field. The key field should probably have a n

Re: [Freeipa-devel] [PATCH][bind-dyndb-ldap] Fix potential dereference of NULL pointer in sync_ctx_init

2014-02-21 Thread Lukas Slebodnik
On (13/12/13 17:44), Petr Spacek wrote: >On 12.11.2013 16:13, Petr Spacek wrote: >>On 5.11.2013 12:29, Tomas Hozza wrote: >>>- Original Message - Hello, Improve performance of initial LDAP synchronization. Changes are not journaled and SOA serial is not incremented dur

Re: [Freeipa-devel] [PATCH 0224-0225] Add function attributes warn_unused_result and nonnull and add missing CHECK()s to string operations

2014-02-21 Thread Lukas Slebodnik
On (21/02/14 16:12), Petr Spacek wrote: >Hello, > >Add function attributes warn_unused_result and nonnull >where appropriate and add missing CHECK()s to string operations. > >Lukas, thanks for catching the missing CHECK() around str_new(). > >As a reward, you can review attached patches. > >Have fu

Re: [Freeipa-devel] [PATCH 0042] Rework how otptoken defaults are handled

2014-02-21 Thread Nathaniel McCallum
On Fri, 2014-02-21 at 16:29 +0100, Jan Cholasta wrote: > Hi, > > On 21.2.2014 16:09, Nathaniel McCallum wrote: > > On Fri, 2014-02-21 at 09:45 -0500, Nathaniel McCallum wrote: > >> We had originally decided to provide defaults on the server side so that > >> they could be part of a global config f

[Freeipa-devel] [PATCH 0043] Remove NULLS from constants.py

2014-02-21 Thread Nathaniel McCallum
In the parameters system, we have been checking for a positive list of values which get converted to None. The problem is that this method can in some cases throw warnings when type coercion doesn't work (particularly, string to unicode). Instead, any values that evaluate to False that are neither

Re: [Freeipa-devel] [PATCH] 1106 IPA REST smart proxy

2014-02-21 Thread Martin Kosek
On 02/21/2014 04:37 PM, Rob Crittenden wrote: > Dmitri Pal wrote: >> On 02/17/2014 04:57 PM, Rob Crittenden wrote: >>> Dmitri Pal wrote: On 02/17/2014 04:13 PM, Rob Crittenden wrote: > Dmitri Pal wrote: >> On 02/17/2014 02:33 PM, Rob Crittenden wrote: >>> Dmitri Pal wrote:

Re: [Freeipa-devel] [PATCH] 1106 IPA REST smart proxy

2014-02-21 Thread Rob Crittenden
Dmitri Pal wrote: On 02/17/2014 04:57 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/17/2014 04:13 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/17/2014 02:33 PM, Rob Crittenden wrote: Dmitri Pal wrote: On 02/17/2014 01:21 PM, Rob Crittenden wrote: Martin Kosek wrote: On 02/14/2014

Re: [Freeipa-devel] [PATCH 0224-0225] Add function attributes warn_unused_result and nonnull and add missing CHECK()s to string operations

2014-02-21 Thread Lukas Slebodnik
On (21/02/14 10:20), Nathaniel McCallum wrote: >On Fri, 2014-02-21 at 16:17 +0100, Petr Spacek wrote: >> On 21.2.2014 16:16, Nathaniel McCallum wrote: >> > On Fri, 2014-02-21 at 16:12 +0100, Petr Spacek wrote: >> >> Hello, >> >> >> >> Add function attributes warn_unused_result and nonnull >> >> whe

Re: [Freeipa-devel] [PATCH 0042] Rework how otptoken defaults are handled

2014-02-21 Thread Jan Cholasta
Hi, On 21.2.2014 16:09, Nathaniel McCallum wrote: On Fri, 2014-02-21 at 09:45 -0500, Nathaniel McCallum wrote: We had originally decided to provide defaults on the server side so that they could be part of a global config for the admin. However, on further reflection, only certain defaults real

Re: [Freeipa-devel] [PATCH 0224-0225] Add function attributes warn_unused_result and nonnull and add missing CHECK()s to string operations

2014-02-21 Thread Nathaniel McCallum
On Fri, 2014-02-21 at 16:17 +0100, Petr Spacek wrote: > On 21.2.2014 16:16, Nathaniel McCallum wrote: > > On Fri, 2014-02-21 at 16:12 +0100, Petr Spacek wrote: > >> Hello, > >> > >> Add function attributes warn_unused_result and nonnull > >> where appropriate and add missing CHECK()s to string oper

Re: [Freeipa-devel] [PATCH 0042] Rework how otptoken defaults are handled

2014-02-21 Thread Petr Viktorin
On 02/21/2014 04:13 PM, Petr Viktorin wrote: On 02/21/2014 03:45 PM, Nathaniel McCallum wrote: [...] NOTE: this patch changes an existing API. VERSION says that we should bump the major version in this case. But we haven't actually released this API yet. Please advise. If I understand correct

Re: [Freeipa-devel] [PATCH 0224-0225] Add function attributes warn_unused_result and nonnull and add missing CHECK()s to string operations

2014-02-21 Thread Petr Spacek
On 21.2.2014 16:16, Nathaniel McCallum wrote: On Fri, 2014-02-21 at 16:12 +0100, Petr Spacek wrote: Hello, Add function attributes warn_unused_result and nonnull where appropriate and add missing CHECK()s to string operations. Lukas, thanks for catching the missing CHECK() around str_new(). A

Re: [Freeipa-devel] [PATCH][bind-dyndb-ldap] Include missing header files.

2014-02-21 Thread Petr Spacek
On 21.2.2014 15:12, Lukas Slebodnik wrote: ehlo, Function get_krb5_tgt is declared in header file krb5_helper.h, but this header file was not included in implementation file krb5_helper.c Function fs_dirs_create is declared in header file fs.h, but this header file was not included in the imple

Re: [Freeipa-devel] [PATCH 0224-0225] Add function attributes warn_unused_result and nonnull and add missing CHECK()s to string operations

2014-02-21 Thread Nathaniel McCallum
On Fri, 2014-02-21 at 16:12 +0100, Petr Spacek wrote: > Hello, > > Add function attributes warn_unused_result and nonnull > where appropriate and add missing CHECK()s to string operations. > > Lukas, thanks for catching the missing CHECK() around str_new(). > > As a reward, you can review attach

Re: [Freeipa-devel] [PATCH 0042] Rework how otptoken defaults are handled

2014-02-21 Thread Petr Viktorin
On 02/21/2014 03:45 PM, Nathaniel McCallum wrote: [...] NOTE: this patch changes an existing API. VERSION says that we should bump the major version in this case. But we haven't actually released this API yet. Please advise. If I understand correctly, there were other VERSION bumps in master

Re: [Freeipa-devel] [PATCH 0042] Rework how otptoken defaults are handled

2014-02-21 Thread Nathaniel McCallum
On Fri, 2014-02-21 at 09:45 -0500, Nathaniel McCallum wrote: > We had originally decided to provide defaults on the server side so that > they could be part of a global config for the admin. However, on further > reflection, only certain defaults really make sense given the > limitations of Google

Re: [Freeipa-devel] [PATCH 0041] Make all ipatokenTOTP attributes mandatory

2014-02-21 Thread Petr Viktorin
On 02/21/2014 04:05 PM, Jan Cholasta wrote: Hi, On 21.2.2014 15:41, Nathaniel McCallum wrote: Originally we made them all optional as a workaround for the lack of SELFDN support in 389DS. However, with the advent of SELFDN, this hack is no longer necessary. This patch updates TOTP to match HOTP

Re: [Freeipa-devel] [PATCH]Extending user plugin with employeenumber field

2014-02-21 Thread Petr Vobornik
On 21.2.2014 15:45, Adam Misnyovszki wrote: Hi, According to http://tools.ietf.org/html/rfc2798 ipa client and web ui extended with employeenumber field. https://fedorahosted.org/freeipa/ticket/4165 Question is, that should we extend user with other fields which are in the RFC, (carLicense, d

Re: [Freeipa-devel] [PATCH 0016] Clarify error message about missing DNS component in ipa-replica-prepare

2014-02-21 Thread Petr Viktorin
On 02/21/2014 03:25 PM, Petr Viktorin wrote: On 02/21/2014 02:57 PM, Petr Spacek wrote: Hello, Clarify error message about missing DNS component in ipa-replica-prepare. Use 'dane' on #freeipa channel have spent half an hour finding out what is wrong because the error message was misleading. I

Re: [Freeipa-devel] [PATCH 0041] Make all ipatokenTOTP attributes mandatory

2014-02-21 Thread Jan Cholasta
Hi, On 21.2.2014 15:41, Nathaniel McCallum wrote: Originally we made them all optional as a workaround for the lack of SELFDN support in 389DS. However, with the advent of SELFDN, this hack is no longer necessary. This patch updates TOTP to match HOTP in this regard. I can't argue with that an

Re: [Freeipa-devel] [PATCH 0040] Use super() properly to avoid an exception

2014-02-21 Thread Petr Viktorin
On 02/21/2014 03:51 PM, Alexander Bokovoy wrote: On Fri, 21 Feb 2014, Nathaniel McCallum wrote: https://fedorahosted.org/freeipa/ticket/4099 From b77bf5c7fdacc7b0224033d608d387be282f98bc Mon Sep 17 00:00:00 2001 From: Nathaniel McCallum Date: Thu, 20 Feb 2014 13:20:01 -0500 Subject: [PATCH]

Re: [Freeipa-devel] [PATCH 0040] Use super() properly to avoid an exception

2014-02-21 Thread Alexander Bokovoy
On Fri, 21 Feb 2014, Nathaniel McCallum wrote: https://fedorahosted.org/freeipa/ticket/4099 From b77bf5c7fdacc7b0224033d608d387be282f98bc Mon Sep 17 00:00:00 2001 From: Nathaniel McCallum Date: Thu, 20 Feb 2014 13:20:01 -0500 Subject: [PATCH] Use super() properly to avoid an exception https

[Freeipa-devel] [PATCH]Extending user plugin with employeenumber field

2014-02-21 Thread Adam Misnyovszki
Hi, According to http://tools.ietf.org/html/rfc2798 ipa client and web ui extended with employeenumber field. https://fedorahosted.org/freeipa/ticket/4165 Question is, that should we extend user with other fields which are in the RFC, (carLicense, departmentNumber, employeeType, etc) if we alre

[Freeipa-devel] [PATCH 0042] Rework how otptoken defaults are handled

2014-02-21 Thread Nathaniel McCallum
We had originally decided to provide defaults on the server side so that they could be part of a global config for the admin. However, on further reflection, only certain defaults really make sense given the limitations of Google Authenticator. Similarly, other defaults may be token specific. Atte

[Freeipa-devel] [PATCH 0041] Make all ipatokenTOTP attributes mandatory

2014-02-21 Thread Nathaniel McCallum
Originally we made them all optional as a workaround for the lack of SELFDN support in 389DS. However, with the advent of SELFDN, this hack is no longer necessary. This patch updates TOTP to match HOTP in this regard. >From 6418883ce51ef488ce5b40460cfa28f6e2cc9250 Mon Sep 17 00:00:00 2001 From: Nat

[Freeipa-devel] [PATCH 0040] Use super() properly to avoid an exception

2014-02-21 Thread Nathaniel McCallum
https://fedorahosted.org/freeipa/ticket/4099 >From b77bf5c7fdacc7b0224033d608d387be282f98bc Mon Sep 17 00:00:00 2001 From: Nathaniel McCallum Date: Thu, 20 Feb 2014 13:20:01 -0500 Subject: [PATCH] Use super() properly to avoid an exception https://fedorahosted.org/freeipa/ticket/4099 --- ipalib/

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-21 Thread Nathaniel McCallum
On Fri, 2014-02-21 at 00:08 +0200, Alexander Bokovoy wrote: > On Thu, 20 Feb 2014, Nathaniel McCallum wrote: > >> > >>There is an error in libotp's find() function which assumes that > >> > >>get_basedn() always returns non-NULL value. This is not true for at > >> > >>least cn=Directory Manager. >

[Freeipa-devel] [PATCH] 0471 permission_add: Remove permission entry if adding the ACI fails

2014-02-21 Thread Petr Viktorin
Hello, A permission object was not removed in permission-add when adding the ACI failed. Here is a fix. https://fedorahosted.org/freeipa/ticket/4187 Earlier we agreed that patch authors should bug the reviewer. I guess now this means I should set Patch-review-by in the ticket, right? So: Mar

Re: [Freeipa-devel] [PATCH 0016] Clarify error message about missing DNS component in ipa-replica-prepare

2014-02-21 Thread Petr Viktorin
On 02/21/2014 02:57 PM, Petr Spacek wrote: Hello, Clarify error message about missing DNS component in ipa-replica-prepare. Use 'dane' on #freeipa channel have spent half an hour finding out what is wrong because the error message was misleading. I think that it is enough to justify this change

Re: [Freeipa-devel] [PATCH] 531-541 OTP UI

2014-02-21 Thread Petr Vobornik
On 10.2.2014 14:12, Petr Vobornik wrote: On 13.1.2014 17:09, Petr Vobornik wrote: Hi, these patches implements the OTP Web UI. Last 5 patches is the OTP UI. First 6 patches is a little refactoring/bug fixes needed for them. General password dialog is introduced to avoid another implementation

[Freeipa-devel] [PATCH][bind-dyndb-ldap] Include missing header files.

2014-02-21 Thread Lukas Slebodnik
ehlo, Function get_krb5_tgt is declared in header file krb5_helper.h, but this header file was not included in implementation file krb5_helper.c Function fs_dirs_create is declared in header file fs.h, but this header file was not included in the implementation file fs.c LS >From 02ed610587749b6

[Freeipa-devel] [PATCH 0016] Clarify error message about missing DNS component in ipa-replica-prepare

2014-02-21 Thread Petr Spacek
Hello, Clarify error message about missing DNS component in ipa-replica-prepare. Use 'dane' on #freeipa channel have spent half an hour finding out what is wrong because the error message was misleading. I think that it is enough to justify this change :-) -- Petr^2 Spacek From 8161ff3f69313

Re: [Freeipa-devel] Reviewer in Trac

2014-02-21 Thread Martin Kosek
On 02/20/2014 01:14 PM, Martin Kosek wrote: > We had a discussion with other developers how better track who is reviewing > which patch. Recently, we introduced the Reviewed-By tag in a commit message, > but that is a post-review tag which is not useful for someone who wants to > know > which patc

Re: [Freeipa-devel] [PATCH] 0467 permission plugin: Do not assume attribute-level rights for new attributes are present

2014-02-21 Thread Martin Kosek
On 02/13/2014 01:41 PM, Petr Viktorin wrote: > Hello, > This fixes https://fedorahosted.org/freeipa/ticket/4121 > > Apply on top of my patches 0464-0466. Works for me. ACK. Pushed to master: 773e006ddd98cf9beabfada9d2830276826ab043 Martin ___ Freeipa

Re: [Freeipa-devel] [PATCH 0204] Remove obsolete zr_get_rbt() function from zone register

2014-02-21 Thread Petr Spacek
On 17.1.2014 16:13, Tomas Hozza wrote: On 11/11/2013 12:53 PM, Petr Spacek wrote: Hello, Remove obsolete zr_get_rbt() function from zone register. ACK. Patch looks good. Pushed to v3 and master branch: fa03da94d04c539ed84cc75d0ac070feb1052820 -- Petr^2 Spacek ___

Re: [Freeipa-devel] [PATCH 0223] Update Fedora SPEC file for v4.0 (RPM expert needed)

2014-02-21 Thread Tomas Hozza
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/21/2014 01:37 PM, Petr Spacek wrote: > On 21.2.2014 13:02, Tomas Hozza wrote: >> On 02/21/2014 12:54 PM, Tomas Hozza wrote: >>> On 02/21/2014 12:10 PM, Petr Spacek wrote: On 21.2.2014 11:05, Tomas Hozza wrote: > On 02/21/2014 10:46 AM, P

Re: [Freeipa-devel] [PATCH 0223] Update Fedora SPEC file for v4.0 (RPM expert needed)

2014-02-21 Thread Petr Spacek
On 21.2.2014 13:02, Tomas Hozza wrote: On 02/21/2014 12:54 PM, Tomas Hozza wrote: On 02/21/2014 12:10 PM, Petr Spacek wrote: On 21.2.2014 11:05, Tomas Hozza wrote: On 02/21/2014 10:46 AM, Petr Spacek wrote: I want to release bind-dyndb-ldap 4.0 to Fedora 20+ but I have found that we need to e

Re: [Freeipa-devel] [PATCH 0181] Replace LDAP persistent search with syncrepl (RFC 4533)

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:44, Petr Spacek wrote: On 7.10.2013 15:19, Tomas Hozza wrote: On 07/22/2013 03:16 PM, Petr Spacek wrote: On 22.7.2013 13:23, Petr Spacek wrote: Hello, Replace LDAP persistent search with syncrepl (RFC 4533). All direct operations with LDAP Persistent Search control are repla

Re: [Freeipa-devel] [PATCH 0207] Do not load invalid zones

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:45, Petr Spacek wrote: On 27.11.2013 16:34, Petr Spacek wrote: Hello, Do not load invalid zones. Without this patch, it was possible to load an invalid zone without proper SOA or NS records because the fake SOA and NS records allowed checks in dns_zone_load() to pass. With th

Re: [Freeipa-devel] [PATCH 0186-0191] Replace LDAP cache with RBTDB

2014-02-21 Thread Petr Spacek
On 13.12.2013 16:02, Petr Spacek wrote: On 23.10.2013 16:54, Tomas Hozza wrote: On 10/10/2013 06:58 PM, Petr Spacek wrote: On 8.10.2013 12:00, Tomas Hozza wrote: On 10/02/2013 12:57 PM, Petr Spacek wrote: On 13.9.2013 15:31, Petr Spacek wrote: On 14.8.2013 16:42, Petr Spacek wrote: On 14.8.

Re: [Freeipa-devel] [PATCH 0209] Silence GCC warnings produced by -Wjump-misses-init

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:45, Petr Spacek wrote: Hello, Silence GCC warnings produced by -Wjump-misses-init. It seems that it is false alarm in our case. This patch should go to branches v3 and master. Pushed to v3 and master branch: 2471ce0b3c0682a65237965188e79c46fa4228ac -- Petr^2 Spacek

Re: [Freeipa-devel] [PATCH 0220] Move temporary files to /var/named/dyndb-ldap directory

2014-02-21 Thread Petr Spacek
On 18.2.2014 17:38, Nathaniel McCallum wrote: On Tue, 2014-02-18 at 09:58 +0100, Petr Spacek wrote: On 28.1.2014 16:45, Petr Spacek wrote: Hello, Move temporary files to /var/named/dyndb-ldap directory. This should make RPM packaging easier. This patch should go to master branch before 4.0 r

Re: [Freeipa-devel] [PATCH 0216] Bump NVR to 3.6

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:45, Petr Spacek wrote: Hello, Bump NVR to 3.6. BIND 9.9.0 is required. Tomas, shouldn't I use Requires: bind >= 32:9.9.0-1 ? This patch should go to branches v3 and master. Pushed to v3 and master branch: a6d7aee2af0c410aeeb51d4295fbb17798661f63 -- Petr^2 Spacek _

Re: [Freeipa-devel] [PATCH 0201] Report error if RFC 4533 initialization failed

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:44, Petr Spacek wrote: On 24.10.2013 16:00, Tomas Hozza wrote: On 10/23/2013 05:14 PM, Petr Spacek wrote: Hello, this patch belongs to 4.0 release. It allows the user to catch some mis-configurations. It produces error messages like this: LDAP error: Critical extension is una

Re: [Freeipa-devel] [PATCH 0197-0200] Preparation for bind-dyndb-ldap release 4.0

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:44, Petr Spacek wrote: On 23.10.2013 17:12, Tomas Hozza wrote: On 10/11/2013 03:35 PM, Petr Spacek wrote: Hello, update documentation and schema files for upcoming version 4.0. This fixes typo in schema file: https://fedorahosted.org/bind-dyndb-ldap/ticket/121 Have a nice we

Re: [Freeipa-devel] [PATCH 0206] Publish zones only after all LDAP events have been processed

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:45, Petr Spacek wrote: On 12.11.2013 16:08, Petr Spacek wrote: Hello, Publish zones only after all LDAP events have been processed. Zones are not exposed in _default DNS view until all events generated before LDAP intermediate message have been processed. This prevents BIND f

Re: [Freeipa-devel] [PATCH 0211] Improve error handling in code for LDAP modification

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:45, Petr Spacek wrote: Hello, Improve error handling in code for LDAP modification. Failed LDAP modification is retried once. This patch should go to branches v3 and master. Pushed to v3 and master branch: b19977b11455e771250f5f5d61f3cb4d6afe1fbf -- Petr^2 Spacek _

Re: [Freeipa-devel] [PATCH 0205] Fix race condition during write to internal RBTDB

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:44, Petr Spacek wrote: On 11.11.2013 13:03, Petr Spacek wrote: Hello, Fix race condition during write to internal RBTDB. RBTDB implementation allows to open only one RBTDB instance for writing at the same time. This patch adds mutex to newversion() implementation in ldap_drive

Re: [Freeipa-devel] [PATCH 0202-0203] Improve performance of initial LDAP synchronizationDetect end of initial LDAP synchronization phase

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:44, Petr Spacek wrote: On 12.11.2013 16:13, Petr Spacek wrote: On 5.11.2013 12:29, Tomas Hozza wrote: - Original Message - Hello, Improve performance of initial LDAP synchronization. Changes are not journaled and SOA serial is not incremented during initial LDAP sync

Re: [Freeipa-devel] [PATCH 0192-0196] Write all changes to journal

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:44, Petr Spacek wrote: On 23.10.2013 17:20, Petr Spacek wrote: On 23.10.2013 17:12, Tomas Hozza wrote: On 10/10/2013 07:05 PM, Petr Spacek wrote: Hello, this patch set adds journaling to bind-dyndb-ldap. Journaling requires proper SOA serial maintenance, so from now SOA seri

Re: [Freeipa-devel] [PATCH][bind-dyndb-ldap] Fix warning duplicate 'const' declaration specifier

2014-02-21 Thread Petr Spacek
On 17.1.2014 16:06, Tomas Hozza wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/30/2013 09:21 AM, Lukas Slebodnik wrote: ehlo, There were few warnings in bind-dyndb-ldap "duplicate 'const' declaration specifier". It does not make sense to have const twice in declaration like a "con

Re: [Freeipa-devel] [PATCH 0214] Make ldap_parse_rrentry() idempotent

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:45, Petr Spacek wrote: Hello, Make ldap_parse_rrentry() idempotent. Now, a call to ldap_parse_rrentry() resets the internal entry interators in ldap_entry_t so the results are always correct. Without this patch, a second call returned empty ldapdb_rdatalist_t because all itera

Re: [Freeipa-devel] [PATCH 0217] Cleanup zone and journal files on LDAP reconnect

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:45, Petr Spacek wrote: Hello, Cleanup zone and journal files on LDAP reconnect. This cleanup solves potential inconsistencies between order of operations in LDAP and order of operations recorded in journal. This patch should go to master branch. Pushed to master branch: 53ac

Re: [Freeipa-devel] [PATCH 0208] Remove local variables which shadow variables from a upper level

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:45, Petr Spacek wrote: Hello, Remove local variables which shadow variables from a upper level. This patch should go to branches v3 and master. Pushed to v3 and master branch: 618b3a8c9a6c808f72d9121b6da27ac1e611a382 -- Petr^2 Spacek

Re: [Freeipa-devel] [PATCH 0218] Limit number of unprocessed syncrepl events in queue to 100

2014-02-21 Thread Petr Spacek
On 7.1.2014 19:36, Petr Spacek wrote: Hello, Limit number of unprocessed syncrepl events in queue to 100. All syncrepl events are processed sequentialy. This patch limits memory consumption in cases where the LDAP server is sending syncrepl events too quickly. LDAP client library should handle

Re: [Freeipa-devel] [PATCH 0215] Update NEWS for upcoming 3.6 release

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:45, Petr Spacek wrote: Hello, Update NEWS for upcoming 3.6 release. This patch should go to branches v3 and master. Pushed to v3 and master branch: 775cad18a63c973a7c437c988fc82087643fa54e -- Petr^2 Spacek ___ Freeipa-devel mailin

Re: [Freeipa-devel] [PATCH 0212] Remove unused parameter attrlist from ldap_entry_nextattr()

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:45, Petr Spacek wrote: Hello, Remove unused parameter attrlist from ldap_entry_nextattr(). This patch should go to branches v3 and master. Pushed to v3 and master branch: 03620d3a448149ff0dc4c75e12b06d896af52a1a -- Petr^2 Spacek _

Re: [Freeipa-devel] [PATCH 0213] Fix crash caused by invalid data in SOA record

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:45, Petr Spacek wrote: Hello, Fix crash caused by invalid data in SOA record. E.g. try to put '\0' to the idnsSOAmName attribute... This patch should go to branches v3 and master. Pushed to v3 and master branch: 6da35665011aa7e9ad9567b5ea098c998e846630 -- Petr^2 Spacek ___

Re: [Freeipa-devel] [PATCH 0210] Add missing default branches to switch statemets

2014-02-21 Thread Petr Spacek
On 13.12.2013 17:45, Petr Spacek wrote: Hello, Add missing default branches to switch statemets. This should help little bit with uninitialized memory usage. This patch should go to branches v3 and master. Pushed to v3 and master branch: ce14966943de2b5e2f577cc5130c511edb132a7c -- Petr^2 Sp

Re: [Freeipa-devel] [PATCH 0184] Use DNS_RDATA_MAXLENGTH from rdata.h instead of own definition

2014-02-21 Thread Petr Spacek
On 1.8.2013 15:51, Petr Spacek wrote: Hello, Use DNS_RDATA_MAXLENGTH from rdata.h instead of own definition. This minor fix could go to v3 and master. Pushed to v3 and master branch: ad4beb6968114eb85c639772050b54dbab53ba7f -- Petr^2 Spacek ___ F

Re: [Freeipa-devel] [PATCH 0185] Do not execute new LDAP search for each updated object

2014-02-21 Thread Petr Spacek
On 1.8.2013 15:52, Petr Spacek wrote: Hello, Do not execute new LDAP search for each updated object. Syncrepl delivers notification about change in particular object along with all data from the object. Resource Records are parsed out from this data instead of data obtained via separate LDAP se

Re: [Freeipa-devel] [PATCH 0221] Make getcwd() calls safer

2014-02-21 Thread Petr Spacek
On 18.2.2014 14:22, Tomas Hozza wrote: On 02/18/2014 10:34 AM, Petr Spacek wrote: ewer GCC complains that I didn't check return value from getcwd() ... Hi. I reviewed all patches from "PATCH 0181" to the latest one "PATCH 0221" and tested the bind-dyndb-ldap on Fedora 20 (adding/removing reco

Re: [Freeipa-devel] [PATCH 0183] Move data structures for parser from ldap_qresult_t to ldap_entry_t

2014-02-21 Thread Petr Spacek
On 7.10.2013 15:20, Tomas Hozza wrote: On 08/01/2013 03:49 PM, Petr Spacek wrote: Hello, Move data structures for parser from ldap_qresult_t to ldap_entry_t. The target branch is master. ACK. Tested Patch bundle 181 - 185. Common tasks like adding/deleting/updating records work fine. Also

Re: [Freeipa-devel] [PATCH 0219] Prevent crash if working directory for zone cannot be created

2014-02-21 Thread Petr Spacek
On 28.1.2014 16:37, Petr Spacek wrote: Hello, Prevent crash if working directory for zone cannot be created. This patch should go to master branch before 4.0 release. Pushed to master branch: a2c5b89e46f556555dc82e42a754e0c2c4102dd6 -- Petr^2 Spacek _

Re: [Freeipa-devel] [PATCH 0223] Update Fedora SPEC file for v4.0 (RPM expert needed)

2014-02-21 Thread Tomas Hozza
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/21/2014 12:54 PM, Tomas Hozza wrote: > On 02/21/2014 12:10 PM, Petr Spacek wrote: >> On 21.2.2014 11:05, Tomas Hozza wrote: >>> On 02/21/2014 10:46 AM, Petr Spacek wrote: I want to release bind-dyndb-ldap 4.0 to Fedora 20+ but I have found >

Re: [Freeipa-devel] [PATCH 0223] Update Fedora SPEC file for v4.0 (RPM expert needed)

2014-02-21 Thread Tomas Hozza
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/21/2014 12:10 PM, Petr Spacek wrote: > On 21.2.2014 11:05, Tomas Hozza wrote: >> On 02/21/2014 10:46 AM, Petr Spacek wrote: >>> I want to release bind-dyndb-ldap 4.0 to Fedora 20+ but I have found >>> that we >>> need to enable SELinux boolean na

Re: [Freeipa-devel] [freeipa] #4185: Index plugin namespaces by classes

2014-02-21 Thread Petr Viktorin
On 02/20/2014 08:00 PM, Dmitri Pal wrote: On 02/20/2014 12:57 PM, Petr Viktorin wrote: On 02/20/2014 06:47 PM, Dmitri Pal wrote: On 02/20/2014 12:39 PM, freeipa wrote: #4185: Index plugin namespaces by classes -+-

Re: [Freeipa-devel] [PATCH] Certificate search max_serial_number problem fixed

2014-02-21 Thread Adam Misnyovszki
- Original Message - > From: "Jan Cholasta" > To: "Adam Misnyovszki" , freeipa-devel@redhat.com > Sent: Friday, February 21, 2014 11:05:12 AM > Subject: Re: [Freeipa-devel] [PATCH] Certificate search max_serial_number > problem fixed > > Hi, > > On 20.2.2014 18:15, Adam Misnyovszki wr

Re: [Freeipa-devel] [PATCH 0223] Update Fedora SPEC file for v4.0 (RPM expert needed)

2014-02-21 Thread Petr Spacek
On 21.2.2014 11:05, Tomas Hozza wrote: On 02/21/2014 10:46 AM, Petr Spacek wrote: I want to release bind-dyndb-ldap 4.0 to Fedora 20+ but I have found that we need to enable SELinux boolean named_write_master_zones otherwise the plugin will not be able to write journal files to /var/named. I ha

Re: [Freeipa-devel] [PATCH] [WIP] 0469 - Remove the unused ipalib.frontend.Property class

2014-02-21 Thread Petr Viktorin
On 02/21/2014 11:13 AM, Jan Cholasta wrote: Hi, On 20.2.2014 09:54, Petr Viktorin wrote: Hello, I had this patch sitting around for some time but didn't get around to polishing and submitting it lately. The ticket was now claimed by "rga" (I assume that's the person who goes by Darth Vader here

Re: [Freeipa-devel] [PATCH] [WIP] 0469 - Remove the unused ipalib.frontend.Property class

2014-02-21 Thread Jan Cholasta
Hi, On 20.2.2014 09:54, Petr Viktorin wrote: Hello, I had this patch sitting around for some time but didn't get around to polishing and submitting it lately. The ticket was now claimed by "rga" (I assume that's the person who goes by Darth Vader here?). I'm sharing the work hoping that it doesn

Re: [Freeipa-devel] [PATCH 0223] Update Fedora SPEC file for v4.0 (RPM expert needed)

2014-02-21 Thread Tomas Hozza
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Peter. See comments below... On 02/21/2014 10:46 AM, Petr Spacek wrote: > Hello list, > > I want to release bind-dyndb-ldap 4.0 to Fedora 20+ but I have found that we > need to enable SELinux boolean named_write_master_zones otherwise the plugin

Re: [Freeipa-devel] [PATCH] Certificate search max_serial_number problem fixed

2014-02-21 Thread Jan Cholasta
Hi, On 20.2.2014 18:15, Adam Misnyovszki wrote: Hi, this patch fixes ticket https://fedorahosted.org/freeipa/ticket/4163 maximum serial number field now accepts only positive numbers Thanks Adam I think you should also add maxvalue to min_serial_number, so that they are consistent. Honza

[Freeipa-devel] [PATCH 0223] Update Fedora SPEC file for v4.0 (RPM expert needed)

2014-02-21 Thread Petr Spacek
Hello list, I want to release bind-dyndb-ldap 4.0 to Fedora 20+ but I have found that we need to enable SELinux boolean named_write_master_zones otherwise the plugin will not be able to write journal files to /var/named. I have asked Miroslav Grepl for advice and his recommendation is to us

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-21 Thread Petr Viktorin
On 02/20/2014 07:45 PM, Nathaniel McCallum wrote: On Wed, 2014-02-12 at 11:49 -0500, Nathaniel McCallum wrote: Through the review process, patches are getting shifted around, added, deleted, etc. So I'm now just going to be posting all the patches as an ordered set. The set attached is ordered a

Re: [Freeipa-devel] [PATCHES] OTP Patches

2014-02-21 Thread Alexander Bokovoy
On Thu, 20 Feb 2014, Nathaniel McCallum wrote: From ead3ef011667dadacfc817725179f38c05177a00 Mon Sep 17 00:00:00 2001 From: Nathaniel McCallum Date: Thu, 20 Feb 2014 13:20:01 -0500 Subject: [PATCH 6/8] Fix a typo where self was omitted https://fedorahosted.org/freeipa/ticket/4099 --- ipalib/plu