Re: [Freeipa-devel] [PATCH 0107-0108] Fix DNS wildcard validation

2014-08-20 Thread Petr Spacek
On 20.8.2014 17:37, Martin Basti wrote: +# dissallowed wildcard (RFC 4592) +no_wildcard_rtypes = ['CNAME', 'DNAME', 'DS', 'NS'] NACK http://tools.ietf.org/html/rfc4592#section-4.3 doesn't forbid CNAME with wildcard owner name. This subsection is is just a "note" for implementer

Re: [Freeipa-devel] [PATCH] - Add DRM to IPA

2014-08-20 Thread Ade Lee
On Wed, 2014-08-20 at 15:35 -0400, Rob Crittenden wrote: > Ade Lee wrote: > > On Thu, 2014-08-14 at 14:29 +0200, Petr Viktorin wrote: > >> On 08/14/2014 10:53 AM, Martin Kosek wrote: > >>> On 08/13/2014 09:54 PM, Ade Lee wrote: > In Dogtag, we have decided to revert the name of the DRM to the

Re: [Freeipa-devel] [PATCH] - Add DRM to IPA

2014-08-20 Thread Rob Crittenden
Ade Lee wrote: > On Thu, 2014-08-14 at 14:29 +0200, Petr Viktorin wrote: >> On 08/14/2014 10:53 AM, Martin Kosek wrote: >>> On 08/13/2014 09:54 PM, Ade Lee wrote: In Dogtag, we have decided to revert the name of the DRM to the old name KRA. DRM was really only used in docs/marketing

Re: [Freeipa-devel] [PATCH] 730-732 webui: Login pages usability improvements

2014-08-20 Thread Petr Vobornik
On 12.8.2014 22:58, Endi Sukma Dewata wrote: On 8/5/2014 6:36 AM, Petr Vobornik wrote: [PATCH] 730 webui: display expired session notification in a more visible area The notification is a primary information of the page. It should be more highlighted. https://fedorahosted.org/freeipa/ticket/4

[Freeipa-devel] [PATCHES 0109-0110] DNS: fix DS record validation

2014-08-20 Thread Martin Basti
Part of DNSSEC Patches attached. -- Martin Basti From f5e3b504911a1729546e45f33d2008e7ab1c421d Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Wed, 20 Aug 2014 18:51:25 +0200 Subject: [PATCH 1/2] DNSSEC: fix DS record validation Part of: https://fedorahosted.org/freeipa/ticket/3801 --- ipal

Re: [Freeipa-devel] [PATCH] 0635 Support delegating RBAC roles to service principals

2014-08-20 Thread Petr Viktorin
On 08/20/2014 10:59 AM, Martin Kosek wrote: On 08/19/2014 07:49 PM, Petr Viktorin wrote: On 08/19/2014 01:41 PM, Martin Kosek wrote: On 08/19/2014 01:28 PM, Petr Viktorin wrote: Services can now be added to roles. https://fedorahosted.org/freeipa/ticket/3164 I added a new integration test f

[Freeipa-devel] [PATCH 0107-0108] Fix DNS wildcard validation

2014-08-20 Thread Martin Basti
Patches attached. Ticket: https://fedorahosted.org/freeipa/ticket/4488 -- Martin Basti From f8e26732ed07466c9fb19d921154b444c393f829 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Wed, 20 Aug 2014 15:14:12 +0200 Subject: [PATCH 1/2] FIX DNS wildcard records (RFC4592) Make validation more s

Re: [Freeipa-devel] [PATCH] Change BuildRequires for Java

2014-08-20 Thread Petr Vobornik
On 20.8.2014 14:17, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/20/2014 07:59 AM, Stephen Gallagher wrote: Requiring a specific version of Java leads to breakages, like the one happening on nightly builds in Fedora Rawhide right now. We should use the more gener

Re: [Freeipa-devel] [PATCH 0061] Ensure ipaUserAuthTypeClass when needed on user creation

2014-08-20 Thread thierry bordaz
On 08/20/2014 03:48 PM, Nathaniel McCallum wrote: On Wed, 2014-08-20 at 14:35 +0200, thierry bordaz wrote: On 08/19/2014 10:46 PM, Nathaniel McCallum wrote: Also, remove the attempt to load the objectClasses when absent. This never makes sense during an add operation. https://fedorahosted.org

Re: [Freeipa-devel] [PATCH 0061] Ensure ipaUserAuthTypeClass when needed on user creation

2014-08-20 Thread Nathaniel McCallum
On Wed, 2014-08-20 at 14:35 +0200, thierry bordaz wrote: > On 08/19/2014 10:46 PM, Nathaniel McCallum wrote: > > > Also, remove the attempt to load the objectClasses when absent. This > > never makes sense during an add operation. > > > > https://fedorahosted.org/freeipa/ticket/4455 > > > > > >

Re: [Freeipa-devel] [PATCH] - Add DRM to IPA

2014-08-20 Thread Petr Viktorin
On 08/18/2014 07:36 PM, Ade Lee wrote: [...] After discussion with Endi, I also removed some functions in dogtag.py (the plugin) which basically just wrapped calls to the keyclient. There is no need to do this wrapping and it is much more flexible for IPA code to call the keyclient directly. A

Re: [Freeipa-devel] [PATCH 0061] Ensure ipaUserAuthTypeClass when needed on user creation

2014-08-20 Thread thierry bordaz
On 08/19/2014 10:46 PM, Nathaniel McCallum wrote: Also, remove the attempt to load the objectClasses when absent. This never makes sense during an add operation. https://fedorahosted.org/freeipa/ticket/4455 ___ Freeipa-devel mailing list Freeipa-deve

Re: [Freeipa-devel] [PATCH] Change BuildRequires for Java

2014-08-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/20/2014 07:59 AM, Stephen Gallagher wrote: > Requiring a specific version of Java leads to breakages, like the > one happening on nightly builds in Fedora Rawhide right now. We > should use the more generic 'java' BuildRequires instead of the >

[Freeipa-devel] [PATCH] Change BuildRequires for Java

2014-08-20 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Requiring a specific version of Java leads to breakages, like the one happening on nightly builds in Fedora Rawhide right now. We should use the more generic 'java' BuildRequires instead of the versioned one. This is breaking my nightly static analys

Re: [Freeipa-devel] [PATCH] 0635 Support delegating RBAC roles to service principals

2014-08-20 Thread Martin Kosek
On 08/20/2014 10:59 AM, Martin Kosek wrote: > On 08/19/2014 07:49 PM, Petr Viktorin wrote: ... > Could we just add the realm if it does not exists in the service-add-member > precallback? s/service-add-member/role-add-member/ Martin ___ Freeipa-devel m

Re: [Freeipa-devel] [PATCH] 0635 Support delegating RBAC roles to service principals

2014-08-20 Thread Martin Kosek
On 08/19/2014 07:49 PM, Petr Viktorin wrote: > On 08/19/2014 01:41 PM, Martin Kosek wrote: >> On 08/19/2014 01:28 PM, Petr Viktorin wrote: >>> Services can now be added to roles. >>> >>> https://fedorahosted.org/freeipa/ticket/3164 >>> >>> >>> I added a new integration test for checking that a serv

Re: [Freeipa-devel] [PATCH] 719 webui-ci: fix table widget add

2014-08-20 Thread Petr Vobornik
On 12.8.2014 17:58, Endi Sukma Dewata wrote: On 8/5/2014 6:20 AM, Petr Vobornik wrote: add_table_record call used old selector for add button which caused 3 fails in CI: - ERROR: Test automember rebuild membership feature for hosts - ERROR: Test automember rebuild membership feature for users -

Re: [Freeipa-devel] [PATCH] 718 webui: better error reporting

2014-08-20 Thread Petr Vobornik
On 12.8.2014 17:57, Endi Sukma Dewata wrote: On 8/5/2014 6:19 AM, Petr Vobornik wrote: On page: - styled to use proper line breaks - "centered" by .container class and not by huge padding Console: - proper line breaks - links in stack trace are clickable(Chrome) ACK. Pushed to ipa-4-0: * d