Re: [Freeipa-devel] [PATCHES] 336-339 Installer certificate options usability fixes

2014-09-30 Thread Martin Kosek
On 09/29/2014 11:02 PM, Petr Viktorin wrote: > On 09/29/2014 04:32 PM, Jan Cholasta wrote: >> Dne 26.9.2014 v 19:40 Jan Cholasta napsal(a): >>> Dne 26.9.2014 v 17:37 Rob Crittenden napsal(a): Petr Viktorin wrote: > On 09/24/2014 06:13 PM, Jan Cholasta wrote: >> Hi, >> >> the at

Re: [Freeipa-devel] [PATCH 0033] Remove trivial path constants

2014-09-30 Thread Martin Kosek
Hello Gabe, Thanks for the patch! And thank you for being patient, most people are focusing on wrapping up FreeIPA 4.1 release, so the review forces are limited. Martin On 09/30/2014 05:13 AM, Gabe Alford wrote: > Updated patch to fix merge conflicts from recent changes. > > On Wed, Sep 24, 201

Re: [Freeipa-devel] [PATCHES] 336-339 Installer certificate options usability fixes

2014-09-30 Thread Martin Kosek
On 09/30/2014 09:00 AM, Martin Kosek wrote: > On 09/29/2014 11:02 PM, Petr Viktorin wrote: >> On 09/29/2014 04:32 PM, Jan Cholasta wrote: >>> Dne 26.9.2014 v 19:40 Jan Cholasta napsal(a): Dne 26.9.2014 v 17:37 Rob Crittenden napsal(a): > Petr Viktorin wrote: >> On 09/24/2014 06:13 PM,

Re: [Freeipa-devel] [PATCHES] 319, 324-335 CA management and renewal fixes

2014-09-30 Thread Jan Cholasta
Dne 29.9.2014 v 18:09 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 29.9.2014 v 15:05 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 26.9.2014 v 17:13 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 23.9.2014 v 20:39 Rob Crittenden napsal(a): Jan Cholasta wrote: Hi, the attached

Re: [Freeipa-devel] [PATCHES] 336-339 Installer certificate options usability fixes

2014-09-30 Thread Petr Viktorin
On 09/30/2014 09:00 AM, Martin Kosek wrote: On 09/29/2014 11:02 PM, Petr Viktorin wrote: On 09/29/2014 04:32 PM, Jan Cholasta wrote: Dne 26.9.2014 v 19:40 Jan Cholasta napsal(a): Dne 26.9.2014 v 17:37 Rob Crittenden napsal(a): Petr Viktorin wrote: On 09/24/2014 06:13 PM, Jan Cholasta wrote:

Re: [Freeipa-devel] [PATCHES] 319, 324-335 CA management and renewal fixes

2014-09-30 Thread Martin Kosek
On 09/30/2014 09:59 AM, Jan Cholasta wrote: > Dne 29.9.2014 v 18:09 Rob Crittenden napsal(a): >> Jan Cholasta wrote: >>> Dne 29.9.2014 v 15:05 Rob Crittenden napsal(a): Jan Cholasta wrote: > Dne 26.9.2014 v 17:13 Rob Crittenden napsal(a): >> Jan Cholasta wrote: >>> Dne 23.9.2014 v

Re: [Freeipa-devel] [PATCHES] 319, 324-335 CA management and renewal fixes

2014-09-30 Thread Jan Cholasta
Dne 30.9.2014 v 10:09 Martin Kosek napsal(a): On 09/30/2014 09:59 AM, Jan Cholasta wrote: Dne 29.9.2014 v 18:09 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 29.9.2014 v 15:05 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 26.9.2014 v 17:13 Rob Crittenden napsal(a): Jan Cholasta wrot

Re: [Freeipa-devel] [PATCHES] 319, 324-335 CA management and renewal fixes

2014-09-30 Thread Martin Kosek
On 09/30/2014 10:19 AM, Jan Cholasta wrote: > Dne 30.9.2014 v 10:09 Martin Kosek napsal(a): >> On 09/30/2014 09:59 AM, Jan Cholasta wrote: >>> Dne 29.9.2014 v 18:09 Rob Crittenden napsal(a): Jan Cholasta wrote: > Dne 29.9.2014 v 15:05 Rob Crittenden napsal(a): >> Jan Cholasta wrote: >>

Re: [Freeipa-devel] [PATCHES 247-281] ID views - management part

2014-09-30 Thread Petr Viktorin
On 09/30/2014 09:56 AM, Tomas Babej wrote: Attaching updated patchset with resolved objections from Petr^1 and Petr^3. (three more patches attached) LGTM. (I never did functional testing for this though.) -- PetrĀ³ ___ Freeipa-devel mailing list F

Re: [Freeipa-devel] [PATCHES 247-281] ID views - management part

2014-09-30 Thread Petr Vobornik
On 30.9.2014 10:22, Petr Viktorin wrote: On 09/30/2014 09:56 AM, Tomas Babej wrote: Attaching updated patchset with resolved objections from Petr^1 and Petr^3. (three more patches attached) LGTM. (I never did functional testing for this though.) ACK 280-4, 281-4 LGTM 282-4 (not tested) --

Re: [Freeipa-devel] [PATCHES 247-281] ID views - management part

2014-09-30 Thread Martin Kosek
On 09/30/2014 10:37 AM, Petr Vobornik wrote: > On 30.9.2014 10:22, Petr Viktorin wrote: >> On 09/30/2014 09:56 AM, Tomas Babej wrote: >>> Attaching updated patchset with resolved objections from Petr^1 and >>> Petr^3. >>> >>> (three more patches attached) >> >> LGTM. (I never did functional testing

Re: [Freeipa-devel] [PATCH] 749-754 webui: new ID views section

2014-09-30 Thread Petr Vobornik
All pushed. master: * 15b6ed67056ce918e11f7ea5c2d193534b5ce6b5 webui: improve breadcrumb navigation * 26bd309c96446b9eda26a08e6924d6e1b4c621fc webui: treat value as pkey in link widget * 27196b92c60917d8488dad8721d2087e9fee716c webui: do not show internal facet name to user * 8b0e2ed991e9a1a49

[Freeipa-devel] [PATCH 0283] idviews: Fix typo in upgrade handling of the Default Trust

2014-09-30 Thread Tomas Babej
Hi, Fixed missing comma. Also removes leading spaces from the ldif, since this is not stripped by the updater. Part of: https://fedorahosted.org/freeipa/ticket/3979 -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org >From 2

Re: [Freeipa-devel] [PATCH 0283] idviews: Fix typo in upgrade handling of the Default Trust

2014-09-30 Thread Jan Cholasta
Dne 30.9.2014 v 11:40 Tomas Babej napsal(a): Hi, Fixed missing comma. Also removes leading spaces from the ldif, since this is not stripped by the updater. Part of: https://fedorahosted.org/freeipa/ticket/3979 ACK. -- Jan Cholasta ___ Freeipa-deve

Re: [Freeipa-devel] [PATCH 0283] idviews: Fix typo in upgrade handling of the Default Trust

2014-09-30 Thread Martin Kosek
On 09/30/2014 11:48 AM, Jan Cholasta wrote: > Dne 30.9.2014 v 11:40 Tomas Babej napsal(a): >> Hi, >> >> Fixed missing comma. Also removes leading spaces from the ldif, >> since this is not stripped by the updater. >> >> Part of: https://fedorahosted.org/freeipa/ticket/3979 > > ACK. Pushed to: mas

[Freeipa-devel] Use "alpha" instead of "pre" for alpha releases

2014-09-30 Thread Petr Viktorin
Last time (2.1) we used "Preview/Testing" for the pre-beta release, but the Git tags were still named alpha_*. I think alpha is a better name, let's use that. -- PetrĀ³ From 50c941ce35f1a715fc3b8e7dc154639760498c05 Mon Sep 17 00:00:00 2001 From: Petr Viktorin Date: Tue, 30 Sep 2014 11:48:20 +020

Re: [Freeipa-devel] Use "alpha" instead of "pre" for alpha releases

2014-09-30 Thread Martin Kosek
On 09/30/2014 12:55 PM, Petr Viktorin wrote: > Last time (2.1) we used "Preview/Testing" for the pre-beta release, > but the Git tags were still named alpha_*. > > I think alpha is a better name, let's use that. > +1, I would also prefer to use Alpha, I this it is more understandable than "pre-r

Re: [Freeipa-devel] Use "alpha" instead of "pre" for alpha releases

2014-09-30 Thread Alexander Bokovoy
On Tue, 30 Sep 2014, Martin Kosek wrote: On 09/30/2014 12:55 PM, Petr Viktorin wrote: Last time (2.1) we used "Preview/Testing" for the pre-beta release, but the Git tags were still named alpha_*. I think alpha is a better name, let's use that. +1, I would also prefer to use Alpha, I this it

Re: [Freeipa-devel] Use "alpha" instead of "pre" for alpha releases

2014-09-30 Thread Petr Vobornik
On 30.9.2014 12:55, Petr Viktorin wrote: Last time (2.1) we used "Preview/Testing" for the pre-beta release, but the Git tags were still named alpha_*. I think alpha is a better name, let's use that. +1 -- Petr Vobornik ___ Freeipa-devel mailing li

Re: [Freeipa-devel] [PATCH 0068] Move OTP synchronization step to after counter writeback

2014-09-30 Thread thierry bordaz
On 09/29/2014 08:38 PM, Nathaniel McCallum wrote: On Thu, 2014-09-25 at 15:15 +0200, thierry bordaz wrote: On 09/19/2014 07:53 PM, Nathaniel McCallum wrote: This prevents synchronization when an authentication collision occurs. https://fedorahosted.org/freeipa/ticket/4493 NOTE: this patch is

[Freeipa-devel] FreeIPA 4.1 Alpha 1

2014-09-30 Thread Martin Kosek
Hello, It is time to produce an Alpha 1 release of FreeIPA 4.1, as a technology preview for other developers or testers. The main reason is that the Views feature is slowly getting complete and we want other people take a look. The FreeIPA framework and UI part are done, SSSD and slapi-nis are in

Re: [Freeipa-devel] Use "alpha" instead of "pre" for alpha releases

2014-09-30 Thread Petr Viktorin
On 09/30/2014 01:15 PM, Alexander Bokovoy wrote: On Tue, 30 Sep 2014, Martin Kosek wrote: On 09/30/2014 12:55 PM, Petr Viktorin wrote: Last time (2.1) we used "Preview/Testing" for the pre-beta release, but the Git tags were still named alpha_*. I think alpha is a better name, let's use that.

Re: [Freeipa-devel] [PATCH 0068] Move OTP synchronization step to after counter writeback

2014-09-30 Thread Nathaniel McCallum
On Tue, 2014-09-30 at 13:42 +0200, thierry bordaz wrote: > On 09/29/2014 08:38 PM, Nathaniel McCallum wrote: > > On Thu, 2014-09-25 at 15:15 +0200, thierry bordaz wrote: > >> On 09/19/2014 07:53 PM, Nathaniel McCallum wrote: > >> > >>> This prevents synchronization when an authentication collision

Re: [Freeipa-devel] [PATCH 0068] Move OTP synchronization step to after counter writeback

2014-09-30 Thread thierry bordaz
On 09/30/2014 02:41 PM, Nathaniel McCallum wrote: On Tue, 2014-09-30 at 13:42 +0200, thierry bordaz wrote: On 09/29/2014 08:38 PM, Nathaniel McCallum wrote: On Thu, 2014-09-25 at 15:15 +0200, thierry bordaz wrote: On 09/19/2014 07:53 PM, Nathaniel McCallum wrote: This prevents synchronizatio

Re: [Freeipa-devel] [PATCH 0068] Move OTP synchronization step to after counter writeback

2014-09-30 Thread Petr Viktorin
On 09/30/2014 02:53 PM, thierry bordaz wrote: On 09/30/2014 02:41 PM, Nathaniel McCallum wrote: On Tue, 2014-09-30 at 13:42 +0200, thierry bordaz wrote: On 09/29/2014 08:38 PM, Nathaniel McCallum wrote: On Thu, 2014-09-25 at 15:15 +0200, thierry bordaz wrote: On 09/19/2014 07:53 PM, Nathaniel

Re: [Freeipa-devel] [PATCH 0064] Create ipa-otp-decrement 389DS plugin

2014-09-30 Thread thierry bordaz
On 09/29/2014 08:30 PM, Nathaniel McCallum wrote: On Mon, 2014-09-22 at 09:32 -0400, Simo Sorce wrote: On Sun, 21 Sep 2014 22:33:47 -0400 Nathaniel McCallum wrote: Comments inline. + +#define ch_malloc(type) \ +(type*) slapi_ch_malloc(sizeof(type)) +#define ch_calloc(count, type) \ +

Re: [Freeipa-devel] [PATCH 0033] Remove trivial path constants

2014-09-30 Thread Petr Viktorin
On 09/30/2014 05:13 AM, Gabe Alford wrote: Updated patch to fix merge conflicts from recent changes. On Wed, Sep 24, 2014 at 8:34 PM, Gabe Alford mailto:redhatri...@gmail.com>> wrote: Hello, Patch for https://fedorahosted.org/freeipa/ticket/4399. Let me know if I missed any. T

Re: [Freeipa-devel] [PATCH] 0001 Refactor selinuxenabled check

2014-09-30 Thread Petr Viktorin
On 09/26/2014 06:34 PM, thierry bordaz wrote: On 09/26/2014 05:53 PM, Francesco Marella wrote: On 26/09/2014 17:43, thierry bordaz wrote: Hello, When called from set_selinux_booleans, if not selinux_enabled, you may want to 'return False' rather than 'return'. Now it looks like ca

Re: [Freeipa-devel] [PATCH 0064] Create ipa-otp-decrement 389DS plugin

2014-09-30 Thread Nathaniel McCallum
On Tue, 2014-09-30 at 18:30 +0200, thierry bordaz wrote: > On 09/29/2014 08:30 PM, Nathaniel McCallum wrote: > > > On Mon, 2014-09-22 at 09:32 -0400, Simo Sorce wrote: > > > On Sun, 21 Sep 2014 22:33:47 -0400 > > > Nathaniel McCallum wrote: > > > > > > Comments inline. > > > > > > > + > > > > +