Re: [Freeipa-devel] [PATCH] Add option to disable setkeytab extended operations

On Wed, 2015-12-02 at 08:40 +0100, Petr Spacek wrote: > On 1.12.2015 12:00, Alexander Bokovoy wrote: > > On Tue, 01 Dec 2015, Alexander Bokovoy wrote: > >> On Tue, 01 Dec 2015, Petr Spacek wrote: > >>> On 1.12.2015 09:47, Alexander Bokovoy wrote: > On Tue, 01 Dec 2015, Petr Spacek wrote: > >>>

Re: [Freeipa-devel] [PATCH 556-557] Add option to disable setkeytab extended operations

On Tue, 2015-12-01 at 16:44 +0100, Petr Vobornik wrote: > On 12/01/2015 04:20 PM, Alexander Bokovoy wrote: > > On Tue, 01 Dec 2015, Martin Kosek wrote: > >> On 12/01/2015 02:59 PM, Simo Sorce wrote: > >>> On Tue, 2015-12-01 at 14:42 +0100, Martin Kosek wrote: > On 12/01/2015 02:38 PM, Simo Sor

[Freeipa-devel] patch acceptance criteria

Is it still mandatory that tests pass the unit tests before acceptance? I've seen a number of cases over the past couple of months where a change goes through then shortly afterward a patch to fix the tests. IMHO this should be caught in advance. Things slip through and goodness knows I've acked m

[Freeipa-devel] [PATCH 0368] FIX DNS tests

Test needs to be updated due deprecation of dns-resolve command. Patch attached From 0166e2455b273a5f8f2811edd92b8287b5d77222 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Mon, 30 Nov 2015 19:04:02 +0100 Subject: [PATCH] Fix DNS tests: dns-resolve returns warning --- ipatests/test_xmlrpc/t

Re: [Freeipa-devel] [PATCH] Removed duplicate domain name validation function

On 02.12.2015 17:28, Martin Basti wrote: On 01.12.2015 16:03, Stanislav Laznicka wrote: Sending the patch with renamed function. Standa On 12/01/2015 09:57 AM, Jan Cholasta wrote: On 1.12.2015 09:37, Petr Spacek wrote: On 30.11.2015 20:00, Martin Basti wrote: On 27.11.2015 16:06, Stan

Re: [Freeipa-devel] [PATCH] Removed duplicate domain name validation function

On 01.12.2015 16:03, Stanislav Laznicka wrote: Sending the patch with renamed function. Standa On 12/01/2015 09:57 AM, Jan Cholasta wrote: On 1.12.2015 09:37, Petr Spacek wrote: On 30.11.2015 20:00, Martin Basti wrote: On 27.11.2015 16:06, Stanislav Laznicka wrote: Please, see the modif

Re: [Freeipa-devel] [PATCH 0364, 0367] ipa-kra-install: allow first KRA to be installed on replica

On 02.12.2015 14:52, Martin Babinsky wrote: On 11/30/2015 06:29 PM, Martin Basti wrote: On 30.11.2015 14:16, Martin Babinsky wrote: On 11/27/2015 05:02 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5460 I tested just master, I will test ipa-4-2 later. patch attached.

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

On (02/12/15 15:41), Tomas Babej wrote: > > >On 12/02/2015 09:24 AM, Tomas Babej wrote: >> >> >> On 12/01/2015 06:27 PM, Tomas Babej wrote: >>> >>> >>> On 11/30/2015 05:32 PM, Lukas Slebodnik wrote: On (30/11/15 13:09), Tomas Babej wrote: > Hi, > > IPA sudo tests worked under the

Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

On 02.12.2015 16:53, Aleš Mareček wrote: - Original Message - From: "Milan Kubík" To: "Martin Basti" Cc: freeipa-devel@redhat.com, "Aleš Mareček" Sent: Tuesday, December 1, 2015 10:31:14 AM Subject: Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

On 02.12.2015 16:18, Oleg Fayans wrote: Hi Martin, On 12/01/2015 04:08 PM, Martin Basti wrote: On 27.11.2015 16:26, Oleg Fayans wrote: And patch N 16 passes lint too: On 11/27/2015 04:03 PM, Oleg Fayans wrote: Hi, On 11/27/2015 03:26 PM, Martin Basti wrote: On 27.11.2015 15:04, Oleg

Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

- Original Message - > From: "Milan Kubík" > To: "Martin Basti" > Cc: freeipa-devel@redhat.com, "Aleš Mareček" > Sent: Tuesday, December 1, 2015 10:31:14 AM > Subject: Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations > into standalone package > > On 11/30/2015 07:13

[Freeipa-devel] [PATCH] 939 topologysuffix: change iparepltopoconfroot API properties

Change CLI option, label and type to reflect that it is a only a DN of the suffix. -- Petr Vobornik From 746ac711ba96e9f5726e2aa37814e376a197219c Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Tue, 1 Dec 2015 13:02:18 +0100 Subject: [PATCH] topologysuffix: change iparepltopoconfroot API prope

[Freeipa-devel] [PATCH 522] replica promotion: allow OTP bulk client enrollment

Hi, the attached patch fixes . Note that you still have to provide admin password in ipa-replica-install, either using --admin-password or interactively, because: a) Admin password is required for replica promotion. This will be fixed with

Re: [Freeipa-devel] [PATCH] First part of the replica promotion tests + testplan

Hi Martin, On 12/01/2015 04:08 PM, Martin Basti wrote: On 27.11.2015 16:26, Oleg Fayans wrote: And patch N 16 passes lint too: On 11/27/2015 04:03 PM, Oleg Fayans wrote: Hi, On 11/27/2015 03:26 PM, Martin Basti wrote: On 27.11.2015 15:04, Oleg Fayans wrote: Hi Martin, All your suggest

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

On 12/02/2015 09:24 AM, Tomas Babej wrote: > > > On 12/01/2015 06:27 PM, Tomas Babej wrote: >> >> >> On 11/30/2015 05:32 PM, Lukas Slebodnik wrote: >>> On (30/11/15 13:09), Tomas Babej wrote: Hi, IPA sudo tests worked under the assumption that the clients that are executing

Re: [Freeipa-devel] [PATCH 0364, 0367] ipa-kra-install: allow first KRA to be installed on replica

On 11/30/2015 06:29 PM, Martin Basti wrote: On 30.11.2015 14:16, Martin Babinsky wrote: On 11/27/2015 05:02 PM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5460 I tested just master, I will test ipa-4-2 later. patch attached. ACK for the master branch. Thanks, additiona

Re: [Freeipa-devel] [PATCH] 0748 Handle encoding for ipautil.run

On 12/02/2015 08:59 AM, Jan Cholasta wrote: > On 1.12.2015 12:26, Petr Viktorin wrote: >> On 11/30/2015 08:59 AM, Jan Cholasta wrote: >>> On 25.11.2015 15:47, Petr Viktorin wrote: On 11/25/2015 11:04 AM, Jan Cholasta wrote: > On 24.11.2015 17:21, Petr Viktorin wrote: >> On 11/23/2015 1

Re: [Freeipa-devel] [PATCH 0098-0099] domain level 1 topology checks during IPA server uninstall

On 02.12.2015 14:10, Martin Basti wrote: On 02.12.2015 14:08, Martin Babinsky wrote: On 12/02/2015 10:45 AM, Martin Babinsky wrote: On 12/01/2015 02:40 PM, Martin Babinsky wrote: On 11/30/2015 08:34 PM, Martin Basti wrote: On 30.11.2015 18:41, Martin Babinsky wrote: On 11/30/2015 06:15

Re: [Freeipa-devel] [PATCH 0098-0099] domain level 1 topology checks during IPA server uninstall

On 02.12.2015 14:08, Martin Babinsky wrote: On 12/02/2015 10:45 AM, Martin Babinsky wrote: On 12/01/2015 02:40 PM, Martin Babinsky wrote: On 11/30/2015 08:34 PM, Martin Basti wrote: On 30.11.2015 18:41, Martin Babinsky wrote: On 11/30/2015 06:15 PM, Martin Basti wrote: On 30.11.2015 16

Re: [Freeipa-devel] [PATCH 0098-0099] domain level 1 topology checks during IPA server uninstall

On 12/02/2015 10:45 AM, Martin Babinsky wrote: On 12/01/2015 02:40 PM, Martin Babinsky wrote: On 11/30/2015 08:34 PM, Martin Basti wrote: On 30.11.2015 18:41, Martin Babinsky wrote: On 11/30/2015 06:15 PM, Martin Basti wrote: On 30.11.2015 16:43, Martin Babinsky wrote: On 11/30/2015 12:3

Re: [Freeipa-devel] Testing replication topologies

Greetings! - Original Message - > From: "Martin Basti" > To: "freeipa-devel" , "Petr Vobornik" > , "Aleš Mareček" > > Sent: Wednesday, December 2, 2015 12:20:56 PM > Subject: Testing replication topologies > > Hello all, > > due to recent bug I found https://fedorahosted.org/freeipa/t

Re: [Freeipa-devel] [PATCH 25] Improve error logging for Dogtag subsystem installation

On 2.12.2015 13:23, Jan Cholasta wrote: > On 2.12.2015 12:54, Petr Spacek wrote: >> On 2.12.2015 12:51, Christian Heimes wrote: >>> On 2015-12-02 08:37, Petr Spacek wrote: On 1.12.2015 18:42, Christian Heimes wrote: > From 33be1f56a64e53d261a1058c4606a7e48c0aac52 Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH] 0749 Package ipapython, ipalib, ipaplatform, ipatests for Python 3

On 12/01/2015 02:37 PM, Jan Cholasta wrote: [...] > /etc/ipa/default.conf is managed by freeipa-client and thus should be owned > by it. > > This is a common pattern in other packages (even other FreeIPA > sub-packages) and I don't see any reason not to follow it here as well. OK. After your patc

Re: [Freeipa-devel] [PATCH 25] Improve error logging for Dogtag subsystem installation

On 2.12.2015 12:54, Petr Spacek wrote: On 2.12.2015 12:51, Christian Heimes wrote: On 2015-12-02 08:37, Petr Spacek wrote: On 1.12.2015 18:42, Christian Heimes wrote: From 33be1f56a64e53d261a1058c4606a7e48c0aac52 Mon Sep 17 00:00:00 2001 From: Christian Heimes Date: Tue, 1 Dec 2015 15:49:53

Re: [Freeipa-devel] [PATCH 25] Improve error logging for Dogtag subsystem installation

On 2.12.2015 12:51, Christian Heimes wrote: > On 2015-12-02 08:37, Petr Spacek wrote: >> On 1.12.2015 18:42, Christian Heimes wrote: >>> From 33be1f56a64e53d261a1058c4606a7e48c0aac52 Mon Sep 17 00:00:00 2001 >>> From: Christian Heimes >>> Date: Tue, 1 Dec 2015 15:49:53 +0100 >>> Subject: [PATCH 25

Re: [Freeipa-devel] [PATCH 25] Improve error logging for Dogtag subsystem installation

On 2015-12-02 08:37, Petr Spacek wrote: > On 1.12.2015 18:42, Christian Heimes wrote: >> From 33be1f56a64e53d261a1058c4606a7e48c0aac52 Mon Sep 17 00:00:00 2001 >> From: Christian Heimes >> Date: Tue, 1 Dec 2015 15:49:53 +0100 >> Subject: [PATCH 25] Improve error logging for Dogtag subsystem instal

Re: [Freeipa-devel] [PATCH 0389] translations: Update ipa.pot file

On 12/02/2015 11:30 AM, Tomas Babej wrote: Hi, the attached patch updates the translations in the master branch. There aren't much string changes between 4.2 and master, most of the bulk of the patch are changed references to the string locations. Thanks, Tomas ACK Pushed to master: f72f8

Re: [Freeipa-devel] [PATCH] 494 Update Contributors.txt

On 12/02/2015 12:35 PM, Martin Basti wrote: > > > On 02.12.2015 12:24, Martin Kosek wrote: >> +Thierry Bordaz >> >> +Thierry Bordaz >> > > Do we want this there? I do not want it there, but I had to add it since Author field in git was wrong when the patch was pushed. So I blame the

Re: [Freeipa-devel] [PATCH] 494 Update Contributors.txt

On 02.12.2015 12:24, Martin Kosek wrote: +Thierry Bordaz +Thierry Bordaz Do we want this there? -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] 494 Update Contributors.txt

On 12/02/2015 12:24 PM, Martin Kosek wrote: Update .mailmap with misconfigured patch authors since the last feature release. Based on the git history, add new Development contributors. ACK pushed to master 4a75a5f7ffd4f5060e84d04e5806b84e5605ddec -- Petr Vobornik -- Manage your subscriptio

[Freeipa-devel] [PATCH] 494 Update Contributors.txt

Update .mailmap with misconfigured patch authors since the last feature release. Based on the git history, add new Development contributors. -- Martin Kosek Associate Manager, Software Engineering - Identity Management Team Red Hat, Inc. From 78ab138e09cebfd4a8df12ae89d43867a40e13c4 Mon Sep 17 0

[Freeipa-devel] Testing replication topologies

Hello all, due to recent bug I found https://fedorahosted.org/freeipa/ticket/5506 I realized we do not have testing of complex topologies. On the other hand, test framework is ready and allows to testing 5 different topologies, can we create test which will test those 5 topologies with for e

Re: [Freeipa-devel] [IPAQE][REVIEW-REQUEST][TEST PLAN] Installation tests

On 02.12.2015 09:52, Oleg Fayans wrote: Hi all, I've updated the test plan according to your feedback. The tests for 'ca' suffix would be added to Topology Plugin testplan during this week. On 11/27/2015 04:37 PM, Martin Basti wrote: On 27.11.2015 15:05, Martin Basti wrote: On 26.11

Re: [Freeipa-devel] [PATCH 0069] ipa-replica-install support caless install with promotion.

On 02/12/15 07:58, Jan Cholasta wrote: On 1.12.2015 14:27, David Kupka wrote: On 30/11/15 17:24, Jan Cholasta wrote: Hi, On 27.11.2015 07:57, David Kupka wrote: On 26/11/15 15:22, David Kupka wrote: On 26/11/15 15:13, David Kupka wrote: On 26/11/15 15:01, David Kupka wrote: https://fedorah

Re: [Freeipa-devel] [PATCH 0098-0099] domain level 1 topology checks during IPA server uninstall

On 12/01/2015 02:40 PM, Martin Babinsky wrote: On 11/30/2015 08:34 PM, Martin Basti wrote: On 30.11.2015 18:41, Martin Babinsky wrote: On 11/30/2015 06:15 PM, Martin Basti wrote: On 30.11.2015 16:43, Martin Babinsky wrote: On 11/30/2015 12:31 PM, Jan Cholasta wrote: Hi, On 27.11.2015 14

Re: [Freeipa-devel] [PATCH 0385] replicainstall: Add possiblity to install client in one

On 12/02/2015 09:53 AM, Martin Babinsky wrote: > On 12/01/2015 04:33 PM, Jan Cholasta wrote: >> On 1.12.2015 16:19, Tomas Babej wrote: >>> >>> >>> On 12/01/2015 08:19 AM, Jan Cholasta wrote: On 30.11.2015 19:17, Simo Sorce wrote: > On Mon, 2015-11-30 at 12:25 +0100, Tomas Babej wrote: >>

Re: [Freeipa-devel] [PATCH 0385] replicainstall: Add possiblity to install client in one

On 12/01/2015 04:33 PM, Jan Cholasta wrote: On 1.12.2015 16:19, Tomas Babej wrote: On 12/01/2015 08:19 AM, Jan Cholasta wrote: On 30.11.2015 19:17, Simo Sorce wrote: On Mon, 2015-11-30 at 12:25 +0100, Tomas Babej wrote: +# Perform only if we have the necessary options +if not any([i

Re: [Freeipa-devel] [IPAQE][REVIEW-REQUEST][TEST PLAN] Installation tests

Hi all, I've updated the test plan according to your feedback. The tests for 'ca' suffix would be added to Topology Plugin testplan during this week. On 11/27/2015 04:37 PM, Martin Basti wrote: On 27.11.2015 15:05, Martin Basti wrote: On 26.11.2015 14:39, Petr Vobornik wrote: On 11/23

Re: [Freeipa-devel] [PATCH 0388] tests: Add hostmask detection for sudo rules validating

On 12/01/2015 06:27 PM, Tomas Babej wrote: > > > On 11/30/2015 05:32 PM, Lukas Slebodnik wrote: >> On (30/11/15 13:09), Tomas Babej wrote: >>> Hi, >>> >>> IPA sudo tests worked under the assumption that the clients that >>> are executing the sudo commands have their IPs assigned within >>> 255.