Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

2016-08-02 Thread Jan Pazdziora
On Tue, Aug 02, 2016 at 05:57:38PM +0300, Alexander Bokovoy wrote: > On Mon, 01 Aug 2016, Rob Crittenden wrote: > > > > How/where does the UI get a Kerberos ticket for the user? > That's indeed a problem -- even with the PKINIT support in KDC that Simo > is polishing up now, we don't have a way to

Re: [Freeipa-devel] [PATCH 0032] Secure permission and cleanup Custodia server.keys

2016-08-02 Thread Christian Heimes
On 2016-07-19 17:03, Martin Basti wrote: > > > On 12.07.2016 16:45, Christian Heimes wrote: >> Custodia's server.keys file contain the private RSA keys for encrypting >> and signing Custodia messages. The file was created with permission 644 >> and is only secured by permission 700 of the directo

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Pavel Vomacka
On 08/02/2016 05:31 PM, Pavel Vomacka wrote: On 08/02/2016 05:27 PM, Martin Basti wrote: On 02.08.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote: Hello, please review attached patches which Split make lint to more targets and add jslint What's the driver to split the checks ou

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Rob Crittenden
Petr Spacek wrote: On 2.8.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote: Hello, please review attached patches which Split make lint to more targets and add jslint What's the driver to split the checks out into separate targets? Most importantly, makeapi and makeaci do not need to

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Pavel Vomacka
On 08/02/2016 05:27 PM, Martin Basti wrote: On 02.08.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote: Hello, please review attached patches which Split make lint to more targets and add jslint What's the driver to split the checks out into separate targets? It is called several

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Petr Spacek
On 2.8.2016 17:12, Rob Crittenden wrote: > Pavel Vomacka wrote: >> Hello, >> >> please review attached patches which Split make lint to more targets and >> add jslint > > What's the driver to split the checks out into separate targets? > > You are moving the makeapi and makeaci from version-updat

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Petr Spacek
On 2.8.2016 17:12, Rob Crittenden wrote: > Pavel Vomacka wrote: >> Hello, >> >> please review attached patches which Split make lint to more targets and >> add jslint > > What's the driver to split the checks out into separate targets? Most importantly, makeapi and makeaci do not need to be calle

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Martin Basti
On 02.08.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote: Hello, please review attached patches which Split make lint to more targets and add jslint What's the driver to split the checks out into separate targets? It is called several times during build (makes build slower), and you

Re: [Freeipa-devel] [PATCH 33] Correct path to HTTPD's systemd service directory

2016-08-02 Thread Martin Basti
On 02.08.2016 17:12, Abhijeet Kasurde wrote: On 08/02/2016 08:32 PM, Christian Heimes wrote: Ticket #5681 and commit 586fee293f42388510fa5436af19460bbe1fdec5 changed the location of the ipa.conf for Apache HTTPD. The variables SYSTEMD_SYSTEM_HTTPD_D_DIR and SYSTEMD_SYSTEM_HTTPD_IPA_CONF poi

Re: [Freeipa-devel] [PATCH 33] Correct path to HTTPD's systemd service directory

2016-08-02 Thread Abhijeet Kasurde
On 08/02/2016 08:32 PM, Christian Heimes wrote: Ticket #5681 and commit 586fee293f42388510fa5436af19460bbe1fdec5 changed the location of the ipa.conf for Apache HTTPD. The variables SYSTEMD_SYSTEM_HTTPD_D_DIR and SYSTEMD_SYSTEM_HTTPD_IPA_CONF point to the wrong directory /etc/systemd/system/htt

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Rob Crittenden
Pavel Vomacka wrote: Hello, please review attached patches which Split make lint to more targets and add jslint What's the driver to split the checks out into separate targets? You are moving the makeapi and makeaci from version-update to lint. They were in version-update for a reason: downs

[Freeipa-devel] [PATCH 33] Correct path to HTTPD's systemd service directory

2016-08-02 Thread Christian Heimes
Ticket #5681 and commit 586fee293f42388510fa5436af19460bbe1fdec5 changed the location of the ipa.conf for Apache HTTPD. The variables SYSTEMD_SYSTEM_HTTPD_D_DIR and SYSTEMD_SYSTEM_HTTPD_IPA_CONF point to the wrong directory /etc/systemd/system/httpd.d/. The path is corrected to /etc/systemd/system

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

2016-08-02 Thread Alexander Bokovoy
On Mon, 01 Aug 2016, Rob Crittenden wrote: Tibor Dudlak wrote: Hi, I have added few lines to code to make optional login with personal certificate (or with smartcard) possible. Some ui changes has to be made. It is not cosher but it definitely work. Thank you, Tibor What about the Apache ch

[Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-02 Thread Pavel Vomacka
Hello, please review attached patches which Split make lint to more targets and add jslint -- Pavel^3 Vomacka From f32919a910dc98301b373a47cc72f68b1310c0ee Mon Sep 17 00:00:00 2001 From: Pavel Vomacka Date: Tue, 2 Aug 2016 16:44:10 +0200 Subject: [PATCH 1/2] Split targets in Makefile Separa

Re: [Freeipa-devel] [PATCH 0003] Test validity of URIs in certificate

2016-08-02 Thread Lenka Doudova
On 07/29/2016 11:43 AM, Lenka Doudova wrote: On 07/29/2016 11:41 AM, Lenka Doudova wrote: On 07/28/2016 01:35 PM, Peter Lacko wrote: Hops, fixed. Peter - Original Message - From: "Lenka Doudova" To:freeipa-devel@redhat.com Sent: Thursday, July 28, 2016 1:32:25 PM Subject: Re: [

Re: [Freeipa-devel] [PATCH 0058] Make get_entries not ignore its size_limit argument

2016-08-02 Thread Stanislav Laznicka
On 07/19/2016 09:20 AM, Jan Cholasta wrote: Hi, On 14.7.2016 14:36, Stanislav Laznicka wrote: Hello, This patch fixes https://fedorahosted.org/freeipa/ticket/5640. With not so much experience with the framework, it raises question in my head whether ipaldap.get_entries is used properly throug

[Freeipa-devel] [PATCH] 0013 Fix ipa hbactest output

2016-08-02 Thread Florence Blanc-Renaud
Hi, please find attached a patch related to 'ipa hbactest' producing a Traceback. https://fedorahosted.org/freeipa/ticket/6157 Flo. >From 38a855bfc1279ae38ac3f8083903af29e9e00a8b Mon Sep 17 00:00:00 2001 From: Florence Blanc-Renaud Date: Tue, 2 Aug 2016 10:40:54 +0200 Subject: [PATCH] Fix ip

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-08-02 Thread Oleg Fayans
Hi Martin, I did! Thank you! On 08/02/2016 12:31 PM, Martin Basti wrote: On 01.08.2016 22:46, Oleg Fayans wrote: The test was redesigned so that it actually tests against an AD user. cleanly applies, passes lint and passes https://paste.fedoraproject.org/399504/00843641/ Okay Did you for

Re: [Freeipa-devel] [PATCH 0048] Remove sys.exit() from installer modules

2016-08-02 Thread Stanislav Laznicka
On 07/28/2016 10:57 AM, Martin Basti wrote: On 17.06.2016 13:56, Stanislav Laznicka wrote: On 06/17/2016 01:01 PM, Petr Vobornik wrote: On 17.6.2016 12:12, Stanislav Laznicka wrote: On 06/17/2016 09:51 AM, Petr Vobornik wrote: On 17.6.2016 09:24, Stanislav Laznicka wrote: On 06/17/2016 08:48

Re: [Freeipa-devel] [Test][Patch-0049, 0050] Certs in ID overrides test

2016-08-02 Thread Martin Basti
On 01.08.2016 22:46, Oleg Fayans wrote: The test was redesigned so that it actually tests against an AD user. cleanly applies, passes lint and passes https://paste.fedoraproject.org/399504/00843641/ Okay Did you forget to send patches? Martin^2 On 06/28/2016 01:40 PM, Oleg Fayans wrote

Re: [Freeipa-devel] [PATCH 0059] Fix to ipa-cacert-manage man and help differences

2016-08-02 Thread Stanislav Laznicka
On 07/19/2016 10:25 AM, Florence Blanc-Renaud wrote: On 07/15/2016 02:09 PM, Stanislav Laznicka wrote: https://fedorahosted.org/freeipa/ticket/6013 Hi Stanislav, thanks for your patch. As CERTFILE is added in the arguments for install, I would suggest to mention it in the command descripti