Re: [Freeipa-devel] [PATCH 0060] Add --force-join option to ipa-replica-install

2016-08-09 Thread Stanislav Laznicka
On 08/10/2016 07:31 AM, Jan Cholasta wrote: On 9.8.2016 18:52, Petr Vobornik wrote: On 08/09/2016 04:18 PM, Martin Basti wrote: On 09.08.2016 16:07, Stanislav Laznicka wrote: https://fedorahosted.org/freeipa/ticket/6183 Didn't we agreed that --force-join should be always used (without

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-09 Thread Jan Cholasta
On 9.8.2016 13:00, Martin Basti wrote: On 05.08.2016 16:44, Martin Basti wrote: On 02.08.2016 18:08, Pavel Vomacka wrote: On 08/02/2016 05:31 PM, Pavel Vomacka wrote: On 08/02/2016 05:27 PM, Martin Basti wrote: On 02.08.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote:

Re: [Freeipa-devel] [PATCH 0154] client: RPM require initscripts to get *-domainname.service

2016-08-09 Thread Jan Cholasta
On 8.8.2016 13:48, Petr Spacek wrote: On 8.8.2016 13:37, Jan Cholasta wrote: Hi, On 8.8.2016 13:22, Petr Spacek wrote: Hello, client: RPM require initscripts to get *-domainname.service https://fedorahosted.org/freeipa/ticket/4831 IIRC there was a task associated with the ticket to

Re: [Freeipa-devel] [PATCH 0060] Add --force-join option to ipa-replica-install

2016-08-09 Thread Jan Cholasta
On 9.8.2016 18:52, Petr Vobornik wrote: On 08/09/2016 04:18 PM, Martin Basti wrote: On 09.08.2016 16:07, Stanislav Laznicka wrote: https://fedorahosted.org/freeipa/ticket/6183 Didn't we agreed that --force-join should be always used (without extra replica-install option) +1 Did we?

Re: [Freeipa-devel] [PATCH 0013-0015] Automatic CSR generation - usability improvements

2016-08-09 Thread Ben Lipton
Aaand there's a typo in patch 15. Updated version attached. On 08/09/2016 02:22 PM, Ben Lipton wrote: Hello, The attached patches improve upon my last patchset to: 0013: Add support for generating a full script that makes a CSR, rather than just a config, and use that support to automate the

[Freeipa-devel] [PATCH 0013-0015] Automatic CSR generation - usability improvements

2016-08-09 Thread Ben Lipton
Hello, The attached patches improve upon my last patchset to: 0013: Add support for generating a full script that makes a CSR, rather than just a config, and use that support to automate the full flow from script generation through cert issuance Usage note: the UI for this could probably use

Re: [Freeipa-devel] [PATCH 0060] Add --force-join option to ipa-replica-install

2016-08-09 Thread Petr Vobornik
On 08/09/2016 04:18 PM, Martin Basti wrote: > > > On 09.08.2016 16:07, Stanislav Laznicka wrote: >> https://fedorahosted.org/freeipa/ticket/6183 >> >> >> > Didn't we agreed that --force-join should be always used (without extra > replica-install option) +1 > > Martin^2 > -- Petr Vobornik

Re: [Freeipa-devel] [PATCH 0561] backup: backup /etc/tmpfiles.d/dirsrv-instance-*

2016-08-09 Thread Martin Basti
On 09.08.2016 18:27, Petr Spacek wrote: On 9.8.2016 12:37, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/6165 ACK Pushed to master: 148e021ac11793d77561fd7ffd3d11ecc09d86a5 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0561] backup: backup /etc/tmpfiles.d/dirsrv-instance-*

2016-08-09 Thread Petr Spacek
On 9.8.2016 12:37, Martin Basti wrote: > https://fedorahosted.org/freeipa/ticket/6165 ACK -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH] ipa-kdb: Allow to build with samba 4.5

2016-08-09 Thread Lukas Slebodnik
On (09/08/16 17:08), Alexander Bokovoy wrote: >On Tue, 09 Aug 2016, Lukas Slebodnik wrote: >> On (09/08/16 14:59), Alexander Bokovoy wrote: >> > On Fri, 05 Aug 2016, Lukas Slebodnik wrote: >> > > ehlo, >> > > >> > > attached patches fix a build of freeipa on fedora 25 and fedora rawhide. >> > >

[Freeipa-devel] [PATCH 0003][Tests] Fix for integration tests replication layouts

2016-08-09 Thread Ganna Kaihorodova
Hello! Domain level 0 doesn't allow to create replica file on CA master, testcase was skipped with Domain level 0 https://fedorahosted.org/freeipa/ticket/6134 Best regards, Ganna Kaihorodova Associate Software Quality Engineer From 7a586aff4b3709d19ac503340b686ab161e6514a Mon Sep 17 00:00:00

Re: [Freeipa-devel] [PATCH] 0097 Add options to write lightweight CA cert or chain to file

2016-08-09 Thread Fraser Tweedale
On Mon, Aug 08, 2016 at 10:49:27AM +0200, Jan Cholasta wrote: > On 8.8.2016 09:06, Fraser Tweedale wrote: > > On Mon, Aug 08, 2016 at 08:54:05AM +0200, Jan Cholasta wrote: > > > Hi, > > > > > > On 8.8.2016 06:34, Fraser Tweedale wrote: > > > > Please review the attached patch with adds

Re: [Freeipa-devel] [PATCH] 0100: Fix question marks in adders in topology graph

2016-08-09 Thread Martin Basti
On 08.08.2016 13:32, Pavel Vomacka wrote: On 08/05/2016 02:15 PM, Pavel Vomacka wrote: Hello, Please review attached patch. https://fedorahosted.org/freeipa/ticket/6175 Changed commit message. -- Pavel^3 Vomacka ACK Pushed to master: 0fdbad1e1a146d7754e0f5377696a9341d50907b --

Re: [Freeipa-devel] [PATCH 0002] Fix ipa-caacl-add-service error message

2016-08-09 Thread Martin Basti
On 09.08.2016 16:18, Petr Spacek wrote: On 9.8.2016 16:16, Tomas Krizek wrote: Hi, please review the attached patch. ACK Pushed to master: af4ebaca6293779ef686c7bacffbc97945ebee95 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 0060] Add --force-join option to ipa-replica-install

2016-08-09 Thread Martin Basti
On 09.08.2016 16:07, Stanislav Laznicka wrote: https://fedorahosted.org/freeipa/ticket/6183 Didn't we agreed that --force-join should be always used (without extra replica-install option) Martin^2 -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH 686] Revert "spec: add conflict with bind-chroot to freeipa-server-dns"

2016-08-09 Thread Martin Basti
On 09.08.2016 16:15, Petr Spacek wrote: On 9.8.2016 14:16, Jan Cholasta wrote: Hi, the attached patch fixes . ACK For historians: Further discussion can be found in https://bugzilla.redhat.com/show_bug.cgi?id=1309700. Pushed to: master:

Re: [Freeipa-devel] [PATCH 0002] Fix ipa-caacl-add-service error message

2016-08-09 Thread Petr Spacek
On 9.8.2016 16:16, Tomas Krizek wrote: > Hi, > > please review the attached patch. ACK -- Petr^2 Spacek -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [PATCH 0002] Fix ipa-caacl-add-service error message

2016-08-09 Thread Tomas Krizek
Hi, please review the attached patch. Thanks, Tomas From 9787d13cd7f0f3b8ce65ca84a7759f180a74d6d8 Mon Sep 17 00:00:00 2001 From: Tomas Krizek Date: Tue, 9 Aug 2016 14:09:24 +0200 Subject: [PATCH] Fix ipa-caalc-add-service error message When service is not found in

Re: [Freeipa-devel] [PATCH 686] Revert "spec: add conflict with bind-chroot to freeipa-server-dns"

2016-08-09 Thread Petr Spacek
On 9.8.2016 14:16, Jan Cholasta wrote: > Hi, > > the attached patch fixes . ACK For historians: Further discussion can be found in https://bugzilla.redhat.com/show_bug.cgi?id=1309700. -- Petr^2 Spacek -- Manage your subscription for the

Re: [Freeipa-devel] [PATCH] ipa-kdb: Allow to build with samba 4.5

2016-08-09 Thread Alexander Bokovoy
On Tue, 09 Aug 2016, Lukas Slebodnik wrote: On (09/08/16 14:59), Alexander Bokovoy wrote: On Fri, 05 Aug 2016, Lukas Slebodnik wrote: ehlo, attached patches fix a build of freeipa on fedora 25 and fedora rawhide. IMHO, this change in krb5pac.h is an ABI change and samba guys should also bump

Re: [Freeipa-devel] [PATCH 0059] Fix to ipa-cacert-manage man and help differences

2016-08-09 Thread Martin Basti
On 09.08.2016 15:13, Florence Blanc-Renaud wrote: On 08/02/2016 09:11 AM, Stanislav Laznicka wrote: On 07/19/2016 10:25 AM, Florence Blanc-Renaud wrote: On 07/15/2016 02:09 PM, Stanislav Laznicka wrote: https://fedorahosted.org/freeipa/ticket/6013 Hi Stanislav, thanks for your patch.

Re: [Freeipa-devel] [PATCH] ipa-kdb: Allow to build with samba 4.5

2016-08-09 Thread Lukas Slebodnik
On (09/08/16 14:59), Alexander Bokovoy wrote: >On Fri, 05 Aug 2016, Lukas Slebodnik wrote: >> ehlo, >> >> attached patches fix a build of freeipa on fedora 25 and fedora rawhide. >> IMHO, this change in krb5pac.h is an ABI change and samba guys should >> also bump a SONAME to related (private?)

Re: [Freeipa-devel] [PATCH 0057] Don't show part of warning containing --force-ntpd in replica install

2016-08-09 Thread Stanislav Laznicka
On 08/04/2016 07:34 AM, Jan Cholasta wrote: On 3.8.2016 19:39, Martin Basti wrote: On 03.08.2016 18:10, Petr Vobornik wrote: On 07/13/2016 12:36 PM, Stanislav Laznicka wrote: On 07/13/2016 09:51 AM, Petr Vobornik wrote: On 07/13/2016 08:26 AM, Stanislav Laznicka wrote: On 07/12/2016 08:44

Re: [Freeipa-devel] [PATCH 0059] Fix to ipa-cacert-manage man and help differences

2016-08-09 Thread Florence Blanc-Renaud
On 08/02/2016 09:11 AM, Stanislav Laznicka wrote: On 07/19/2016 10:25 AM, Florence Blanc-Renaud wrote: On 07/15/2016 02:09 PM, Stanislav Laznicka wrote: https://fedorahosted.org/freeipa/ticket/6013 Hi Stanislav, thanks for your patch. As CERTFILE is added in the arguments for install, I

Re: [Freeipa-devel] [PATCH] ipa-kdb: Allow to build with samba 4.5

2016-08-09 Thread Martin Basti
On 09.08.2016 13:59, Alexander Bokovoy wrote: On Fri, 05 Aug 2016, Lukas Slebodnik wrote: ehlo, attached patches fix a build of freeipa on fedora 25 and fedora rawhide. IMHO, this change in krb5pac.h is an ABI change and samba guys should also bump a SONAME to related (private?) libraries. I

[Freeipa-devel] [PATCH 686] Revert "spec: add conflict with bind-chroot to freeipa-server-dns"

2016-08-09 Thread Jan Cholasta
Hi, the attached patch fixes . Honza -- Jan Cholasta From 5158ea147f6b6df93b5834d993114a2251202791 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Tue, 9 Aug 2016 14:12:50 +0200 Subject: [PATCH] Revert "spec: add conflict

Re: [Freeipa-devel] [PATCH] ipa-kdb: Allow to build with samba 4.5

2016-08-09 Thread Alexander Bokovoy
On Fri, 05 Aug 2016, Lukas Slebodnik wrote: ehlo, attached patches fix a build of freeipa on fedora 25 and fedora rawhide. IMHO, this change in krb5pac.h is an ABI change and samba guys should also bump a SONAME to related (private?) libraries. I could not see it; but maybe I overlooked it. It

Re: [Freeipa-devel] [PATCH 0034] Secure permissions of Custodia server.keys

2016-08-09 Thread Martin Basti
On 08.08.2016 16:09, Christian Heimes wrote: I have split up patch 0032 into two smaller patches. This patch only addresses the server.keys file. Custodia's server.keys file contain the private RSA keys for encrypting and signing Custodia messages. The file was created with permission 644 and

Re: [Freeipa-devel] [PATCH 0213] support multiple uid values in slapi-nis users map

2016-08-09 Thread Alexander Bokovoy
On Tue, 09 Aug 2016, thierry bordaz wrote: On 08/09/2016 12:49 PM, Martin Basti wrote: On 08.08.2016 17:30, thierry bordaz wrote: On 08/08/2016 05:20 PM, Alexander Bokovoy wrote: On Mon, 08 Aug 2016, thierry bordaz wrote: On 08/08/2016 04:20 PM, Alexander Bokovoy wrote: On Mon, 08

[Freeipa-devel] [PATCH] webui: 0084, 0101: refactoring rpc module

2016-08-09 Thread Pavel Vomacka
Hello, please review attached patches. The rpc module is now separated from display layer and changing activity text while loading metadata. https://fedorahosted.org/freeipa/ticket/6144 -- Pavel^3 Vomacka From e8253e5327c008f291e1401c81f68f4f3b194ded Mon Sep 17 00:00:00 2001 From: Pavel

Re: [Freeipa-devel] [PATCH 0213] support multiple uid values in slapi-nis users map

2016-08-09 Thread thierry bordaz
On 08/09/2016 12:49 PM, Martin Basti wrote: On 08.08.2016 17:30, thierry bordaz wrote: On 08/08/2016 05:20 PM, Alexander Bokovoy wrote: On Mon, 08 Aug 2016, thierry bordaz wrote: On 08/08/2016 04:20 PM, Alexander Bokovoy wrote: On Mon, 08 Aug 2016, thierry bordaz wrote: On

Re: [Freeipa-devel] [PATCH 0032] Secure permission and cleanup Custodia server.keys

2016-08-09 Thread Martin Basti
On 03.08.2016 20:21, Martin Basti wrote: On 03.08.2016 19:18, Martin Basti wrote: On 02.08.2016 20:02, Christian Heimes wrote: On 2016-07-19 17:03, Martin Basti wrote: On 12.07.2016 16:45, Christian Heimes wrote: Custodia's server.keys file contain the private RSA keys for encrypting

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

2016-08-09 Thread Martin Basti
On 05.08.2016 16:44, Martin Basti wrote: On 02.08.2016 18:08, Pavel Vomacka wrote: On 08/02/2016 05:31 PM, Pavel Vomacka wrote: On 08/02/2016 05:27 PM, Martin Basti wrote: On 02.08.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote: Hello, please review attached patches which

Re: [Freeipa-devel] [PATCH 0213] support multiple uid values in slapi-nis users map

2016-08-09 Thread Martin Basti
On 08.08.2016 17:30, thierry bordaz wrote: On 08/08/2016 05:20 PM, Alexander Bokovoy wrote: On Mon, 08 Aug 2016, thierry bordaz wrote: On 08/08/2016 04:20 PM, Alexander Bokovoy wrote: On Mon, 08 Aug 2016, thierry bordaz wrote: On 08/08/2016 10:56 AM, Alexander Bokovoy wrote: On Mon,

[Freeipa-devel] [PATCH 0561] backup: backup /etc/tmpfiles.d/dirsrv-instance-*

2016-08-09 Thread Martin Basti
https://fedorahosted.org/freeipa/ticket/6165 Patch attached. From 2d959938873f9a5129ffb1aa860d22dfdf3f1bc1 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Fri, 5 Aug 2016 17:35:49 +0200 Subject: [PATCH] ipa-backup: backup /etc/tmpfiles.d/dirsrv-.conf This file allows

Re: [Freeipa-devel] [PATCH] ca-less tests updated

2016-08-09 Thread Oleg Fayans
Hi all, Bump for the review of the 0013 patch. The script it addresses can be reused in some WebUI tests - one more reason to have it reviewed/merged The rest patches should be re-tested, since they were prepared a good while ago On 05/10/2016 05:08 PM, Oleg Fayans wrote: Hi David, After