[Freeipa-devel] [freeipa PR#62][comment] Configure Anonymous PKINIT on server install

2016-12-01 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/62 Title: #62: Configure Anonymous PKINIT on server install abbra commented: """ @simo5 https://github.com/abbra/freeipa/tree/kdc-pkinit can be used for rebase of this PR """ See the full comment at

[Freeipa-devel] [freeipa PR#228][closed] cert-request: allow directoryName in SAN extension

2016-12-01 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/228 Author: frasertweedale Title: #228: cert-request: allow directoryName in SAN extension Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/228/head:pr228 git checkout

[Freeipa-devel] [freeipa PR#228][comment] cert-request: allow directoryName in SAN extension

2016-12-01 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/228 Title: #228: cert-request: allow directoryName in SAN extension frasertweedale commented: """ I'm closing this PR (and associated ticket). I felt it was an uncontroversial change (and tbh it looks like there are numbers on my side), but noone is

[Freeipa-devel] [freeipa PR#299][opened] Remove "Request Certificate with SubjectAltName" permission

2016-12-01 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/299 Author: frasertweedale Title: #299: Remove "Request Certificate with SubjectAltName" permission Action: opened PR body: """ Fixes: https://fedorahosted.org/freeipa/ticket/6526 *Note: the ticket hasn't been triaged or even agreed to. But here

[Freeipa-devel] [freeipa PR#298][opened] ipaldap: handle binary encoding option transparently

2016-12-01 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/298 Author: frasertweedale Title: #298: ipaldap: handle binary encoding option transparently Action: opened PR body: """ This patchset addresses https://fedorahosted.org/freeipa/ticket/6529. I'm publishing it for discussion and review but it

[Freeipa-devel] [freeipa PR#62][comment] Configure Anonymous PKINIT on server install

2016-12-01 Thread abbra
URL: https://github.com/freeipa/freeipa/pull/62 Title: #62: Configure Anonymous PKINIT on server install abbra commented: """ @simo5 I did a rebase a while a go and maintain it rebased against the master. I'll submit a new PR with the rebase. """ See the full comment at

[Freeipa-devel] [freeipa PR#227][comment] cert-request: match names against principal aliases

2016-12-01 Thread frasertweedale
URL: https://github.com/freeipa/freeipa/pull/227 Title: #227: cert-request: match names against principal aliases frasertweedale commented: """ @martbab I agree with doing the refactor you propose, but I deem it out of scope for this ticket. Doing that refactor entails a cleanup of how we

[Freeipa-devel] [freeipa PR#288][comment] Fix missing translation string

2016-12-01 Thread shanyin
URL: https://github.com/freeipa/freeipa/pull/288 Title: #288: Fix missing translation string shanyin commented: """ Ok, I have done changes, commit and push operations on local branch. Thanks! @martbab @mbasti-rh """ See the full comment at

[Freeipa-devel] [freeipa PR#62][comment] Configure Anonymous PKINIT on server install

2016-12-01 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/62 Title: #62: Configure Anonymous PKINIT on server install simo5 commented: """ @abbra this code needs rebase and I need it as dependency for solving ticket #5959, did you do any work on this ? If not I'll rebase tomorrow. """ See the full comment

[Freeipa-devel] [freeipa PR#206][comment] Properly handle multiple cookies in rpcclient

2016-12-01 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/206 Title: #206: Properly handle multiple cookies in rpcclient simo5 commented: """ This new patch should fix it. """ See the full comment at https://github.com/freeipa/freeipa/pull/206#issuecomment-264299396 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#206][synchronized] Properly handle multiple cookies in rpcclient

2016-12-01 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/206 Author: simo5 Title: #206: Properly handle multiple cookies in rpcclient Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/206/head:pr206 git checkout pr206

[Freeipa-devel] [freeipa PR#297][opened] Adjustments for setup requirements v2

2016-12-01 Thread pvomacka
URL: https://github.com/freeipa/freeipa/pull/297 Author: pvomacka Title: #297: Adjustments for setup requirements v2 Action: opened PR body: """ Remove setup requirement on wheel since it triggers download. https://fedorahosted.org/freeipa/ticket/6468 """ To pull the PR as Git branch: git

[Freeipa-devel] [freeipa PR#293][synchronized] Run out-of-tree tests in Travis CI

2016-12-01 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/293 Author: martbab Title: #293: Run out-of-tree tests in Travis CI Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/293/head:pr293 git checkout pr293 From

[Freeipa-devel] [freeipa PR#296][comment] Require python-gssapi >= 1.2.0, take 2

2016-12-01 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/296 Title: #296: Require python-gssapi >= 1.2.0, take 2 martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/5dc5960e715b378b6090935ba133d6f332427de5 """ See the full comment at

[Freeipa-devel] [freeipa PR#296][+pushed] Require python-gssapi >= 1.2.0, take 2

2016-12-01 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/296 Title: #296: Require python-gssapi >= 1.2.0, take 2 Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#295][comment] Issue6474 fixups

2016-12-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/295 Title: #295: Issue6474 fixups stlaz commented: """ Good :) The tests seem to pass, the changes are trivial, ACK. """ See the full comment at https://github.com/freeipa/freeipa/pull/295#issuecomment-264207266 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#295][+ack] Issue6474 fixups

2016-12-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/295 Title: #295: Issue6474 fixups Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#296][closed] Require python-gssapi >= 1.2.0, take 2

2016-12-01 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/296 Author: tiran Title: #296: Require python-gssapi >= 1.2.0, take 2 Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/296/head:pr296 git checkout pr296 -- Manage

[Freeipa-devel] [freeipa PR#296][+ack] Require python-gssapi >= 1.2.0, take 2

2016-12-01 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/296 Title: #296: Require python-gssapi >= 1.2.0, take 2 Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-12-01 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/280 Title: #280: Set explicit confdir option for global contexts pvoborni commented: """ Lets push this code if it is correct but only misses usecases mentioned above". Honza will implement the missing usecases in separate PR. """ See the full

[Freeipa-devel] [freeipa PR#295][comment] Issue6474 fixups

2016-12-01 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/295 Title: #295: Issue6474 fixups tiran commented: """ Yes, that is fine. The other tests all depend on ipaserver package or a running FreeIPA server anyway. ipatests for ipalib and ipapython allow me to run tests on the standalone packages. (Peek

[Freeipa-devel] [freeipa PR#296][opened] equire python-gssapi >= 1.2.0, take 2

2016-12-01 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/296 Author: tiran Title: #296: equire python-gssapi >= 1.2.0, take 2 Action: opened PR body: """ Fix version range typo in ipasetup.py.in. Sorry, the bug slipped through my internal tests. The version pinning is only relevant for make

[Freeipa-devel] [freeipa PR#296][synchronized] Require python-gssapi >= 1.2.0, take 2

2016-12-01 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/296 Author: tiran Title: #296: Require python-gssapi >= 1.2.0, take 2 Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/296/head:pr296 git checkout pr296 From

[Freeipa-devel] [freeipa PR#296][edited] Require python-gssapi >= 1.2.0, take 2

2016-12-01 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/296 Author: tiran Title: #296: Require python-gssapi >= 1.2.0, take 2 Action: edited Changed field: title Original value: """ equire python-gssapi >= 1.2.0, take 2 """ -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [freeipa PR#296][comment] equire python-gssapi >= 1.2.0, take 2

2016-12-01 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/296 Title: #296: equire python-gssapi >= 1.2.0, take 2 tiran commented: """ Fix for typo introduced in #289 """ See the full comment at https://github.com/freeipa/freeipa/pull/296#issuecomment-264196691 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#295][comment] Issue6474 fixups

2016-12-01 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/295 Title: #295: Issue6474 fixups stlaz commented: """ There are some more ipaplatform imports left, some in test_xmlrpc, test_webui, test_install and test_cmdline (of which I think may interest you). Is it ok these are left there? """ See the

[Freeipa-devel] [freeipa PR#267][comment] ipa-replica-conncheck: do not close listening ports until required

2016-12-01 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/267 Title: #267: ipa-replica-conncheck: do not close listening ports until required mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/af0ba661889c2e2c9a35d4cff9681c2abab73649 """ See the full comment at

[Freeipa-devel] [freeipa PR#267][+pushed] ipa-replica-conncheck: do not close listening ports until required

2016-12-01 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/267 Title: #267: ipa-replica-conncheck: do not close listening ports until required Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#263][+pushed] Backwards compatibility with setuptools 0.9.8

2016-12-01 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/263 Title: #263: Backwards compatibility with setuptools 0.9.8 Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA:

[Freeipa-devel] [freeipa PR#263][comment] Backwards compatibility with setuptools 0.9.8

2016-12-01 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/263 Title: #263: Backwards compatibility with setuptools 0.9.8 mbasti-rh commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/027fc32fe0424659c5aecb4531299fe8d4a503d3 """ See the full comment at

[Freeipa-devel] [freeipa PR#295][opened] Issue6474 fixups

2016-12-01 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/295 Author: tiran Title: #295: Issue6474 fixups Action: opened PR body: """ Three small fixes that slipped through the review of #271. * ipatests for ipalib and ipapython no longer depend on ipaplatform * pylint fix for ipapython.certdb for

[Freeipa-devel] [freeipa PR#263][closed] Backwards compatibility with setuptools 0.9.8

2016-12-01 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/263 Author: tiran Title: #263: Backwards compatibility with setuptools 0.9.8 Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/263/head:pr263 git checkout pr263 --

[Freeipa-devel] [freeipa PR#294][comment] client, platform: Use paths.SSH* instead of get_config_dir().

2016-12-01 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/294 Title: #294: client, platform: Use paths.SSH* instead of get_config_dir(). martbab commented: """ @tiran I agree, PEP8 errors are often overlooked in the slew of other stuff that gets printed out in the container. I will address this in

[Freeipa-devel] [freeipa PR#294][comment] client, platform: Use paths.SSH* instead of get_config_dir().

2016-12-01 Thread tjaalton
URL: https://github.com/freeipa/freeipa/pull/294 Title: #294: client, platform: Use paths.SSH* instead of get_config_dir(). tjaalton commented: """ oh, thanks for pointing that out.. new one pushed """ See the full comment at https://github.com/freeipa/freeipa/pull/294#issuecomment-264174457

[Freeipa-devel] [freeipa PR#294][synchronized] client, platform: Use paths.SSH* instead of get_config_dir().

2016-12-01 Thread tjaalton
URL: https://github.com/freeipa/freeipa/pull/294 Author: tjaalton Title: #294: client, platform: Use paths.SSH* instead of get_config_dir(). Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/294/head:pr294

[Freeipa-devel] [freeipa PR#294][comment] client, platform: Use paths.SSH* instead of get_config_dir().

2016-12-01 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/294 Title: #294: client, platform: Use paths.SSH* instead of get_config_dir(). tiran commented: """ @tjaalton Travis CI output is a bit confusing. PEP 8 checks are performed first. The remaining checks are still executed. @martbab What do you think

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-12-01 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/280 Title: #280: Set explicit confdir option for global contexts tiran commented: """ @pvoborni No, my answer is an disagreement. Honza does not want the approve the PR as it stands now. My proposal is * Review this PR under the premise that it

[Freeipa-devel] [freeipa PR#294][comment] client, platform: Use paths.SSH* instead of get_config_dir().

2016-12-01 Thread mirielka
URL: https://github.com/freeipa/freeipa/pull/294 Title: #294: client, platform: Use paths.SSH* instead of get_config_dir(). mirielka commented: """ Build passes fine, pep8 does not: ./ipaclient/install/client.py:1006:80: E501 line too long (82 > 79 characters)

[Freeipa-devel] [freeipa PR#294][comment] client, platform: Use paths.SSH* instead of get_config_dir().

2016-12-01 Thread tjaalton
URL: https://github.com/freeipa/freeipa/pull/294 Title: #294: client, platform: Use paths.SSH* instead of get_config_dir(). tjaalton commented: """ I don't understand why travis claims it failed while the build passed fine """ See the full comment at

[Freeipa-devel] [freeipa PR#288][comment] Fix missing translation string

2016-12-01 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/288 Title: #288: Fix missing translation string mbasti-rh commented: """ ``` git rebase -i master fix-missing-translation-string ``` it will open interactive mode and you can remove all lines (commits) that you want to remove. Then save that

[Freeipa-devel] [freeipa PR#294][synchronized] client, platform: Use paths.SSH* instead of get_config_dir().

2016-12-01 Thread tjaalton
URL: https://github.com/freeipa/freeipa/pull/294 Author: tjaalton Title: #294: client, platform: Use paths.SSH* instead of get_config_dir(). Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/294/head:pr294

[Freeipa-devel] [freeipa PR#294][synchronized] client, platform: Use paths.SSH* instead of get_config_dir().

2016-12-01 Thread tjaalton
URL: https://github.com/freeipa/freeipa/pull/294 Author: tjaalton Title: #294: client, platform: Use paths.SSH* instead of get_config_dir(). Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/294/head:pr294

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-12-01 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/280 Title: #280: Set explicit confdir option for global contexts pvoborni commented: """ Christian, was your answer agreement to Honza's proposal? I.e. push this PR? To rest later by Honza? """ See the full comment at

[Freeipa-devel] [freeipa PR#280][comment] Set explicit confdir option for global contexts

2016-12-01 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/280 Title: #280: Set explicit confdir option for global contexts pvoborni commented: """ Christian, was your answer agreement to Honza's proposal? I.e. push this PR? To rest later by Honza? """ See the full comment at

[Freeipa-devel] [freeipa PR#181][synchronized] Tests : User Tracker creation of user with minimal values

2016-12-01 Thread gkaihorodova
URL: https://github.com/freeipa/freeipa/pull/181 Author: gkaihorodova Title: #181: Tests : User Tracker creation of user with minimal values Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/181/head:pr181