[Freeipa-devel] [freeipa PR#179][+pushed] Fix for handling CalledProcessError in authconfig

2017-01-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/179 Title: #179: Fix for handling CalledProcessError in authconfig Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page

[Freeipa-devel] [freeipa PR#179][comment] Fix for handling CalledProcessError in authconfig

2017-01-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/179 Title: #179: Fix for handling CalledProcessError in authconfig martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/6d52c0fe6acb09f3b8525840dfacc3f0885eac37 """ See the full comment at https://github.com/freei

[Freeipa-devel] [freeipa PR#179][closed] Fix for handling CalledProcessError in authconfig

2017-01-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/179 Author: Akasurde Title: #179: Fix for handling CalledProcessError in authconfig Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/179/head:pr179 git checkout pr179 -

[Freeipa-devel] [freeipa PR#394][comment] Add fix for ipa plugins command

2017-01-17 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/394 Title: #394: Add fix for ipa plugins command HonzaCholasta commented: """ @mbasti-rh, no. Classes aren't named using unicode strings either. """ See the full comment at https://github.com/freeipa/freeipa/pull/394#issuecomment-273395287 -- Manag

[Freeipa-devel] [freeipa PR#337][synchronized] Client-side CSR autogeneration (take 2)

2017-01-17 Thread LiptonB
URL: https://github.com/freeipa/freeipa/pull/337 Author: LiptonB Title: #337: Client-side CSR autogeneration (take 2) Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/337/head:pr337 git checkout pr337 From 4

[Freeipa-devel] [freeipa PR#394][comment] Add fix for ipa plugins command

2017-01-17 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/394 Title: #394: Add fix for ipa plugins command mbasti-rh commented: """ Shouldn't be namespaces named using unicode strings? """ See the full comment at https://github.com/freeipa/freeipa/pull/394#issuecomment-273275568 -- Manage your subscriptio

[Freeipa-devel] [freeipa PR#389][+ack] Fix build in mock

2017-01-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/389 Title: #389: Fix build in mock Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#389][comment] Fix build in mock

2017-01-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/389 Title: #389: Fix build in mock tomaskrizek commented: """ Thanks for the fix and explanation! """ See the full comment at https://github.com/freeipa/freeipa/pull/389#issuecomment-273206316 -- Manage your subscription for the Freeipa-devel maili

[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions

2017-01-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/347 Title: #347: Improvements in {get|set}_directive functions martbab commented: """ Thanks, I have fixed the docstrings. I have also made directive unquoting less silly. """ See the full comment at https://github.com/freeipa/freeipa/pull/347#issu

[Freeipa-devel] [freeipa PR#347][synchronized] Improvements in {get|set}_directive functions

2017-01-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/347 Author: martbab Title: #347: Improvements in {get|set}_directive functions Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/347/head:pr347 git checkout pr347

[Freeipa-devel] [freeipa PR#396][comment] Explicitly remove support of SSLv2

2017-01-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/396 Title: #396: Explicitly remove support of SSLv2 tiran commented: """ * What is the point of supporting SSL 3.0, TLS 1.0 and TLS 1.1 on the client side these days? How about we remove ancient and potentially dangerous TLS versions completely? * W

[Freeipa-devel] [freeipa PR#359][synchronized] dogtag: search past the first 100 certificates

2017-01-17 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/359 Author: HonzaCholasta Title: #359: dogtag: search past the first 100 certificates Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/359/head:pr359 git checkout

[Freeipa-devel] [freeipa PR#390][+ack] WebUI: Fix Coverity JS bugs

2017-01-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/390 Title: #390: WebUI: Fix Coverity JS bugs Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#359][comment] dogtag: search past the first 100 certificates

2017-01-17 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/359 Title: #359: dogtag: search past the first 100 certificates HonzaCholasta commented: """ I have identified some issues in search limit handling in `cert-find` and fixed them in an additional commit. See commit message for details. """ See the fu

[Freeipa-devel] [freeipa PR#359][synchronized] dogtag: search past the first 100 certificates

2017-01-17 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/359 Author: HonzaCholasta Title: #359: dogtag: search past the first 100 certificates Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/359/head:pr359 git checkout

[Freeipa-devel] [freeipa PR#373][synchronized] ipaplatform: Add Debian platform module.

2017-01-17 Thread tjaalton
URL: https://github.com/freeipa/freeipa/pull/373 Author: tjaalton Title: #373: ipaplatform: Add Debian platform module. Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/373/head:pr373 git checkout pr373 From

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-01-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ @lslebodn I think you misunderstood me. The PR adds a new build flavor that ignores and skips the any server-related steps of the build process. The fact that this PR ign

[Freeipa-devel] [freeipa PR#364][synchronized] Client-only builds with --disable-server

2017-01-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Author: tiran Title: #364: Client-only builds with --disable-server Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/364/head:pr364 git checkout pr364 From aa

[Freeipa-devel] [freeipa PR#389][comment] Fix build in mock

2017-01-17 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/389 Title: #389: Fix build in mock lslebodn commented: """ @tiran or @pvomacka, @tomaskrizek It would be good if you could test/ack the latest version of the patch. Because currently it is not possible to build freeIPA with upstream spec file in mo

Re: [Freeipa-devel] Stageuser API

2017-01-17 Thread Alexander Bokovoy
On ti, 17 tammi 2017, Christian Heimes wrote: On 2017-01-17 12:56, David Kupka wrote: Hi Christian, uniqueness of uid is not checked in staging area on purpose, it may be changed multiple times before the stageuser is transformed into user (activated). The uid uniqueness is then checked during a

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-01-17 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ I fine with ignoring python related parts; but it should be documented. But you might ask other freeIPA developers. (maybe on freeipa-devel) """ See the full comment a

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-01-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tiran commented: """ @lslebodn I like the idea to move the server related header and lib detection to a separate m4 file. In server-less mode, I plan to ignore the Python server part complete

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-01-17 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ I think it would be simpler to read the code without to many `AM_COND_IF()`. IMHO it would be simpler to move C-related part to separate file (e.g. `server_daemons.m4`

Re: [Freeipa-devel] Stageuser API

2017-01-17 Thread Christian Heimes
On 2017-01-17 12:56, David Kupka wrote: > Hi Christian, > uniqueness of uid is not checked in staging area on purpose, it may be > changed multiple times before the stageuser is transformed into user > (activated). The uid uniqueness is then checked during activation. > > Third party application t

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-01-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ I'm not really experienced with autotools, so I do not want to ack this PR without someone else taking a look. I'm also not sure about the best practices in this ar

[Freeipa-devel] [freeipa PR#179][+ack] Fix for handling CalledProcessError in authconfig

2017-01-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/179 Title: #179: Fix for handling CalledProcessError in authconfig Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Co

[Freeipa-devel] [freeipa PR#179][comment] Fix for handling CalledProcessError in authconfig

2017-01-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/179 Title: #179: Fix for handling CalledProcessError in authconfig tomaskrizek commented: """ Since there's been no suggestions for a more descriptive error message -> ack. """ See the full comment at https://github.com/freeipa/freeipa/pull/179#issu

[Freeipa-devel] [freeipa PR#179][comment] Fix for handling CalledProcessError in authconfig

2017-01-17 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/179 Title: #179: Fix for handling CalledProcessError in authconfig Akasurde commented: """ @tomaskrizek Done. """ See the full comment at https://github.com/freeipa/freeipa/pull/179#issuecomment-273122447 -- Manage your subscription for the Freeipa

[Freeipa-devel] [freeipa PR#179][synchronized] Fix for handling CalledProcessError in authconfig

2017-01-17 Thread Akasurde
URL: https://github.com/freeipa/freeipa/pull/179 Author: Akasurde Title: #179: Fix for handling CalledProcessError in authconfig Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/179/head:pr179 git checkout p

Re: [Freeipa-devel] Stageuser API

2017-01-17 Thread Alexander Bokovoy
On ti, 17 tammi 2017, Martin Basti wrote: On 17.01.2017 12:38, Christian Heimes wrote: On 2017-01-16 15:52, David Kupka wrote: Hello everyone! I've noticed that our API for stageuser is missing some commands that user has (stageuser-{add,remove}-{principal,cert}). I was wondering if there is

[Freeipa-devel] [freeipa PR#347][comment] Improvements in {get|set}_directive functions

2017-01-17 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/347 Title: #347: Improvements in {get|set}_directive functions tomaskrizek commented: """ I still managed to find a an issue for certain edge cases. See inline comments for more info. """ See the full comment at https://github.com/freeipa/freeipa/p

Re: [Freeipa-devel] Stageuser API

2017-01-17 Thread David Kupka
On 17/01/17 12:38, Christian Heimes wrote: On 2017-01-16 15:52, David Kupka wrote: Hello everyone! I've noticed that our API for stageuser is missing some commands that user has (stageuser-{add,remove}-{principal,cert}). I was wondering if there is reason for it but after asking some fellows de

Re: [Freeipa-devel] Stageuser API

2017-01-17 Thread Martin Basti
On 17.01.2017 12:38, Christian Heimes wrote: On 2017-01-16 15:52, David Kupka wrote: Hello everyone! I've noticed that our API for stageuser is missing some commands that user has (stageuser-{add,remove}-{principal,cert}). I was wondering if there is reason for it but after asking some fellow

[Freeipa-devel] [freeipa PR#382][comment] [Py3] ipa-server-install fixes (working NTP, DS, CA install steps)

2017-01-17 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/382 Title: #382: [Py3] ipa-server-install fixes (working NTP, DS, CA install steps) mbasti-rh commented: """ We had discussion with @HonzaCholasta, and IPA framework only expects that everything is UTF-8 only, so even in case we parse UTF-32 properly

[Freeipa-devel] [freeipa PR#397][opened] Improve wheel building and provide ipaserver wheel for local testing

2017-01-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/397 Author: tiran Title: #397: Improve wheel building and provide ipaserver wheel for local testing Action: opened PR body: """ The PR improve wheel bundle building and allows ipaserver bundles for local testing with instrumented build of Python.

Re: [Freeipa-devel] Stageuser API

2017-01-17 Thread Christian Heimes
On 2017-01-16 15:52, David Kupka wrote: > Hello everyone! > > I've noticed that our API for stageuser is missing some commands that > user has (stageuser-{add,remove}-{principal,cert}). I was wondering if > there is reason for it but after asking some fellows developers it seems > that there's non

Re: [Freeipa-devel] Stageuser API

2017-01-17 Thread Alexander Bokovoy
On ti, 17 tammi 2017, Florence Blanc-Renaud wrote: On 01/16/2017 03:52 PM, David Kupka wrote: Hello everyone! I've noticed that our API for stageuser is missing some commands that user has (stageuser-{add,remove}-{principal,cert}). I was wondering if there is reason for it but after asking some

[Freeipa-devel] [freeipa PR#372][comment] Restore IPA 3.0 compatibility of copy-schema-to-ca.py

2017-01-17 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/372 Title: #372: Restore IPA 3.0 compatibility of copy-schema-to-ca.py mbasti-rh commented: """ @tiran +1, but first this has to be generally approved :) topic for meeting maybe (today?) """ See the full comment at https://github.com/freeipa/freeip

[Freeipa-devel] [freeipa PR#372][comment] Restore IPA 3.0 compatibility of copy-schema-to-ca.py

2017-01-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/372 Title: #372: Restore IPA 3.0 compatibility of copy-schema-to-ca.py tiran commented: """ Or we just grab a working and tested version from an old release. """ See the full comment at https://github.com/freeipa/freeipa/pull/372#issuecomment-273110

Re: [Freeipa-devel] Stageuser API

2017-01-17 Thread Florence Blanc-Renaud
On 01/16/2017 03:52 PM, David Kupka wrote: Hello everyone! I've noticed that our API for stageuser is missing some commands that user has (stageuser-{add,remove}-{principal,cert}). I was wondering if there is reason for it but after asking some fellows developers it seems that there's none. I u

[Freeipa-devel] [freeipa PR#372][comment] Restore IPA 3.0 compatibility of copy-schema-to-ca.py

2017-01-17 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/372 Title: #372: Restore IPA 3.0 compatibility of copy-schema-to-ca.py stlaz commented: """ +1, we need to fix the script first, though. """ See the full comment at https://github.com/freeipa/freeipa/pull/372#issuecomment-273108618 -- Manage your s

[Freeipa-devel] [freeipa PR#372][comment] Restore IPA 3.0 compatibility of copy-schema-to-ca.py

2017-01-17 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/372 Title: #372: Restore IPA 3.0 compatibility of copy-schema-to-ca.py tiran commented: """ So with *separate script* you meant a separate downloadable version of the script. Got it! :) It seems we have a consent. @mbasti-rh I second your proposal t

[Freeipa-devel] [freeipa PR#372][comment] Restore IPA 3.0 compatibility of copy-schema-to-ca.py

2017-01-17 Thread mbasti-rh
URL: https://github.com/freeipa/freeipa/pull/372 Title: #372: Restore IPA 3.0 compatibility of copy-schema-to-ca.py mbasti-rh commented: """ I proposed 2 ideas: - move it to ipa-3-3 branch (or) - extract that script from freeipa repo and allow to download that script from freeipa.org (and acces

[Freeipa-devel] [freeipa PR#372][comment] Restore IPA 3.0 compatibility of copy-schema-to-ca.py

2017-01-17 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/372 Title: #372: Restore IPA 3.0 compatibility of copy-schema-to-ca.py martbab commented: """ IIRC @mbasti-rh proposed to maintain the script separately and serve it to users via external repo or something but the idea was rejected. """ See the full

[Freeipa-devel] [freeipa PR#266][synchronized] ipapython: simplify Env object initialization

2017-01-17 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/266 Author: HonzaCholasta Title: #266: ipapython: simplify Env object initialization Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/266/head:pr266 git checkout