URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
tiran commented:
"""
@LiptonB yes, it's correct.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/337#issuecomment-273705203
--
Manage your subscription for the Freeipa-dev
URL: https://github.com/freeipa/freeipa/pull/403
Title: #403: Add new ipa passwd-generate command
stlaz commented:
"""
Hello and thank you for the contribution! However, I do not see what's in this
for us. I do not think FreeIPA is intended to be used as a password generator.
There are other t
URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn,
xmlrpc_uri, ldap_uri
HonzaCholasta commented:
"""
@pvoborni, my plan is to amend / extend this patch.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/113#i
URL: https://github.com/freeipa/freeipa/pull/403
Author: redhatrises
Title: #403: Add new ipa passwd-generate command
Action: opened
PR body:
"""
This PR adds a new command line option `ipa passwd-generate` that uses the
refactored `ipa_password_generate()` function. This is useful for genera
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
LiptonB commented:
"""
@tiran Thanks to the team for resuming the review, too! Added the dependency,
does that look right?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/
URL: https://github.com/freeipa/freeipa/pull/337
Author: LiptonB
Title: #337: Client-side CSR autogeneration (take 2)
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/337/head:pr337
git checkout pr337
From 4
URL: https://github.com/freeipa/freeipa/pull/181
Author: gkaihorodova
Title: #181: Tests : User Tracker creation of user with minimal values
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/181/head:pr181
gi
URL: https://github.com/freeipa/freeipa/pull/210
Author: gkaihorodova
Title: #210: Tests: Stage User Tracker implementation
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/210/head:pr210
git checkout pr210
URL: https://github.com/freeipa/freeipa/pull/402
Author: MartinBasti
Title: #402: [master] wait_for_entry improvements
Action: opened
PR body:
"""
Backport useful commits from #401 to master
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetc
URL: https://github.com/freeipa/freeipa/pull/401
Author: MartinBasti
Title: #401: [4.4] Wait until http principal entry is replicated to replica
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/401/head:pr40
URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn,
xmlrpc_uri, ldap_uri
pvoborni commented:
"""
@HonzaCholasta with @pspacek no longer caring about this PR, we should close
it. But before we do it, what are your thoughts on wh
URL: https://github.com/freeipa/freeipa/pull/398
Author: flo-renaud
Title: #398: Support for Certificate Identity Mapping
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/398/head:pr398
git checkout pr398
Fr
URL: https://github.com/freeipa/freeipa/pull/401
Author: MartinBasti
Title: #401: [4.4] Wait until http principal entry is replicated to replica
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/401/head:pr40
URL: https://github.com/freeipa/freeipa/pull/401
Author: MartinBasti
Title: #401: [4.4] Wait until http principal entry is replicated to replica
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/401/head:pr40
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
tomaskrizek commented:
"""
@HonzaCholasta Perhaps it's more of a personal preference, but I'd rather see
an existing version of a certain package. Since the spec file is processed
URL: https://github.com/freeipa/freeipa/pull/386
Title: #386: Tests: Add tree root domain role in legacy client tests
martbab commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/822a119100f8ab93aacdb14b982609f1dc69531d
ipa-4-4:
https://fedorahosted.org/freeipa/change
URL: https://github.com/freeipa/freeipa/pull/386
Author: gkaihorodova
Title: #386: Tests: Add tree root domain role in legacy client tests
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/386/head:pr386
git checko
URL: https://github.com/freeipa/freeipa/pull/386
Title: #386: Tests: Add tree root domain role in legacy client tests
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.or
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
HonzaCholasta commented:
"""
I see, didn't notice that. In this case, IMO either the current `pki-base >=
10.2.1` or an unversioned `pki-base-python2` is fine.
"""
See the full com
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
tiran commented:
"""
You would still depend on potentially non-existing package.
```pki-base-python2``` was introduced in 10.3. ```pki-base``` will switch to
Python 3 as soon as RH
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
HonzaCholasta commented:
"""
@tiran, I'm sorry to have to point this out, but the decision whether this PR
is accepted or not is not yours to make, you are not a member of the core
URL: https://github.com/freeipa/freeipa/pull/399
Author: dkupka
Title: #399: Certificate mapping test
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/399/head:pr399
git checkout pr399
From fb73c25fa30d0d374
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
tomaskrizek commented:
"""
I agree with @tiran here. Even though `>= 10.2.1` will match the correct
package, I don't think it's a good practice to use non-existent package numbers
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
tiran commented:
"""
I can't see a valid argument in your response. As a co-maintainer of PKI's
Python packages I'm strictly against claiming compatibility with a non-existing
pack
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
HonzaCholasta commented:
"""
That is of no concern to us. `pki-base-python3 >= 10.2.1` will get us the
correct package in all cases and under no circumstances will it cause an
atte
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
MartinBasti commented:
"""
I would like to have `py3 str` <=> `py2 unicode`, `py3 bytes` <=> `py2 str`,
but framework is far away from this ideal state.
So I have no strong opinion, and once we will d
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
HonzaCholasta commented:
"""
We are OK with the patch because fixing the root cause is out of the scope of
this PR.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/394#issuecommen
URL: https://github.com/freeipa/freeipa/pull/244
Title: #244: Add templating to ipaplatform path [RFC]
tiran commented:
"""
My PoC is a bit too magic and complicated. PR #373 for Debian support comes
along nicely without additional magic. I'm closing the PR. I'll keep the branch
around in case
URL: https://github.com/freeipa/freeipa/pull/244
Author: tiran
Title: #244: Add templating to ipaplatform path [RFC]
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/244/head:pr244
git checkout pr244
--
Manage yo
URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn,
xmlrpc_uri, ldap_uri
tiran commented:
"""
I would appreciate to have this fix landed in master rather sooner than later.
The questionable default values have triggered hard to
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
tiran commented:
"""
**namespace keys are always ASCII** and **use the proper text datatype to
represent text** are not a contradiction.
At least two IPA developers (@MartinBasti and me) feel that it
On Wed, Jan 18, 2017 at 09:59:49AM +0100, David Kupka wrote:
> Hello everyone!
> I would like to bring your attention to just published PRs implementing
> FreeIPA part of Certificate Identity Mapping feature [0]:
>
> - certmap plugin [1] by Flo
> - WebUI for certmap plugin [3] by Pavel
> - tests f
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
HonzaCholasta commented:
"""
@tiran, namespace keys are always ASCII. But feel free to open a ticket to
convert all remaining uses of `str` as text to `unicode`, changing it for one
random bit in this
URL: https://github.com/freeipa/freeipa/pull/398
Title: #398: Support for Certificate Identity Mapping
MartinBasti commented:
"""
I put some inline commets, @flo-renaud if you don't know where to register OIDs
feel free to ping me
"""
See the full comment at
https://github.com/freeipa/freeipa
URL: https://github.com/freeipa/freeipa/pull/379
Author: tiran
Title: #379: Packaging: Add placeholder and IPA commands packages
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/379/head:pr379
git checkout p
URL: https://github.com/freeipa/freeipa/pull/393
Title: #393: [Py3] allow to run wsgi - part1
tiran commented:
"""
@MartinBasti cert tests are failing. I have restarted the failing job. Let's
see if the error persists or was just caused by a Travis hick up.
"""
See the full comment at
https:/
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
tiran commented:
"""
```pki-base-python3 >= 10.2.1``` would mean that FreeIPA is compatible with
```pki-base-python2 == 10.2.1``` which clearly does not exist.
"""
See the full com
URL: https://github.com/freeipa/freeipa/pull/386
Title: #386: Tests: Add tree root domain role in legacy client tests
martbab commented:
"""
Looks good, let's see if it fixes our CI
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/386#issuecomment-273425390
--
Manage your s
URL: https://github.com/freeipa/freeipa/pull/386
Title: #386: Tests: Add tree root domain role in legacy client tests
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/p
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
tiran commented:
"""
In Python 2 str is a Chimera with the head of a text object and the body of a
bytes object. It's just text if all text you got is ASCII. For clean polyglot
code it's highly recomm
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
HonzaCholasta commented:
"""
The namespace keys *are* text (`str`) in both Python 2 and 3. The issue here is
that the RPC layer assumes that `str` is binary data, which the patch correctly
fixes by co
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
tiran commented:
"""
Why should *Python 2 class names are str instances* prevent us from making the
namespace keys text? In Python 2 ASCII str and ASCII unicode are equivalent
dict keys (same hash, co
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
tiran commented:
"""
Why should *Python 2 class names are str instances* prevent us from making the
namespace keys text? In Python 2 ASCII str and ASCII unicode are equivalent
dict keys (same hash, co
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
HonzaCholasta commented:
"""
@tiran, the dependency says `>= 10.2.1`, not `== 10.2.1`, so we are not
depending on any non-existent packages.
"""
See the full comment at
https://gi
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
Akasurde commented:
"""
@martbab Yes, I will write a test case for this scenario and attach here.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/394#issuecomment-273420038
--
Ma
URL: https://github.com/freeipa/freeipa/pull/387
Title: #387: Update warning message for ipa server uninstall
Akasurde commented:
"""
@martbab Thanks for review.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/387#issuecomment-273419794
--
Manage your subscription for the
URL: https://github.com/freeipa/freeipa/pull/179
Title: #179: Fix for handling CalledProcessError in authconfig
Akasurde commented:
"""
@tomaskrizek @martbab Thanks for review.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/179#issuecomment-273419730
--
Manage your subscr
Hello everyone!
I would like to bring your attention to just published PRs implementing
FreeIPA part of Certificate Identity Mapping feature [0]:
- certmap plugin [1] by Flo
- WebUI for certmap plugin [3] by Pavel
- tests for certmap plugin [2] by me
Also please think about names of the comman
URL: https://github.com/freeipa/freeipa/pull/372
Author: tiran
Title: #372: Restore IPA 3.0 compatibility of copy-schema-to-ca.py
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/372/head:pr372
git checkout pr372
URL: https://github.com/freeipa/freeipa/pull/372
Title: #372: Restore IPA 3.0 compatibility of copy-schema-to-ca.py
tiran commented:
"""
I have updated the ticket
https://fedorahosted.org/freeipa/ticket/6540#comment:5 with the result of this
discussion. I'm going to close the PR. Let's start a
URL: https://github.com/freeipa/freeipa/pull/400
Author: pvomacka
Title: #400: WebUI: Certificate Mapping
Action: edited
Changed field: body
Original value:
"""
Add WebUI for certificate mapping
"""
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mail
URL: https://github.com/freeipa/freeipa/pull/400
Author: pvomacka
Title: #400: WebUI: Certificate Mapping
Action: opened
PR body:
"""
Add WebUI for certificate mapping
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/400/h
URL: https://github.com/freeipa/freeipa/pull/336
Title: #336: [py3] pki: add missing depedency pki-base[-python3]
tiran commented:
"""
What's the hold up here?
Martin and I discussed the necessity to raise the version requirements. Python
3 packages for PKI simply do not exist until 10.3. I do
URL: https://github.com/freeipa/freeipa/pull/394
Title: #394: Add fix for ipa plugins command
martbab commented:
"""
@Akasurde are you OK with writing a simple regression test for this command as
a part of this PR?
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/394#issuec
URL: https://github.com/freeipa/freeipa/pull/399
Author: dkupka
Title: #399: Certificate mapping test
Action: opened
PR body:
"""
https://fedorahosted.org/freeipa/ticket/6542
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull
URL: https://github.com/freeipa/freeipa/pull/387
Title: #387: Update warning message for ipa server uninstall
martbab commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/ae2d0a221772267ecda30896dc8897a3f4b4a97b
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/387
Title: #387: Update warning message for ipa server uninstall
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/C
URL: https://github.com/freeipa/freeipa/pull/387
Author: Akasurde
Title: #387: Update warning message for ipa server uninstall
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/387/head:pr387
git checkout pr387
--
URL: https://github.com/freeipa/freeipa/pull/387
Title: #387: Update warning message for ipa server uninstall
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Cont
URL: https://github.com/freeipa/freeipa/pull/181
Title: #181: Tests : User Tracker creation of user with minimal values
MartinBasti commented:
"""
@gkaihorodova you haven't pushed the changes to github repo
```
git push --force
```
"""
See the full comment at
https://github.com/freeipa/freei
URL: https://github.com/freeipa/freeipa/pull/210
Title: #210: Tests: Stage User Tracker implementation
martbab commented:
"""
@gkaihorodova the PR cannot be pushed in current form because the first commit
298e1a136c6a430e8deaa558a946ba51874ffd95 is already pushed to master.
So to rebase it cor
URL: https://github.com/freeipa/freeipa/pull/398
Author: flo-renaud
Title: #398: Support for Certificate Identity Mapping
Action: opened
PR body:
"""
See design http://www.freeipa.org/page/V4/Certificate_Identity_Mapping
https://fedorahosted.org/freeipa/ticket/6542
"""
To pull the PR as Git
URL: https://github.com/freeipa/freeipa/pull/390
Author: pvomacka
Title: #390: WebUI: Fix Coverity JS bugs
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/390/head:pr390
git checkout pr390
--
Manage your subscri
URL: https://github.com/freeipa/freeipa/pull/378
Author: tiran
Title: #378: Clean / ignore make check artefact
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/378/head:pr378
git checkout pr378
--
Manage your sub
URL: https://github.com/freeipa/freeipa/pull/389
Author: lslebodn
Title: #389: Fix build in mock
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/389/head:pr389
git checkout pr389
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/378
Title: #378: Clean / ignore make check artefact
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Cod
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
tiran commented:
"""
@LiptonB thanks a lot for resuming your work!
Please add jinja2 to ``` ipaclient/setup.py```, too.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/337
URL: https://github.com/freeipa/freeipa/pull/390
Title: #390: WebUI: Fix Coverity JS bugs
martbab commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/a69c4448c58b2438952fd806e2515eea7575b27b
https://fedorahosted.org/freeipa/changeset/9d2ef64fb9e1357dc4a3cde8d93c796da
URL: https://github.com/freeipa/freeipa/pull/390
Title: #390: WebUI: Fix Coverity JS bugs
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/389
Title: #389: Fix build in mock
martbab commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/5c18feaa206bbaee692fc3640b7b79c8d9d6a638
https://fedorahosted.org/freeipa/changeset/3f91469f327d8d9f3b27e0b67c54a4f47ad845c1
ht
URL: https://github.com/freeipa/freeipa/pull/378
Title: #378: Clean / ignore make check artefact
martbab commented:
"""
Fixed upstream
master:
https://fedorahosted.org/freeipa/changeset/d8343a96dd206c9f25cf032a50f3b48fb8166db1
"""
See the full comment at
https://github.com/freeipa/freeipa/pull
URL: https://github.com/freeipa/freeipa/pull/389
Title: #389: Fix build in mock
Label: +pushed
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
72 matches
Mail list logo