[Freeipa-devel] [freeipa PR#496][opened] Use newer Certificate.serial_number in krainstance.py

2017-02-22 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/496 Author: stlaz Title: #496: Use newer Certificate.serial_number in krainstance.py Action: opened PR body: """ This bit was missed in https://github.com/freeipa/freeipa/pull/458 """ To pull the PR as Git branch: git remote add ghfreeipa https://g

[Freeipa-devel] [freeipa PR#495][comment] Fix ipa-server-upgrade

2017-02-22 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/495 Title: #495: Fix ipa-server-upgrade stlaz commented: """ I see where this is going, added the ticket to the commit message. """ See the full comment at https://github.com/freeipa/freeipa/pull/495#issuecomment-281912763 -- Manage your subscripti

[Freeipa-devel] [freeipa PR#495][synchronized] Fix ipa-server-upgrade

2017-02-22 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/495 Author: stlaz Title: #495: Fix ipa-server-upgrade Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/495/head:pr495 git checkout pr495 From 499ce6c6ef6f921f0be8

[Freeipa-devel] [freeipa PR#495][comment] Fix ipa-server-upgrade

2017-02-22 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/495 Title: #495: Fix ipa-server-upgrade HonzaCholasta commented: """ @MartinBasti, https://fedorahosted.org/freeipa/ticket/5959. """ See the full comment at https://github.com/freeipa/freeipa/pull/495#issuecomment-281905518 -- Manage your subscript

Re: [Freeipa-devel] Requiring simultaneous authentication to Linux resources

2017-02-22 Thread Fraser Tweedale
On Wed, Feb 22, 2017 at 10:00:04AM -0500, Simo Sorce wrote: > On Wed, 2017-02-22 at 10:59 +, Oucema Bellagha wrote: > > I want to figure out a solution which allow user"a" to authenticate to > > a host only when user"b" is accessing the host for security reasons. > > > > > > Easy explanation:

[Freeipa-devel] [freeipa PR#398][comment] Support for Certificate Identity Mapping

2017-02-22 Thread flo-renaud
URL: https://github.com/freeipa/freeipa/pull/398 Title: #398: Support for Certificate Identity Mapping flo-renaud commented: """ Hi @sumit-bose , I am not able to reproduce this issue: `[root@vm-161 ~]# kinit -k [root@vm-161 ~]# klist Ticket cache: KEYRING:persistent:0:krb_ccache_h6XRpeK Default

[Freeipa-devel] [freeipa PR#398][comment] Support for Certificate Identity Mapping

2017-02-22 Thread sumit-bose
URL: https://github.com/freeipa/freeipa/pull/398 Title: #398: Support for Certificate Identity Mapping sumit-bose commented: """ It looks like the ACis on the latest version do not allow hosts to access the rules. When I do 'kinit -k' on the IPA server or a client and call ldapsearch -H ld

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ >Thanks for your contribution. I added your patch to my PR. On my system I ran >into a minor issue. >Some C99 types like uint8_t were not defined and I had to >include

[Freeipa-devel] [freeipa PR#492][comment] [WIP] config: remove meaningless defaults

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/492 Title: #492: [WIP] config: remove meaningless defaults tiran commented: """ It's probably easier to always define options like ```'ldap_uri``` but use ```None``` as default. ``` cd .; ./makeaci --validate ./makeaci: ipaserver/plugins/dogtag.py:2

[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages tiran commented: """ @MartinBasti I have rebased the branch and added wheel + placeholder building to make check. The pylint violations have disappeared. """ See the full comment at https://gith

[Freeipa-devel] [freeipa PR#472][synchronized] Packaging: Add placeholder packages

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/472 Author: tiran Title: #472: Packaging: Add placeholder packages Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/472/head:pr472 git checkout pr472 From 4adaffb

[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages

2017-02-22 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ LGTM, please rebase and I will test it. """ See the full comment at https://github.com/freeipa/freeipa/pull/472#issuecomment-281749499 -- Manage your subscription for t

[Freeipa-devel] [freeipa PR#495][comment] Fix ipa-server-upgrade

2017-02-22 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/495 Title: #495: Fix ipa-server-upgrade MartinBasti commented: """ Does this belong to any ticket which caused this regression? """ See the full comment at https://github.com/freeipa/freeipa/pull/495#issuecomment-281748907 -- Manage your subscripti

[Freeipa-devel] [freeipa PR#457][closed] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-22 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/457 Author: martbab Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/457/head:pr457 git checkou

[Freeipa-devel] [freeipa PR#457][+pushed] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-22 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/457 Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeip

[Freeipa-devel] [freeipa PR#457][comment] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-22 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/457 Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab MartinBasti commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/af998c4d30175fb3ecc148e1b3a7aca03ef9239a https://fedorahosted.org/freeipa/changes

[Freeipa-devel] [freeipa PR#457][+ack] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-22 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/457 Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.o

[Freeipa-devel] [freeipa PR#367][comment] Remove nsslib from IPA

2017-02-22 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/367 Title: #367: Remove nsslib from IPA stlaz commented: """ First set of fixes to comments arrived, throwing it to Travis. """ See the full comment at https://github.com/freeipa/freeipa/pull/367#issuecomment-281710491 -- Manage your subscription f

Re: [Freeipa-devel] Requiring simultaneous authentication to Linux resources

2017-02-22 Thread Simo Sorce
On Wed, 2017-02-22 at 10:59 +, Oucema Bellagha wrote: > I want to figure out a solution which allow user"a" to authenticate to > a host only when user"b" is accessing the host for security reasons. > > > Easy explanation: authenticate to hostx needs (user a + user b) > > > I'm brainstorming

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server pvoborni commented: """ Also I added section to FreeIPA wiki: http://www.freeipa.org/page/V4/Build_system_refactoring#Packager_-_client_only_build """ See the full comment at https://github.

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop martbab commented: """ @pvoborni should the fix go also into 4-4 branch? see https://fedorahosted.org/freeipa/ticket/6673#comment:3 """ See the full comment at https://github.com/freeipa/

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build pvoborni commented: """ #364 was pushed. """ See the full comment at https://github.com/freeipa/freeipa/pull/494#issuecomment-281690828 -- Manage your subscription for the Freeipa-devel mailing list: http

[Freeipa-devel] [freeipa PR#494][closed] Support client-only build

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/494 Author: lslebodn Title: #494: Support client-only build Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/494/head:pr494 git checkout pr494 -- Manage your subscript

[Freeipa-devel] [freeipa PR#494][+rejected] Support client-only build

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build Label: +rejected -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/b8f304c66994ae82ea484a4e8bd057d4ccf1e6bd """ See the full comment at https://github.com/freeipa/free

[Freeipa-devel] [freeipa PR#468][+pushed] Remove non-sensical kdestroy on https stop

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contri

[Freeipa-devel] [freeipa PR#468][closed] Remove non-sensical kdestroy on https stop

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Author: simo5 Title: #468: Remove non-sensical kdestroy on https stop Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/468/head:pr468 git checkout pr468 -- Manage

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server pvoborni commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/70554938d4f9ba5b347cd4bc8001428e905198e4 https://fedorahosted.org/freeipa/changeset/41d7ae54fafc6deb602

[Freeipa-devel] [freeipa PR#364][closed] Client-only builds with --disable-server

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/364 Author: tiran Title: #364: Client-only builds with --disable-server Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/364/head:pr364 git checkout pr364 -- Manage yo

[Freeipa-devel] [freeipa PR#364][+pushed] Client-only builds with --disable-server

2017-02-22 Thread pvoborni
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribu

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ On (22/02/17 06:16), Simo Sorce wrote: >So this is the reasoning and why I am approving this PR and not #494. > >When you build all components, including server bits, te

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 01:52), Tomas Krizek wrote: >@lslebodn My bad, there was some leftover stuff that `git clean -dfx` didn't >clear for some reason. > >Nevertheless, this does work and allo

[Freeipa-devel] [freeipa PR#490][synchronized] [WIP] certdb: use certutil and match_hostname for cert verification

2017-02-22 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/490 Author: HonzaCholasta Title: #490: [WIP] certdb: use certutil and match_hostname for cert verification Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/490/h

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-22 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server simo5 commented: """ So this is the reasoning and why I am approving this PR and not #494. When you build all components, including server bits, tests are installed, therefore when we build j

[Freeipa-devel] [freeipa PR#364][+ack] Client-only builds with --disable-server

2017-02-22 Thread simo5
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/

[Freeipa-devel] [freeipa PR#434][comment] csrgen: Automate full cert request flow

2017-02-22 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/434 Title: #434: csrgen: Automate full cert request flow HonzaCholasta commented: """ Thank you. LGTM, but please squash the fixup commit. """ See the full comment at https://github.com/freeipa/freeipa/pull/434#issuecomment-281679144 -- Manage your

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 03:24), Christian Heimes wrote: >python-requests is a bad example because it suffers from the same issue as IPA. > >A better example is any other modern Python project lik

Re: [Freeipa-devel] MD5 certificate fingerprints removal

2017-02-22 Thread Fraser Tweedale
On Wed, Feb 22, 2017 at 01:41:22PM +0100, Tomas Krizek wrote: > On 02/22/2017 12:28 AM, Fraser Tweedale wrote: > > On Tue, Feb 21, 2017 at 05:23:07PM +0100, Standa Laznicka wrote: > >> On 02/21/2017 04:24 PM, Tomas Krizek wrote: > >>> On 02/21/2017 03:23 PM, Rob Crittenden wrote: > Standa Lazn

Re: [Freeipa-devel] MD5 certificate fingerprints removal

2017-02-22 Thread Tomas Krizek
On 02/22/2017 12:28 AM, Fraser Tweedale wrote: > On Tue, Feb 21, 2017 at 05:23:07PM +0100, Standa Laznicka wrote: >> On 02/21/2017 04:24 PM, Tomas Krizek wrote: >>> On 02/21/2017 03:23 PM, Rob Crittenden wrote: Standa Laznicka wrote: > Hello, > > Since we're trying to make FreeIPA

[Freeipa-devel] [freeipa PR#367][comment] Remove nsslib from IPA

2017-02-22 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/367 Title: #367: Remove nsslib from IPA HonzaCholasta commented: """ Besides what I wrote in inline comments, we need to get rid of `/var/lib/ipa/radb` now that it's unused. """ See the full comment at https://github.com/freeipa/freeipa/pull/367#is

Re: [Freeipa-devel] MD5 certificate fingerprints removal

2017-02-22 Thread Standa Laznicka
On 02/22/2017 12:28 AM, Fraser Tweedale wrote: On Tue, Feb 21, 2017 at 05:23:07PM +0100, Standa Laznicka wrote: On 02/21/2017 04:24 PM, Tomas Krizek wrote: On 02/21/2017 03:23 PM, Rob Crittenden wrote: Standa Laznicka wrote: Hello, Since we're trying to make FreeIPA work in FIPS we got to th

[Freeipa-devel] [freeipa PR#479][comment] Merge AD trust installer into composite ones

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/479 Title: #479: Merge AD trust installer into composite ones martbab commented: """ I have added a basic integration tests for the built-in AD trust installation, you can run them on 3 machines (master + 2 replicas) by running ```bash # ipa-run-tes

[Freeipa-devel] [freeipa PR#479][synchronized] Merge AD trust installer into composite ones

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/479 Author: martbab Title: #479: Merge AD trust installer into composite ones Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/479/head:pr479 git checkout pr479 F

[Freeipa-devel] [freeipa PR#468][+ack] Remove non-sensical kdestroy on https stop

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribut

[Freeipa-devel] [freeipa PR#468][comment] Remove non-sensical kdestroy on https stop

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/468 Title: #468: Remove non-sensical kdestroy on https stop martbab commented: """ I have also noticed that the ccache is not created there, strange. However I think it is better to explicitly specify file-based ccache anyway just to be one the safe

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 03:24), Christian Heimes wrote: >python-requests is a bad example because it suffers from the same issue as IPA. > >A better example is any other modern Python project lik

[Freeipa-devel] [freeipa PR#495][comment] Fix ipa-server-upgrade

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/495 Title: #495: Fix ipa-server-upgrade tiran commented: """ Looks totally reasonable. I checked, ```SimpleServiceInstance('ipa_memcached')``` does not raise an exception if systemd has no service file for IPA memcached at all. """ See the full com

[Freeipa-devel] [freeipa PR#495][+ack] Fix ipa-server-upgrade

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/495 Title: #495: Fix ipa-server-upgrade Label: +ack -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#495][opened] Fix ipa-server-upgrade

2017-02-22 Thread stlaz
URL: https://github.com/freeipa/freeipa/pull/495 Author: stlaz Title: #495: Fix ipa-server-upgrade Action: opened PR body: """ I was to eager to ACK https://github.com/freeipa/freeipa/pull/471. Running ipa-server-upgrade would fail to stop ipa_memcached if it's already uninstalled. """ To pu

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tiran commented: """ python-requests is a bad example because it suffers from the same issue as IPA. A better example is any other modern Python project like cryptography. It runs tests with installed files

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ >Thanks for your contribution. I added your patch to my PR. On my system I ran >into a minor issue. >Some C99 types like uint8_t were not defined and I had to >include

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 03:04), Christian Heimes wrote: >You are aware that your example code checks the wrong code? It is testing >in-tree sources, not the actual sources that get packaged and

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tiran commented: """ You are aware that your example code checks the wrong code? It is testing in-tree sources, not the actual sources that get packaged and installed. """ See the full comment at https://g

[Freeipa-devel] Requiring simultaneous authentication to Linux resources

2017-02-22 Thread Oucema Bellagha
I want to figure out a solution which allow user"a" to authenticate to a host only when user"b" is accessing the host for security reasons. Easy explanation: authenticate to hostx needs (user a + user b) I'm brainstorming some ideas using Yubikey or ssh-keys.. Is there any application which a

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 02:51), Christian Heimes wrote: >You assumption is incorrect. ```ipatests``` does not depend on >```ipaserver```, >https://github.com/freeipa/freeipa/blob/master/ipatest

[Freeipa-devel] [freeipa PR#457][comment] adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/457 Title: #457: adtrustinstance: use LDAPI/EXTERNAL to retrieve CIFS keytab martbab commented: """ Bump for review. """ See the full comment at https://github.com/freeipa/freeipa/pull/457#issuecomment-281635160 -- Manage your subscription for the

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tiran commented: """ You assumption is incorrect. ```ipatests``` does not depend on ```ipaserver```, https://github.com/freeipa/freeipa/blob/master/ipatests/setup.py#L61 ``` install_requires=[

[Freeipa-devel] [freeipa PR#479][comment] Merge AD trust installer into composite ones

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/479 Title: #479: Merge AD trust installer into composite ones martbab commented: """ Bump for review. """ See the full comment at https://github.com/freeipa/freeipa/pull/479#issuecomment-281635086 -- Manage your subscription for the Freeipa-devel m

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 02:09), Christian Heimes wrote: >There are two reasons we decided on ```--without-ipatests```: > >* ```--with-tests``` / ```--without-tests``` is technically not correct.

Re: [Freeipa-devel] Certificate Identity Mapping - new API to retrieve matching users

2017-02-22 Thread Jan Cholasta
On 22.2.2017 11:28, Sumit Bose wrote: On Wed, Feb 22, 2017 at 10:02:24AM +0100, Petr Vobornik wrote: On 02/22/2017 12:43 AM, Fraser Tweedale wrote: On Tue, Feb 21, 2017 at 06:12:23PM +0100, Petr Vobornik wrote: On 02/21/2017 05:15 PM, Florence Blanc-Renaud wrote: Hi, related to the Certifica

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 02:23), Christian Heimes wrote: >tiran requested changes on this pull request. > >see comments > >> -CFLAGS="$bck_cflags" >- >-LIBPDB_NAME="" >-AC_CHECK_LIB([samba-passdb]

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 02:16), Christian Heimes wrote: >NACK on 42fb9b1c > >* Either use ```--with-ipaplatform=redhat``` on CentOS >* Or implement a proper way to fill ipaplatfrom from ```/etc/o

Re: [Freeipa-devel] Certificate Identity Mapping - new API to retrieve matching users

2017-02-22 Thread Sumit Bose
On Wed, Feb 22, 2017 at 10:02:24AM +0100, Petr Vobornik wrote: > On 02/22/2017 12:43 AM, Fraser Tweedale wrote: > > On Tue, Feb 21, 2017 at 06:12:23PM +0100, Petr Vobornik wrote: > > > On 02/21/2017 05:15 PM, Florence Blanc-Renaud wrote: > > > > Hi, > > > > > > > > related to the Certificate Ident

[Freeipa-devel] [freeipa PR#494][synchronized] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Author: lslebodn Title: #494: Support client-only build Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/494/head:pr494 git checkout pr494 From b4e0d5ed62bfdb

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tiran commented: """ NACK on 42fb9b1c * Either use ```--with-ipaplatform=redhat``` on CentOS * Or implement a proper way to fill ipaplatfrom from ```/etc/os-relase``` value ```ID_LIKE```, https://www.freede

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tiran commented: """ There are two reasons we decided on ```--without-ipatests```: * ```--with-tests``` / ```--without-tests``` is technically not correct. We still compile C tests. The flag is about the co

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 01:43), Christian Heimes wrote: >NACK on aece4c3c > >We compromised on ```--without-ipatests``` with installation of ipatests >defaulting to true. The compromose was alre

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-22 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server tomaskrizek commented: """ The PR works and the `--without-ipatests` option omits the ipatests directory. However, #494 doesn't install extra dependencies with `mock --without=server`. """ Se

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tomaskrizek commented: """ @lslebodn My bad, there was some leftover stuff that `git clean -dfx` didn't clear for some reason. Nevertheless, this does work and allows a client only, as well as installing t

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tiran commented: """ NACK on aece4c3c We compromised on ```--without-ipatests``` with installation of ipatests defaulting to true. The compromose was already ACKed by @simo5 """ See the full comment at h

[Freeipa-devel] [freeipa PR#476][synchronized] vault: cache the transport certificate on client

2017-02-22 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/476 Author: HonzaCholasta Title: #476: vault: cache the transport certificate on client Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/476/head:pr476 git checko

[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages

2017-02-22 Thread MartinBasti
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages MartinBasti commented: """ Thank you. I see errors reported by pylint ``` * Module ipaserver.install.installutils ipaserver/install/installutils.py:1209: [E1101(no-member), store_versio

Re: [Freeipa-devel] FreeIPA and wildcard certificates

2017-02-22 Thread Martin Kosek
On 02/20/2017 06:03 AM, Fraser Tweedale wrote: > On Fri, Feb 10, 2017 at 11:48:39AM +0100, Martin Kosek wrote: >> On 02/10/2017 10:37 AM, Fraser Tweedale wrote: >>> On Fri, Feb 10, 2017 at 09:23:10AM +0100, Martin Kosek wrote: On 02/09/2017 10:44 PM, Fraser Tweedale wrote: > On Thu, Feb 09

[Freeipa-devel] [freeipa PR#397][comment] Improve wheel building and provide ipaserver wheel for local testing

2017-02-22 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/397 Title: #397: Improve wheel building and provide ipaserver wheel for local testing HonzaCholasta commented: """ The trust plugin and other trust bits are optional. The cert plugin, which depends on `pyhbac`, is *not* optional, so you can't apply

[Freeipa-devel] [freeipa PR#485][closed] Fix session logout

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/485 Author: simo5 Title: #485: Fix session logout Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/485/head:pr485 git checkout pr485 -- Manage your subscription for th

[Freeipa-devel] [freeipa PR#485][+pushed] Fix session logout

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/485 Title: #485: Fix session logout Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

[Freeipa-devel] [freeipa PR#485][comment] Fix session logout

2017-02-22 Thread martbab
URL: https://github.com/freeipa/freeipa/pull/485 Title: #485: Fix session logout martbab commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/908d2eaba46f5f123b49af400a8b696545c62b54 """ See the full comment at https://github.com/freeipa/freeipa/pull/485#issuecommen

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ BTW I tested client-only build on fedora24, fedora25, fedora rawhide, epel7, debian stable, debian testing, debian unstable """ See the full comment at https://github.com/freeipa/fr

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build lslebodn commented: """ On (22/02/17 00:59), Tomas Krizek wrote: >I'm not able to run autoreconf, it fails with the following error: > >``` >configure.ac:447: error: required file 'init/tmpfilesd/Makefile.in'

Re: [Freeipa-devel] Certificate Identity Mapping - new API to retrieve matching users

2017-02-22 Thread Petr Vobornik
On 02/22/2017 12:43 AM, Fraser Tweedale wrote: On Tue, Feb 21, 2017 at 06:12:23PM +0100, Petr Vobornik wrote: On 02/21/2017 05:15 PM, Florence Blanc-Renaud wrote: Hi, related to the Certificate Identity Mapping feature, a new CLI will be needed to find all the users matching a given certificat

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ >Thanks for your contribution. I added your patch to my PR. On my system I ran >into a minor issue. >Some C99 types like uint8_t were not defined and I had to >include

[Freeipa-devel] [freeipa PR#494][comment] Support client-only build

2017-02-22 Thread tomaskrizek
URL: https://github.com/freeipa/freeipa/pull/494 Title: #494: Support client-only build tomaskrizek commented: """ I'm not able to run autoreconf, it fails with the following error: ``` configure.ac:447: error: required file 'init/tmpfilesd/Makefile.in' not found asn1/Makefile.am: installing '.

[Freeipa-devel] [freeipa PR#364][comment] Client-only builds with --disable-server

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/364 Title: #364: Client-only builds with --disable-server lslebodn commented: """ >Thanks for your contribution. I added your patch to my PR. On my system I ran >into a minor issue. >Some C99 types like uint8_t were not defined and I had to >include

[Freeipa-devel] [freeipa PR#494][opened] Support client-only build

2017-02-22 Thread lslebodn
URL: https://github.com/freeipa/freeipa/pull/494 Author: lslebodn Title: #494: Support client-only build Action: opened PR body: """ How to test: * autoreconf -if * ./configure --disable-server * make srpms * mock --rebuild dist/rpms/freeipa-4.4.90.*.src.rpm --resultdir . * mock --rebuild dist

[Freeipa-devel] [freeipa PR#397][comment] Improve wheel building and provide ipaserver wheel for local testing

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/397 Title: #397: Improve wheel building and provide ipaserver wheel for local testing tiran commented: """ @HonzaCholasta FreeIPA has conditional imports for SSSD modules in several places, e.g. in the trust plugin. 96f614e closes the gap and applie

[Freeipa-devel] [freeipa PR#472][comment] Packaging: Add placeholder packages

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/472 Title: #472: Packaging: Add placeholder packages tiran commented: """ OK, you got ```with_wheels``` in ```freeipa.spec.in``` now. ```with_wheels``` is more logical than ```with_pypi``` because wheels have more uses than just PyPI upload. """ Se

[Freeipa-devel] [freeipa PR#472][synchronized] Packaging: Add placeholder packages

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/472 Author: tiran Title: #472: Packaging: Add placeholder packages Action: synchronized To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/472/head:pr472 git checkout pr472 From 1d3e58c

[Freeipa-devel] [freeipa PR#492][comment] [WIP] config: remove meaningless defaults

2017-02-22 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/492 Title: #492: [WIP] config: remove meaningless defaults HonzaCholasta commented: """ Sure. """ See the full comment at https://github.com/freeipa/freeipa/pull/492#issuecomment-281597461 -- Manage your subscription for the Freeipa-devel mailing l

[Freeipa-devel] [freeipa PR#492][comment] [WIP] config: remove meaningless defaults

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/492 Title: #492: [WIP] config: remove meaningless defaults tiran commented: """ Can you add a comment to explain the order of checks and assignments? Without explanation, it's going to confuse the next poor developer. """ See the full comment at ht

[Freeipa-devel] [freeipa PR#301][closed] scripts, tests: explicitly set confdir in the rest of server code

2017-02-22 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/301 Author: HonzaCholasta Title: #301: scripts, tests: explicitly set confdir in the rest of server code Action: closed To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/301/head:pr301

[Freeipa-devel] [freeipa PR#301][+pushed] scripts, tests: explicitly set confdir in the rest of server code

2017-02-22 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/301 Title: #301: scripts, tests: explicitly set confdir in the rest of server code Label: +pushed -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.

[Freeipa-devel] [freeipa PR#301][comment] scripts, tests: explicitly set confdir in the rest of server code

2017-02-22 Thread HonzaCholasta
URL: https://github.com/freeipa/freeipa/pull/301 Title: #301: scripts, tests: explicitly set confdir in the rest of server code HonzaCholasta commented: """ Fixed upstream master: https://fedorahosted.org/freeipa/changeset/fe6f2b6f6effcf9f3c58e1e3f6d0874609c10c25 """ See the full comment at ht

[Freeipa-devel] [freeipa PR#301][comment] scripts, tests: explicitly set confdir in the rest of server code

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/301 Title: #301: scripts, tests: explicitly set confdir in the rest of server code tiran commented: """ My philosophy is: _Don't fix it it it ain't broken._ """ See the full comment at https://github.com/freeipa/freeipa/pull/301#issuecomment-2815966

[Freeipa-devel] [freeipa PR#301][comment] scripts, tests: explicitly set confdir in the rest of server code

2017-02-22 Thread tiran
URL: https://github.com/freeipa/freeipa/pull/301 Title: #301: scripts, tests: explicitly set confdir in the rest of server code tiran commented: """ My philosophy is: _Don't fix it it it ain't broken._ """ See the full comment at https://github.com/freeipa/freeipa/pull/301#issuecomment-2815966