Greetings!
I've received the information from Milan who was UQE reviewer for this design
document - ACK on the current version.
Have a nice day,
- alich -
- Original Message -
> From: "Fraser Tweedale"
> To: "Alexander Bokovoy"
> Cc: "freeipa-devel"
> Sent: Thursday, April 21, 2016 9:
Design doc reviewed. Some minor specifications discussed with Petr and Martin,
added to the doc. UQE_ACK.
Thanks,
- alich -
- Original Message -
> From: "Martin Basti"
> To: "Simo Sorce" , "Petr Spacek"
> Cc: freeipa-devel@redhat.com
> Sent: Thursday, April 21, 2016 7:39:02 PM
> Subjec
Hello,
it looks good, thanks!
ACK.
Target: master
- Original Message -
> From: "Filip Skola"
> To: freeipa-devel@redhat.com
> Cc: "Milan Kubík" , "Aleš Mareček"
> Sent: Monday, April 11, 2016 5:06:26 PM
> Subject: [PATCH 0009] Refactor tes
ACK.
Thank you!
Master push: Make sure it will go *after or together with* the previous patch
from Filip, #0007, thanks!
- alich -
- Original Message -
> From: "Filip Skola"
> To: "Aleš Mareček"
> Cc: freeipa-devel@redhat.com, "Milan Kubík"
&g
ACK.
Thank you!
- alich -
- Original Message -
> From: "Filip Skola"
> To: "Aleš Mareček"
> Cc: freeipa-devel@redhat.com, "Milan Kubík"
> Sent: Wednesday, February 24, 2016 8:07:55 PM
> Subject: Re: [Freeipa-devel] [PATCH] 0007 Refactor tes
E501 line too long (82 > 79 characters)
tracker/sudocmdgroup_plugin.py:64:80: E501 line too long (82 > 79 characters)
- Original Message -----
> From: "Filip Skola"
> To: "Aleš Mareček"
> Cc: freeipa-devel@redhat.com, "Milan Kubík"
>
line too long (81 >
79 characters)
[root@master2 freeipa]# grep 'Class for'
ipatests/test_xmlrpc/tracker/sudocmd_plugin.py
""" Class for host plugin like tests """
- Original Message -
> From: "Filip Skola"
> To: "Ale
NACK.
"create_sudocmd" and "delete_sudocmd" should be imported from Tracker, not from
the previous test (sudocmd_plugin).
- alich -
- Original Message -
> From: "Filip Skola"
> To: freeipa-devel@redhat.com
> Sent: Thursday, January 28, 2016 12:49:17 PM
> Subject: [Freeipa-devel] [PAT
NACK.
"create_sudocmd" and "delete_sudocmd" should be placed in Tracker. So this
patch should create the tracker as well.
- Original Message -
> From: "Filip Skola"
> To: freeipa-devel@redhat.com
> Sent: Monday, January 25, 2016 3:57:25 PM
> Subject: [Freeipa-devel] [PATCH] 0007 Refacto
Tested + several other dependent tests executed as well - PASS.
The patch looks good, ACK.
- Original Message -
> From: "Filip Skola"
> To: "Milan Kubík"
> Cc: freeipa-devel@redhat.com, "Aleš Mareček"
> Sent: Monday, January 25, 2016 11:55:3
- Original Message -
> From: "Milan Kubík"
> To: "Petr Vobornik"
> Cc: "freeipa-devel" , "Ales Marecek"
>
> Sent: Tuesday, December 15, 2015 4:53:18 PM
> Subject: Re: [Freeipa-devel] Testing FreeIPA 4.3 for GA
>
> On 12/15/2015 04:35 PM, Petr Vobornik wrote:
> > On 12/15/2015 01:05 A
Ah, sorry, haven't realized there had been devel list attached.
Ok, there is some problem with \r\n in the patch.
Filip, please take a look at it...
Thanks...
- alich -
- Original Message -
> From: "Filip Škola"
> To: "Aleš Mareček"
> Cc: freeipa-devel
- Original Message -
> From: "Aleš Mareček"
> To: "Filip Škola"
> Cc: freeipa-devel@redhat.com, "Milan Kubík"
> Sent: Thursday, December 10, 2015 4:11:47 PM
> Subject: Re: [Freeipa-devel] [PATCH] 0001 Refactor test_user_plugin
>
> Ah, sorry, h
Ahoj Filipe,
zase tam vidim to '\r\n'... Prisel jsi na to, co to zpusobuje?
Jinak patche jdu otestovat...
- alich -
- Original Message -
> From: "Filip Škola"
> To: "Aleš Mareček"
> Cc: freeipa-devel@redhat.com, "Milan Kubík"
> Sen
NACK.
$ ./make-lint
* Module ipatests.test_xmlrpc.test_user_plugin
ipatests/test_xmlrpc/test_user_plugin.py:42: [E0611(no-name-in-module), ] No
name 'ldaptracker' in module 'ipatests.test_xmlrpc')
$ grep ldaptracker ipatests/test_xmlrpc/test_user_plugin.py
from ipatests.test_xmlrpc
Hello,
ACK for code
NACK for the placing "get_client_ip_with_hostmask" function to test_sudo.py
(this function should be in some more general file)
- Original Message -
> From: "Oleg Fayans"
> To: freeipa-devel@redhat.com
> Sent: Thursday, December 3, 2015 3:32:46 PM
> Subject: Re: [Fre
- Original Message -
> From: "Milan Kubík"
> To: "Martin Basti"
> Cc: freeipa-devel@redhat.com, "Aleš Mareček"
> Sent: Tuesday, December 1, 2015 10:31:14 AM
> Subject: Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations
&g
Greetings!
- Original Message -
> From: "Martin Basti"
> To: "freeipa-devel" , "Petr Vobornik"
> , "Aleš Mareček"
>
> Sent: Wednesday, December 2, 2015 12:20:56 PM
> Subject: Testing replication topologies
>
> Hello all,
7-18:
>
> def get_user_dn(cn):
>
> return DN(('cn', cn), api.env.container_user, api.env.basedn)
>
>
> should be
>
> def get_user_dn(uid):
>
> return DN(('uid', uid), api.env.container_user, api.env.basedn)
>
>
> Some tests may fail becau
Looks good. ACK.
- Original Message -
> From: "Milan Kubík"
> To: "freeipa-devel"
> Cc: "Filip Skola" , "Ales Marecek"
> Sent: Friday, November 20, 2015 3:44:30 PM
> Subject: [patch 0025] Separated Tracker implementations into standalone
> package
>
> Fixes https://fedorahosted.org/fr
ACK.
- Original Message -
> From: "Martin Basti"
> To: "freeipa-devel"
> Sent: Friday, November 13, 2015 7:39:00 PM
> Subject: [Freeipa-devel] [PATCH 0347] Fix CI tests domain_level ENV config
>
> Patch attached.
>
> Following test should pass:
> ipa-run-tests test_integration/test_tes
ACK.
- Original Message -
> From: "Martin Basti"
> To: "freeipa-devel"
> Sent: Monday, November 16, 2015 4:06:51 PM
> Subject: [Freeipa-devel] [PATCH 0348] CI: fix KRA installation with domain
> level>0
>
> Patch attached.
> Part of https://fedorahosted.org/freeipa/ticket/5379
>
>
Looks good, ACK.
- Original Message -
> From: "Milan Kubík"
> To: freeipa-devel@redhat.com
> Sent: Thursday, November 5, 2015 12:20:29 PM
> Subject: Re: [Freeipa-devel] [patch 0023] Applied tier0 and tier1 marks on
> unit tests and xmlrpc tests
>
> On 11/05/2015 11:20 AM, Milan Kubík wr
ok, it's not fault of patch itself, ACK
- Original Message -
> From: "Aleš Mareček"
> To: "Jan Cholasta"
> Cc: "freeipa-devel"
> Sent: Monday, October 12, 2015 3:45:51 PM
> Subject: Re: [Freeipa-devel] [PATCH 503] upgrade: make
Hello,
the patch looks good but pep8 cries:
# pep8 ipaserver/install/server/upgrade.py
ipaserver/install/server/upgrade.py:53:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:68:1: E302 expected 2 blank lines, found 1
ipaserver/install/server/upgrade.py:83:25: E261 at l
Greetings!
Martin, thanks for your review and comments!
I changed the name of the patch and setup my git variables properly. I also
re-tested it and got all passed. I'm sending a new patch that is attached.
- Original Message -
> From: "Martin Basti"
> To: "Ale
Greetings!
This is my very first patch, ticket#4746.
Have a nice day!
- alich -From 0f7eb27d1470e785e3799bc78c367d8118917f99 Mon Sep 17 00:00:00 2001
From: root
Date: Tue, 24 Mar 2015 14:40:49 +0100
Subject: [PATCH] ipatests - added tests for SOA record Maintenance
---
ipatests/test_xmlrpc/tes
27 matches
Mail list logo
