Re: [Freeipa-devel] [PATCH] 222 Fixed incorrect link to browser config after session expiration

2012-10-23 Thread Endi Sukma Dewata
On 10/17/2012 5:07 AM, Petr Vobornik wrote: Fixed typo in message placeholder. https://fedorahosted.org/freeipa/ticket/3187 ACK. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freei

Re: [Freeipa-devel] [PATCHES] backport of Firefox extension to FreeIPA 2.2

2012-10-16 Thread Endi Sukma Dewata
On 10/12/2012 5:55 AM, Petr Viktorin wrote: On 10/11/2012 02:55 PM, Petr Vobornik wrote: This bunch of patches is a backport of Firefox extension to FreeIPA 2.2. First apply pvoborni's patches then pviktori's. I tested several replication/upgrade scenarios. Upgrading from 2.2.0 and to master

Re: [Freeipa-devel] [PATCH] [WIP] Firefox extension

2012-10-05 Thread Endi Sukma Dewata
On 10/5/2012 10:43 AM, Petr Vobornik wrote: 1. It looks like the Firefox is limited to version 10 to 15 in install/ffextension/install.rdf. Do we need the upper limit? 10.0 15.0.* My understanding is that maxversion represents maximum tested version. [https://developer.mozilla.org/en-US/do

Re: [Freeipa-devel] [PATCH] [WIP] Firefox extension

2012-10-05 Thread Endi Sukma Dewata
On 10/5/2012 8:56 AM, Alexander Bokovoy wrote: On Thu, 04 Oct 2012, Petr Vobornik wrote: On 10/03/2012 04:19 PM, Simo Sorce wrote: On Wed, 2012-10-03 at 15:50 +0200, Petr Vobornik wrote: As Alexander proposed in other channel. I will remove the removal of configure.jar and offer the old config

Re: [Freeipa-devel] [PATCH] 212 Fix integer validation when boundary value is empty string

2012-09-18 Thread Endi Sukma Dewata
On 9/18/2012 6:36 AM, Petr Vobornik wrote: Updated patch attached. ACK. 1. Instead of IPA.not_defined() it might be better to call it IPA.defined() to avoid double negations like this: if (!IPA.not_defined(metadata.minvalue, true) ... Function renamed, logic negated. Unit tests for IPA.

Re: [Freeipa-devel] [PATCH] 212 Fix integer validation when boundary value is empty string

2012-09-17 Thread Endi Sukma Dewata
On 9/11/2012 10:09 AM, Petr Vobornik wrote: There was an error in number validation check. If boundary value was an empty string, validation of a number always failed. This patch fixes the problem by not performing the check in these cases. Basic unit tests for IPA.metadata_validator created.

Re: [Freeipa-devel] [PATCH] 214 Fix jquery error when using '??' in a pkey

2012-09-17 Thread Endi Sukma Dewata
On 9/14/2012 8:00 AM, Petr Vobornik wrote: This patch is only for FreeIPA 2.2. It is already fixed in 3.0. If '??' is used in a adder dialog as a pkey it can cause "jQuery15208158273949015573_1346241267446 was not called" error. Update of jquery library fixes the issue. Update reveals an incorr

Re: [Freeipa-devel] [PATCH] 304 Allow localhost in zone ACIs

2012-09-10 Thread Endi Sukma Dewata
On 9/6/2012 7:00 AM, Martin Kosek wrote: On 09/06/2012 01:35 PM, Petr Vobornik wrote: On 09/06/2012 11:51 AM, Martin Kosek wrote: Loopback address, "localhost" and "localnets" ACIs are no longer an issue for bind-dyndb-ldap. Allow them in our validators. Martin's patch works and looks good -

Re: [Freeipa-devel] [PATCH] 211 Prevent opening of multiple dirty dialogs on navigation

2012-09-10 Thread Endi Sukma Dewata
On 9/7/2012 7:37 AM, Petr Vobornik wrote: Facets which performs AJAX call after update refresh (clear dirty state) after calling callback of dirty dialog. It might lead to multiple openings of dirty dialog. Assuming that calling dirty dialog's callback can be evaluated as "dirty state is gone",

Re: [Freeipa-devel] [PATCH] 209 Fixed problem while deleting entry with unsaved changes

2012-09-05 Thread Endi Sukma Dewata
On 9/5/2012 10:00 AM, Petr Vobornik wrote: While deleting an entry it now resets a facet if there are unsaved changes. It prevents pop up of various error dialogs when UI tries to redirect to search page after successful delete. https://fedorahosted.org/freeipa/ticket/3047 ACK. -- Endi S. Dew

Re: [Freeipa-devel] [PATCH] 206-208 Fixed number parameters MIN boundary validation in Web UI

2012-09-05 Thread Endi Sukma Dewata
On 9/5/2012 9:08 AM, Petr Vobornik wrote: Integers were missing most of minimum checks and Decimals boundaries weren't checked at all in Web UI. First part is done in ipalib, second in Web UI. 1) [PATCH] 206 Fixed metadata serialization of Numbers and DNs: There were following problems: 1. DNs

Re: [Freeipa-devel] [PATCH] 205 Reflect API change of SSH store in Web UI

2012-09-05 Thread Endi Sukma Dewata
On 9/5/2012 3:14 AM, Petr Vobornik wrote: Format of ipasshpubkey in users and hosts changed from BYTES to STR. Web UI no longer gets the value as base64 encoded string in an object. Label was changed to reflect that the key don't have to be plain base64 encoded blob. https://fedorahosted.org/fr

Re: [Freeipa-devel] [PATCH] 204 Update of confirmation of actions

2012-09-05 Thread Endi Sukma Dewata
On 9/3/2012 11:05 AM, Petr Vobornik wrote: This patch is changing confirmation of actions according to ticket #3035, see the ticket description. It does following changes: * Confirmation of update action was removed. * Action lists resets to first action (which is usually a NOP: '-- select a

Re: [Freeipa-devel] [PATCH] 203 Notify success on add, delete and update

2012-09-05 Thread Endi Sukma Dewata
On 9/3/2012 8:35 AM, Petr Vobornik wrote: Notification of success was added to: * details facet: update * association facet and association widget: add, delete items * attribute facet: delete items (notification of add should be handled in entity adder dialog) * sudo rule: add, remove opt

Re: [Freeipa-devel] [PATCH] 197 Fixed search in HBAC test

2012-09-05 Thread Endi Sukma Dewata
On 9/3/2012 6:28 AM, Petr Vobornik wrote: b) force refresh when searching with unchanged filter I did (b). Updated patch attached. I don't want to implement 'expiration date' at the moment. It's too widespread change. Maybe in FreeIPA 3.2. ACK. -- Endi S. Dewata ___

Re: [Freeipa-devel] [PATCH] 199 Permissions: select only applicable options on type change

2012-09-05 Thread Endi Sukma Dewata
On 9/3/2012 5:59 AM, Petr Vobornik wrote: Updated patch attached. ACK. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] Paging in Web UI

2012-09-01 Thread Endi Sukma Dewata
On 8/31/2012 9:54 AM, Petr Vobornik wrote: How about this, when you open the search page for the first time it will do a regular search, no paging. Instead of showing the paging controls (Prev & Next buttons) we show "See more results..." If you click that it will rerun the search with paging (wh

Re: [Freeipa-devel] Paging in Web UI

2012-08-29 Thread Endi Sukma Dewata
On 8/29/2012 10:24 AM, Rich Megginson wrote: On 08/29/2012 09:16 AM, Endi Sukma Dewata wrote: On 8/29/2012 9:49 AM, Rich Megginson wrote: We can also use Simple Paged Results, but if I understood correctly it requires the httpd to maintain an open connection to the LDAP server foreach user and

Re: [Freeipa-devel] Paging in Web UI

2012-08-29 Thread Endi Sukma Dewata
On 8/29/2012 8:49 AM, Petr Vobornik wrote: Another possibility is to use VLV, but it seems to require open connection too and only works with a predefined filter. Apart from the possible connection problem I think it is very usable for default views of search pages. User can freely page. I don'

Re: [Freeipa-devel] Paging in Web UI

2012-08-29 Thread Endi Sukma Dewata
On 8/29/2012 9:49 AM, Rich Megginson wrote: We can also use Simple Paged Results, but if I understood correctly it requires the httpd to maintain an open connection to the LDAP server foreach user and for each page. Not for each user. In 389-ds-base-1.2.11 you can have multiple simple paged re

Re: [Freeipa-devel] Paging in Web UI

2012-08-28 Thread Endi Sukma Dewata
On 8/28/2012 11:23 AM, Petr Vobornik wrote: Your possible solution does not address how many results are fetched (unless I misunderstood). > If paging is enabled it doesn't, but it expects, that admin will disable it for larger setups.For smaller setups it isn't of much an issue. If paging is d

Re: [Freeipa-devel] Paging in Web UI

2012-08-28 Thread Endi Sukma Dewata
On 8/28/2012 8:30 AM, Petr Vobornik wrote: I would like to point out a problem in Web UI related to paging and suggest a possible solution: Current implementation of paging in Web UI is not serving it purpose which should be to do operations faster and be able to find all users. How current imp

Re: [Freeipa-devel] [PATCH] 202 Password policy paging with proper sorting

2012-08-28 Thread Endi Sukma Dewata
ACK. Some comments below. On 8/27/2012 10:51 AM, Petr Vobornik wrote: This patch adds option to disable sorting when paging. It allowed to enable paging in password policy with order of items untouched (they are sorted on server side by priority). Is the sorting we see in the UI and CLI ident

Re: [Freeipa-devel] [PATCH] 201 Successful action notification

2012-08-28 Thread Endi Sukma Dewata
On 8/27/2012 5:57 AM, Petr Vobornik wrote: User was not notified about success of actions executed from action list, action panel or facet control bar. This patch adds IPA.notify_success(message) call. It creates a yellow notification area with supplied message in Web UI header in the middle of

Re: [Freeipa-devel] [PATCH] 200 Fix issue which broke setup of Web UI unit tests

2012-08-28 Thread Endi Sukma Dewata
On 8/27/2012 5:52 AM, Petr Vobornik wrote: Fix issue which broke setup of Web UI unit tests Web UI itself wasn't negatively affected. Issue introduced in be144da672e0634f7aaeff69d662cbc4d11aff0f (#2897). https://fedorahosted.org/freeipa/ticket/2897 ACK. -- Endi S. Dewata __

Re: [Freeipa-devel] [PATCH] 199 Permissions: select only applicable options on type change

2012-08-28 Thread Endi Sukma Dewata
Found a couple of issues with Undo: 1. Using the scenario described in the ticket, if I undo the Type back to User Group the Attributes aren't updated, it still shows the Service attributes. 2. After that, if I undo the Attributes it will show the originally selected attribute (description)

Re: [Freeipa-devel] [PATCH] 198 Revert change causing failure in test automation

2012-08-28 Thread Endi Sukma Dewata
On 8/22/2012 2:50 AM, Petr Vobornik wrote: Move of click handler in patch for #2834 causes failure of automation tests. This patch reverts the problematic part. It should not affect function of fix for #2834. https://fedorahosted.org/freeipa/ticket/3014 ACK. -- Endi S. Dewata __

Re: [Freeipa-devel] [PATCH] 197 Fixed search in HBAC test

2012-08-28 Thread Endi Sukma Dewata
On 8/21/2012 9:03 AM, Petr Vobornik wrote: Search in HBAC test wasn't working because expired flag wasn't set. https://fedorahosted.org/freeipa/ticket/2931 Notes: HBAC facets don't have refresh button. They can be refreshed by changing filter and searching. If one search with same filter, it se

Re: [Freeipa-devel] [PATCH] 193 Range Web UI

2012-08-20 Thread Endi Sukma Dewata
On 8/20/2012 10:49 AM, Petr Vobornik wrote: Updated patch attached. Preview can be seen at: http://pvoborni.fedorapeople.org/ranges/#ipaserver=range&navigation=ipaserver&range-facet=search ACK. I agree, all options should be display and depending on the Range type either Secondary RID base or

Re: [Freeipa-devel] [PATCH] 196 Update other facets on delete from search page

2012-08-13 Thread Endi Sukma Dewata
On 8/10/2012 6:48 AM, Petr Vobornik wrote: When an object in search facet was deleted, other facets were not notified that they need to refresh. If one crated object with same pkey as deleted object and then navigated to it's details he could see old object's data. This notification was added.

Re: [Freeipa-devel] [PATCH] 195 Disable caching of Web UI login_kerberos request

2012-08-13 Thread Endi Sukma Dewata
On 8/10/2012 6:13 AM, Petr Vobornik wrote: IE caches login_kerberos request so SSO doesn't work after logout. This patch disables the caching. https://fedorahosted.org/freeipa/ticket/2991 ACK. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeip

Re: [Freeipa-devel] [PATCH] 194 Handle case when trusted domain user access the Web UI

2012-08-13 Thread Endi Sukma Dewata
On 8/10/2012 6:11 AM, Petr Vobornik wrote: WebUI catches the fact that the user can't access LDAP server with a current ticket. It shows form-based auth login dialog. Previoustly an ugly error was returned on an almost empty page, and user had no recourse. https://fedorahosted.org/freeipa/ticket

Re: [Freeipa-devel] [PATCH] 193 Range Web UI

2012-08-13 Thread Endi Sukma Dewata
On 8/6/2012 2:08 AM, Petr Vobornik wrote: Range web UI was implemented. It consist of: * new menu item - 'ranges' in 'IPA Server' tab * new search page * new details page https://fedorahosted.org/freeipa/ticket/2894 Some comments/questions: 1) I'm not sure about options in adder dial

Re: [Freeipa-devel] [PATCH] 186-192 Web UI: Group external member support

2012-08-13 Thread Endi Sukma Dewata
On 8/10/2012 6:04 AM, Petr Vobornik wrote: Attaching all patches. Patches 186-189 are changed or rebased. Rest is intact. ACK. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-

Re: [Freeipa-devel] [PATCH] 186-192 Web UI: Group external member support

2012-08-06 Thread Endi Sukma Dewata
ACK. The patches work, but I have some comments: 1. Would it be better to use radio buttons to define mutually exclusive options? Something like this: Group type: (o) Normal ( ) External ( ) POSIX GID: [] 2. If you decide to use rad

Re: [Freeipa-devel] [PATCH] 185 PAC Type options for services in Web UI

2012-08-01 Thread Endi Sukma Dewata
On 8/1/2012 11:04 AM, Petr Vobornik wrote: Following options were added to Web UI * PAC Type in service * PAC Type in configuration Testing metadata for objects and commands were regenerated. https://fedorahosted.org/freeipa/ticket/2958 ACK. -- Endi S. Dewata _

Re: [Freeipa-devel] [PATCHES] 177-184 Rebase of jquery and jquery-ui libs

2012-08-01 Thread Endi Sukma Dewata
On 8/1/2012 8:43 AM, Petr Vobornik wrote: Silly mistake. I should test builds more often when playing with files... Updated patch 178 attached. Build and install should work. ACK. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat

Re: [Freeipa-devel] [PATCHES] 177-184 Rebase of jquery and jquery-ui libs

2012-07-31 Thread Endi Sukma Dewata
On 7/27/2012 11:59 AM, Petr Vobornik wrote: This effort was driven by ticket https://fedorahosted.org/freeipa/ticket/2817 which needed update of jqury-ui library. When I was at it I also updated core jquery lib. All patches are associated with ticket #2817 which might be bad. Should I split it to

Re: [Freeipa-devel] [PATCH] 175, 176 Fixed: Unable to select option in combobox in IE and Chrome

2012-07-31 Thread Endi Sukma Dewata
On 7/27/2012 10:55 AM, Petr Vobornik wrote: [PATCH] 175 Fixed: Unable to select option in combobox in IE and Chrome There's probably a bug regarding z-index stacking in Chrome and IE. It appears when combobox is used in dialog. Combobox's select area had z-index=1010. When first jquery dialog is

Re: [Freeipa-devel] [PATCH] 174 Fix autoscroll to top in tables in IE

2012-07-23 Thread Endi Sukma Dewata
On 7/23/2012 9:05 AM, Petr Vobornik wrote: In IE when a window is small (horizontal scrollbar is displayed) click or keyboard input on various parts of UI makes search tables scroll to top. It prevents from selecting items in a table. This issue happens when using absolute positioned element with

Re: [Freeipa-devel] [PATCH] 173 IDs and names for dialogs

2012-07-23 Thread Endi Sukma Dewata
On 7/19/2012 8:07 AM, Petr Vobornik wrote: It's hard to detect if or which type of dialog is displayed because not all dialogs have IDs. On dialog open, it's id or name (if id is not set) is used for containing element id. Many of dialog types were missing id or name so name was added to each di

Re: [Freeipa-devel] [PATCH] 172 Bigger textarea for permission type=subtree

2012-07-17 Thread Endi Sukma Dewata
On 7/17/2012 9:25 AM, Petr Vobornik wrote: Possible improvement, instead of using a fixed column size the text area also could be made to occupy 100% of available width. Ideally it should have the same width as the text field or drop down list in this dialog. Updated patch attached. I added tw

Re: [Freeipa-devel] [PATCH] 172 Bigger textarea for permission type=subtree

2012-07-16 Thread Endi Sukma Dewata
On 7/16/2012 6:53 AM, Petr Vobornik wrote: Patch description: Adder dialog and details facet for permission type=subtree have small textarea for defining subtree filter. It was unconfortable to define the filter. This difference was removed. https://fedorahosted.org/freeipa/ticket/2832 Note reg

Re: [Freeipa-devel] [PATCH] 171 Fixed display of attributes_widget in IE9

2012-07-16 Thread Endi Sukma Dewata
On 7/16/2012 3:56 AM, Petr Vobornik wrote: Attributes widget is using overflow css rule in tbody element. IE9 doesn't handle it well. To fix the issue, attributes widget was slightly modified and conditional css stylesheet was added just for fixing IE problems. https://fedorahosted.org/freeipa/

Re: [Freeipa-devel] [PATCH] 170 Differentiation of widget type and text_widget input type

2012-07-16 Thread Endi Sukma Dewata
On 7/12/2012 8:10 AM, Petr Vobornik wrote: There was a clash of 'type' attribute in widget's spec. Usually 'type' is used for telling a builder which field and widget to build. Text widget used this attribute also for definion of html input type. It was problematic for some special widgets, which

Re: [Freeipa-devel] [PATCH] 168 Password policy measurement units

2012-07-09 Thread Endi Sukma Dewata
On 7/9/2012 10:21 AM, Petr Vobornik wrote: Note: I think we should improve handling of measurement units in server plugins. Label and measurement unit should be separated and send in metadata. Client - Web UI or CLI would then decide when and where to display the units. I will create an enhanceme

Re: [Freeipa-devel] [PATCH] 169 Web UI: kerberos ticket policy measurement units

2012-07-09 Thread Endi Sukma Dewata
On 7/9/2012 10:32 AM, Petr Vobornik wrote: Added measurement units for kerberos ticket policy. https://fedorahosted.org/freeipa/ticket/2444 Note: patch depends on pvoborni-0168. ACK. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@

Re: [Freeipa-devel] [PATCH] 167 Add and remove dns per-domain permission in Web UI

2012-07-09 Thread Endi Sukma Dewata
On 7/9/2012 6:55 AM, Petr Vobornik wrote: Patch functionality depends on not yet posted pviktori's patch which adds error_code (in case of command error) to batch response. Patch description: This patch adds support for new per-domain permissions to Web UI. User with assigned permission (throu

Re: [Freeipa-devel] [PATCH] 165 Display loginas information only after login

2012-07-09 Thread Endi Sukma Dewata
On 7/4/2012 8:08 AM, Petr Vobornik wrote: On 07/02/2012 05:49 PM, Endi Sukma Dewata wrote: ACK. Some more comments below. Feel free to fix before push or later separately. Implemented most of the issues, look bellow. Update patch attached. ACK. -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] 165 Display loginas information only after login

2012-07-02 Thread Endi Sukma Dewata
ACK. Some more comments below. Feel free to fix before push or later separately. On 7/2/2012 2:55 AM, Petr Vobornik wrote: On 06/28/2012 10:47 PM, Endi Sukma Dewata wrote: On 6/28/2012 9:07 AM, Petr Vobornik wrote: Message 'Logged in as: u...@freeipa.org' was displayed before user

Re: [Freeipa-devel] [PATCH] 165 Display loginas information only after login

2012-06-28 Thread Endi Sukma Dewata
On 6/28/2012 9:07 AM, Petr Vobornik wrote: Message 'Logged in as: u...@freeipa.org' was displayed before user was logged in. It was wrong. Now 'Logged in as: XXX' is displayed only when user XXX is logged in. So no more u...@freeipa.org :) . https://fedorahosted.org/freeipa/ticket/2882 It mig

Re: [Freeipa-devel] [PATCH] 162 Web UI password is going to expire in n days notification

2012-06-28 Thread Endi Sukma Dewata
On 6/28/2012 8:59 AM, Petr Vobornik wrote: On 06/27/2012 04:33 PM, Petr Vobornik wrote: On 06/27/2012 03:54 AM, Endi Sukma Dewata wrote: On 6/26/2012 9:46 AM, Petr Vobornik wrote: This is patch is more like a draft. I'm not sure where to display the 'password is going to expire

Re: [Freeipa-devel] [PATCH] 164 Continuation of removing of not supported command options from Web UI

2012-06-28 Thread Endi Sukma Dewata
On 6/27/2012 11:22 AM, Petr Vobornik wrote: This patch removes following non-existing command options: * all,rights in host_disable * record_type in dns_record_add * all,rights in various xxx_remove_xxx commands used in rule_association_table_field (removing association) https://fedorahost

Re: [Freeipa-devel] [PATCH] 163 Refactored association facet to use facet buttons with actions

2012-06-28 Thread Endi Sukma Dewata
On 6/27/2012 11:19 AM, Petr Vobornik wrote: Association facet was refactored to use new concept of control buttons. It is the last facet type which don't use this concept. It fixes regression introduced by previous refactoring of table facet (delete button was never enabled). https://fedorahoste

Re: [Freeipa-devel] [PATCH] 162 Web UI password is going to expire in n days notification

2012-06-26 Thread Endi Sukma Dewata
On 6/26/2012 9:46 AM, Petr Vobornik wrote: This is patch is more like a draft. I'm not sure where to display the 'password is going to expire' notification. I was deciding between: 1) red bold text in Web UI header 2) popup dialog after Web UI initialization I don't like unwanted pop-up di

Re: [Freeipa-devel] freeIPA as a samba backend

2012-06-26 Thread Endi Sukma Dewata
On 6/26/2012 12:53 PM, Rich Megginson wrote: IPA will keep all of your passwords in sync - userPassword, sambaNTPassword, sambaLMPassword, and your kerberos passwords. 389 cannot do this - the functionality that does this is provided by an IPA password plugin. Openldap has a similar plugin, but

Re: [Freeipa-devel] [PATCH] 159 Action panel for certificates

2012-06-26 Thread Endi Sukma Dewata
On 6/26/2012 12:36 PM, Petr Vobornik wrote: I'm testing using self-signed CA. When I open the host/service details page there's a JS error at certificate.js:928 (undefined status_revoked), so the page seems to hang and looks blank. In the old code the status_revoked panel will only be created if

Re: [Freeipa-devel] [PATCH] 160,161 Trust Web UI

2012-06-25 Thread Endi Sukma Dewata
On 6/25/2012 11:18 AM, Alexander Bokovoy wrote: ACK abbra-53 & abbra-54. One thing though, the error message is not very user friendly. Feel free to fix before push. % ipa trust-add ad.test --type=asdf ipa: ERROR: invalid 'type': must be one of (u'ad',) The ValidationError specifies this mess

Re: [Freeipa-devel] [PATCH] 160,161 Trust Web UI

2012-06-25 Thread Endi Sukma Dewata
/2012 01:44 AM, Endi Sukma Dewata wrote: On 6/22/2012 11:48 AM, Alexander Bokovoy wrote: 2. First two chunks of install/ui/test/data/ipa_init_commands.json and install/ui/test/data/ipa_init_objects.json changes look unrelated to this ticket. These files are snapshots of metadata used for demo

Re: [Freeipa-devel] [PATCH] 159 Action panel for certificates

2012-06-25 Thread Endi Sukma Dewata
On 6/12/2012 7:48 AM, Petr Vobornik wrote: This is a continuation of effort which transforms status widgets with buttons executing actions to separate status widget and action panels. This patch strips certificate status widget of its buttons and separates the actions to their own objects. Approp

Re: [Freeipa-devel] [PATCH] 160,161 Trust Web UI

2012-06-22 Thread Endi Sukma Dewata
On 6/22/2012 11:48 AM, Alexander Bokovoy wrote: 2. First two chunks of install/ui/test/data/ipa_init_commands.json and install/ui/test/data/ipa_init_objects.json changes look unrelated to this ticket. These files are snapshots of metadata used for demo/testing. I suppose Petr was updating the

Re: [Freeipa-devel] [PATCH] 147 Set network.http.sendRefererHeader to 2 on browser config

2012-06-21 Thread Endi Sukma Dewata
On 6/21/2012 11:29 AM, Petr Vobornik wrote: I modified the patch to set it in old browsers. Patch attached. I tested it in Firefox 3.6.17 in fresh install of RHEL 6.1. ACK. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com ht

Re: [Freeipa-devel] [PATCH] 147 Set network.http.sendRefererHeader to 2 on browser config

2012-06-20 Thread Endi Sukma Dewata
Sorry for the late response. I have some questions below. On 6/11/2012 1:38 PM, Rob Crittenden wrote: Petr Vobornik wrote: This patch adds a functionality which sets Firefox network.http.sendRefererHeader configuration option to value '2' which enables it. Possible values: http://kb.mozillazin

Re: [Freeipa-devel] [PATCH] 158 Separate reset password page

2012-06-20 Thread Endi Sukma Dewata
On 6/19/2012 1:22 AM, Petr Vobornik wrote: Updated patch attached. Sorry for late update, I was working on trust UI and didn't want to switch context. No problem. It would be nicer if this page can use the same fonts as the login dialog in patch #157, but that can be fixed separately. ACK.

Re: [Freeipa-devel] [PATCH] 157 Added password reset capabilities to unauthorized dialog

2012-06-20 Thread Endi Sukma Dewata
ACK, but feel free to make additional minor changes as suggested below before push. On 6/19/2012 9:01 AM, Petr Vobornik wrote: In general I like simplifying the dialog so I took most of your suggestions and implemented them following way: Login -

Re: [Freeipa-devel] [PATCH] 158 Separate reset password page

2012-06-13 Thread Endi Sukma Dewata
On 6/13/2012 8:32 AM, Petr Vobornik wrote: On 06/13/2012 01:25 AM, Endi Sukma Dewata wrote: On 6/8/2012 10:54 AM, Petr Vobornik wrote: This patch adds separate reset password page. It is a complement to separate login page. It differentiate from reset password capabilities in Web UI&#

Re: [Freeipa-devel] [PATCH] 157 Added password reset capabilities to unauthorized dialog

2012-06-13 Thread Endi Sukma Dewata
On 6/13/2012 8:15 AM, Petr Vobornik wrote: I'll address all issues once we decide on the solution. 1. If you click 'form-based authentication the dialog title still shows 'Kerberos ticket no longer valid' which is not relevant for form-based authentication. It might be better to use 'Login' as

Re: [Freeipa-devel] [PATCH] 158 Separate reset password page

2012-06-12 Thread Endi Sukma Dewata
On 6/8/2012 10:54 AM, Petr Vobornik wrote: This patch adds separate reset password page. It is a complement to separate login page. It differentiate from reset password capabilities in Web UI's anauthorized dialog by not performing login. This is useful for users who wants only to reset the passw

Re: [Freeipa-devel] [PATCH] 157 Added password reset capabilities to unauthorized dialog

2012-06-12 Thread Endi Sukma Dewata
On 6/8/2012 10:52 AM, Petr Vobornik wrote: and now the patch... On 06/08/2012 05:51 PM, Petr Vobornik wrote: For those of you who are only interest in user perspective I prepared a set of screenshots to demonstrate workflow of password reset: http://pvoborni.fedorapeople.org/ux/reset_password_wo

Re: [Freeipa-devel] [PATCH] 155 Action panel for host enrollment

2012-06-12 Thread Endi Sukma Dewata
On 6/6/2012 10:59 AM, Petr Vobornik wrote: Widgets in host enrollment sections were modified. They now serve only for displaying of has_key and has_password status. Functionality for setting otp and unprovisioning was moved to separate dialogs. Execution points for opening of these dialogs are it

Re: [Freeipa-devel] [PATCH] 156 Action panel for service provisioning

2012-06-12 Thread Endi Sukma Dewata
On 6/7/2012 3:52 AM, Petr Vobornik wrote: Service provisioning status widget was modified only to display the has_keytab status. Button for 'delete key,unprovision' was moved as action to newly created action panel in the same section. This required to moved the creation of the unprovisioning dia

Re: [Freeipa-devel] [PATCH] 151, 152 Removal of illegal options in association dialog

2012-06-06 Thread Endi Sukma Dewata
On 6/6/2012 7:12 AM, Petr Vobornik wrote: On 06/05/2012 08:38 PM, Endi Sukma Dewata wrote: If I understood correctly the json_exclude_attrs already defines the list of attributes to be excluded, so is it still necessary to define json_only_presence_options which basically will remove all

Re: [Freeipa-devel] [PATCH] 151, 152 Removal of illegal options in association dialog

2012-06-05 Thread Endi Sukma Dewata
If I understood correctly the json_exclude_attrs already defines the list of attributes to be excluded, so is it still necessary to define json_only_presence_options which basically will remove all attributes except name? Suppose later you're writing the UI console where you can type the CLI co

Re: [Freeipa-devel] [PATCH] 150 Text widget's dirty state is changed on various input methods

2012-05-31 Thread Endi Sukma Dewata
On 5/28/2012 6:44 AM, Petr Vobornik wrote: on_value_changed event in textboxes and textareas was raised only on keyboard input. If user used different input method such as paste or browser undo and redo functions widget's on_value_changed event wasn't raised and so dirty state wasn't changed as w

Re: [Freeipa-devel] [PATCH] 149 Added links to netgroup member tables

2012-05-31 Thread Endi Sukma Dewata
On 5/25/2012 11:23 AM, Petr Vobornik wrote: Tables with members in netgroup were missing links for navigation to associated details pages. This patch adds these links. https://fedorahosted.org/freeipa/ticket/2670 ACK. -- Endi S. Dewata ___ Freeipa-

Re: [Freeipa-devel] [PATCH] 148 Removal of illegal options in JSON-RPC calls

2012-05-31 Thread Endi Sukma Dewata
On 5/25/2012 9:57 AM, Petr Vobornik wrote: Ticket https://fedorahosted.org/freeipa/ticket/2509 bans using non existent options. If such option is supplied command ends with error. It uncovered several cases in Web UI. This patch is fixing these cases. Automember, Self-service and Delegation don'

Re: [Freeipa-devel] [PATCH] 146 Added cancel button to service unprovision dialog

2012-05-31 Thread Endi Sukma Dewata
On 5/24/2012 4:11 AM, Petr Vobornik wrote: Service unprovision dialog was missing a cancel button. The button was added. https://fedorahosted.org/freeipa/ticket/1811 ACK. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com htt

Re: [Freeipa-devel] [PATCHES] 138-145 Action panel for user password reset

2012-05-31 Thread Endi Sukma Dewata
ACK. Looks good. Some comments: 1. I suppose the select_action will always be the first action in any header_actions, and the action doesn't actually do anything. You might want to consider the '-- select action --' as part of the IPA.action_list_widget and add it automatically in init_option

Re: [Freeipa-devel] [PATCH] 137 Instructions to generate cert use certutil instead of openssl

2012-05-31 Thread Endi Sukma Dewata
On 5/11/2012 6:37 AM, Petr Vobornik wrote: Instructions to generate certificate were changed. Now they use certutil instead of openssl. In the example is also used option for specifying key size. https://fedorahosted.org/freeipa/ticket/2725 This is already pushed, but the text probably could b

Re: [Freeipa-devel] [PATCH] 133 Action list for user password

2012-05-14 Thread Endi Sukma Dewata
36 AM, Petr Vobornik wrote: > On 05/08/2012 01:47 AM, Endi Sukma Dewata wrote: >> 10. The 'Action List' in ticket #2248 for the password reset is actually >> different than the action list for Enable/Disable. I was proposing to >> create a small panel under the 'Ac

Re: [Freeipa-devel] [PATCH] 136 Correction of nested search facets tab labels

2012-05-14 Thread Endi Sukma Dewata
On 5/10/2012 5:29 AM, Petr Vobornik wrote: Nested search facets were using 'search' tab label instead of their nested entity name. This patch is fixing that regression. https://fedorahosted.org/freeipa/ticket/2744 ACK. -- Endi S. Dewata ___ Freeip

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-14 Thread Endi Sukma Dewata
On 5/10/2012 7:19 AM, Petr Vobornik wrote: Updated patch attached. See comments below. On 05/08/2012 04:23 AM, Endi Sukma Dewata wrote: Try adding a very long DNS zone, then open the zone. Compare the breadcrumbs in the DNS Resource Records page and in the Settings page, in my case the second

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-07 Thread Endi Sukma Dewata
On 5/3/2012 8:26 AM, Petr Vobornik wrote: On 05/03/2012 03:19 PM, Petr Vobornik wrote: I found that limitation of maximum pkey length in facet header is not working well. Attaching patch #134 which actually calculates it. I found useless line in the patch. Corrected version attached. Try add

Re: [Freeipa-devel] [PATCHES] 124-132 Inconsistent ways to show/change entry status

2012-05-07 Thread Endi Sukma Dewata
The code works, it's ACKed. I have some comments below: On 5/2/2012 8:33 AM, Petr Vobornik wrote: This bunch of patches are implementing ticket #2247. They introduce some new logic and types of internal objects. There might be design issues (mainly in state evaluation). I would appreciate some o

Re: [Freeipa-devel] [PATCH] 122 Added permission field to delegation

2012-04-18 Thread Endi Sukma Dewata
On 4/18/2012 10:02 AM, Rob Crittenden wrote: Petr Vobornik wrote: Permission field is missing in delegation so it can't be set/modified. It was added to delegation details facet and adder dialog. The field is using checkboxes instead of multivalued textbox because it can have only two effectiv

Re: [Freeipa-devel] [PATCH] 118-119 DNS forward policy: checkboxes changed to radio buttons

2012-04-10 Thread Endi Sukma Dewata
On 4/5/2012 10:58 AM, Petr Vobornik wrote: Revised patch 118 attached. I used: * Forward first * Forward only and set 'default_value' to 'first'. So there would be always some value checked, which indicates what is actually used. There is a little issue with undo button if policy is not set '' b

Re: [Freeipa-devel] [PATCH] 118-119 DNS forward policy: checkboxes changed to radio buttons

2012-04-05 Thread Endi Sukma Dewata
On 4/4/2012 5:36 AM, Petr Vobornik wrote: DNS forward policy fields were using mutually exclusive checkboxes. Such behavior is unusual for users. Checkboxes were changed to radios with new option 'none/default' to set empty value ''. https://fedorahosted.org/freeipa/ticket/2599 Second patch re

Re: [Freeipa-devel] [PATCH] 117 Added attrs field to permission for target=subtree

2012-04-05 Thread Endi Sukma Dewata
On 4/4/2012 2:19 AM, Petr Vobornik wrote: Permission form was missing attrs field for target=subtree. All other target types have it. It uses multivalued text widget, same as filter, because we can't predict the target type. https://fedorahosted.org/freeipa/ticket/2592 ACK. -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] 116 Fixed: permission attrs table didn't update its available options on load

2012-04-05 Thread Endi Sukma Dewata
On 4/4/2012 2:18 AM, Petr Vobornik wrote: It could lead to state where attributes from other object type were displayed instead of the correct ones. https://fedorahosted.org/freeipa/ticket/2590 ACK. -- Endi S. Dewata ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 115 Reworked netgroup Web UI to allow setting user/host category

2012-04-05 Thread Endi Sukma Dewata
On 3/29/2012 7:46 AM, Petr Vobornik wrote: This patch is changing netgroup web ui to look more like hbac or sudo rule UI. This change allows to define and display user category, host category and external host. The core of the change is changing member attributes (user, group, host, hostgroup) t

Re: [Freeipa-devel] [PATCHES] 113-114 Facet expiration flag

2012-03-27 Thread Endi Sukma Dewata
On 3/22/2012 12:50 PM, Petr Vobornik wrote: The effort was split to two patches. See patch descriptions. ACK on both. Nice job. See comments below. Notes: Case #7 (automatic: an open facet should automatically refresh itself when it expires) I don't want to implement because I think it can ca

Re: [Freeipa-devel] [PATCH] 107 Content is no more overwritten by error message

2012-03-19 Thread Endi Sukma Dewata
On 3/19/2012 1:06 PM, Petr Vobornik wrote: One more thing, this may not be a problem now, but the error_container uses both facet-content and facet-error CSS classes. I understand this is done to avoid code duplication, but this also means the facet will have 2 facet-contents. CSS classes can be

Re: [Freeipa-devel] [PATCH] 107 Content is no more overwritten by error message

2012-03-19 Thread Endi Sukma Dewata
ACK 106-1 and 111. See comments below. On 3/16/2012 9:41 AM, Petr Vobornik wrote: On 03/13/2012 10:54 PM, Endi Sukma Dewata wrote: In the ticket I added 2 more scenarios to reproduce the problem. So we have 3 possible cases: 1. invalid UI state 2. non-existent entry 3. server down For case #1

Re: [Freeipa-devel] [PATCH] 112 Added mac address to host page

2012-03-19 Thread Endi Sukma Dewata
On 3/19/2012 9:05 AM, Petr Vobornik wrote: Part of support for ether maps. https://fedorahosted.org/freeipa/ticket/2548 ACK. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-d

Re: [Freeipa-devel] [PATCH] 109 Fixed rpm build warning - extension.js listed twice

2012-03-19 Thread Endi Sukma Dewata
On 3/15/2012 8:52 AM, Petr Vobornik wrote: Attached updated patch with totally different approach (thanks Endi). This patch moves extension.js to new directory: 'ext'. Ext directory should serve as a place for user extensions. It eliminated the problem. ACK. -- Endi S. Dewata __

[Freeipa-devel] [PATCH] 349 Fixed boot.ldif permission.

2012-03-16 Thread Endi Sukma Dewata
Sukma Dewata Date: Fri, 16 Mar 2012 17:15:26 -0500 Subject: [PATCH] Fixed boot.ldif permission. The server installation failed on F17 due to permission problem. The /var/lib/dirsrv/boot.ldif was previously owned and only readable by root. It is now owned by DS user dirsrv. Ticket #2544 --- ipaserver

Re: [Freeipa-devel] [PATCH] 924 display both hex and decimal serial numbers

2012-03-14 Thread Endi Sukma Dewata
On 3/7/2012 9:57 AM, Petr Vobornik wrote: On 03/06/2012 09:56 PM, Rob Crittenden wrote: UI portion added as well. ACK for the UI part. I attached a patch which extends UI static testing data - to keep things in solid state. ACK for Petr's patch #101. -- Endi S. Dewata _

Re: [Freeipa-devel] [PATCH] 108 Better hbactest validation message

2012-03-14 Thread Endi Sukma Dewata
On 3/12/2012 8:22 AM, Petr Vobornik wrote: HBAC Test validation message now contains all missing values in form of list of links instead of general 'missing values' message and redirection to first missing value's facet. When a link is clicked user is redirected to value's facet. https://fedora

Re: [Freeipa-devel] [PATCH] 107 Fixed evaluating checkbox dirty status

2012-03-14 Thread Endi Sukma Dewata
ACK. I have some comments below. On 3/9/2012 11:20 AM, Petr Vobornik wrote: Problem: When value in checkbox is modified twice in a row (so it is at its original value) an 'undo' button is still visible even when it shouldn't be. Cause: IPA server sends boolean values as 'TRUE' or 'FALSE' (strin

Re: [Freeipa-devel] [PATCH] 107 Content is no more overwritten by error message

2012-03-13 Thread Endi Sukma Dewata
On 3/9/2012 7:16 AM, Petr Vobornik wrote: When an error which caused calling of report_error occur, the content of a facet got replaced by error message. There was no way how to force the facet to recreate its content and the facet became unusable. This patch creates a container for an error mes

<    1   2   3   4   5   6   7   8   9   10   >