Re: [Freeipa-devel] [PATCH] 023 Circular entity dependency

2011-10-17 Thread Endi Sukma Dewata
On 10/10/2011 10:13 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1531 (3.0 Core Effort Iteration 01 September Y11 Release) Implemented solution: * all entities are created on application start * dependant objects (facets and dialogs) are created at once on their first use in

Re: [Freeipa-devel] [PATCH] 026 Fixed: Unable to add external user for RunAs User for Sudo

2011-10-17 Thread Endi Sukma Dewata
On 10/17/2011 10:12 AM, Alexander Bokovoy wrote: On Mon, 17 Oct 2011, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1987 -- Petr Vobornik From 931b27dbb54ace65e2213ffed718ee04ace5fc07 Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Mon, 17 Oct 2011 11:48:03 +0200 Subject: [

Re: [Freeipa-devel] [PATCH] 020 Fixed links to images in config and migration pages

2011-10-06 Thread Endi Sukma Dewata
On 10/6/2011 8:42 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1932 Description of problem: Title is missing while configuring browser for the first time. Actual results: There is no title on this screen. I noticed it only on step 8 and later so I am not sure if title is als

[Freeipa-devel] [PATCH] 293 Added selectable labels for radio buttons.

2011-09-30 Thread Endi Sukma Dewata
The radio buttons in association facet and radio widget are now linked to their labels so that they can be selected by clicking the labels. Ticket #1782 -- Endi S. Dewata From c371c34f1208b802b0e1d9c74c00b8fb23533476 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 30 Sep 2011 21:25:47

Re: [Freeipa-devel] [PATCH] 285 Added confirmation when adding multiple entries.

2011-09-30 Thread Endi Sukma Dewata
On 9/27/2011 6:05 PM, Endi Sukma Dewata wrote: On 9/27/2011 4:01 PM, Endi Sukma Dewata wrote: The adder dialog has been modified to show a confirmation message after each successful addition. Ticket #1786 Rebased on top of 286 (because 286 needs to go to ipa-2-1 branch). Rebased on top of

[Freeipa-devel] [PATCH] 292 Disable sudo options Delete button if nothing selected.

2011-09-30 Thread Endi Sukma Dewata
The Delete button for sudo options in sudo rule details page now will only work if there is at least one row selected. Ticket #1896 -- Endi S. Dewata From e016787c3b19616fdbf6c0e3f283fe74195e5694 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 30 Sep 2011 16:52:41 -0500 Subject: [PATCH

[Freeipa-devel] [PATCH] 291 I18n clean-up.

2011-09-30 Thread Endi Sukma Dewata
The hard-coded 'undo' and 'undo all' labels have been moved into internal.py to allow translation. Ticket #1897 -- Endi S. Dewata From 78b2f9f53aa524a3e95977d66f4d999a3787fa2b Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 30 Sep 2011 11:49:00 -0500 Subject: [PATCH] I18n clean-up. Th

[Freeipa-devel] [PATCH] 290 Fixed missing default shell field.

2011-09-30 Thread Endi Sukma Dewata
The config default page has been fixed to provide a field for the ipadefaultloginshell attribute. Ticket #1895 Pushed to master and ipa-2-1 under one-liner/trivial rule. -- Endi S. Dewata From f504ff049f2b64cd4c8a6b65e85a890559c8451b Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 30

Re: [Freeipa-devel] [PATCH] 288 Disable enroll button if nothing selected.

2011-09-28 Thread Endi Sukma Dewata
On 9/28/2011 7:59 PM, Adam Young wrote: On 09/28/2011 06:50 PM, Endi Sukma Dewata wrote: A new IPA.dialog_button class has been added to encapsulate the buttons in the dialog box so they can be managed more easily. The adder dialog has been modified to disable the enroll button if there is no

[Freeipa-devel] [PATCH] 288 Disable enroll button if nothing selected.

2011-09-28 Thread Endi Sukma Dewata
A new IPA.dialog_button class has been added to encapsulate the buttons in the dialog box so they can be managed more easily. The adder dialog has been modified to disable the enroll button if there is no entries selected. Ticket #1856 -- Endi S. Dewata From 0b94a6059fdb02161169413df34439f670c1

Re: [Freeipa-devel] [PATCH] 287 Updated color scheme.

2011-09-28 Thread Endi Sukma Dewata
On 9/27/2011 10:12 PM, Endi Sukma Dewata wrote: The UI background has been replaced with new images from UXD. Ticket #1842 Demo: http://edewata.fedorapeople.org/freeipa/install/ui/index.html Pushed to master and ipa-2-1. -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] 285 Added confirmation when adding multiple entries.

2011-09-27 Thread Endi Sukma Dewata
On 9/27/2011 4:01 PM, Endi Sukma Dewata wrote: The adder dialog has been modified to show a confirmation message after each successful addition. Ticket #1786 Rebased on top of 286 (because 286 needs to go to ipa-2-1 branch). -- Endi S. Dewata From 62ace18cde62f8515990f22e1b6e68a71f2a7af5 Mon

[Freeipa-devel] [PATCH] 286 Fixed tab and dialog widths.

2011-09-27 Thread Endi Sukma Dewata
The width of the 1st level tab has been modified to expand according to the size of the tab label. The width of the adder dialogs have been increased to allow longer button labels. Ticket #1825 -- Endi S. Dewata From 382fd4a07a2c61b82e0238400801453c493f34af Mon Sep 17 00:00:00 2001 From: Endi S

Re: [Freeipa-devel] [PATCH] 275 Use editable combobox for service type.

2011-09-27 Thread Endi Sukma Dewata
On 9/16/2011 12:16 PM, Endi Sukma Dewata wrote: The service type field in the service adder dialog has been modified to use an editable combobox. Ticket #1633. Rebased (removed undo parameter). -- Endi S. Dewata From 8a135be9e592132524f3b15ef876ffc224c7d4a6 Mon Sep 17 00:00:00 2001 From

Re: [Freeipa-devel] [PATCH] 018 Fixed: Enrolment dialog offers to add entity to reflexive association.

2011-09-27 Thread Endi Sukma Dewata
On 9/27/2011 3:32 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1883 based on patch edewata-284 Not sure if this patch is the right approach. This logic shouldn't probably be in association dialog as it isn't application independent. Cleaner but more complex would be to make

Re: [Freeipa-devel] [PATCH] 284 Fixed duplicate entries in enrollment dialog.

2011-09-27 Thread Endi Sukma Dewata
On 9/27/2011 3:04 AM, Petr Vobornik wrote: On 09/26/2011 08:57 PM, Endi Sukma Dewata wrote: The IPA.association_adder_dialog has been modified not to show search results that are already selected to prevent duplicates. Ticket #1859 ACK Pushed to master and ipa-2-1. -- Endi S. Dewata

[Freeipa-devel] [PATCH] 285 Added confirmation when adding multiple entries.

2011-09-27 Thread Endi Sukma Dewata
The adder dialog has been modified to show a confirmation message after each successful addition. Ticket #1786 -- Endi S. Dewata From 1d56e6010e36abc14adfb8b20a1b87d5deaf11c8 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 27 Sep 2011 09:28:14 -0500 Subject: [PATCH] Added confirmation

Re: [Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message

2011-09-27 Thread Endi Sukma Dewata
On 9/27/2011 7:50 AM, Petr Vobornik wrote: I've added padding and unified font-weight in error-message style. The padding is added because text of the message was right on the border which wasn't much readable. Font-weight is added because sometimes it inherits font-weight from other style and so

[Freeipa-devel] [PATCH] 284 Fixed duplicate entries in enrollment dialog.

2011-09-26 Thread Endi Sukma Dewata
The IPA.association_adder_dialog has been modified not to show search results that are already selected to prevent duplicates. Ticket #1859 -- Endi S. Dewata From 5eb76a60683d86d0e9baa682cb5be855b1b162fd Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Mon, 26 Sep 2011 13:44:22 -0500 Subject

Re: [Freeipa-devel] [PATCH] 278 Replaced description text fields with text areas.

2011-09-26 Thread Endi Sukma Dewata
On 9/26/2011 10:01 AM, Petr Vobornik wrote: On 09/17/2011 01:42 AM, Endi Sukma Dewata wrote: Ticket #1783 It needs rebase and removing 'undo: false' because it's based on your patch 270 and has conflicts with 271-4a and 271-4b. Rebased. I also removed the 'undo: fa

[Freeipa-devel] [PATCH] 283 Fixed add/delete arrows position.

2011-09-26 Thread Endi Sukma Dewata
The IPA.adder_dialog has been modified such that it shows the >> arrow first then the << arrow. Ticket #1858 Pushed to master and ipa-2-1 under one-liner/trivial rule. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://

Re: [Freeipa-devel] [PATCH] 277 Updated DNS zone details page.

2011-09-26 Thread Endi Sukma Dewata
On 9/26/2011 8:36 AM, Petr Vobornik wrote: On 09/17/2011 12:19 AM, Endi Sukma Dewata wrote: The DNS zone details page has been modified to use radio buttons for active zone and dynamic update fields, and text area for BIND update policy field. Ticket #1781, #1785 In ticket #1781 is a note

Re: [Freeipa-devel] [PATCH] 017 Fixed: Column header for attributes table should be full, width

2011-09-26 Thread Endi Sukma Dewata
On 9/26/2011 4:25 AM, Petr Vobornik wrote: I've reworked the patch. It's simplified and it uses already build-in functionality. This is much better. ACK and pushed to master and ipa-2-1. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel

Re: [Freeipa-devel] [PATCH] 017 Fixed: Column header for attributes table should be full, width

2011-09-25 Thread Endi Sukma Dewata
On 9/23/2011 11:05 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1841 The column header for the attributes table (IPA.attributes_widget) does not cover the entire width of the table. This problem appears in the adder dialog and details page for permissions, self-service permis

Re: [Freeipa-devel] [PATCH] 280 Fixed problem displaying special characters.

2011-09-23 Thread Endi Sukma Dewata
On 9/23/2011 6:51 AM, Petr Vobornik wrote: On 09/20/2011 08:35 PM, Endi Sukma Dewata wrote: Some jQuery objects in various locations have been modified to use text() to show values obtained from the server (except messages). The text() will automatically encode special characters. Ticket #1798

Re: [Freeipa-devel] [PATCH] 281 Fixed problem on combobox with search limit.

2011-09-23 Thread Endi Sukma Dewata
On 9/23/2011 7:46 AM, Petr Vobornik wrote: On 09/20/2011 11:18 PM, Endi Sukma Dewata wrote: The IPA.combobox_widget has been modified such that if the drop-down list doesn't contain the stored value (due to search limit) it will not select anything from the list. The widget has also

Re: [Freeipa-devel] [PATCH] 271 Modified dialog to use sections.

2011-09-23 Thread Endi Sukma Dewata
On 9/23/2011 4:31 AM, Petr Vobornik wrote: On 09/22/2011 09:15 PM, Endi Sukma Dewata wrote: I've split the patch into two: 4a is the revised original patch, ACK 4b is the additional cleanup for the undo. you missed: dns.js:562 and host.js:406 . Beside this it's OK. Fixed. W

Re: [Freeipa-devel] Structured DNS record API proposal - summary

2011-09-22 Thread Endi Sukma Dewata
On 9/22/2011 7:24 AM, Martin Kosek wrote: 2) Some DNS records may be pretty large. MX record data is small, but for example CERT records have an entire certificate stored in it. Wouldn't there be a problem if we place the large DNS record in URL? This is how the DNS record list page could be re

Re: [Freeipa-devel] [PATCH] 276 Fixed problem enabling/disabling DNS zone.

2011-09-22 Thread Endi Sukma Dewata
On 9/22/2011 6:59 AM, Petr Vobornik wrote: On 09/17/2011 12:18 AM, Endi Sukma Dewata wrote: The details facet for DNS zone has been modified to use dnszone- enable/disable for idnszoneactive and dnszone-mod for other fields. Ticket #1813 ACK Pushed to master and ipa-2-1. Btw it doesn&#

Re: [Freeipa-devel] [PATCH] 279 Fixed problem enrolling member with the same name.

2011-09-22 Thread Endi Sukma Dewata
On 9/22/2011 11:14 AM, Petr Vobornik wrote: On 09/20/2011 02:19 AM, Endi Sukma Dewata wrote: The IPA.association_adder_dialog has been modified to use an exclusion list to hide entries that are already enrolled. The IPA.adder_dialog has been modified to store the columns directly in the

[Freeipa-devel] [PATCH] 282 Fixed missing cancel button in unprovisioning dialog.

2011-09-21 Thread Endi Sukma Dewata
The host unprovisioning dialog has been modified to provide a cancel button. Ticket #1811 Pushed to master and ipa-2-1 under one-liner/trivial rule. -- Endi S. Dewata From 24ad1d692c294ed0410504ef0b535f86e10cc9d8 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Wed, 21 Sep 2011 16:53:30 -05

Re: [Freeipa-devel] [PATCH] 273 Removed HBAC rule type.

2011-09-21 Thread Endi Sukma Dewata
On 9/20/2011 8:02 AM, Petr Vobornik wrote: On 09/16/2011 06:24 PM, Endi Sukma Dewata wrote: HBAC rule type has been removed from the list page and details page because it is no longer supported in IPA 3.0. Ticket #1795 This should be pushed to master branch only. ACK Pushed to master

Re: [Freeipa-devel] [PATCH] 272 Fixed columns in HBAC/sudo rules list pages.

2011-09-21 Thread Endi Sukma Dewata
On 9/20/2011 7:15 AM, Petr Vobornik wrote: On 09/16/2011 06:24 PM, Endi Sukma Dewata wrote: The following list pages were modified to show these columns only: * HBAC rules: name, type, enabled, description * Sudo rules: name, enabled, description Ticket #1796 ACK Pushed to master and ipa

[Freeipa-devel] [PATCH] 281 Fixed problem on combobox with search limit.

2011-09-20 Thread Endi Sukma Dewata
The IPA.combobox_widget has been modified such that if the drop-down list doesn't contain the stored value (due to search limit) it will not select anything from the list. The widget has also been modified not to select the value that matches the filter automatically because that might not be the

Re: [Freeipa-devel] [PATCH] 270 Fixed posix group checkbox.

2011-09-20 Thread Endi Sukma Dewata
On 9/20/2011 6:57 AM, Petr Vobornik wrote: Attached is the updated patch. I fixed the test case and did some cleanup. This is actually the problem I mentioned in the meeting (so patch 271 is actually fine). It looks like currently the checkbox widget is only used with boolean attributes. And it

[Freeipa-devel] [PATCH] 280 Fixed problem displaying special characters.

2011-09-20 Thread Endi Sukma Dewata
Some jQuery objects in various locations have been modified to use text() to show values obtained from the server (except messages). The text() will automatically encode special characters. Ticket #1798 -- Endi S. Dewata From 2af9922e6e271f1f48a47d20296facee5d6cb049 Mon Sep 17 00:00:00 2001 From

Re: [Freeipa-devel] Structured DNS record API proposal

2011-09-20 Thread Endi Sukma Dewata
On 9/20/2011 6:15 AM, Martin Kosek wrote: ACK. Proposal looks like it will work fairly easily with the UI. We'll have to make some chagnes due to the Add doing something different based on the type, but that is the case anyway. Yes, I was thinking how can we integrate this new API to WebUI. AF

[Freeipa-devel] [PATCH] 279 Fixed problem enrolling member with the same name.

2011-09-19 Thread Endi Sukma Dewata
The IPA.association_adder_dialog has been modified to use an exclusion list to hide entries that are already enrolled. The IPA.adder_dialog has been modified to store the columns directly in the available & selected tables. Ticket #1797 -- Endi S. Dewata From f8339f3fb32840fc6f2aa5b4b98f587cabd

[Freeipa-devel] [PATCH] 278 Replaced description text fields with text areas.

2011-09-16 Thread Endi Sukma Dewata
Ticket #1783 -- Endi S. Dewata From 252d019c46f243bafb801a137d2ba9aa81704d1e Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 16 Sep 2011 18:21:41 -0500 Subject: [PATCH] Replaced description text fields with text areas. Ticket #1783 --- install/ui/aci.js | 70 ++

[Freeipa-devel] [PATCH] 276 Fixed problem enabling/disabling DNS zone.

2011-09-16 Thread Endi Sukma Dewata
The details facet for DNS zone has been modified to use dnszone- enable/disable for idnszoneactive and dnszone-mod for other fields. Ticket #1813 -- Endi S. Dewata From edffb9b9c7cd2c0ae4f7ca07fa5e46bca5d33386 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 16 Sep 2011 16:06:07 -0500 S

[Freeipa-devel] [PATCH] 277 Updated DNS zone details page.

2011-09-16 Thread Endi Sukma Dewata
The DNS zone details page has been modified to use radio buttons for active zone and dynamic update fields, and text area for BIND update policy field. Ticket #1781, #1785 -- Endi S. Dewata From ca019ce4c78195e8d504f474155743f325283d82 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 16

[Freeipa-devel] [PATCH] 275 Use editable combobox for service type.

2011-09-16 Thread Endi Sukma Dewata
The service type field in the service adder dialog has been modified to use an editable combobox. Ticket #1633. -- Endi S. Dewata From 0e3929b1b0db342771429eba64e789e65a79 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 16 Sep 2011 12:02:12 -0500 Subject: [PATCH] Use editable combo

[Freeipa-devel] [PATCH] 274 Removed entitlement menu.

2011-09-16 Thread Endi Sukma Dewata
Ticket #1806 Pushed to master and ipa-2-1 under one-liner/trivial rule. -- Endi S. Dewata From 29c167299ff61f89a3fdfad3905ca73931581560 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 16 Sep 2011 11:27:48 -0500 Subject: [PATCH] Removed entitlement menu. Ticket #1806 --- install/ui/we

[Freeipa-devel] [PATCH] 273 Removed HBAC rule type.

2011-09-16 Thread Endi Sukma Dewata
HBAC rule type has been removed from the list page and details page because it is no longer supported in IPA 3.0. Ticket #1795 This should be pushed to master branch only. -- Endi S. Dewata From f7ae8252b4482cfd8b320617ec3cedc22c2c8b00 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 1

[Freeipa-devel] [PATCH] 272 Fixed columns in HBAC/sudo rules list pages.

2011-09-16 Thread Endi Sukma Dewata
The following list pages were modified to show these columns only: * HBAC rules: name, type, enabled, description * Sudo rules: name, enabled, description Ticket #1796 -- Endi S. Dewata From de81aeff5c86471d7173dda98bc12e5f0d4efd05 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 16 S

Re: [Freeipa-devel] [PATCH] 270 Fixed posix group checkbox.

2011-09-16 Thread Endi Sukma Dewata
On 9/15/2011 11:36 AM, Petr Vobornik wrote: On 09/15/2011 02:06 AM, Endi Sukma Dewata wrote: In the adder dialog for groups the checkbox has been modified to use the correct field name "nonposix" and be checked by default. Note: This is a temporary fix to minimize the changes due

[Freeipa-devel] [PATCH] 270 Fixed posix group checkbox.

2011-09-14 Thread Endi Sukma Dewata
In the adder dialog for groups the checkbox has been modified to use the correct field name "nonposix" and be checked by default. Note: This is a temporary fix to minimize the changes due to release schedule. Eventually the field label will be changed into "Non-POSIX group" and the checkbox will

[Freeipa-devel] [PATCH] 269 Fixed problem opening host adder dialog.

2011-09-14 Thread Endi Sukma Dewata
The hidden fqdn field in the host adder dialog has been changed to use a generic widget instead of text widget to avoid null pointer error since the UI elements are never created. Ticket #1788 Pushed to master and ipa-2-1 under one-liner/trivial rule. -- Endi S. Dewata From 5e7a5bdfa92cd63f96aa

Re: [Freeipa-devel] [PATCH] 016 Fixed: Some widgets do not have space for validation error message

2011-09-14 Thread Endi Sukma Dewata
On 9/14/2011 7:23 AM, Petr Vobornik wrote: Forgot to update tests - to address newly added validation row in table_widget. One issue, in all search and association facets we now have 2 rows of footer (there are 2 horizontal lines at the bottom). I think it would be better to use a single row

Re: [Freeipa-devel] [PATCH] 268 Fixed labels for run-as users and groups.

2011-09-13 Thread Endi Sukma Dewata
On 9/13/2011 7:54 AM, Petr Vobornik wrote: The labels from entity parameter are actually more appropriate. I've updated the patch to use them instead. I also fixed some of the labels (the run-as group label & doc is incorrect). ACK Pushed to master and ipa-2-1. -- Endi S. Dewata ___

Re: [Freeipa-devel] [PATCH] 015 Fixed: Missing read permission option in RBAC permission

2011-09-13 Thread Endi Sukma Dewata
On 9/13/2011 8:08 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1787 In 'IPA Server/RBAC/Permission/Settings/Rights' is missing a option for setting 'read' permission which is supported in CLI. As discussed in the meeting, the UI will not provide a 'read' checkbox (sorry!).

Re: [Freeipa-devel] [PATCH] 268 Fixed labels for run-as users and groups.

2011-09-13 Thread Endi Sukma Dewata
On 9/13/2011 7:54 AM, Petr Vobornik wrote: The labels from entity parameter are actually more appropriate. I've updated the patch to use them instead. I also fixed some of the labels (the run-as group label & doc is incorrect). ACK Pushed to master and ipa-2-1. -- Endi S. Dewata ___

Re: [Freeipa-devel] [PATCH] 014 Code cleanup: widget creation

2011-09-13 Thread Endi Sukma Dewata
On 9/13/2011 7:57 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1788 Removed code duplication of undo links. Simplified code of widget creation to be more readable. ACK and pushed to master and ipa-2-1. One little thing though, the create_undo() will always append a space

Re: [Freeipa-devel] [PATCH] 267 Fixed missing optional field.

2011-09-12 Thread Endi Sukma Dewata
On 9/12/2011 7:24 AM, Petr Vobornik wrote: On 09/10/2011 02:20 AM, Endi Sukma Dewata wrote: The optional uid field in user's adder dialog did not appear when the link is clicked to show the field. This is a regression introduced in the patch for ticket #1648. The click handler for the

Re: [Freeipa-devel] [PATCH] 012 Fixed inconsistency in enabling delete buttons

2011-09-12 Thread Endi Sukma Dewata
On 9/9/2011 6:24 AM, Petr Vobornik wrote: On 09/07/2011 09:06 PM, Endi Sukma Dewata wrote: On 9/7/2011 7:16 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1640 .. One issue, in HBAC/sudo rules details page if the category is changed from 'all' to 'specif

[Freeipa-devel] [PATCH] 268 Fixed labels for run-as users and groups.

2011-09-09 Thread Endi Sukma Dewata
The labels for the run-as users and groups tables in sudo rule details page have been modified to improve the clarity. Ticket #1752 -- Endi S. Dewata From c05edd38c54994a295c3d7d15477bd87a599ee0d Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 9 Sep 2011 18:58:52 -0500 Subject: [PATCH]

[Freeipa-devel] [PATCH] 267 Fixed missing optional field.

2011-09-09 Thread Endi Sukma Dewata
The optional uid field in user's adder dialog did not appear when the link is clicked to show the field. This is a regression introduced in the patch for ticket #1648. The click handler for the link field has been moved into a new closure so that the variables point to the correct elements. Note

Re: [Freeipa-devel] [PATCH] 866 don't allow a otp to be set on enrolled hosts

2011-09-09 Thread Endi Sukma Dewata
On 9/8/2011 12:51 PM, Rob Crittenden wrote: Don't allow a one-time password to be set on enrolled hosts. This will invalidate the existing keytab. ACK and pushed to master and ipa-2-1. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@r

Re: [Freeipa-devel] [PATCH] 266 Fixed sudo rule association dialogs.

2011-09-08 Thread Endi Sukma Dewata
On 9/8/2011 10:28 AM, Endi Sukma Dewata wrote: The adder dialog for the user and host tables in sudo rule details page have been fixed to use --not-in-sudorules to avoid showing entries that are already added into the rule either directly or indirectly via groups. This does not apply to the

[Freeipa-devel] [PATCH] 265 Fixed sudo rule association dialogs.

2011-09-08 Thread Endi Sukma Dewata
The adder dialog for the user and host tables in sudo rule details page have been fixed to use --not-in-sudorules to avoid showing entries that are already added into the rule either directly or indirectly via groups. This does not apply to the command and run-as tables because they do not suppor

[Freeipa-devel] [PATCH] 265 Fixed layout problem in permission adder dialog.

2011-09-07 Thread Endi Sukma Dewata
In order to maintain consistent layout between details page and dialog boxes the IPA.details_list_section has been replaced with IPA.details_table_section which is based on table. The IPA.target_section and other subclasses of IPA.details_list_section have been converted to use IPA.details_table_

[Freeipa-devel] [PATCH] 264 Fixed unit test for entity select widget.

2011-09-07 Thread Endi Sukma Dewata
The unit test for IPA.entity_select_widget has been fixed to check the options after loading the record. Pushed under one-liner/trivial rule. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/list

Re: [Freeipa-devel] [PATCH] 013 Fixed: JavaScript type error in entitlement page

2011-09-07 Thread Endi Sukma Dewata
On 9/7/2011 11:24 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1767 Opening IPA Server/Entitlements causes: "Uncaught TypeError: Cannot call method 'addClass' of undefined" error - Details.js:489 ACK. Pushed to master and ipa-2-1. -- Endi S. Dewata __

Re: [Freeipa-devel] [PATCH] 012 Fixed inconsistency in enabling delete buttons

2011-09-07 Thread Endi Sukma Dewata
On 9/7/2011 7:16 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1640 On the HBAC Rules page, where the rules are listed, if no rule is selected, the "Delete" button is not enabled, and cannot be clicked on. But edit a Rule, and Delete button is enabled in the available sections

Re: [Freeipa-devel] [PATCH] 263 Fixed problem with combobox using Sahi

2011-09-06 Thread Endi Sukma Dewata
On 9/5/2011 9:51 PM, Adam Young wrote: On 09/01/2011 05:24 PM, Endi Sukma Dewata wrote: The IPA.combobox_widget has been temporarily fixed to support automation using Sahi. Ticket #1754 This looks like a reasonable change. I think that most combo-box controls would close once you made a

[Freeipa-devel] [PATCH] 263 Fixed problem with combobox using Sahi

2011-09-01 Thread Endi Sukma Dewata
The IPA.combobox_widget has been temporarily fixed to support automation using Sahi. Ticket #1754 Pushed to master and ipa-2-1 under one-liner/trivial rule. -- Endi S. Dewata From 510f702d842c0489e6e0cddf15f86ca574370bf4 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Thu, 1 Sep 2011 16:17

Re: [Freeipa-devel] [PATCH] 262 Fixed missing permission filter field.

2011-09-01 Thread Endi Sukma Dewata
On 9/1/2011 9:07 AM, Rob Crittenden wrote: Endi Sukma Dewata wrote: Due to a recent change, all dialog boxes are now reset initially. The IPA.target_section has been modified to show the default target (i.e. filter) and the fields properly when reset. Ticket #1748 ACK Pushed to master and

Re: [Freeipa-devel] [PATCH] 261 Fixed hard-coded UI message in entity.js.

2011-09-01 Thread Endi Sukma Dewata
On 9/1/2011 9:07 AM, Rob Crittenden wrote: Endi Sukma Dewata wrote: The hard-coded label in IPA.facet has been moved into internal.py to allow translation. Ticket #1701 ACK Pushed to master and ipa-2-1. -- Endi S. Dewata ___ Freeipa-devel

[Freeipa-devel] [PATCH] 262 Fixed missing permission filter field.

2011-08-31 Thread Endi Sukma Dewata
Due to a recent change, all dialog boxes are now reset initially. The IPA.target_section has been modified to show the default target (i.e. filter) and the fields properly when reset. Ticket #1748 -- Endi S. Dewata freeipa-edewata-0262-Fixed-missing-permission-filter-field.patch Description: a

[Freeipa-devel] [PATCH] 261 Fixed hard-coded UI message in entity.js.

2011-08-31 Thread Endi Sukma Dewata
The hard-coded label in IPA.facet has been moved into internal.py to allow translation. Ticket #1701 -- Endi S. Dewata freeipa-edewata-0261-Fixed-hard-coded-UI-message-in-entity.js.patch Description: application/mbox ___ Freeipa-devel mailing list Fr

Re: [Freeipa-devel] [PATCH] 011 Attributes table not scrollable

2011-08-31 Thread Endi Sukma Dewata
On 8/31/2011 8:04 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1739 The attributes table (IPA.attributes_widget) used in Permissions, Self-Service Permissions, and Delegations is supposed to be short but scrollable. In Firefox 3.6 it works fine, but in Firefox 6.0 it appears

Re: [Freeipa-devel] [PATCH] 260 Fixed problem with combobox.

2011-08-31 Thread Endi Sukma Dewata
On 8/31/2011 6:36 AM, Petr Vobornik wrote: On 08/31/2011 07:30 AM, Endi Sukma Dewata wrote: The entity select widget has been modified to handle timing issue in both dialog box and details page. Ticket #1736 ACK Pushed to master and ipa-2-1. -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] 259 Fixed problem adding hostgroup into netgroup.

2011-08-31 Thread Endi Sukma Dewata
On 8/31/2011 3:46 AM, Petr Vobornik wrote: On 08/30/2011 09:06 PM, Endi Sukma Dewata wrote: The memberof_netgroup association facet for hostgroup has been explicitly defined to use the serial associator so it will invoke the right methods. Ticket #1737 ACK Pushed to master and ipa-2-1. I

Re: [Freeipa-devel] [PATCH] 258 Fixed hard-coded UI messages.

2011-08-31 Thread Endi Sukma Dewata
On 8/31/2011 2:42 AM, Petr Vobornik wrote: On 08/30/2011 04:43 PM, Endi Sukma Dewata wrote: Some hard-coded messages in ipa.js have been moved into internal.py. The messages in internal.py have been rearranged to match the output (ipa_init.json). A new method IPA.get_message() has been added

[Freeipa-devel] [PATCH] 260 Fixed problem with combobox.

2011-08-30 Thread Endi Sukma Dewata
The entity select widget has been modified to handle timing issue in both dialog box and details page. Ticket #1736 -- Endi S. Dewata freeipa-edewata-0260-Fixed-problem-with-combobox.patch Description: application/mbox ___ Freeipa-devel mailing list

Re: [Freeipa-devel] [PATCH] 010 Enable update and reset buttons only if dirty

2011-08-30 Thread Endi Sukma Dewata
On 8/30/2011 7:36 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1697 Original problem: Update name of the automount location (Policy -> Automount -> custom_location -> Settings -> Update) in the WEBUI refer to an unknown command. Solution: Tracking dirty state in field -> sec

[Freeipa-devel] [PATCH] 259 Fixed problem adding hostgroup into netgroup.

2011-08-30 Thread Endi Sukma Dewata
The memberof_netgroup association facet for hostgroup has been explicitly defined to use the serial associator so it will invoke the right methods. Ticket #1737 -- Endi S. Dewata freeipa-edewata-0259-Fixed-problem-adding-hostgroup-into-netgroup.patch Description: application/mbox _

Re: [Freeipa-devel] [PATCH] 257 Fixed host adder dialog to show default DNS zone.

2011-08-30 Thread Endi Sukma Dewata
On 8/30/2011 3:21 AM, Petr Vobornik wrote: On 08/29/2011 04:09 PM, Endi Sukma Dewata wrote: The DNS zone widget for host adder dialog has been modified not to provide an empty option, so it will show the first available zone. Ticket #1685 ACK Pushed to master and ipa-2-1. -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] 009 Modifying sudo options refreshes the whole page

2011-08-29 Thread Endi Sukma Dewata
On 8/29/2011 7:58 AM, Petr Vobornik wrote: I would say that the network issue and the same concurrent edit issue can be so rare, that the update isn't much necessary and it slows down more frequent failures like non-concurrent adding of the same option. If we want UI to be faster, we should remo

[Freeipa-devel] [PATCH] 257 Fixed host adder dialog to show default DNS zone.

2011-08-29 Thread Endi Sukma Dewata
The DNS zone widget for host adder dialog has been modified not to provide an empty option, so it will show the first available zone. Ticket #1685 -- Endi S. Dewata From b2f14d73824bc12e6d7bb47e3907312efd1aaa97 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 26 Aug 2011 14:27:48 -0500

Re: [Freeipa-devel] [PATCH] 009 Modifying sudo options refreshes the whole page

2011-08-26 Thread Endi Sukma Dewata
On 8/26/2011 11:41 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1689 Currently adding or deleting sudo options will refresh the entire page. It's not a problem but the code could be optimized to refresh only the sudo options table We have several scenarios for sudo options:

Re: [Freeipa-devel] [PATCH] 255 Fixed host OTP status.

2011-08-26 Thread Endi Sukma Dewata
On 8/26/2011 9:26 AM, Petr Vobornik wrote: On 08/25/2011 03:29 AM, Endi Sukma Dewata wrote: The host details page has been modified to show the status of the OTP. Setting a new OTP is now done using a dialog box. Ticket #1710 Attached is a rebased version. Note: As mentioned in rcrit&#

Re: [Freeipa-devel] [PATCH] 256 Fixed host keytab status after setting OTP.

2011-08-26 Thread Endi Sukma Dewata
On 8/26/2011 9:26 AM, Petr Vobornik wrote: On 08/26/2011 12:14 AM, Endi Sukma Dewata wrote: The host details page has been modified to update the keytab status based on the data returned by the host-mod command for setting OTP. Ticket #1710 ACK Pushed to master and ipa-2-1. -- Endi S

[Freeipa-devel] [PATCH] 256 Fixed host keytab status after setting OTP.

2011-08-25 Thread Endi Sukma Dewata
The host details page has been modified to update the keytab status based on the data returned by the host-mod command for setting OTP. Ticket #1710 -- Endi S. Dewata From aa7f42b45f84f65a4735ccc3d8e8e4a2cf6479a2 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Thu, 25 Aug 2011 14:03:48 -050

Re: [Freeipa-devel] [PATCH] 857 get password/keytab status in host-mod

2011-08-25 Thread Endi Sukma Dewata
On 8/25/2011 10:51 AM, Rob Crittenden wrote: Rob Crittenden wrote: I missed retrieving password/keytab status when doing a host-mod. Revised patch ACK. Pushed to master and ipa-2-1. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@re

Re: [Freeipa-devel] [PATCH] 008 Modify serial associator to use batch

2011-08-25 Thread Endi Sukma Dewata
On 8/25/2011 8:23 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1688 The serial associator is used to execute a command multiple times with different parameters. This is used for adding/removing a user into/from multiple groups. It has some issues: Each command is executed on

Re: [Freeipa-devel] [PATCH] 254 Fixed default map type in automount map adder dialog.

2011-08-25 Thread Endi Sukma Dewata
On 8/25/2011 5:23 AM, Petr Vobornik wrote: On 08/24/2011 04:10 AM, Endi Sukma Dewata wrote: The adder dialog for automount map has been modified to select the direct map by default. Ticket #1698 ACK Pushed to master and ipa-2-1. -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] 252 Removed unnecessary HBAC/sudo rule category modification.

2011-08-25 Thread Endi Sukma Dewata
On 8/23/2011 12:12 PM, Petr Vobornik wrote: On 08/22/2011 11:37 PM, Endi Sukma Dewata wrote: Since the Add/Delete links in the association table are disabled when the category is set to 'all', it's no longer necessary to check the category before showing the add/delete dialogs

Re: [Freeipa-devel] [PATCH] 007 Validation of details facet before update

2011-08-24 Thread Endi Sukma Dewata
On 8/24/2011 8:59 AM, Petr Vobornik wrote: Validation of details facet before update https://fedorahosted.org/freeipa/ticket/1676 The ticket is a duplicate of server error, but it revealed few UI errors. Newly performs validation of details facet before update. If validation fails, notification

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-24 Thread Endi Sukma Dewata
On 8/24/2011 3:40 AM, Petr Vobornik wrote: It's good enough for #1628 so we can push both patches. Pushed to master and ipa-2-1. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeip

[Freeipa-devel] [PATCH] 254 Fixed default map type in automount map adder dialog.

2011-08-23 Thread Endi Sukma Dewata
The adder dialog for automount map has been modified to select the direct map by default. Ticket #1698 -- Endi S. Dewata From 8ec68b3e841e7cb3beb3bed4a82726acc9d0d530 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 23 Aug 2011 20:45:06 -0500 Subject: [PATCH] Fixed default map type in a

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-23 Thread Endi Sukma Dewata
On 8/23/2011 6:34 AM, Petr Vobornik wrote: On 08/22/2011 07:05 PM, Endi Sukma Dewata wrote: One more issue, a command could return multiple error messages in each failure, but right now the get_failed() only reads the first message in each failure. Try adding several users into a group, but

Re: [Freeipa-devel] [PATCH] 251 Updated add and delete association dialog titles.

2011-08-23 Thread Endi Sukma Dewata
On 8/23/2011 8:56 AM, Petr Vobornik wrote: On 08/22/2011 08:50 PM, Endi Sukma Dewata wrote: The association table widget and facet have been modified to accept titles for the add and delete dialogs. The table and facet definitions have been modified to specify the appropriate titles. Some

[Freeipa-devel] [PATCH] 252 Removed unnecessary HBAC/sudo rule category modification.

2011-08-22 Thread Endi Sukma Dewata
Since the Add/Delete links in the association table are disabled when the category is set to 'all', it's no longer necessary to check the category before showing the add/delete dialogs and modify the category before adding entries. Thus, the IPA.rule_association_table_widget is no longer needed.

[Freeipa-devel] [PATCH] 251 Updated add and delete association dialog titles.

2011-08-22 Thread Endi Sukma Dewata
The association table widget and facet have been modified to accept titles for the add and delete dialogs. The table and facet definitions have been modified to specify the appropriate titles. Some unused code have been removed. Ticket #1629 -- Endi S. Dewata From c5c8d97ce08c7a64aa5755a0ef2e32

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-22 Thread Endi Sukma Dewata
On 8/22/2011 10:06 AM, Petr Vobornik wrote: 'Failed' moved to command. On 'failed' success is transformed to error - can be change behaviour of serial associator in some commands (previously some commands were executed even after 'failed' of previous). It isn't probably big issue because they fai

Re: [Freeipa-devel] [PATCH] 006 Uncheck checkboxes in association after deletion

2011-08-19 Thread Endi Sukma Dewata
On 8/19/2011 11:50 AM, Petr Vobornik wrote: done Pushed to master and ipa-2-1. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 250 Replaced page dirty dialog title.

2011-08-19 Thread Endi Sukma Dewata
The title of page dirty dialog has been changed to 'Unsaved Changes'. Ticket #1653 Pushed to master and ipa-2-1 under one-liner/trivial rule. -- Endi S. Dewata From 49e49b4ce286e0341c85a467b94bb45561b62dbc Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 19 Aug 2011 11:27:01 -0500 Subj

Re: [Freeipa-devel] [PATCH] 249 Removed 'Hide already enrolled' checkbox.

2011-08-19 Thread Endi Sukma Dewata
On 8/19/2011 7:04 AM, Petr Vobornik wrote: On 08/18/2011 04:53 PM, Endi Sukma Dewata wrote: The 'Hide already enrolled' has been removed from the enrollment dialog because it is checked by default and entries that are already enrolled cannot be enrolled again. Ticket #1638 ACK

Re: [Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-18 Thread Endi Sukma Dewata
On 8/18/2011 10:03 AM, Simo Sorce wrote: On Tue, 2011-08-16 at 16:13 -0500, Endi Sukma Dewata wrote: On 8/15/2011 10:44 AM, Petr Vobornik wrote: On 08/11/2011 07:44 PM, Endi Sukma Dewata wrote: The dialog box for resetting user password has been modified to use the standard layout. patch

<    1   2   3   4   5   6   7   8   9   10   >