Re: [Freeipa-devel] [PATCH] 006 Uncheck checkboxes in association after deletion

2011-08-18 Thread Endi Sukma Dewata
On 8/18/2011 8:18 AM, Petr Vobornik wrote: https://fedorahosted.org/freeipa/ticket/1639 - added unchecking all checkboxes of table_widget and its derivates to on_load method. line '$('input[name=select]', that.tbody).attr('checked', false);' can be unnecessary because load method is recreating

Re: [Freeipa-devel] [PATCH] 005 Show error in serial association

2011-08-18 Thread Endi Sukma Dewata
On 8/17/2011 10:38 AM, Petr Vobornik wrote: Ticket #1628 - https://fedorahosted.org/freeipa/ticket/1628 Unreported insufficient access error This patch is dependant on freeipa-pvoborni-0004-1-error-dialog-for-batch-command.patch. This may be only a checking if approach of this patch is good. I

[Freeipa-devel] [PATCH] 249 Removed 'Hide already enrolled' checkbox.

2011-08-18 Thread Endi Sukma Dewata
The 'Hide already enrolled' has been removed from the enrollment dialog because it is checked by default and entries that are already enrolled cannot be enrolled again. Ticket #1638 -- Endi S. Dewata From 7ab8bb1bb641c1b140e7662ecd4bf9aa74f75ef2 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Dat

[Freeipa-devel] [PATCH] 248 Fixed problem selecting value from combobox

2011-08-17 Thread Endi Sukma Dewata
The IPA.combobox_widget has been modified to use the 'change' event to capture the selected value from the drop-down list. Ticket #1654 Pushed to master and ipa-2-1 under one-liner/trivial rule. -- Endi S. Dewata From 347854b34129807a70dd08982f684d20e62c253f Mon Sep 17 00:00:00 2001 From: Endi

Re: [Freeipa-devel] [PATCH] 247 Hide activation/deactivation link from regular users.

2011-08-17 Thread Endi Sukma Dewata
On 8/17/2011 2:57 AM, Petr Vobornik wrote: On 08/16/2011 11:49 PM, Endi Sukma Dewata wrote: The IPA.user_status_widget has been modified to show/hide the link for activating/deactivating users according to the attributelevelrights. Ticket #1625 ACK Pushed to master and ipa-2-1. -- Endi S

Re: [Freeipa-devel] [PATCH] 246 Fixed browser configuration pages

2011-08-17 Thread Endi Sukma Dewata
On 8/17/2011 3:38 AM, Petr Vobornik wrote: On 08/16/2011 11:20 PM, Endi Sukma Dewata wrote: The browser configuration pages have been modified to improve the content and appearance. Ticket #1624 ACK Pushed to master and ipa-2-1. -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] 004 error dialog for batch command

2011-08-17 Thread Endi Sukma Dewata
On 8/15/2011 12:49 PM, Endi Sukma Dewata wrote: On 8/15/2011 10:28 AM, Petr Vobornik wrote: done ACK. Will push after release. Pushed to master and ipa-2-1. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https

[Freeipa-devel] [PATCH] 247 Hide activation/deactivation link from regular users.

2011-08-16 Thread Endi Sukma Dewata
The IPA.user_status_widget has been modified to show/hide the link for activating/deactivating users according to the attributelevelrights. Ticket #1625 -- Endi S. Dewata From 9fde9b1a20a5d939ebcdbe42ade14ebc774e2245 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 16 Aug 2011 16:30:01

Re: [Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-16 Thread Endi Sukma Dewata
On 8/15/2011 10:44 AM, Petr Vobornik wrote: On 08/11/2011 07:44 PM, Endi Sukma Dewata wrote: The dialog box for resetting user password has been modified to use the standard layout. patch from code and working perspective is OK. Has this patch assigned some ticket? Don't know exactly

Re: [Freeipa-devel] [PATCH] 004 error dialog for batch command

2011-08-15 Thread Endi Sukma Dewata
On 8/15/2011 10:28 AM, Petr Vobornik wrote: done ACK. Will push after release. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-15 Thread Endi Sukma Dewata
On 8/15/2011 11:01 AM, Dmitri Pal wrote: patch from code and working perspective is OK. Has this patch assigned some ticket? Don't know exactly what is IPA's policy for submitting patches without tickets in Trac (for future tracking). I would prefer to have a ticket. OK, I'll open a ticket f

Re: [Freeipa-devel] [PATCH] 245 Fixed problem with buttons in enrollment dialog.

2011-08-15 Thread Endi Sukma Dewata
On 8/15/2011 9:43 AM, Petr Vobornik wrote: On 08/15/2011 04:29 PM, Endi Sukma Dewata wrote: The panel for selection buttons (i.e. ">>" and "<<") has been re- positioned to avoid being covered by the adder-dialog-right panel. Ticket #1626 ACK Push

[Freeipa-devel] [PATCH] 245 Fixed problem with buttons in enrollment dialog.

2011-08-15 Thread Endi Sukma Dewata
The panel for selection buttons (i.e. ">>" and "<<") has been re- positioned to avoid being covered by the adder-dialog-right panel. Ticket #1626 -- Endi S. Dewata From 8ddbbf310fb429267dc9663e65a3a24f0ec6e8ff Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Mon, 15 Aug 2011 09:13:13 -0500 S

[Freeipa-devel] [PATCH] 244 Fixed link style in dialog box.

2011-08-15 Thread Endi Sukma Dewata
The general link style defined in ipa.css was overriden by a more specific rule in jquery-ui.css. So the style has been modified to include the more specific rule. Ticket #1623 Pushed under one-liner rule. -- Endi S. Dewata From 234bf969b4e0f7ad46bd60b8b0709256364b Mon Sep 17 00:00:00 2001

Re: [Freeipa-devel] [PATCH] 109 Update 389-ds-base version

2011-08-11 Thread Endi Sukma Dewata
On 8/11/2011 7:12 AM, Alexander Bokovoy wrote: On 11.08.2011 15:07, Martin Kosek wrote: The patch is applicable on top of my patch 108. ACK as well. This is straight-forward. Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freei

Re: [Freeipa-devel] [PATCH] [WIP] 108 Fix client enrollment

2011-08-11 Thread Endi Sukma Dewata
On 8/11/2011 7:06 AM, Alexander Bokovoy wrote: On 11.08.2011 14:59, Martin Kosek wrote: Thanks, that was the problem. I wonder how I missed it. Attaching the updated patch, client enrollment on F-15 works. ACK. Should we wait until xmlrpc-c flies into F15 updates? Pushed to master. -- Endi S

[Freeipa-devel] [PATCH] 243 Fixed problem clicking 3rd level tabs.

2011-08-11 Thread Endi Sukma Dewata
The 3rd level tabs were partially covered by the content panel, so only the top portion can be clicked. The content panel has been repositioned to avoid the problem. Pushed under one-liner/trivial rule. -- Endi S. Dewata From 7f18bd82c86867d5cc1e3af607a2ba76177402e3 Mon Sep 17 00:00:00 2001 From

[Freeipa-devel] [PATCH] 242 Removed custom layout for password reset.

2011-08-11 Thread Endi Sukma Dewata
The dialog box for resetting user password has been modified to use the standard layout. -- Endi S. Dewata From d1c3958f1f0e5a2b5cdc3a45e03bcf5c009a2268 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Wed, 10 Aug 2011 22:47:39 -0500 Subject: [PATCH] Removed custom layout for password reset.

Re: [Freeipa-devel] [PATCH] 004 error dialog for batch command

2011-08-11 Thread Endi Sukma Dewata
On 8/11/2011 11:03 AM, Endi Sukma Dewata wrote: Some issues: 1. I think by default all batch commands should use this feature. The batch command is used for various purposes, not just for deletion. Consider this scenario: First, find a way to log in simultaneously using different accounts. You

Re: [Freeipa-devel] [PATCH] 004 error dialog for batch command

2011-08-11 Thread Endi Sukma Dewata
On 8/11/2011 9:01 AM, Petr Vobornik wrote: [PATCH] error dialog for batch command https://fedorahosted.org/freeipa/ticket/1597 https://fedorahosted.org/freeipa/ticket/1592 Added option to show multiple errors in error dialog. Notes: - also covering '[ipa webui] Does not return appropriate erro

Re: [Freeipa-devel] [PATCH] 241 Fixed broken links in ipa_error.css and ipa_migration.css.

2011-08-11 Thread Endi Sukma Dewata
On 8/11/2011 3:53 AM, Petr Vobornik wrote: ACK I don't like that there is no pattern in image file naming. Sometimes it uses dashes, sometimes underscores. Some file names are capitalized. But this isn't the subject of this patch (ticket). Yes, it's an existing issue. I opened a new ticket for

Re: [Freeipa-devel] [PATCH] 240 Fixed DNS zone adder dialog.

2011-08-10 Thread Endi Sukma Dewata
On 8/10/2011 3:08 AM, Petr Vobornik wrote: On 08/09/2011 10:09 PM, Endi Sukma Dewata wrote: The DNS zone adder dialog has been modified to use radio buttons to select whether to enter a zone name or a reverse zone IP network. Ticket #1575 ACK Same repetitive code as in host adder dialog

Re: [Freeipa-devel] [PATCH] 239 Fixed host adder dialog.

2011-08-10 Thread Endi Sukma Dewata
On 8/10/2011 1:57 AM, Petr Vobornik wrote: On 08/09/2011 08:04 PM, Endi Sukma Dewata wrote: On 8/9/2011 7:12 AM, Petr Vobornik wrote: NACK "Add and edit" without existing DNS reverse zone don't redirect to edit page. Field 'fqdn' doesn't exist any more so gett

[Freeipa-devel] [PATCH] 241 Fixed broken links in ipa_error.css and ipa_migration.css.

2011-08-09 Thread Endi Sukma Dewata
Some of the images that were previously deleted are actually needed by ipa_error.css and ipa_migration.css, so they have been restored. Ticket #1564 -- Endi S. Dewata From 92b5307e6134c0611a466f636724df27c607576a Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 9 Aug 2011 16:08:29 -0500

[Freeipa-devel] [PATCH] 240 Fixed DNS zone adder dialog.

2011-08-09 Thread Endi Sukma Dewata
The DNS zone adder dialog has been modified to use radio buttons to select whether to enter a zone name or a reverse zone IP network. Ticket #1575 -- Endi S. Dewata From 0c8eadaa3690335c65f6e9ec094094a94481c66b Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Mon, 8 Aug 2011 17:24:05 -0500 S

Re: [Freeipa-devel] [PATCH] 239 Fixed host adder dialog.

2011-08-09 Thread Endi Sukma Dewata
On 8/9/2011 7:12 AM, Petr Vobornik wrote: NACK "Add and edit" without existing DNS reverse zone don't redirect to edit page. Field 'fqdn' doesn't exist any more so getting fqdn from field in host.js:280 "fqdn: that.get_field('fqdn').save()" isn't functional. Fixed. Now the fqdn is obtained fr

Re: [Freeipa-devel] [PATCH] 238 Fixed error after login on IE

2011-08-09 Thread Endi Sukma Dewata
On 8/9/2011 6:06 AM, Petr Vobornik wrote: Code looks good. But, I didn't test it in IE9, because I don't have one nor Windows vm (will try to get one). Modifications in error handling are OK. If it really works in IE I would consider it ACKed. Since we don't officially support IE, as long as

[Freeipa-devel] [PATCH] 239 Fixed host adder dialog.

2011-08-08 Thread Endi Sukma Dewata
The host adder dialog has been modified to use separate fields for hostname and DNS zone. The hostname is a text field and the DNS zone is an editable drop-down list. The fields will have the following behavior: - If the user types a dot into the hostname field, the cursor will automatically

[Freeipa-devel] [PATCH] 238 Fixed error after login on IE

2011-08-08 Thread Endi Sukma Dewata
The IE does not resend the request body during negotiation, so after after a successful authentication the server could not find the JSON request to parse. The Web UI has been modified to detect this error and resend the initialization request. Ticket #1540 -- Endi S. Dewata From dbe61f4469252d

Re: [Freeipa-devel] [PATCH] 002 Fixed adding host without DNS reverse zone

2011-08-05 Thread Endi Sukma Dewata
On 8/5/2011 11:33 AM, Petr Vobornik wrote: The default values in ipa.js:576-579 are redundant because they will be overridden by the spec in init(). Removed. I think the assignments in init() can be replaced by something like this: that.xhr = spec.xhr || {}; Note that the default value

[Freeipa-devel] [PATCH] 237 Fixed facet group labels.

2011-08-05 Thread Endi Sukma Dewata
The facet group labels have been modified according to UXD spec. Some facet groups will have more descriptive labels. Some others will not have any labels because the facet tab is self-explanatory. Ticket #1423, #1561 -- Endi S. Dewata From 5fa054671d194c3b39e79473ecf114af4e38b77c Mon Sep 17 00:

[Freeipa-devel] [PATCH] 236 Fixed 3rd level tab style.

2011-08-05 Thread Endi Sukma Dewata
The 3rd level tab style has been adjusted according to UXD input. -- Endi S. Dewata From 847dff570538705a765f52ebf4724694c96127af Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 5 Aug 2011 10:17:08 -0500 Subject: [PATCH] Fixed 3rd level tab style. The 3rd level tab style has been adjus

Re: [Freeipa-devel] [PATCH] 002 Fixed adding host without DNS reverse zone

2011-08-04 Thread Endi Sukma Dewata
On 8/4/2011 4:22 AM, Petr Vobornik wrote: new version attached Almost there, just a few more minor issues. Also these changes should be reverted back to maintain the Ajax context: - that.on_error.call(this, xhr, text_status, error_thrown); + that.on_error(xhr, text_status, error_thrown); -

[Freeipa-devel] [PATCH] 235 Linked entries in HBAC/sudo details page.

2011-08-03 Thread Endi Sukma Dewata
The association tables in HBAC/sudo details page have been modified to link the entries to the appropriate details page. Ticket #1535 -- Endi S. Dewata From f2ddcc2b33d8bfddb34796ed7bf712708e33d735 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Wed, 3 Aug 2011 17:15:05 -0500 Subject: [PATC

[Freeipa-devel] [PATCH] 234 Resizable adder dialog box.

2011-08-02 Thread Endi Sukma Dewata
The tables in the adder dialog have been modified to expand according to the size of the dialog. This patch also fixes the problem with row height on IE. Ticket #1542 -- Endi S. Dewata From 89f0d9153ddc25963ce5b216dc1c0558ef477483 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 2 Aug

[Freeipa-devel] [PATCH] 233 Fixed misaligned search icon.

2011-08-02 Thread Endi Sukma Dewata
The magnifier icon for the search field has been fixed to display properly in all browsers. Ticket #1541 -- Endi S. Dewata From f5adab1577be26311c2a485e6c9e0f0a81cbd6cd Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 2 Aug 2011 16:03:36 -0500 Subject: [PATCH] Fixed misaligned search ic

[Freeipa-devel] [PATCH] 232 Fixed missing icons.

2011-08-02 Thread Endi Sukma Dewata
The Makefile.am and the spec file have been fixed to include all icons in the install/ui folder. Ticket #1559 -- Endi S. Dewata From d5fdb61d4baaf84f769dd65d1489a6253a6b0e2d Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 2 Aug 2011 12:42:42 -0500 Subject: [PATCH] Fixed missing icons.

[Freeipa-devel] [PATCH] 231 Fixed certificate buttons.

2011-08-02 Thread Endi Sukma Dewata
The certificate buttons including Get, View, Revoke, Restore for hosts and services have been fixed to use the correct entity name. Ticket #1556 -- Endi S. Dewata From 972907a576f5d41036f3c356f7fe7061091b516e Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 2 Aug 2011 10:26:12 -0500 Sub

Re: [Freeipa-devel] [PATCH] 002 Fixed adding host without DNS reverse zone

2011-07-29 Thread Endi Sukma Dewata
On 7/29/2011 11:12 AM, Petr Vobornik wrote: There was a small error in add.js:162. Fixed! Nice job on the dialog boxes. There's a problem though, the Retry doesn't quite work. This is because 'this' object passed to IPA.error_dialog actually points to Ajax context instead of the IPA.command,

Re: [Freeipa-devel] [PATCH] 0282-use-other_entity-for-adder-columns

2011-07-29 Thread Endi Sukma Dewata
On 7/28/2011 9:30 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 230 Added association facets for HBAC and sudo.

2011-07-28 Thread Endi Sukma Dewata
The HBAC service, HBAC service group, sudo command and sudo command group have been modified to show the associations as facets. Ticket #1536 -- Endi S. Dewata From 2445adacfa78ce0bf400c5f91190654b52fc2027 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Thu, 28 Jul 2011 17:23:41 -0500 Subje

[Freeipa-devel] [PATCH] 229 Fixed missing memberof definition in HBAC service.

2011-07-28 Thread Endi Sukma Dewata
The HBAC service class has been modified to define the memberof relationship with HBAC service group. Ticket #1546 -- Endi S. Dewata From 4a62c49c9a1dba5582401337a1c55d7bde0a8868 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Thu, 28 Jul 2011 18:45:44 -0500 Subject: [PATCH] Fixed missing m

[Freeipa-devel] [PATCH] 228 Fixed problem unprovisioning service.

2011-07-28 Thread Endi Sukma Dewata
The IPA.service_provisioning_status_widget has been modified to execute the disable command with the right entity name. Ticket #1543 Pushed under one-liner rule. -- Endi S. Dewata From e2a9fb9edaee6c473360c65308b2a9be25ea27c9 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Thu, 28 Jul 2011

[Freeipa-devel] [PATCH] 227 Fixed missing section header in sudo command group.

2011-07-28 Thread Endi Sukma Dewata
The sudo command group details page has been fixed to use the correct label name. Ticket #1537. Pushed to master under one-liner rule. -- Endi S. Dewata From 8c2d2e75770a984ce844120a874449069febda7b Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Thu, 28 Jul 2011 13:58:30 -0500 Subject: [P

Re: [Freeipa-devel] [PATCH] 0281-dns-section-header-i18n

2011-07-28 Thread Endi Sukma Dewata
On 7/28/2011 2:00 PM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-28 Thread Endi Sukma Dewata
On 7/28/2011 9:30 AM, Adam Young wrote: ACK 270-14, 278-4, and 280-1. Please squash before push. Thanks. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-27 Thread Endi Sukma Dewata
On 7/27/2011 8:14 PM, Adam Young wrote: 59. The initialization area in IPA.association_adder_dialog (association.js:212) should be marked with a comment. Done The default_columns() invocation should be moved into the initialization area because this is not a precondition checking like in #57.

[Freeipa-devel] [PATCH] 226 Fixed hard-coded label in Find button.

2011-07-27 Thread Endi Sukma Dewata
The IPA.adder_dialog has been modified to use translated label for the Find button. Pushed to master under one-liner rule. -- Endi S. Dewata From 7d1c2a3f4563e97458f586b83a42ede2eeb4b1ff Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Wed, 27 Jul 2011 16:35:16 -0500 Subject: [PATCH] Fixed h

Re: [Freeipa-devel] [PATCH] 225 Fixed hard-coded labels in sudo rules.

2011-07-27 Thread Endi Sukma Dewata
On 7/26/2011 4:52 PM, Adam Young wrote: On 07/26/2011 01:19 PM, Endi Sukma Dewata wrote: The sudo rule interface has been modified to remove unused labels and use translated dialog box title. Ticket #1518 ACK Pushed to master. -- Endi S. Dewata

Re: [Freeipa-devel] [PATCH] 224 Fixed problem setting host OTP.

2011-07-27 Thread Endi Sukma Dewata
On 7/26/2011 4:52 PM, Adam Young wrote: On 07/26/2011 11:17 AM, Endi Sukma Dewata wrote: The handler for host 'Set OTP' button has been modified to obtain the primary key from the entity and return false to stop the normal event processing. Ticket #1511 ACK Pushed to master.

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-26 Thread Endi Sukma Dewata
On 7/26/2011 3:36 PM, Adam Young wrote: 41. The radio buttons in the 'As Whom' section in sudo rule section are missing the labels. It should show the doc attributes of the ipasudorunasusercategory and ipasudorunasgroupcategory. Fixed These labels (sudo.js:1033,1069) should be followed by "a c

Re: [Freeipa-devel] [PATCH] 002 Fixed adding host without DNS reverse zone

2011-07-26 Thread Endi Sukma Dewata
On 7/26/2011 6:27 AM, Petr Vobornik wrote: Fixed adding host without DNS reverse zone https://fedorahosted.org/freeipa/ticket/1481 Shows status dialog instead of error dialog (error 4304 is treated like success). This patch is fixing the problem, but maybe in a wrong way. Main problem was tha

[Freeipa-devel] [PATCH] 225 Fixed hard-coded labels in sudo rules.

2011-07-26 Thread Endi Sukma Dewata
The sudo rule interface has been modified to remove unused labels and use translated dialog box title. Ticket #1518 -- Endi S. Dewata From b0c85d3ffc2c72009b4b50b8b189992d570c5ff7 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 26 Jul 2011 11:42:25 -0500 Subject: [PATCH] Fixed hard-cod

[Freeipa-devel] [PATCH] 224 Fixed problem setting host OTP.

2011-07-26 Thread Endi Sukma Dewata
The handler for host 'Set OTP' button has been modified to obtain the primary key from the entity and return false to stop the normal event processing. Ticket #1511 -- Endi S. Dewata From e0b2f3b0d52b6dee71dc4551b6981263fb388f68 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 26 Jul 20

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-25 Thread Endi Sukma Dewata
On 7/25/2011 8:59 PM, Adam Young wrote: I think we should remove IPA.spacer_widget and leave the IPA.dnszone_adder_dialog unchanged for now. The current code, although it might not be very concise, is done correctly and does produce the desired layout (label on the right of the checkbox and a spa

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-25 Thread Endi Sukma Dewata
On 7/25/2011 11:56 AM, Adam Young wrote: 30. The IPA.spacer_widget is used to create spacing for layout. Widgets should not be used this way because it diverges from the original design. Widgets are supposed to correspond to attribute. It has a name (required for storing in a map), metadata,

[Freeipa-devel] [PATCH] 223 Fixed problem bookmarking Policy/IPA Server tabs

2011-07-25 Thread Endi Sukma Dewata
When opening a bookmark, each tab level will be updated separately from top to bottom according to the URL state. The navigation code has been modified to recognize when an ancestor tab is being updated and not change the URL state. Ticket #1521 -- Endi S. Dewata From 78ee31d4247dd7952efe6dfd6f8

[Freeipa-devel] [PATCH] 222 New icons for entitlement buttons

2011-07-25 Thread Endi Sukma Dewata
The entitlement facets have been modified to use the new icons provided by Kyle Baker. Ticket #1425 -- Endi S. Dewata From f53afa07fb4bd1c067aac78800d5156f7d061de4 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Mon, 25 Jul 2011 10:59:34 -0500 Subject: [PATCH] New icons for entitlement butt

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-22 Thread Endi Sukma Dewata
On 7/22/2011 12:18 PM, Endi Sukma Dewata wrote: On 7/22/2011 10:34 AM, Adam Young wrote: While this version has a Navigation fix in it, it is going to be rebased on top of Endi Dewata's patch for putting the state inside each of the facets. Rebased. I'll continue the review. S

Re: [Freeipa-devel] [PATCH] 0274-move-dns-to-identity-tab

2011-07-22 Thread Endi Sukma Dewata
On 7/22/2011 2:39 PM, Adam Young wrote: It makes a lot more sense here. ACK, but there's a jslint warning. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 221 Fixed click handlers on certificate buttons.

2011-07-22 Thread Endi Sukma Dewata
The click event handlers for certificate buttons have been fixed to stop standard event processing which causes the page to change. -- Endi S. Dewata From eb263c323a61e3d197c86585643e7dab351b1f4a Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 22 Jul 2011 14:32:33 -0500 Subject: [PATCH]

[Freeipa-devel] [PATCH] 220 Fixed navigation unit test.

2011-07-22 Thread Endi Sukma Dewata
The mock-up get_state() has been modified to return an empty object if it's called without parameter. It's the same as $bbq.getState(). Pushed under one-liner/trivial rule. -- Endi S. Dewata From 489f99000e23e3566ab4e1e6a2b6dca6402a3c46 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 2

[Freeipa-devel] [PATCH] 219 Fixed navigation problems.

2011-07-22 Thread Endi Sukma Dewata
The navigation code has been modified store the facet's state separately in the facet object itself. The path state is stored in the navigation object. When the path is changed to view a new facet, only the path and the state of the new facet will be shown in the URL, thus keeping the URL short.

[Freeipa-devel] [PATCH] 218 Fixed problem with navigation state loading.

2011-07-22 Thread Endi Sukma Dewata
The select event handler in the navigation tab has been modified to distinguish the source of the event. If the event is triggered by URL hash change, it will use the state specified in the URL. If the event is triggered by a mouse click, it will use the state stored internally. -- Endi S. Dewata

[Freeipa-devel] [PATCH] 217 Refactored IPA.current_facet().

2011-07-22 Thread Endi Sukma Dewata
The IPA.current_facet() has been merged into IPA.entity.setup() and replaced by IPA.entity.get_facet(). The setup() will read the current facet's name from the -facet URL parameter and store the facet object in the entity object. The get_facet() without any parameter will return the current facet

Re: [Freeipa-devel] [PATCH] 214 Fixed problem loading data in HBAC/sudo details page.

2011-07-21 Thread Endi Sukma Dewata
On 7/21/2011 10:25 AM, Adam Young wrote: On 07/21/2011 10:27 AM, Endi Sukma Dewata wrote: On 7/21/2011 9:23 AM, Endi Sukma Dewata wrote: In a recent change the details page was changed to create and locate field containers with 'details-field' CSS class. The HBAC and sudo custom det

Re: [Freeipa-devel] [PATCH] 213 Removed entitlement registration UUID field.

2011-07-21 Thread Endi Sukma Dewata
On 7/21/2011 10:23 AM, Adam Young wrote: On 07/21/2011 10:59 AM, Endi Sukma Dewata wrote: On 7/21/2011 9:47 AM, Adam Young wrote: Close to ACK, but: Either remove all of the references to the field, or comment them out. Suggest going the commented out route. Also, leave the commas inside the

Re: [Freeipa-devel] [PATCH] 213 Removed entitlement registration UUID field.

2011-07-21 Thread Endi Sukma Dewata
On 7/21/2011 9:47 AM, Adam Young wrote: Close to ACK, but: Either remove all of the references to the field, or comment them out. Suggest going the commented out route. Also, leave the commas inside the commented out code, so that you can just remove the comment and the code will be valid, even i

[Freeipa-devel] [PATCH] 215 Removed HBAC access time code.

2011-07-21 Thread Endi Sukma Dewata
The HBAC access time is currently not supported, so the related UI code has been removed to reduce maintenance issue. When the feature becomes supported in the future the code may be restored/rewritten. Ticket #546 -- Endi S. Dewata From 4ae2161ee45bc1749deccb13f0eedb1fb40a32cd Mon Sep 17 00:00:

Re: [Freeipa-devel] [PATCH] 214 Fixed problem loading data in HBAC/sudo details page.

2011-07-21 Thread Endi Sukma Dewata
On 7/21/2011 9:23 AM, Endi Sukma Dewata wrote: In a recent change the details page was changed to create and locate field containers with 'details-field' CSS class. The HBAC and sudo custom details pages have been modified to use the same CSS class. Ticket #1508 Patch attached.

[Freeipa-devel] [PATCH] 214 Fixed problem loading data in HBAC/sudo details page.

2011-07-21 Thread Endi Sukma Dewata
In a recent change the details page was changed to create and locate field containers with 'details-field' CSS class. The HBAC and sudo custom details pages have been modified to use the same CSS class. Ticket #1508 -- Endi S. Dewata ___ Freeipa-devel

[Freeipa-devel] [PATCH] 213 Removed entitlement registration UUID field.

2011-07-20 Thread Endi Sukma Dewata
The UUID field has been removed from the entitlement registration dialog box because it's currently not supported. The code has been modified not to send empty UUID value should this become supported in the future. Ticket #1506 -- Endi S. Dewata From bf72a8817b43172dd28d06bd3f4249153ac591e3 Mon

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-20 Thread Endi Sukma Dewata
On 7/20/2011 9:18 PM, Adam Young wrote: 8. Triggering a stack trace by calling null function probably will only work with Firebug, normal users will not get any notification about the error. This happens in dialog.js:301 and widget.js:1137. Gonna leave this, as we will catch things in developm

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-20 Thread Endi Sukma Dewata
On 7/20/2011 7:08 PM, Endi Sukma Dewata wrote: This is based on patch 270-2: 19. Updating HBAC and sudo rules doesn't work, the fields always reset to the original values. No undo buttons appear. 20. The Get & View buttons in host details page generate an error. Create a ho

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-20 Thread Endi Sukma Dewata
On 7/20/2011 2:50 PM, Adam Young wrote: 8. Triggering a stack trace by calling null function probably will only work with Firebug, normal users will not get any notification about the error. This happens in dialog.js:301 and widget.js:1137. Gonna leave this, as we will catch things in develop

Re: [Freeipa-devel] [PATCH] 0270-removing-setters-setup-and-init

2011-07-20 Thread Endi Sukma Dewata
On 7/19/2011 6:38 PM, Adam Young wrote: Missed a change to fix the unit tests. I haven't finished testing it, but here are some issues: 1. If DNS is disabled, the DNS zone entity throws an uncaught exception so the execution stops. 2. In add.js:41 the IPA.nav.show_entity_page() takes an arr

Re: [Freeipa-devel] [PATCH] 212 Creating reverse zones from IP address.

2011-07-20 Thread Endi Sukma Dewata
On 7/20/2011 1:45 PM, Adam Young wrote: ACK, but put in the space between the reverse checkbox line and the next row. Add a ticket for refactoring the dialogs to allow more layout options on a widget, so we can reduce the complexity of the code in the future. New patch attached. -- Endi S. Dew

[Freeipa-devel] [PATCH] 212 Creating reverse zones from IP address.

2011-07-20 Thread Endi Sukma Dewata
A custom adder dialog has been added for DNS zones to simplify creating reverse zones from IP address. The dialog provides a checkbox which indicates whether the content of the zone name field is an IP address. The IP address will be used to generate the reverse zone name and email address. Ticke

[Freeipa-devel] [PATCH] 211 Added checkbox to remove hosts from DNS.

2011-07-19 Thread Endi Sukma Dewata
A custom deleter dialog for hosts has been added to provide an option whether to remove the hosts from DNS. Ticket #1470 -- Endi S. Dewata From 68010a0e620b7c1220e617c5f5fcf2f0db59352e Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Tue, 19 Jul 2011 13:46:09 -0500 Subject: [PATCH] Added che

[Freeipa-devel] [PATCH] 210 Fixed host details fields.

2011-07-18 Thread Endi Sukma Dewata
The host details facet has been fixed to remove a redundant field and include some missing fields. Ticket #1484 -- Endi S. Dewata From 3e3efd2c92454513f004e8c9ae00fe6fd14d842e Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Mon, 18 Jul 2011 15:07:18 -0500 Subject: [PATCH] Fixed host details

[Freeipa-devel] [PATCH] 209 Removed reverse zones from host adder dialog.

2011-07-18 Thread Endi Sukma Dewata
The host adder dialog has been modified to specify the new flag for retrieving the forward zones only. Ticket #1458 -- Endi S. Dewata From abea002ce23b74db537103658bfbb8a147e2c39e Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Mon, 18 Jul 2011 11:42:22 -0500 Subject: [PATCH] Removed revers

Re: [Freeipa-devel] [PATCH] 208 Entity select widget improvements

2011-07-18 Thread Endi Sukma Dewata
On 7/18/2011 11:52 AM, Endi Sukma Dewata wrote: On 7/18/2011 10:44 AM, Endi Sukma Dewata wrote: The IPA.entity_select_widget has been modified into a searchable and editable drop down list. Ticket #1361 Fixed z-index problem and renamed base class to IPA.combobox_widget. Included new icon

Re: [Freeipa-devel] [PATCH] 208 Entity select widget improvements

2011-07-18 Thread Endi Sukma Dewata
On 7/18/2011 10:44 AM, Endi Sukma Dewata wrote: The IPA.entity_select_widget has been modified into a searchable and editable drop down list. Ticket #1361 Fixed z-index problem and renamed base class to IPA.combobox_widget. -- Endi S. Dewata From 3e68a57cb5e406c556f480f82c53909a7c148fb5 Mon

[Freeipa-devel] [PATCH] 208 Entity select widget improvements

2011-07-18 Thread Endi Sukma Dewata
The IPA.entity_select_widget has been modified into a searchable and editable drop down list. Ticket #1361 -- Endi S. Dewata From 5affc4f0a2748a1882b4f883b657ffcc5bfbf7d5 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 15 Jul 2011 12:18:59 -0500 Subject: [PATCH] Entity select widget im

Re: [Freeipa-devel] [PATCH] 0267-dnsrecord-mod-ui

2011-07-13 Thread Endi Sukma Dewata
On 7/13/2011 4:03 PM, Adam Young wrote: 3. I cannot try this due to issue #2, but in CLI when the last data is removed using -mod the record itself will be deleted. The record has to be re-added before it can be modified again. A user might encounter this issue if he removes all existing data, cl

Re: [Freeipa-devel] [PATCH]0269-remove-HBAC-warning-from-static-UI

2011-07-13 Thread Endi Sukma Dewata
On 7/13/2011 2:02 PM, Adam Young wrote: This patch only affects development. ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0267-dnsrecord-mod-ui

2011-07-13 Thread Endi Sukma Dewata
On 7/12/2011 4:47 PM, Adam Young wrote: Some issues: 1. In DNS record adder dialog, the data field is required but it's not checked before submit. There is no param_info for this field, so the required flag may need to be specified explicitly in the field declaration. 2. Adding/deleting r

[Freeipa-devel] [PATCH] 206 Fixed object_name and object_name_plural, internationalization

2011-07-12 Thread Endi Sukma Dewata
The object_name, object_name_plural and messages that use these attributes have been converted to support translation. The label attribute in the Param class has been modified to accept unicode string. Ticket #1435 -- Endi S. Dewata From 0fb19d888e845dca25df219b374730e010499586 Mon Sep 17 00:00:

Re: [Freeipa-devel] [PATCH] 205 Fixed collapsed table in Chrome.

2011-07-12 Thread Endi Sukma Dewata
On 7/11/2011 8:15 PM, Endi Sukma Dewata wrote: The .content-table class has been modified to expand properly in Firefox and Chrome. Ticket #1450 ACKed and pushed by ayoung. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com

[Freeipa-devel] [PATCH] 205 Fixed collapsed table in Chrome.

2011-07-11 Thread Endi Sukma Dewata
The .content-table class has been modified to expand properly in Firefox and Chrome. Ticket #1450 -- Endi S. Dewata From 8223ed1b8b5027c14f9b41ec6c1b8f5489b9a0f9 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Mon, 11 Jul 2011 19:45:14 -0500 Subject: [PATCH] Fixed collapsed table in Chrome.

Re: [Freeipa-devel] [PATCH] 204 Added sudo options.

2011-07-11 Thread Endi Sukma Dewata
On 7/11/2011 4:03 PM, Adam Young wrote: OK, that makes sense. ACK Pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 204 Added sudo options.

2011-07-11 Thread Endi Sukma Dewata
On 7/11/2011 12:41 PM, Adam Young wrote: Tempted to ACK. Before I do, question: why did you make it a section as opposed to a widget? The only other place we have a custom section is for the permissions, where we are optionally showing a set of related widgets together, and we needed to reuse tha

Re: [Freeipa-devel] [PATCH] 0268-indirect-admins

2011-07-11 Thread Endi Sukma Dewata
On 7/11/2011 10:10 AM, Adam Young wrote: ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 204 Added sudo options.

2011-07-11 Thread Endi Sukma Dewata
On 7/11/2011 10:50 AM, Endi Sukma Dewata wrote: A table has been added into sudo rule details page for managing sudo options. Ticket #1447 Patch attached. -- Endi S. Dewata From 9c595dcabb8c93be6de0bedbacb8411329d53f5c Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Sat, 9 Jul 2011 03

[Freeipa-devel] [PATCH] 204 Added sudo options.

2011-07-11 Thread Endi Sukma Dewata
A table has been added into sudo rule details page for managing sudo options. Ticket #1447 -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0266-clear-errors-on-reset

2011-07-08 Thread Endi Sukma Dewata
On 7/8/2011 12:29 PM, Adam Young wrote: Removed code in is_dirty check, as it deson't seem to get triggered now. ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listi

[Freeipa-devel] [PATCH] 203 Fixed missing entitlement import button label

2011-07-08 Thread Endi Sukma Dewata
Pushed under one-liner rule. Ticket #1456 -- Endi S. Dewata From 2bf8167d42ec14f98634c8891f50939353d8513e Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Fri, 8 Jul 2011 11:44:36 -0500 Subject: [PATCH] Fixed missing entitlement import button label Ticket #1456 --- install/ui/entitle.js |

Re: [Freeipa-devel] [PATCH] 0266-clear-errors-on-reset

2011-07-08 Thread Endi Sukma Dewata
On 7/8/2011 10:06 AM, Adam Young wrote: Some issues: 1. The new code in IPA.widget.test_dirty() seems to be redundant. if ((that.values.length === 0) && (values.length === 1) && values[0] === ""){ return false; } It's already covered by a similar code above i

Re: [Freeipa-devel] [PATCH] 0265-check-required-on-blur

2011-07-07 Thread Endi Sukma Dewata
On 7/7/2011 4:57 PM, Adam Young wrote: No longer testing on blur, as it was causing to many issues. Now checking upon click of the add button. ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https:

[Freeipa-devel] [PATCH] 202 Fixed test fixture file name.

2011-07-07 Thread Endi Sukma Dewata
Pushed under one-liner rule. -- Endi S. Dewata From fc48dce3c934ec9ef2ce318366a1bf6f0c734bd5 Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Thu, 7 Jul 2011 15:28:55 -0500 Subject: [PATCH] Fixed test fixture file name. --- .../data/{permission_del => permission_del.json} |0 1 files

<    2   3   4   5   6   7   8   9   10   11   >