URL: https://github.com/freeipa/freeipa/pull/433
Author: LiptonB
Title: #433: csrgen: Allow some certificate fields to be specified by the user
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/433
URL: https://github.com/freeipa/freeipa/pull/717
Author: LiptonB
Title: #717: csrgen: Finish NSS support
Action: opened
PR body:
"""
I took the approach of generating a new key for each request, as keys already
stored in a database are difficult to name precisely. I also had
URL: https://github.com/freeipa/freeipa/pull/542
Title: #542: Implementation independent interface for CSR generation
LiptonB commented:
"""
@HonzaCholasta, thanks! I have an attempt at NSS support in progress. It
might take me a few more days to get it ready to send out, but I t
URL: https://github.com/freeipa/freeipa/pull/542
Title: #542: Implementation independent interface for CSR generation
LiptonB commented:
"""
Thanks for the clarification, @HonzaCholasta. (And for the timely intervention
in #579 to make it actually invisible).
A new version i
URL: https://github.com/freeipa/freeipa/pull/542
Title: #542: Implementation independent interface for CSR generation
LiptonB commented:
"""
Thanks for the clarification, @HonzaCholasta. (And for the timely intervention
in #579 to make it actually invisible).
A new version i
URL: https://github.com/freeipa/freeipa/pull/542
Author: LiptonB
Title: #542: Implementation independent interface for CSR generation
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/542/head:pr542
git
URL: https://github.com/freeipa/freeipa/pull/542
Title: #542: Implementation independent interface for CSR generation
LiptonB commented:
"""
Regarding this comment from @MartinBasti in #590:
> > For the record, #542 removes the helper parameter of
URL: https://github.com/freeipa/freeipa/pull/433
Title: #433: csrgen: Allow some certificate fields to be specified by the user
LiptonB commented:
"""
Rebased, thanks.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/433#issuecomment-28681603
URL: https://github.com/freeipa/freeipa/pull/590
Title: #590: Validate user input for cert-get-requestdata
LiptonB commented:
"""
I don't think one could really add a new helper without modifying the code, so
there's probably no need to allow arbitrary strings. Given that
URL: https://github.com/freeipa/freeipa/pull/433
Author: LiptonB
Title: #433: csrgen: Allow some certificate fields to be specified by the user
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/433
URL: https://github.com/freeipa/freeipa/pull/590
Title: #590: Validate user input for cert-get-requestdata
LiptonB commented:
"""
I don't think one could really add a new helper without modifying the code, so
there's probably no need to allow arbitrary strings. Given that
URL: https://github.com/freeipa/freeipa/pull/542
Title: #542: Implementation independent interface for CSR generation
LiptonB commented:
"""
Thanks for the feedback. I will put together a new version using CFFI and the
`openssl req` format for subject names.
Regarding helpers
URL: https://github.com/freeipa/freeipa/pull/542
Author: LiptonB
Title: #542: Implementation independent interface for CSR generation
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/542/head:pr542
git
URL: https://github.com/freeipa/freeipa/pull/542
Author: LiptonB
Title: #542: Implementation independent interface for CSR generation
Action: opened
PR body:
"""
@HonzaCholasta and everyone, here is where I am so far on the
[CertificationRequestInfo-based interface for CSR
ge
URL: https://github.com/freeipa/freeipa/pull/433
Author: LiptonB
Title: #433: csrgen: Allow some certificate fields to be specified by the user
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/433
URL: https://github.com/freeipa/freeipa/pull/537
Title: #537: test_csrgen: adjusted comparison test scripts for CSRGenerator
LiptonB commented:
"""
Thanks for catching this, sorry about the breakage. The change looks good to me.
"""
See the full comment at
http
URL: https://github.com/freeipa/freeipa/pull/534
Title: #534: Move csrgen templates into ipaclient package
LiptonB commented:
"""
I think this is a much better way to make it configurable than how I had it,
and the implementation looks good to me. Thanks!
"""
URL: https://github.com/freeipa/freeipa/pull/534
Title: #534: Move csrgen templates into ipaclient package
LiptonB commented:
"""
Oops, sorry about the breakage. This seems fine to me, although I hadn't really
been thinking of the templates and rules as data files. T
URL: https://github.com/freeipa/freeipa/pull/434
Title: #434: csrgen: Automate full cert request flow
LiptonB commented:
"""
@HonzaCholasta thanks, updated!
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/434#issuecomment-28293163
URL: https://github.com/freeipa/freeipa/pull/434
Author: LiptonB
Title: #434: csrgen: Automate full cert request flow
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/434/head:pr434
git checkout pr434
From
URL: https://github.com/freeipa/freeipa/pull/434
Title: #434: csrgen: Automate full cert request flow
LiptonB commented:
"""
Thanks for the comments, and sorry about submitting this with lint errors. I
think I've followed all of your suggestions, let me know what you think.
&q
URL: https://github.com/freeipa/freeipa/pull/434
Author: LiptonB
Title: #434: csrgen: Automate full cert request flow
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/434/head:pr434
git checkout pr434
From
URL: https://github.com/freeipa/freeipa/pull/433
Title: #433: csrgen: Allow some certificate fields to be specified by the user
LiptonB commented:
"""
Sorry for submitting this with lint errors - fixed now.
"""
See the full comment at
https://github.com/freeipa
URL: https://github.com/freeipa/freeipa/pull/433
Author: LiptonB
Title: #433: csrgen: Allow some certificate fields to be specified by the user
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/433
URL: https://github.com/freeipa/freeipa/pull/434
Author: LiptonB
Title: #434: csrgen: Automate full cert request flow
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/434/head:pr434
git checkout pr434
From
URL: https://github.com/freeipa/freeipa/pull/434
Author: LiptonB
Title: #434: csrgen: Automate full cert request flow
Action: opened
PR body:
"""
Adds `--autogenerate` flag to `ipa cert-request` command. It no longer
requires a CSR passed on the command line, instead it creates
URL: https://github.com/freeipa/freeipa/pull/433
Author: LiptonB
Title: #433: csrgen: Allow some certificate fields to be specified by the user
Action: opened
PR body:
"""
These patches allow CSR generation rules to contain a "prompt," which will
cause data to b
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
LiptonB commented:
"""
@HonzaCholasta, updated, please take a look. I standardized on "CSR generation
profile" because the names of the objects in the code and the di
URL: https://github.com/freeipa/freeipa/pull/337
Author: LiptonB
Title: #337: Client-side CSR autogeneration (take 2)
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/337/head:pr337
git checkout pr337
From
URL: https://github.com/freeipa/freeipa/pull/337
Author: LiptonB
Title: #337: Client-side CSR autogeneration (take 2)
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/337/head:pr337
git checkout pr337
From
URL: https://github.com/freeipa/freeipa/pull/337
Author: LiptonB
Title: #337: Client-side CSR autogeneration (take 2)
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/337/head:pr337
git checkout pr337
From
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
LiptonB commented:
"""
@HonzaCholasta, I think we're on the same page, then. I removed the dogtag
profile and the validation from the `profile_id` parameter, and rebased the PR
URL: https://github.com/freeipa/freeipa/pull/10
Author: LiptonB
Title: #10: Client-side CSR autogeneration
Action: closed
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/10/head:pr10
git checkout pr10
--
Manage your
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
LiptonB commented:
"""
@HonzaCholasta, I think I see what you mean about these templates not being
dependent on dogtag, and I'm fine with removing the `userCert` dogtag profil
URL: https://github.com/freeipa/freeipa/pull/337
Title: #337: Client-side CSR autogeneration (take 2)
LiptonB commented:
"""
@tiran Thanks to the team for resuming the review, too! Added the dependency,
does that look right?
"""
See the full comment at
https://g
URL: https://github.com/freeipa/freeipa/pull/337
Author: LiptonB
Title: #337: Client-side CSR autogeneration (take 2)
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/337/head:pr337
git checkout pr337
From
URL: https://github.com/freeipa/freeipa/pull/337
Author: LiptonB
Title: #337: Client-side CSR autogeneration (take 2)
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/337/head:pr337
git checkout pr337
From
URL: https://github.com/freeipa/freeipa/pull/10
Title: #10: Client-side CSR autogeneration
LiptonB commented:
"""
Updated to fix conflicts with master again. I'm not sure what's up with Travis,
it seems to be checking out PR #109 instead of this one for the pep8 check:
`
URL: https://github.com/freeipa/freeipa/pull/10
Title: #10: Client-side CSR autogeneration
LiptonB commented:
"""
Thanks, I've updated the code based on your comments (force pushed to fix
conflicts with master). And thanks for pointing out that email! I don't know
how I m
URL: https://github.com/freeipa/freeipa/pull/10
Title: #10: Client-side CSR autogeneration
LiptonB commented:
"""
@jcholast, when you get a chance, could you take another look at this and let
me know what else is needed?
"""
See the full comment at
https://gith
URL: https://github.com/freeipa/freeipa/pull/10
Title: #10: Client-side CSR autogeneration
LiptonB commented:
"""
`csrgen` sounds good to me. The new modules have now been moved to
`ipaclient.plugins.csrgen`, `ipaclient.csrgen`, and
`ipatests.test_ipaclient.test_csrgen`.
FYI:
LiptonB's pull request #10: "Client-side CSR autogeneration" was synchronized
See the full pull-request at https://github.com/freeipa/freeipa/pull/10
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/10/head:pr10
git checkout
LiptonB's pull request #10: "Client-side CSR autogeneration" was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/10
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/10/head:pr10
git checkout
LiptonB's pull request #10: "Client-side CSR autogeneration" was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/10
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/10/head:pr10
git checkout
LiptonB commented on a pull request
"""
I've added a commit (Use data_sources option to define which fields are
rendered) that simplifies the way we avoid rendering rules whose source data
are missing, as discussed here:
https://www.redhat.com/archives/freeipa-devel/2016-Sep
LiptonB's pull request #10: "Client-side CSR autogeneration" was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/10
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/10/head:pr10
git checkout
LiptonB commented on a pull request
"""
As discussed elsewhere, this script generation is a fairly low-level operation;
you have to specify the helper and know how to run the script. Most users will
probably want a command that just takes in a private key location and a profil
LiptonB's pull request #10: "Client-side CSR autogeneration" was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/10
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/10/head:pr10
git checkout
LiptonB's pull request #10: "Client-side CSR autogeneration" was synchronize
See the full pull-request at https://github.com/freeipa/freeipa/pull/10
... or pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/10/head:pr10
git checkout
49 matches
Mail list logo
