Re: [Freeipa-devel] Checking OCSP and CRL during certificate login

On 04/11/2017 03:24 PM, Rob Crittenden wrote: Pavel Vomacka wrote: Hello, With the recent addition of certificate mapping and certificate login support into WebUI, we need to handle also revoking of certificates which are used for login. There is ticket which requests this functionality

Re: [Freeipa-devel] Checking OCSP and CRL during certificate login

On 04/11/2017 02:16 PM, Alexander Bokovoy wrote: On ti, 11 huhti 2017, Pavel Vomacka wrote: Hello, With the recent addition of certificate mapping and certificate login support into WebUI, we need to handle also revoking of certificates which are used for login. There is ticket which

[Freeipa-devel] Checking OCSP and CRL during certificate login

Hello, With the recent addition of certificate mapping and certificate login support into WebUI, we need to handle also revoking of certificates which are used for login. There is ticket which requests this functionality: https://pagure.io/freeipa/issue/6370 We (me, David and Jan) are

Re: [Freeipa-devel] [PATCH] webui: 0084, 0101: refactoring rpc module

Moved to PR: https://github.com/freeipa/freeipa/pull/327 On 11/10/2016 07:47 PM, Petr Vobornik wrote: On 08/09/2016 01:29 PM, Pavel Vomacka wrote: Hello, please review attached patches. The rpc module is now separated from display layer and changing activity text while loading metadata

Re: [Freeipa-devel] [PATCH] 0102-0104: webui: Add support for setting custom table pagination size

I created PR for this https://github.com/freeipa/freeipa/pull/300 On 10/26/2016 09:55 AM, Martin Basti wrote: On 11.08.2016 16:18, Pavel Vomacka wrote: Hello, please review attached patches. https://fedorahosted.org/freeipa/ticket/5742 bump for review -- Pavel^3 Vomacka

Re: [Freeipa-devel] links to docs in the messages from code

On 10/13/2016 08:54 AM, Martin Basti wrote: On 12.10.2016 19:56, Petr Spacek wrote: Hello FreeIPA developers, looking at freeipa-users mailing list, a lot of questions could be answered by just quick glance to the docs. I wonder if we should add links HTML version of docs on

Re: [Freeipa-devel] [PATCH] webui: Fix coverity bugs

Bump for review. On 08/05/2016 02:33 PM, Pavel Vomacka wrote: On 08/01/2016 05:53 PM, Petr Vobornik wrote: On 07/29/2016 03:25 PM, Alexander Bokovoy wrote: On Fri, 29 Jul 2016, Pavel Vomacka wrote: Hello, please review attached patches which fixes errors from Coverity. -- Pavel^3

Re: [Freeipa-devel] [DESIGN][UPDATE] Time-Based HBAC Policies

On 08/16/2016 08:21 AM, Stanislav Laznicka wrote: On 08/12/2016 06:48 PM, Petr Spacek wrote: On 11.8.2016 12:34, Stanislav Laznicka wrote: Hello, I updated the design of the Time-Based HBAC Policies according to the discussion we led here earlier. Please check the design page

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

On 08/17/2016 02:42 PM, Pavel Vomacka wrote: On 08/11/2016 07:49 PM, Petr Vobornik wrote: On 08/11/2016 07:21 PM, Martin Basti wrote: On 11.08.2016 18:57, Pavel Vomacka wrote: On 08/11/2016 02:00 PM, Petr Vobornik wrote: On 08/11/2016 10:54 AM, Alexander Bokovoy wrote: On Thu, 11 Aug

Re: [Freeipa-devel] [PATCH 688] server install: do not prompt for cert file PIN repeatedly

On 08/17/2016 10:24 AM, Jan Cholasta wrote: Hi, the attached patch fixes . Honza ACK. -- Pavel^3 Vomacka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

On 08/11/2016 07:49 PM, Petr Vobornik wrote: On 08/11/2016 07:21 PM, Martin Basti wrote: On 11.08.2016 18:57, Pavel Vomacka wrote: On 08/11/2016 02:00 PM, Petr Vobornik wrote: On 08/11/2016 10:54 AM, Alexander Bokovoy wrote: On Thu, 11 Aug 2016, Jan Cholasta wrote: On 4.8.2016 17:27

Re: [Freeipa-devel] [PATCHES 681-682] cert: speed up cert-find, do not crash on invalid data in cert-find

On 08/12/2016 08:29 AM, Jan Cholasta wrote: On 11.8.2016 19:43, Martin Basti wrote: On 11.08.2016 16:09, Jan Cholasta wrote: On 11.8.2016 14:27, Martin Basti wrote: On 01.08.2016 10:27, Jan Cholasta wrote: On 1.8.2016 10:19, Jan Cholasta wrote: Hi, the attached patches fix

[Freeipa-devel] [PATCH] 0106, 0107: webui: add warning that only one CA server exists

Hello, Please review attached patches which adds warning that only one CA server is installed. https://fedorahosted.org/freeipa/ticket/5828 -- Pavel^3 Vomacka From 747702c89ee8ca482fa589ff331498881fad2224 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Tue,

Re: [Freeipa-devel] [PATCH] 0001 Added new authentication method

will send another patch witch updated commit message. -- Pavel^3 Vomacka From 6cb9d1152789c2d015b3a85ded622980241a2137 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Thu, 11 Aug 2016 18:53:55 +0200 Subject: [PATCH] Add 'trusted to auth as user' checkbox --- instal

[Freeipa-devel] [PATCH] 0102-0104: webui: Add support for setting custom table pagination size

Hello, please review attached patches. https://fedorahosted.org/freeipa/ticket/5742 -- Pavel^3 Vomacka From 0b4898eb7eed06c4e50f6b5606736d0023a58de5 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Thu, 11 Aug 2016 15:51:33 +0200 Subject: [PATCH 1/3] Add java

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

On 08/10/2016 07:55 AM, Jan Cholasta wrote: On 9.8.2016 13:00, Martin Basti wrote: On 05.08.2016 16:44, Martin Basti wrote: On 02.08.2016 18:08, Pavel Vomacka wrote: On 08/02/2016 05:31 PM, Pavel Vomacka wrote: On 08/02/2016 05:27 PM, Martin Basti wrote: On 02.08.2016 17:12, Rob

[Freeipa-devel] [PATCH] webui: 0084, 0101: refactoring rpc module

6,7 @@ define(['dojo/_base/declare', error: handler }; -IPA.display_activity_icon(); +topic.publish('rpc-start'); $.ajax(request); return d.promise; }, -- 2.5.5 From 2bf16885faaeb58d544c3a988fa7857cdd36d339 Mon

Re: [Freeipa-devel] [PATCH] 0100: Fix question marks in adders in topology graph

On 08/05/2016 02:15 PM, Pavel Vomacka wrote: Hello, Please review attached patch. https://fedorahosted.org/freeipa/ticket/6175 Changed commit message. -- Pavel^3 Vomacka From c792fbdf68e338c763079615595de68f63c0107a Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

On 08/02/2016 05:31 PM, Pavel Vomacka wrote: On 08/02/2016 05:27 PM, Martin Basti wrote: On 02.08.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote: Hello, please review attached patches which Split make lint to more targets and add jslint What's the driver to split the checks

Re: [Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

On 08/02/2016 05:27 PM, Martin Basti wrote: On 02.08.2016 17:12, Rob Crittenden wrote: Pavel Vomacka wrote: Hello, please review attached patches which Split make lint to more targets and add jslint What's the driver to split the checks out into separate targets? It is called

[Freeipa-devel] [PATCH]: 0098-99 : Split make lint to more targets and add jslint

Hello, please review attached patches which Split make lint to more targets and add jslint -- Pavel^3 Vomacka From f32919a910dc98301b373a47cc72f68b1310c0ee Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Tue, 2 Aug 2016 16:44:10 +0200 Subject: [PATCH 1/2]

Re: [Freeipa-devel] [PATCH] 0078-82: webui tests: tests for new certificate widget

On 07/28/2016 08:16 AM, Lenka Doudova wrote: On 07/20/2016 04:51 PM, Pavel Vomacka wrote: Please review attached patches, which add tests for new certificate widget in WebUI. https://fedorahosted.org/freeipa/ticket/6064 Hi, thanks for patches. Functionally ok, but you have lots

[Freeipa-devel] [PATCH] webui: Fix coverity bugs

Hello, please review attached patches which fixes errors from Coverity. -- Pavel^3 Vomacka From 0391289b3f6844897e2a9f3ae549bd4c33233ffc Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 25 Jul 2016 10:36:47 +0200 Subject: [PATCH 01/13] Coverity - null p

[Freeipa-devel] [PATCH] 0083: webui: remove full name column from user to user group adder dialog

Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Thu, 21 Jul 2016 17:44:50 +0200 Subject: [PATCH] Remove full name from adding user to user group dialog As the 'cn' is not in the response of user-show there is empty column in adder dialog. Therefore the column was removed.

[Freeipa-devel] [PATCH] 0078-82: webui tests: tests for new certificate widget

Please review attached patches, which add tests for new certificate widget in WebUI. https://fedorahosted.org/freeipa/ticket/6064 -- Pavel^3 Vomacka From 66879ea9d38ea42e2ac5641d0f89643edea83d16 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Wed, 20 Jul 2016 16

Re: [Freeipa-devel] [PATCH] webui test: bunch of patches which fix webui patches

On 07/11/2016 06:33 PM, Pavel Vomacka wrote: Hello, please review these patches. First four of them fixes patches and the last one fixes small bug in WebUI which causes that some tests fail. https://fedorahosted.org/freeipa/ticket/6050 https://fedorahosted.org/freeipa/ticket/6052 https

[Freeipa-devel] [PATCH] webui test: bunch of patches which fix webui patches

://fedorahosted.org/freeipa/ticket/6054 -- Pavel^3 Vomacka From 1f2bd1df86a27e732dd5414c4649d4a4a7f98eb8 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 11 Jul 2016 14:39:54 +0200 Subject: [PATCH 1/5] Close host adder dialog before showing 4304 dialog The adder

Re: [Freeipa-devel] [PATCH] pwpolicy: Do not expire passwords when maxlife is set to 0 (infinity).

ontime and krbPasswordExpiration thanks thierry On 06/30/2016 09:34 PM, David Kupka wrote: On 04/05/16 17:22, Pavel Vomacka wrote: On 05/04/2016 04:36 PM, Simo Sorce wrote: On Wed, 2016-05-04 at 15:39 +0200, Martin Kosek wrote: On 05/02/2016 02:28 PM, David Kupka wrote: https://fedorahost

Re: [Freeipa-devel] [PATCH] 0067-72: webui for kerberos aliases

On 06/30/2016 05:27 PM, Petr Vobornik wrote: On 06/30/2016 02:48 PM, Pavel Vomacka wrote: Hello, please review these patches. First two patches fix two minor bugs in custom_command_multivalued_widget. The rest of patches add webui for kerberos aliases. https://fedorahosted.org/freeipa

[Freeipa-devel] [PATCH] 0067-72: webui for kerberos aliases

:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Thu, 30 Jun 2016 14:32:27 +0200 Subject: [PATCH 1/6] Change error handling of remove command The custom_command_multivalued_widget handles remove command error correctly and shows errror message. Part of: https://fedorahosted.org/f

Re: [Freeipa-devel] [PATCH] 0062, 63: webui: Add button for 'server-del' command

On 06/29/2016 05:42 PM, Petr Vobornik wrote: On 06/24/2016 12:40 PM, Pavel Vomacka wrote: Hello, please review attached patches, they add 'Delete Server' button. 1. there is a whitespace warning while applying patch 63. 2. It breaks expectation of no_init. Instead of var

Re: [Freeipa-devel] [PATCH] 0064: webui: simplify confirmation messages in confirmation dialogs

On 06/29/2016 04:40 PM, Petr Vobornik wrote: On 06/27/2016 05:50 PM, Pavel Vomacka wrote: Hello, Please review attached patch which simplifies confirmation messages for 'remove cert hold' and 'restore cert' actions. I'd change: You can select a reason from the pull-down list

Re: [Freeipa-devel] [PATCH] 0061: webui: Add support for 'dns_update_system_records' command

On 06/28/2016 03:12 PM, Petr Spacek wrote: On 27.6.2016 17:48, Pavel Vomacka wrote: On 06/23/2016 04:58 PM, Petr Vobornik wrote: On 06/23/2016 04:34 PM, Martin Basti wrote: On 23.06.2016 09:57, Pavel Vomacka wrote: Hello, please review attached patch. Part of: https://fedorahosted.org

[Freeipa-devel] [PATCH] 0064: webui: simplify confirmation messages in confirmation dialogs

Hello, Please review attached patch which simplifies confirmation messages for 'remove cert hold' and 'restore cert' actions. -- Pavel^3 Vomacka From d3d10e8481be242dac5f66cc1ba6c622696a6758 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 27 Jun 2016 17

Re: [Freeipa-devel] [PATCH] 0061: webui: Add support for 'dns_update_system_records' command

On 06/23/2016 04:58 PM, Petr Vobornik wrote: On 06/23/2016 04:34 PM, Martin Basti wrote: On 23.06.2016 09:57, Pavel Vomacka wrote: Hello, please review attached patch. Part of: https://fedorahosted.org/freeipa/ticket/5905 Works for me In this patch and also in some other(cert

Re: [Freeipa-devel] [PATCH] 0018-0030, 52 webui: add support for more certificates

On 06/23/2016 03:17 PM, Petr Vobornik wrote: comments inline On 06/20/2016 02:37 PM, Pavel Vomacka wrote: On 06/14/2016 09:41 PM, Pavel Vomacka wrote: On 05/13/2016 06:56 PM, Petr Vobornik wrote: On 04/26/2016 04:23 PM, Pavel Vomacka wrote: Self-NACK for patches 0027, 28, 29, 30 - used

[Freeipa-devel] [PATCH] 0062, 63: webui: Add button for 'server-del' command

Hello, please review attached patches, they add 'Delete Server' button. -- Pavel^3 Vomacka From d8100e60bb7cf248f65191223e3e11340372d193 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Fri, 24 Jun 2016 12:07:03 +0200 Subject: [PATCH 1/2] Add support to change

[Freeipa-devel] [PATCH] 0061: webui: Add support for 'dns_update_system_records' command

Hello, please review attached patch. Part of: https://fedorahosted.org/freeipa/ticket/5905 -- Pavel^3 Vomacka From d8efa6ec479f61bde2dce321337d1ac6b8c75f74 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Wed, 22 Jun 2016 18:13:27 +0200 Subject: [PATCH] Add

[Freeipa-devel] [PATCH] 0060: webui: Add dnsdefaultttl field on DNS Zone config page

Hello, please review the attached patch. It is counterpart of: https://fedorahosted.org/freeipa/ticket/2956 -- Pavel^3 Vomacka From 9ac60ab982aceff128542c3ca1c91f250347b464 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Tue, 21 Jun 2016 15:43:18 +0200 Subject:

[Freeipa-devel] [PATCH] 0054-55: WebUI: extend DNS and trust config pages

Hello, please review attached patches - they extend DNS and trust config pages. https://fedorahosted.org/freeipa/ticket/5906 -- Pavel^3 Vomacka From 8b637991feda190c53430d0f281eafab5d6f5250 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Wed, 15 Jun 2016 17:43:13

Re: [Freeipa-devel] [PATCH 0162] Do not update result of *-config-show with empty server attributes

On 06/20/2016 03:35 PM, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5960 Hello, thank you for the patch, it works for me. But I didn't do the code review. -- Pavel^3 Vomacka -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCHES 551-552, 623-624] cert: add owner information, allow search by certificate

: On 6.4.2016 15:46, Pavel Vomacka wrote: On 03/16/2016 01:50 PM, Jan Cholasta wrote: Hi, the attached patches implement the server-side part of <https://fedorahosted.org/freeipa/ticket/5381>. Honza Hi, thank you for the patches. I tested them and they work well. But I would like to ask you w

[Freeipa-devel] [PATCH] 0059: webui: make 'Actions' strings translatable

Hello, please review attached patch. -- Pavel^3 Vomacka From ff35b4ae33714783c42751f917e2c21fd390cbd7 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 20 Jun 2016 20:43:26 +0200 Subject: [PATCH] Make Actions string translatable Remove hardcoded strings 'A

[Freeipa-devel] [PATCH] 0058 WebUI: certificate widget on ID override user page

Hello, please review attached patch. https://fedorahosted.org/freeipa/ticket/5926 -- Pavel^3 Vomacka From aa6ef0a9b51d8c2d955399a044d1ee90cc6f936e Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Fri, 17 Jun 2016 10:05:52 +0200 Subject: [PATCH] Add certificate

Re: [Freeipa-devel] [PATCH] 0048-50: webui: extend topology graph functionality

On 06/13/2016 10:48 AM, Pavel Vomacka wrote: Hello, please review attached patches which extend topology graph functionality. First two add possibility to create agreement using mouse and the third one adds 'Autogenerated' placeholder. 0047,48: https://fedorahosted.org/freeipa/ticket/5648

Re: [Freeipa-devel] [PATCH] 0056 webui: Counterpart of dnsserver-{find, show, mod}

On 06/16/2016 12:06 PM, Pavel Vomacka wrote: Hello, please review attached patch. https://fedorahosted.org/freeipa/ticket/5905 Fixed commit message -- Pavel^3 Vomacka From c61e0dd9190be2537ecd8da0a4fa5c0ace81a81e Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Dat

[Freeipa-devel] [PATCH] 0056 webui: Counterpart of dnsserver-{find, show, mod}

Hello, please review attached patch. https://fedorahosted.org/freeipa/ticket/5905 -- Pavel^3 Vomacka From 16270e37ce76796e76513270f5833241d4f5c892 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Thu, 16 Jun 2016 10:09:36 +0200 Subject: [PATCH] DNS Servers: Web U

[Freeipa-devel] [PATCH] 0053: webui: allow to set weight of server without location

:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Fri, 10 Jun 2016 09:39:36 +0200 Subject: [PATCH] Allow to set weight of a server without location There was a bug when a new server was added it was not possible to set weight until a location was set. This change corrects it and

Re: [Freeipa-devel] [PATCH] 0045-47: webui: Sub-CAs

On 06/14/2016 06:42 AM, Fraser Tweedale wrote: On Mon, Jun 13, 2016 at 07:48:58PM +0200, Pavel Vomacka wrote: On 06/13/2016 06:55 AM, Fraser Tweedale wrote: On Fri, Jun 10, 2016 at 04:34:33PM +0200, Pavel Vomacka wrote: Hello, please review these new patches which add WebUI for Sub-CAs

Re: [Freeipa-devel] [PATCH] 0045-47: webui: Sub-CAs

On 06/13/2016 06:55 AM, Fraser Tweedale wrote: On Fri, Jun 10, 2016 at 04:34:33PM +0200, Pavel Vomacka wrote: Hello, please review these new patches which add WebUI for Sub-CAs. https://fedorahosted.org/freeipa/ticket/5939 Hi Pavel, I have reviewed the functionality of the patches

Re: [Freeipa-devel] [PATCH] 0051: webui: correct jslint warning

On 06/13/2016 12:00 PM, Pavel Vomacka wrote: Hello, I forgot to run jslint during the last review and there was one warning, so this patch fixes it. -- Pavel^3 Vomacka Added ticket to the commit message. From 21a8d78e680e06389b17447ecac34fa1042bda2e Mon Sep 17 00:00:00 2001 From

Re: [Freeipa-devel] [PATCH] 0208-0209 webUI changes for external trust and UPN suffixes

On 06/09/2016 02:19 PM, Alexander Bokovoy wrote: On Thu, 09 Jun 2016, Sumit Bose wrote: On Thu, Jun 09, 2016 at 02:30:52PM +0300, Alexander Bokovoy wrote: Hi, webUI changes to support external trust and showing UPN suffixes are attached. UPN Suffixes defined on AD side and fetched with

[Freeipa-devel] [PATCH] 0045-47: webui: Sub-CAs

Hello, please review these new patches which add WebUI for Sub-CAs. https://fedorahosted.org/freeipa/ticket/5939 -- Pavel^3 Vomacka From e76324180aa9518a93867fd6c9daa50a8fa79c1f Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Fri, 10 Jun 2016 16:12:45 +0200 S

Re: [Freeipa-devel] [PATCH] 0036-38 webui: Server roles

On 06/08/2016 04:09 PM, Petr Vobornik wrote: On 06/05/2016 07:22 PM, Pavel Vomacka wrote: On 06/03/2016 03:10 PM, Petr Vobornik wrote: On 06/02/2016 01:40 PM, Pavel Vomacka wrote: Hello, please review my patches which add webui for server roles. Did not test yet. I'm waiting for rebase

Re: [Freeipa-devel] [PATCH] 0041: webui: add create/retrieve keytab tables for hosts

On 06/09/2016 02:03 PM, Petr Vobornik wrote: On 06/08/2016 03:32 PM, Pavel Vomacka wrote: On 06/08/2016 02:20 PM, Petr Vobornik wrote: On 06/06/2016 04:17 PM, Pavel Vomacka wrote: Hello, please review attached patch. Ticket: https://fedorahosted.org/freeipa/ticket/5931 Also tables

Re: [Freeipa-devel] [PATCH] 0039-40: DNS Location: WebUI

On 06/09/2016 10:44 AM, Pavel Vomacka wrote: On 06/09/2016 10:15 AM, Pavel Vomacka wrote: On 06/08/2016 04:40 PM, Petr Vobornik wrote: On 06/07/2016 10:07 AM, Pavel Vomacka wrote: On 06/06/2016 07:51 PM, Martin Basti wrote: On 05.06.2016 18:34, Pavel Vomacka wrote: Hello, please

Re: [Freeipa-devel] [PATCH] 0042: Fix bad searching of reverse DNS zone

On 06/08/2016 06:36 PM, Petr Vobornik wrote: On 06/07/2016 10:30 AM, Pavel Vomacka wrote: On 06/07/2016 09:08 AM, Petr Spacek wrote: Hi, the commit message does not say what was wrong and why and what works now. Please improve the commit message before pushing this. Commit message

Re: [Freeipa-devel] [PATCH] 0039-40: DNS Location: WebUI

On 06/09/2016 10:15 AM, Pavel Vomacka wrote: On 06/08/2016 04:40 PM, Petr Vobornik wrote: On 06/07/2016 10:07 AM, Pavel Vomacka wrote: On 06/06/2016 07:51 PM, Martin Basti wrote: On 05.06.2016 18:34, Pavel Vomacka wrote: Hello, please review attached patches which add WebUI part

Re: [Freeipa-devel] [PATCH] 0039-40: DNS Location: WebUI

On 06/08/2016 04:40 PM, Petr Vobornik wrote: On 06/07/2016 10:07 AM, Pavel Vomacka wrote: On 06/06/2016 07:51 PM, Martin Basti wrote: On 05.06.2016 18:34, Pavel Vomacka wrote: Hello, please review attached patches which add WebUI part of DNS Locations feature. -- Pavel^3 Vomacka

Re: [Freeipa-devel] [PATCH] 0041: webui: add create/retrieve keytab tables for hosts

On 06/08/2016 02:20 PM, Petr Vobornik wrote: On 06/06/2016 04:17 PM, Pavel Vomacka wrote: Hello, please review attached patch. Ticket: https://fedorahosted.org/freeipa/ticket/5931 Also tables for host groups are needed. + the same UI should be also on host page. Added, please see

Re: [Freeipa-devel] [PATCH] 0059..0064 Lightweight sub-CAs

On 06/08/2016 01:21 PM, Pavel Vomacka wrote: On 06/08/2016 05:15 AM, Fraser Tweedale wrote: On Tue, Jun 07, 2016 at 03:42:22PM +1000, Fraser Tweedale wrote: On Wed, Jun 01, 2016 at 02:51:04PM +1000, Fraser Tweedale wrote: Hi team, This patchset implements the 'ca' plugin for creating

Re: [Freeipa-devel] [PATCH] 0059..0064 Lightweight sub-CAs

On 06/08/2016 05:15 AM, Fraser Tweedale wrote: On Tue, Jun 07, 2016 at 03:42:22PM +1000, Fraser Tweedale wrote: On Wed, Jun 01, 2016 at 02:51:04PM +1000, Fraser Tweedale wrote: Hi team, This patchset implements the 'ca' plugin for creating and managing lightweight sub-CAs, and updates the

Re: [Freeipa-devel] [PATCHES 0146-0152] Server Roles v2

On 06/07/2016 12:07 PM, Martin Babinsky wrote: On 06/03/2016 05:25 PM, Martin Babinsky wrote: I am sending rebased patches implementing http://www.freeipa.org/page/V4/Server_Roles I hope the patches work since I have had a lot of fun rebasing them on top of thin client and DNS locations

Re: [Freeipa-devel] [PATCH 0499] Pylint: exclude some files/dirs from check

On 06/06/2016 04:26 PM, Martin Basti wrote: See commit message, yacctab.py causes lint errors and must be excluded Patch attached. Works well, ACK. -- Pavel^3 Vomacka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0042: Fix bad searching of reverse DNS zone

On 06/07/2016 09:08 AM, Petr Spacek wrote: Hi, the commit message does not say what was wrong and why and what works now. Please improve the commit message before pushing this. Commit message improved. Petr^2 Spacek On 6.6.2016 19:03, Pavel Vomacka wrote: Fix bad searching of reverse DNS

Re: [Freeipa-devel] [PATCH] 0039-40: DNS Location: WebUI

On 06/06/2016 07:51 PM, Martin Basti wrote: On 05.06.2016 18:34, Pavel Vomacka wrote: Hello, please review attached patches which add WebUI part of DNS Locations feature. -- Pavel^3 Vomacka NACK 1) When I edit location description and click on revert button, then that nice

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

On 06/06/2016 07:03 PM, Petr Vobornik wrote: On 06/06/2016 12:27 PM, Pavel Vomacka wrote: On 06/02/2016 06:22 PM, Petr Vobornik wrote: On 06/01/2016 10:41 AM, Pavel Vomacka wrote: On 05/27/2016 05:58 PM, Pavel Vomacka wrote: On 05/27/2016 05:44 PM, Nathaniel McCallum wrote: On Fri, 2016

[Freeipa-devel] [PATCH] 0042: Fix bad searching of reverse DNS zone

Fix bad searching of reverse DNS zone https://fedorahosted.org/freeipa/ticket/5796 -- Pavel^3 Vomacka From ff1e9d9930146ae998bec34e739d0cd8a1fdaa55 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 6 Jun 2016 18:56:03 +0200 Subject: [PATCH] Fix bad sea

[Freeipa-devel] [PATCH] 0041: webui: add create/retrieve keytab tables for hosts

Hello, please review attached patch. Ticket: https://fedorahosted.org/freeipa/ticket/5931 -- Pavel^3 Vomacka From bef7a296008a32b981d78d521ce452e06b8b59c8 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 6 Jun 2016 12:59:24 +0200 Subject: [PATCH] Add

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

On 06/02/2016 06:22 PM, Petr Vobornik wrote: On 06/01/2016 10:41 AM, Pavel Vomacka wrote: On 05/27/2016 05:58 PM, Pavel Vomacka wrote: On 05/27/2016 05:44 PM, Nathaniel McCallum wrote: On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote: On 05/12/2016 11:13 PM, Nathaniel McCallum

Re: [Freeipa-devel] [PATCH] 0036-38 webui: Server roles

On 06/03/2016 03:10 PM, Petr Vobornik wrote: On 06/02/2016 01:40 PM, Pavel Vomacka wrote: Hello, please review my patches which add webui for server roles. Did not test yet. I'm waiting for rebase of backend. Patch 36: ACK (assuming it works when ^^ is available) Patch 37: 1. typo

[Freeipa-devel] [PATCH] 0039-40: DNS Location: WebUI

Hello, please review attached patches which add WebUI part of DNS Locations feature. -- Pavel^3 Vomacka From b2e30e910608d8be549e126889ff9a011149f58b Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Sun, 5 Jun 2016 18:03:17 +0200 Subject: [PATCH 1/2] Add a

Re: [Freeipa-devel] [PATCH] 0013, 0017 webui: Add ability to convert users from preserved to staged state

On 06/02/2016 06:45 PM, Petr Vobornik wrote: On 04/20/2016 07:05 PM, Pavel Vomacka wrote: On 04/15/2016 06:44 PM, Petr Vobornik wrote: On 04/13/2016 02:56 PM, Pavel Vomacka wrote: Hello, This patch adds ability to convert users from preserved to staged state. Fixes this ticket:https

Re: [Freeipa-devel] [PATCH 0473-0476, 0478-0482]DNS Locations: Prologue

On 06/02/2016 02:20 PM, Jan Cholasta wrote: On 2.6.2016 14:06, Petr Spacek wrote: On 1.6.2016 18:00, Martin Basti wrote: updated patches attached freeipa-mbasti-0473.6-DNS-Locations-Always-create-DNS-related-privileges.patch From 549379a36281d80818fca4ec929d499efafda044 Mon Sep 17

Re: [Freeipa-devel] [PATCH 0149-0152] Server Roles: user-facing part

On 05/30/2016 07:13 PM, Martin Babinsky wrote: These patches implement the usable part of Server Roles design. There might be some discrepancies between the design and actual implementation, I was head first in hacking and was not very disciplined in keeping the design up to date. I will

[Freeipa-devel] [PATCH] 0036-38 webui: Server roles

Hello, please review my patches which add webui for server roles. -- Pavel^3 Vomacka From 142e46045f6fe4f64ce20a1b822508fece767579 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Thu, 2 Jun 2016 13:07:00 +0200 Subject: [PATCH 1/3] Association table can be rea

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

On 05/27/2016 05:58 PM, Pavel Vomacka wrote: On 05/27/2016 05:44 PM, Nathaniel McCallum wrote: On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote: On 05/12/2016 11:13 PM, Nathaniel McCallum wrote: On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote: Hi, the patch adds webui part

Re: [Freeipa-devel] [WIP] Thin client

On 05/30/2016 08:28 AM, Jan Cholasta wrote: On 28.5.2016 18:33, Pavel Vomacka wrote: On 05/27/2016 10:33 AM, Petr Spacek wrote: On 27.5.2016 09:26, Martin Basti wrote: On 27.05.2016 07:49, Jan Cholasta wrote: On 26.5.2016 18:43, Martin Basti wrote: On 26.05.2016 11:21, Martin Basti

Re: [Freeipa-devel] [WIP] Thin client

On 05/27/2016 10:33 AM, Petr Spacek wrote: On 27.5.2016 09:26, Martin Basti wrote: On 27.05.2016 07:49, Jan Cholasta wrote: On 26.5.2016 18:43, Martin Basti wrote: On 26.05.2016 11:21, Martin Basti wrote: On 26.05.2016 07:15, Jan Cholasta wrote: On 25.5.2016 18:17, Martin Basti wrote:

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

On 05/27/2016 05:44 PM, Nathaniel McCallum wrote: On Fri, 2016-05-27 at 17:43 +0200, Pavel Vomacka wrote: On 05/12/2016 11:13 PM, Nathaniel McCallum wrote: On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote: Hi, the patch adds webui part for authentication indicators. Ticket: https

Re: [Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

On 05/12/2016 11:13 PM, Nathaniel McCallum wrote: On Wed, 2016-05-11 at 13:08 +0200, Pavel Vomacka wrote: Hi, the patch adds webui part for authentication indicators. Ticket: https://fedorahosted.org/freeipa/ticket/5872 The otp option displays as: OTP. The radius option displays as: Radius

[Freeipa-devel] [PATCH] 0035: webui: change Restore cert to Remove cert hold

Hi, please review attached patch. It change Restore certificate strings to Remove certificate hold to be consistent with CLI. https://fedorahosted.org/freeipa/ticket/5878 -- Pavel^3 Vomacka From bd0c90c5c52120a5cc7989fd2e6160a13a845ee4 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pv

Re: [Freeipa-devel] [PATCH] 0011 webui: Offer OTP generation for host enrollment in the UI

On 05/11/2016 03:28 PM, Petr Vobornik wrote: On 03/31/2016 04:59 PM, Pavel Vomacka wrote: Hello, This patch adds option to add host dialog which allows to show generated OTP. The patch also changes the way of informing user about success of adding host but only when the 'Generate OTP' option

Re: [Freeipa-devel] [PATCHES 0089-0093] Authentication Indicators

On 05/06/2016 02:44 PM, Sumit Bose wrote: On Wed, May 04, 2016 at 05:33:55PM -0400, Nathaniel McCallum wrote: This series of patches implements authentication indicator insertion, evaluation and management in FreeIPA. Besides these patches, two other patches are needed to round out support.

[Freeipa-devel] [PATCH] 0034: webui: Authentication indicators

Hi, the patch adds webui part for authentication indicators. Ticket: https://fedorahosted.org/freeipa/ticket/5872 -- Pavel^3 Vomacka From 912519a2d1a834763f553c2b7b254d8908d85122 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Wed, 11 May 2016 12:54:43 +0200 S

[Freeipa-devel] [PATCH] 0033 webui: Mention SAN names in 'Issue new certificate'

:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Mon, 25 Apr 2016 09:38:30 +0200 Subject: [PATCH] Extend the certificate request dialog The command for requesting certificate for hosts and services is extended. There is added how to add DNS name as subjectAltName. https://fedorahosted.or

Re: [Freeipa-devel] [PATCH] pwpolicy: Do not expire passwords when maxlife is set to 0 (infinity).

On 05/04/2016 04:36 PM, Simo Sorce wrote: On Wed, 2016-05-04 at 15:39 +0200, Martin Kosek wrote: On 05/02/2016 02:28 PM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/2795 That patch looks suspiciously short given the struggles I saw in

[Freeipa-devel] [PATCH] 0032 webui: change lang.hitch to the javascript bind method

Hi, please review the attached patch. https://fedorahosted.org/freeipa/ticket/5702 -- Pavel^3 Vomacka From 0e197613accb6ac94563507d67477fc8b5851767 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Fri, 29 Apr 2016 15:02:18 +0200 Subject: [PATCH] Change lang

Re: [Freeipa-devel] [PATCH] Added fix for notifying user about locked user account in WebUI

On 04/20/2016 07:52 AM, Abhijeet Kasurde wrote: Hi All, Please review this patch. Fixes : https://fedorahosted.org/freeipa/ticket/5076 Thanks, Abhijeet Kasurde Hi, Javascript part LGTM. -- Pavel^3 Vomacka -- Manage your subscription for the Freeipa-devel mailing list:

[Freeipa-devel] [PATCH] 0031 webui: add ability to review certificate request dialog

Hi please review the attached patch. Fixes this ticket: https://fedorahosted.org/freeipa/ticket/5652 -- Pavel^3 Vomacka From e9dcb0e1c1f7e557f336c0d7346047442824a962 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Tue, 26 Apr 2016 14:55:54 +0200 Subject: [PATC

Re: [Freeipa-devel] [PATCH] Added warning to user for Internet Explorer

On 04/25/2016 01:00 PM, Abhijeet Kasurde wrote: Hi All, Please review the attached patch. Thanks, Abhijeet Kasurde Hi, thank you for the patch, ACK. -- Pavel^3 Vomacka -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 0018-0030 webui: add support for more certificates

Self-NACK for patches 0027, 28, 29, 30 - used incorrect policy. I also attach all patches which were not changed - it is easier to get the whole patchset. On 04/26/2016 02:02 PM, Pavel Vomacka wrote: I forgot to mention that my patches requires patches from : https://www.redhat.com/archives

[Freeipa-devel] [PATCH] 0018-0030 webui: add support for more certificates

/freeipa/ticket/5776 -- Pavel^3 Vomacka From 7a0f73dd7f103b3ac4f4d28af2f0cb6654a6d95f Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Fri, 22 Apr 2016 10:22:30 +0200 Subject: [PATCH 01/13] Add support for dropdown menu in multivalued widget Every single widget

Re: [Freeipa-devel] [PATCH] 0013, 0017 webui: Add ability to convert users from preserved to staged state

On 04/15/2016 06:44 PM, Petr Vobornik wrote: On 04/13/2016 02:56 PM, Pavel Vomacka wrote: Hello, This patch adds ability to convert users from preserved to staged state. Fixes this ticket: https://fedorahosted.org/freeipa/ticket/5371 -- Pavel^3 Vomacka The patch requires rebase

Re: [Freeipa-devel] [PATCH] 0015, 16 webui: Add 'Skip overlap check' checkbox to the dns adder dialogs

On 04/14/2016 02:03 PM, Martin Basti wrote: On 14.04.2016 13:03, Pavel Vomacka wrote: Hello, The first patch (0015) adds the checkbox to the dns zone adder dialog. The second patch (0016) adds the 'skip overlap check' checkbox to the dns forward zone adder dialog. This patch requires

Re: [Freeipa-devel] [PATCH] 0009 webui: Show certificates in useful format

On 04/15/2016 03:42 PM, Petr Vobornik wrote: On 03/30/2016 12:46 PM, Pavel Vomacka wrote: On 03/29/2016 11:42 AM, Pavel Vomacka wrote: On 03/16/2016 06:56 PM, Petr Vobornik wrote: On 03/15/2016 01:23 PM, Pavel Vomacka wrote: Hello, patch for https://fedorahosted.org/freeipa/ticket/5311

[Freeipa-devel] [PATCH] 0015, 16 webui: Add 'Skip overlap check' checkbox to the dns adder dialogs

shouldn't contain that checkbox. -- Pavel^3 Vomacka >From f1ce4ef65fbfd1f4f05c34b4bb89e0de294fa909 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Thu, 14 Apr 2016 12:21:49 +0200 Subject: [PATCH] Add 'skip overlap check' checkbox into add zone dial

[Freeipa-devel] [PATCH] 0014 webui: Update delete dialog on active user details page

17 00:00:00 2001 From: Pavel Vomacka <pvoma...@redhat.com> Date: Sun, 10 Apr 2016 23:46:15 +0200 Subject: [PATCH] Update the delete dialog on details user page Add option to preserve user to the delete dialog on active user's details page. The delete dialog is the same as on the page of a

Re: [Freeipa-devel] [PATCHES 551-552] ipalib: add basecert plugins

On 03/16/2016 01:50 PM, Jan Cholasta wrote: Hi, the attached patches implement the server-side part of . Honza Hi, thank you for the patches. I tested them and they work well. But I would like to ask you whether would be possible to extend

Re: [Freeipa-devel] [TESTS][PATCH 0011] WebUI: Creating user without private group

On 03/31/2016 04:16 PM, Lenka Doudova wrote: On 03/31/2016 12:42 PM, Pavel Vomacka wrote: On 03/18/2016 11:24 AM, Lenka Doudova wrote: On 03/10/2016 06:58 PM, Petr Vobornik wrote: On 03/08/2016 01:17 PM, Lenka Doudova wrote: On 03/08/2016 12:59 PM, Petr Vobornik wrote: On 03/07

  1   2   >