URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
pspacek commented:
"""
Works for me, server installation including DNSSEC worked fine.
"""
See the full comment at
https://github.com/freeipa/freeipa/p
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/358
Title: #358: Use the tar Posix option for tarballs
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/358
Title: #358: Use the tar Posix option for tarballs
pspacek commented:
"""
Thanks, ACK!
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/358#issuecomment-268527273
--
Manage your subscription
URL: https://github.com/freeipa/freeipa/pull/358
Title: #358: Use the tar Posix option for tarballs
pspacek commented:
"""
CondACK if the message is corrected.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/358#issuecomment-26845716
URL: https://github.com/freeipa/freeipa/pull/358
Title: #358: Use the tar Posix option for tarballs
pspacek commented:
"""
Please add a note *why* it is necessary. Something like "ustar format we used
before could not handle files with > 65535" or so. This will help
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/6
Title: #6: handle termination of syncrepl watcher thread
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/6
Title: #6: handle termination of syncrepl watcher thread
pspacek commented:
"""
We are almost there. Just minor changes will make it perfect :-)
"""
See the full comment at
https://github.com/freeipa/bind-
URL: https://github.com/freeipa/freeipa/pull/279
Title: #279: installer: Stop adding distro-specific NTP servers into ntp.conf
pspacek commented:
"""
ACK
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/279#issuecomment-267986862
--
Manage you
URL: https://github.com/freeipa/freeipa/pull/352
Author: pspacek
Title: #352: Clarify meaning of --domain and --realm in installers
Action: opened
PR body:
"""
Man pages need bigger overhaul. Take this as hot-fix for FAQ.
https://fedorahosted.org/freeipa/ticket/6574
&quo
URL: https://github.com/freeipa/freeipa/pull/347
Title: #347: Improvements in {get|set}_directive functions
pspacek commented:
"""
Please see my in-line comments.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/347#issuecomment-26789916
URL: https://github.com/freeipa/freeipa/pull/333
Author: pspacek
Title: #333: Remove named-pkcs11 workarounds from DNSSEC tests.
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/333/head:pr333
git checkout
URL: https://github.com/freeipa/freeipa/pull/333
Author: pspacek
Title: #333: Remove named-pkcs11 workarounds from DNSSEC tests.
Action: opened
PR body:
"""
As far as I can tell the tests are passing for some time in Jenkins so
maybe a bug in some underlying component was fixe
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/5
Author: pspacek
Title: #5: Add GDB pretty-printers for plugin data structures to contrib.
Action: opened
PR body:
"""
These are convenience scripts I created over time to ease digging in
bind-dyndb-ldap data structures
URL: https://github.com/freeipa/freeipa/pull/330
Author: pspacek
Title: #330: Build: forbid builds in working directories containing white
spaces
Action: opened
PR body:
"""
Spaces are causing problems in libtool, makefiles, autoconf itself, gettextize
framework etc. so th
URL: https://github.com/freeipa/freeipa/pull/272
Author: pspacek
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same
time
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
I've found the root cause - incorrect order of operations in freeipa.spec.in.
Now it should work.
""&quo
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
pspacek commented:
"""
Talk is cheap so here is the code!
~~~
import math
import string
import random
class TokenGenerator(object):
"""Tunable tok
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
pspacek commented:
"""
The main problem here is that we are mixing two approaches together, i.e.
entropy specification using bits + specification using character classes e
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
pspacek commented:
"""
@mbasti-rh You are missing the point and thus do not answer my question: The
docstring does not tell anything about relation of 'entropy' and th
URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA
pspacek commented:
"""
Guys, I'm confused. What exactly is the purpose of `TokenGenerator`? The
docstring does not explain to me what is relation between argument
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
To be sure I re-built RPMs from this PR using `makerpms.sh` script. My findings
are:
- `/usr/bin/ipa-run-tests` is a symli
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
Relevant parts of SPEC file are here:
https://github.com/freeipa/freeipa/pull/272/commits/684f4f5d4fbcfc62c555f7ef85
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
`make install` will install whatever is auto-detected during configure (or
overriden by `$PYTHON` variable while ca
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
@martbab Can I do something in the build system to make your CI implementation
easier?
"""
See the f
URL: https://github.com/freeipa/freeipa/pull/307
Title: #307: Lowered the version of gettext
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
I've synchronized `python-cryptography` and `python-gssapi` versions. Thank you
for noticing. Let's see if CI tests pa
URL: https://github.com/freeipa/freeipa/pull/272
Author: pspacek
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same
time
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull
URL: https://github.com/freeipa/freeipa/pull/307
Title: #307: Lowered the version of gettext
pspacek commented:
"""
@pvomacka Pavel, you did not remove the `po/Rules-quot` file. Adding it to
`.gitignore` is not enough.
NACK (sorry for messing with the label, too fat fingers)
&q
URL: https://github.com/freeipa/freeipa/pull/307
Title: #307: Lowered the version of gettext
Label: -ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/307
Title: #307: Lowered the version of gettext
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
I've implemented tiran's proposal and rebased the patchset.
"""
See the full comment at
https://g
URL: https://github.com/freeipa/freeipa/pull/272
Author: pspacek
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same
time
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
I'm fine with `make pylint PYTHON=python3` as long as you can agree on it :-)
"""
See the full comment at
URL: https://github.com/freeipa/freeipa/pull/314
Title: #314: RFC: privilege separation for ipa framework code
pspacek commented:
"""
@simo5 Please extend the design page with image description which explains each
of the steps. There are numbers and letters in
URL: https://github.com/freeipa/freeipa/pull/279
Title: #279: installer: Stop adding distro-specific NTP servers into ntp.conf
pspacek commented:
"""
NACK
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/279#issuecomment-26508409
URL: https://github.com/freeipa/freeipa/pull/309
Title: #309: ipa-replica-conncheck: fix race condition
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/307
Title: #307: Lowered the version of gettext
pspacek commented:
"""
If the file `Rules-quot` is generated by `autoreconf -i`, please remove it
completely and add it into `.gitignore`.
"""
See the full comment
URL: https://github.com/freeipa/freeipa/pull/306
Title: #306: Ignore backup~ files like config.h.in~
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/304
Title: #304: Relax check for .git to support freeipa in submodules
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/1
Title: #1: Port bind-dyndb-ldap to BIND 9.11
pspacek commented:
"""
Pushed to master:
2649ef1da1cbfc1203337665c4e589e1fe75f04b BIND 9.11: Remove #if blocks for older
BIND versions.
8178f3cf856829c081a663a2e3f4d77ecc2db6b1
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/1
Author: pspacek
Title: #1: Port bind-dyndb-ldap to BIND 9.11
Action: closed
To pull the PR as Git branch:
git remote add ghbind-dyndb-ldap https://github.com/freeipa/bind-dyndb-ldap
git fetch ghbind-dyndb-ldap pull/1/head:pr1
git checkout
URL: https://github.com/freeipa/freeipa/pull/284
Title: #284: ipautil: check for open ports on all resolved IPs
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/267
Title: #267: ipa-replica-conncheck: do not close listening ports until required
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
@mbasti-rh @jcholast @tiran
If you want I can replace the `--with-pytlint` option with `--enable-pylint`
option (without
URL: https://github.com/freeipa/freeipa/pull/272
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same time
pspacek commented:
"""
Fixed. Now `with_pylint` section contains nested section `with_python3`.
"""
See the full comment at
https
URL: https://github.com/freeipa/freeipa/pull/272
Author: pspacek
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same
time
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull
URL: https://github.com/freeipa/freeipa/pull/281
Title: #281: Accept server host names resolvable only using /etc/hosts
pspacek commented:
"""
`--no-host-dns` disables all checks (theoretically) so it should be used only
in special cases. Given it acts as kind of force sw
URL: https://github.com/freeipa/freeipa/pull/281
Title: #281: Accept server host names resolvable only using /etc/hosts
pspacek commented:
"""
This entierly depens on configuration. Imagine following imaginary company
setup:
- public part of DNS tree is `example.com.`
- priv
URL: https://github.com/freeipa/freeipa/pull/279
Title: #279: installer: Stop adding distro-specific NTP servers into ntp.conf
pspacek commented:
"""
Have you tested the code? I would bet that it will remove everything except
127.127... from the list of servers.
"&quo
URL: https://github.com/freeipa/freeipa/pull/279
Title: #279: installer: Stop adding distro-specific NTP servers into ntp.conf
pspacek commented:
"""
NACK
```
Pylint is running, please wait ...
* Module ipaserver.install.ntpinstance
ipaserver/install/ntpinstance.py:23
URL: https://github.com/freeipa/freeipa/pull/281
Author: pspacek
Title: #281: Accept server host names resolvable only using /etc/hosts
Action: opened
PR body:
"""
Apparently "files" implementation of hosts NSS database cannot deal with
trailing period in hos
URL: https://github.com/freeipa/freeipa/pull/213
Author: pspacek
Title: #213: Build system refactoring phase 3
Action: edited
Changed field: body
Original value:
"""
This monster patch-set refactors most of build system and moves most of the
logic from SPEC file
URL: https://github.com/freeipa/freeipa/pull/268
Title: #268: Build system must regenerate file when template changes
pspacek commented:
"""
Oh, you are right, I was mixing `CONFIG_STATUS_DEPEDENCIES` and
`AC_CONFIG_FILES`. Sorry!
So please let me explain the problem with `
URL: https://github.com/freeipa/freeipa/pull/268
Title: #268: Build system must regenerate file when template changes
pspacek commented:
"""
I already described problems with `AC_CONFIG_FILE` in
https://github.com/freeipa/freeipa/pull/251#issuecomment-261470338 a week
URL: https://github.com/freeipa/freeipa/pull/273
Author: pspacek
Title: #273: Build: workaround bug while calling parallel make from rpmbuild
Action: opened
PR body:
"""
https://fedorahosted.org/freeipa/ticket/6418
"""
To pull the PR as Git branch:
git remote ad
URL: https://github.com/freeipa/freeipa/pull/213
Author: pspacek
Title: #213: Build system refactoring phase 3
Action: edited
Changed field: body
Original value:
"""
This monster patch-set refactors most of build system and moves most of the
logic from SPEC file
URL: https://github.com/freeipa/freeipa/pull/272
Author: pspacek
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same
time
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull
URL: https://github.com/freeipa/freeipa/pull/272
Author: pspacek
Title: #272: Build: makerpms.sh generates Python 2 & 3 packages at the same
time
Action: opened
PR body:
"""
Petr Viktorin recommended me to copy the whole build directory and run
configure twice, wi
URL: https://github.com/freeipa/freeipa/pull/113
Title: #113: ipalib.constants: Remove default domain, realm, basedn,
xmlrpc_uri, ldap_uri
pspacek commented:
"""
Honza will take care of this as part of ipalib cleanup for the Integration
Improvements project.
"&quo
URL: https://github.com/freeipa/freeipa/pull/268
Author: pspacek
Title: #268: Build system must regenerate file when template changes
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/268/head:pr268
git
URL: https://github.com/freeipa/freeipa/pull/268
Author: pspacek
Title: #268: Build system must regenerate file when template changes
Action: opened
PR body:
"""
Proper fix for https://fedorahosted.org/freeipa/ticket/6498.
This PR obsoletes #251.
"""
To pull th
URL: https://github.com/freeipa/freeipa/pull/251
Title: #251: Add rebuild rule for template files
Label: +rejected
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/251
Title: #251: Add rebuild rule for template files
pspacek commented:
"""
I'm going to provide a proper fix as agreed on meeting today.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/251#issuecom
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
pspacek commented:
"""
@tiran You are right, I forgot to remove the `config.rpath` when
`AM_GNU_GETTEXT_VERSION` macro was introduced. This version fix
URL: https://github.com/freeipa/freeipa/pull/260
Author: pspacek
Title: #260: Build: fix path in ipa-ods-exporter.socket unit file
Action: opened
PR body:
"""
This fixes regression caused by incorrect
daemons/dnssec/ipa-ods-exporter.socket.in path template intro
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/1
Title: #1: Port bind-dyndb-ldap to BIND 9.11
pspacek commented:
"""
@stutiredboy There is probably a issue in path overriding logic. I will take
care of this in separate PR because it works when you have BIND 9.11 instal
URL: https://github.com/freeipa/bind-dyndb-ldap/pull/1
Title: #1: Port bind-dyndb-ldap to BIND 9.11
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/253
Title: #253: Add .eggs to Gitignore
pspacek commented:
"""
I'm using this script to build IPA:
~~~
rm -rvf ~/rpmbuild/{BUILD,BUILDROOT,SPECS,SOURCES,RPMS,SRPMS}
mkdir -pv ~/rpmbuild/{BUILD,BUILDROOT,SPECS,SOURCES,RPMS,SRPMS
URL: https://github.com/freeipa/freeipa/pull/251
Title: #251: Add rebuild rule for template files
pspacek commented:
"""
NACK:
- the variable is defined incorrectly, it should be in configure.ac (see
Automake manual chapter [16 Rebuilding
Makefiles](https://www.gnu.org/so
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
pspacek commented:
"""
Good catch, fixed & rebased on top of current master.
"""
See the full comment at
https://github.com/freeipa/freei
URL: https://github.com/freeipa/freeipa/pull/253
Title: #253: Add .eggs to Gitignore
pspacek commented:
"""
@tiran Please provide me a ticket number which is linked to the commits which
caused creation of .eggs. Thanks.
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
pspacek commented:
"""
As far as I can tell all the nits mentioned *above* are addressed in the last
version. Enjoy review :-)
"""
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
pspacek commented:
"""
This is rebased and fixed version. It should work including linters. Missing
things:
- [x] use fresh gettext files generated by auto
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
pspacek commented:
"""
As far as I can tell all the nits mentioned below are addressed in the last
version. Enjoy review :-)
"""
URL: https://github.com/freeipa/freeipa/pull/246
Title: #246: Build: ignore rpmbuild for lint target
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA:
URL: https://github.com/freeipa/freeipa/pull/195
Author: tiran
Title: #195: Make ipaclient pip install-able
Action: edited
Changed field: body
Original value:
"""
This makes ipaclient and dependencies pip install-able by adding install
requirements to all `setup.py`. A new make target
URL: https://github.com/freeipa/freeipa/pull/238
Title: #238: Build system refactoring phase 8: update translation system
pspacek commented:
"""
This is rebased and fixed version. It should work including linters. Missing
things:
- [ ] use fresh gettext files generated by auto
URL: https://github.com/freeipa/freeipa/pull/236
Title: #236: Build phase 7: cleanup
Label: +ack
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
URL: https://github.com/freeipa/freeipa/pull/236
Title: #236: Build phase 7: cleanup
pspacek commented:
"""
ACKing on behalf of Lukas.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/236#issuecomment-260776818
--
Manage your subscription for
URL: https://github.com/freeipa/freeipa/pull/236
Title: #236: Build phase 7: cleanup
pspacek commented:
"""
@lslebodn There is currently no plan to support distcheck: Python setuptools do
not support VPATH builds as AFAIK it is impossible to do that without patching
set
URL: https://github.com/freeipa/freeipa/pull/236
Title: #236: Build phase 7: cleanup
pspacek commented:
"""
Rebased.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/236#issuecomment-260769221
--
Manage your subscription for the Fre
URL: https://github.com/freeipa/freeipa/pull/236
Author: pspacek
Title: #236: Build phase 7: cleanup
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/236/head:pr236
git checkout pr236
From
URL: https://github.com/freeipa/freeipa/pull/236
Title: #236: Build phase 7: cleanup
pspacek commented:
"""
@lslebodn I've dropped the controversial patch which removes NULLs to allow you
to send PR which adds it everywhere as you proposed. I'm going to wait till
URL: https://github.com/freeipa/freeipa/pull/215
Title: #215: Add script to setup krb5 NFS exports
pspacek commented:
"""
It sounds to me that it could be an useful plugin for ipa-advise tool. This is
the tool which is supposed to given advies like 'install this and that' and s
URL: https://github.com/freeipa/freeipa/pull/237
Author: pspacek
Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs
option
Action: reopened
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/237
URL: https://github.com/freeipa/freeipa/pull/237
Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs
option
pspacek commented:
"""
Given the code change went to ipa-4-4 branch, I would merge it to ipa-4-4 as
well. It does not make sense to keep it only
URL: https://github.com/freeipa/freeipa/pull/236
Title: #236: Build phase 7: cleanup
pspacek commented:
"""
Hi Lukas. Given there is no technical justification to have it I'm going to
remove these. Simple is better than complex.
"""
See the full comment at
http
URL: https://github.com/freeipa/freeipa/pull/237
Author: pspacek
Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs
option
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/237
URL: https://github.com/freeipa/freeipa/pull/237
Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs
option
pspacek commented:
"""
Here you go.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/237#issuecomment-26028076
URL: https://github.com/freeipa/freeipa/pull/237
Author: pspacek
Title: #237: Update man page for ipa-adtrust-install by removing --no-msdcs
option
Action: opened
PR body:
"""
https://bugzilla.redhat.com/show_bug.cgi?id=1392778
"""
To pull the PR as Git br
URL: https://github.com/freeipa/freeipa/pull/236
Author: pspacek
Title: #236: Build phase 7: cleanup
Action: opened
PR body:
"""
Depends on PR #233.
- Clean-up ancient leftovers and clean minor bugs here and there.
- Support --enable-silent-rules and V=0 variable for make to
URL: https://github.com/freeipa/freeipa/pull/233
Author: pspacek
Title: #233: Build phase 6: %install cleanup
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/233/head:pr233
git checkout pr233
From
URL: https://github.com/freeipa/freeipa/pull/233
Title: #233: Build phase 6: %install cleanup
pspacek commented:
"""
I've fixed incorrect use of `-D` in `install` calls above.
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/233#issuecom
URL: https://github.com/freeipa/freeipa/pull/233
Author: pspacek
Title: #233: Build phase 6: %install cleanup
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/233/head:pr233
git checkout pr233
From
URL: https://github.com/freeipa/freeipa/pull/233
Title: #233: Build phase 6: %install cleanup
pspacek commented:
"""
@tiran Please re-review and set review status accordingly. Thanks!
"""
See the full comment at
https://github.com/freeipa/freeipa/pull/233#iss
URL: https://github.com/freeipa/freeipa/pull/233
Title: #233: Build phase 6: %install cleanup
pspacek commented:
"""
This version fixes the fixable issues, i.e. everything mentioned above except
changing file ownership.
"""
See the full comment at
https://githu
URL: https://github.com/freeipa/freeipa/pull/233
Author: pspacek
Title: #233: Build phase 6: %install cleanup
Action: synchronized
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/233/head:pr233
git checkout pr233
From
URL: https://github.com/freeipa/freeipa/pull/233
Title: #233: Build phase 6: %install cleanup
pspacek commented:
"""
> Failed to open: 'freeipa.spec.in', not a valid spec file.
Damn it! I added the last commit with comment in SPEC file and did not run
tests on that. Surp
URL: https://github.com/freeipa/freeipa/pull/213
Author: pspacek
Title: #213: Build system refactoring phase 3
Action: edited
Changed field: body
Original value:
"""
This monster patch-set refactors most of build system and moves most of the
logic from SPEC file
1 - 100 of 198 matches
Mail list logo
