Re: [Freeipa-devel] [PATCH] 0003 batch command can be used to trigger internal errors on server

2016-06-14 Thread Martin Basti
On 14.06.2016 08:04, Stanislav Laznicka wrote: On 06/13/2016 10:15 AM, Petr Vobornik wrote: On 06/10/2016 06:31 PM, Stanislav Laznicka wrote: On 06/08/2016 02:06 PM, Florence Blanc-Renaud wrote: On 06/08/2016 10:07 AM, Petr Spacek wrote: On 7.6.2016 15:11, Stanislav Laznicka wrote: Hello,

Re: [Freeipa-devel] [PATCH] 0003 batch command can be used to trigger internal errors on server

2016-06-14 Thread Stanislav Laznicka
On 06/13/2016 10:15 AM, Petr Vobornik wrote: On 06/10/2016 06:31 PM, Stanislav Laznicka wrote: On 06/08/2016 02:06 PM, Florence Blanc-Renaud wrote: On 06/08/2016 10:07 AM, Petr Spacek wrote: On 7.6.2016 15:11, Stanislav Laznicka wrote: Hello, Thank you for your patch. As the thin-client

Re: [Freeipa-devel] [PATCH] 0003 batch command can be used to trigger internal errors on server

2016-06-13 Thread Petr Vobornik
On 06/10/2016 06:31 PM, Stanislav Laznicka wrote: > On 06/08/2016 02:06 PM, Florence Blanc-Renaud wrote: >> On 06/08/2016 10:07 AM, Petr Spacek wrote: >>> On 7.6.2016 15:11, Stanislav Laznicka wrote: Hello, Thank you for your patch. As the thin-client patches were pushed in the

Re: [Freeipa-devel] [PATCH] 0003 batch command can be used to trigger internal errors on server

2016-06-10 Thread Stanislav Laznicka
On 06/08/2016 02:06 PM, Florence Blanc-Renaud wrote: On 06/08/2016 10:07 AM, Petr Spacek wrote: On 7.6.2016 15:11, Stanislav Laznicka wrote: Hello, Thank you for your patch. As the thin-client patches were pushed in the meantime, the patch won't apply. Could you please send a rebased version?

Re: [Freeipa-devel] [PATCH] 0003 batch command can be used to trigger internal errors on server

2016-06-08 Thread Stanislav Laznicka
On 06/08/2016 02:09 PM, Petr Vobornik wrote: On 06/08/2016 10:07 AM, Petr Spacek wrote: On 7.6.2016 15:11, Stanislav Laznicka wrote: Hello, Thank you for your patch. As the thin-client patches were pushed in the meantime, the patch won't apply. Could you please send a rebased version? Also,

Re: [Freeipa-devel] [PATCH] 0003 batch command can be used to trigger internal errors on server

2016-06-08 Thread Petr Vobornik
On 06/08/2016 10:07 AM, Petr Spacek wrote: > On 7.6.2016 15:11, Stanislav Laznicka wrote: >> Hello, >> >> Thank you for your patch. As the thin-client patches were pushed in the >> meantime, the patch won't apply. Could you please send a rebased version? >> >> Also, I have a few comments to the

Re: [Freeipa-devel] [PATCH] 0003 batch command can be used to trigger internal errors on server

2016-06-08 Thread Florence Blanc-Renaud
On 06/08/2016 10:07 AM, Petr Spacek wrote: On 7.6.2016 15:11, Stanislav Laznicka wrote: Hello, Thank you for your patch. As the thin-client patches were pushed in the meantime, the patch won't apply. Could you please send a rebased version? Also, I have a few comments to the patch: 1) I

Re: [Freeipa-devel] [PATCH] 0003 batch command can be used to trigger internal errors on server

2016-06-08 Thread Petr Spacek
On 7.6.2016 15:11, Stanislav Laznicka wrote: > Hello, > > Thank you for your patch. As the thin-client patches were pushed in the > meantime, the patch won't apply. Could you please send a rebased version? > > Also, I have a few comments to the patch: > > 1) I think that the commit message

Re: [Freeipa-devel] [PATCH] 0003 batch command can be used to trigger internal errors on server

2016-06-07 Thread Stanislav Laznicka
Hello, Thank you for your patch. As the thin-client patches were pushed in the meantime, the patch won't apply. Could you please send a rebased version? Also, I have a few comments to the patch: 1) I think that the commit message should be rather a brief conclusion to the changes made in

[Freeipa-devel] [PATCH] 0003 batch command can be used to trigger internal errors on server

2016-05-27 Thread Florence Blanc-Renaud
Hi all, the following patch checks the format of parameters passed to a method called through the batch command. I picked the ConversionError for invalid parameters format but this choice can be discussed if you have better suggestions... Fixes: https://fedorahosted.org/freeipa/ticket/5810