Re: [Freeipa-devel] [PATCH] 0016 user life cycle: Display the wrong attribute name when mandatory attribute is missing

2015-07-02 Thread Tomas Babej
On 07/02/2015 10:34 AM, thierry bordaz wrote: > On 07/01/2015 05:39 PM, Tomas Babej wrote: >> Hi Thierry, >> >> I think it would be better to use: >> >> error=_('Entry has no \'%s\'') % attr >> >> or even better, use named substitution: >> >> error=_('Entry has no \'%(attribute)s\'') % dict(attri

Re: [Freeipa-devel] [PATCH] 0016 user life cycle: Display the wrong attribute name when mandatory attribute is missing

2015-07-02 Thread thierry bordaz
On 07/01/2015 05:39 PM, Tomas Babej wrote: Hi Thierry, I think it would be better to use: error=_('Entry has no \'%s\'') % attr or even better, use named substitution: error=_('Entry has no \'%(attribute)s\'') % dict(attribute=attr) This way will generate a more readable strings for translat

Re: [Freeipa-devel] [PATCH] 0016 user life cycle: Display the wrong attribute name when mandatory attribute is missing

2015-07-01 Thread Tomas Babej
Hi Thierry, I think it would be better to use: error=_('Entry has no \'%s\'') % attr or even better, use named substitution: error=_('Entry has no \'%(attribute)s\'') % dict(attribute=attr) This way will generate a more readable strings for translators. Tomas -- Manage your subscription for

[Freeipa-devel] [PATCH] 0016 user life cycle: Display the wrong attribute name when mandatory attribute is missing

2015-07-01 Thread thierry bordaz
From 99d65933e49360750cf18f06315e1e259dd71126 Mon Sep 17 00:00:00 2001 From: Thierry Bordaz Date: Wed, 1 Jul 2015 14:46:22 +0200 Subject: [PATCH] Display the wrong attribute name when mandatory attribute is missing When activating a stageuser, if 'sn' or 'cn' or 'uid' is missing it displays an