Re: [Freeipa-devel] [PATCH] 0017 Do not require description in UI.

2014-10-01 Thread Martin Basti
On 29/09/14 12:57, Martin Kosek wrote: On 09/29/2014 11:04 AM, David Kupka wrote: On 09/29/2014 10:22 AM, Martin Kosek wrote: On 09/29/2014 10:09 AM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4387 The changes look OK so far, except the test fix. The test_batch_plugin.py

Re: [Freeipa-devel] [PATCH] 0017 Do not require description in UI.

2014-10-01 Thread Martin Kosek
On 10/01/2014 04:27 PM, Martin Basti wrote: On 29/09/14 12:57, Martin Kosek wrote: On 09/29/2014 11:04 AM, David Kupka wrote: On 09/29/2014 10:22 AM, Martin Kosek wrote: On 09/29/2014 10:09 AM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4387 The changes look OK so far, except

[Freeipa-devel] [PATCH] 0017 Do not require description in UI.

2014-09-29 Thread David Kupka
https://fedorahosted.org/freeipa/ticket/4387 -- David Kupka From 8a0ac7417e904c21946e08bbdd759550bffab5ad Mon Sep 17 00:00:00 2001 From: David Kupka dku...@redhat.com Date: Fri, 26 Sep 2014 02:54:28 -0400 Subject: [PATCH] Do not require description in UI. Description attribute is not required in

Re: [Freeipa-devel] [PATCH] 0017 Do not require description in UI.

2014-09-29 Thread Martin Kosek
On 09/29/2014 10:09 AM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4387 The changes look OK so far, except the test fix. The test_batch_plugin.py test is apparently testing that batch command behaves well in RequirementError for options. Thus, we should not remove it, we should

Re: [Freeipa-devel] [PATCH] 0017 Do not require description in UI.

2014-09-29 Thread David Kupka
On 09/29/2014 10:22 AM, Martin Kosek wrote: On 09/29/2014 10:09 AM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4387 The changes look OK so far, except the test fix. The test_batch_plugin.py test is apparently testing that batch command behaves well in RequirementError for

Re: [Freeipa-devel] [PATCH] 0017 Do not require description in UI.

2014-09-29 Thread Martin Kosek
On 09/29/2014 11:04 AM, David Kupka wrote: On 09/29/2014 10:22 AM, Martin Kosek wrote: On 09/29/2014 10:09 AM, David Kupka wrote: https://fedorahosted.org/freeipa/ticket/4387 The changes look OK so far, except the test fix. The test_batch_plugin.py test is apparently testing that batch