There was an error in number validation check. If boundary value was an
empty string, validation of a number always failed. This patch fixes the
problem by not performing the check in these cases.
Basic unit tests for IPA.metadata_validator created.
--
Petr Vobornik
From 4bde0e0f7dd1b02ce6ae1b3
On 9/11/2012 10:09 AM, Petr Vobornik wrote:
There was an error in number validation check. If boundary value was an
empty string, validation of a number always failed. This patch fixes the
problem by not performing the check in these cases.
Basic unit tests for IPA.metadata_validator created.
On 09/18/2012 04:45 AM, Endi Sukma Dewata wrote:
On 9/11/2012 10:09 AM, Petr Vobornik wrote:
There was an error in number validation check. If boundary value was an
empty string, validation of a number always failed. This patch fixes the
problem by not performing the check in these cases.
Basic
On 9/18/2012 6:36 AM, Petr Vobornik wrote:
Updated patch attached.
ACK.
1. Instead of IPA.not_defined() it might be better to call it
IPA.defined() to avoid double negations like this:
if (!IPA.not_defined(metadata.minvalue, true) ...
Function renamed, logic negated. Unit tests for IPA.
