[Freeipa-devel] [PATCH] 23 Allow one letter net/hostgroups names

2012-05-02 Thread Ondrej Hamada
https://fedorahosted.org/freeipa/ticket/2671 Changed regex validating net/hostgroup names to allow single letter names. Unit-tests added. But the current validation allows weird (host|net)group names like: ".", ".-", "..". I'm just not sure, do we really want to allow stuff like this? Patch

Re: [Freeipa-devel] [PATCH] 23 Allow one letter net/hostgroups names

2012-05-03 Thread Ondrej Hamada
On 05/02/2012 05:49 PM, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2671 Changed regex validating net/hostgroup names to allow single letter names. Unit-tests added. But the current validation allows weird (host|net)group names like: ".", ".-", "..". I'm just not sure, do we

Re: [Freeipa-devel] [PATCH] 23 Allow one letter net/hostgroups names

2012-05-03 Thread Martin Kosek
On Thu, 2012-05-03 at 17:08 +0200, Ondrej Hamada wrote: > On 05/02/2012 05:49 PM, Ondrej Hamada wrote: > > https://fedorahosted.org/freeipa/ticket/2671 > > > > Changed regex validating net/hostgroup names to allow single letter > > names. Unit-tests added. > > > > But the current validation a

Re: [Freeipa-devel] [PATCH] 23 Allow one letter net/hostgroups names

2012-05-04 Thread Ondrej Hamada
On 05/03/2012 05:44 PM, Martin Kosek wrote: On Thu, 2012-05-03 at 17:08 +0200, Ondrej Hamada wrote: On 05/02/2012 05:49 PM, Ondrej Hamada wrote: https://fedorahosted.org/freeipa/ticket/2671 Changed regex validating net/hostgroup names to allow single letter names. Unit-tests added. But the cu

Re: [Freeipa-devel] [PATCH] 23 Allow one letter net/hostgroups names

2012-05-06 Thread Martin Kosek
On Fri, 2012-05-04 at 10:37 +0200, Ondrej Hamada wrote: > On 05/03/2012 05:44 PM, Martin Kosek wrote: > > On Thu, 2012-05-03 at 17:08 +0200, Ondrej Hamada wrote: > >> On 05/02/2012 05:49 PM, Ondrej Hamada wrote: > >>> https://fedorahosted.org/freeipa/ticket/2671 > >>> > >>> Changed regex validating