Re: [Freeipa-devel] [PATCH] 232 Increase service startup timeout default

2014-01-17 Thread Martin Kosek
On 01/15/2014 05:38 PM, Alexander Bokovoy wrote: > On Wed, 15 Jan 2014, Jan Cholasta wrote: >> don't see why a single fix should be dispersed among multiple patches. > Patch attached, it obsoletes your patch 179. Thanks, but I don't understand why you squashed my patch 179 into yo

Re: [Freeipa-devel] [PATCH] 232 Increase service startup timeout default

2014-01-15 Thread Alexander Bokovoy
On Wed, 15 Jan 2014, Jan Cholasta wrote: don't see why a single fix should be dispersed among multiple patches. Patch attached, it obsoletes your patch 179. Thanks, but I don't understand why you squashed my patch 179 into your patch, the fixes are for separate issues (yield exception handling

Re: [Freeipa-devel] [PATCH] 232 Increase service startup timeout default

2014-01-15 Thread Jan Cholasta
On 15.1.2014 13:55, Alexander Bokovoy wrote: On Wed, 15 Jan 2014, Jan Cholasta wrote: On 15.1.2014 13:21, Alexander Bokovoy wrote: On Wed, 15 Jan 2014, Jan Cholasta wrote: On 15.1.2014 12:17, Martin Kosek wrote: On 01/15/2014 11:20 AM, Alexander Bokovoy wrote: On Wed, 15 Jan 2014, Jan Cholas

Re: [Freeipa-devel] [PATCH] 232 Increase service startup timeout default

2014-01-15 Thread Alexander Bokovoy
On Wed, 15 Jan 2014, Jan Cholasta wrote: On 15.1.2014 13:21, Alexander Bokovoy wrote: On Wed, 15 Jan 2014, Jan Cholasta wrote: On 15.1.2014 12:17, Martin Kosek wrote: On 01/15/2014 11:20 AM, Alexander Bokovoy wrote: On Wed, 15 Jan 2014, Jan Cholasta wrote: Hi, the attached patch should fix

Re: [Freeipa-devel] [PATCH] 232 Increase service startup timeout default

2014-01-15 Thread Jan Cholasta
On 15.1.2014 13:21, Alexander Bokovoy wrote: On Wed, 15 Jan 2014, Jan Cholasta wrote: On 15.1.2014 12:17, Martin Kosek wrote: On 01/15/2014 11:20 AM, Alexander Bokovoy wrote: On Wed, 15 Jan 2014, Jan Cholasta wrote: Hi, the attached patch should fix

Re: [Freeipa-devel] [PATCH] 232 Increase service startup timeout default

2014-01-15 Thread Alexander Bokovoy
On Wed, 15 Jan 2014, Jan Cholasta wrote: On 15.1.2014 12:17, Martin Kosek wrote: On 01/15/2014 11:20 AM, Alexander Bokovoy wrote: On Wed, 15 Jan 2014, Jan Cholasta wrote: Hi, the attached patch should fix . I have also attached patch 179, which f

Re: [Freeipa-devel] [PATCH] 232 Increase service startup timeout default

2014-01-15 Thread Jan Cholasta
On 15.1.2014 12:17, Martin Kosek wrote: On 01/15/2014 11:20 AM, Alexander Bokovoy wrote: On Wed, 15 Jan 2014, Jan Cholasta wrote: Hi, the attached patch should fix . I have also attached patch 179, which fixes a related bug in certificate renewal.

Re: [Freeipa-devel] [PATCH] 232 Increase service startup timeout default

2014-01-15 Thread Martin Kosek
On 01/15/2014 11:20 AM, Alexander Bokovoy wrote: > On Wed, 15 Jan 2014, Jan Cholasta wrote: >> Hi, >> >> the attached patch should fix . >> >> I have also attached patch 179, which fixes a related bug in certificate >> renewal. > > NACK for this part:

Re: [Freeipa-devel] [PATCH] 232 Increase service startup timeout default

2014-01-15 Thread Alexander Bokovoy
On Wed, 15 Jan 2014, Jan Cholasta wrote: Hi, the attached patch should fix . I have also attached patch 179, which fixes a related bug in certificate renewal. NACK for this part: This fixes a possible NSS database corruption in renew_ca_cert.

[Freeipa-devel] [PATCH] 232 Increase service startup timeout default

2014-01-15 Thread Jan Cholasta
Hi, the attached patch should fix . I have also attached patch 179, which fixes a related bug in certificate renewal. Honza -- Jan Cholasta >From b1d43e12aeecf5d5a98aad3f12c3d6bb8dd46453 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Tue, 1