[Freeipa-devel] [PATCH] 295 Fixed inconsistent required/optional attributes.

2011-10-20 Thread Endi Sukma Dewata
The dialogs and details pages have been modified to use the * symbol to mark required fields. The automount map and the DNS zone dialogs have been modified to update the required fields according to the input type. Ticket #1696 -- Endi S. Dewata From 1320f4fc2aee116909d13b2dc388b9642815a7d8 Mon

Re: [Freeipa-devel] [PATCH] 295 Fixed inconsistent required/optional attributes.

2011-10-21 Thread Petr Vobornik
On 10/20/2011 09:35 PM, Endi Sukma Dewata wrote: The dialogs and details pages have been modified to use the * symbol to mark required fields. The automount map and the DNS zone dialogs have been modified to update the required fields according to the input type. Ticket #1696 1) Wouldn't be b

Re: [Freeipa-devel] [PATCH] 295 Fixed inconsistent required/optional attributes.

2011-10-24 Thread Endi Sukma Dewata
On 10/21/2011 6:40 AM, Petr Vobornik wrote: 1) Wouldn't be better if the asterisk has different color than the label? Visually I don't like it that much and I think it can be overlook. Attaching a proposition. I used green IPAish color because red usually means error. Code from browser how it wa

Re: [Freeipa-devel] [PATCH] 295 Fixed inconsistent required/optional attributes.

2011-10-25 Thread Petr Vobornik
On 10/24/2011 10:43 PM, Endi Sukma Dewata wrote: On 10/21/2011 6:40 AM, Petr Vobornik wrote: 1) Wouldn't be better if the asterisk has different color than the label? Visually I don't like it that much and I think it can be overlook. Attaching a proposition. I used green IPAish color because red

Re: [Freeipa-devel] [PATCH] 295 Fixed inconsistent required/optional attributes.

2011-10-25 Thread Endi Sukma Dewata
On 10/25/2011 9:20 AM, Petr Vobornik wrote: ACK Pushed to master. Also proposing minor visual enhancement (see attached patch). ACK and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redha