[Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-05 Thread Martin Kosek
We allowed IP addresses without network specification which lead to unexpected results when the zone was being created. We should rather strictly require the prefix/netmask specifying the IP network that the reverse zone should be created for. This is already done in Web UI. A unit test exercising

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-05 Thread Jan Cholasta
Dne 5.9.2012 10:04, Martin Kosek napsal(a): We allowed IP addresses without network specification which lead to unexpected results when the zone was being created. We should rather strictly require the prefix/netmask specifying the IP network that the reverse zone should be created for. This is a

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-05 Thread Petr Spacek
On 09/05/2012 11:30 AM, Jan Cholasta wrote: Dne 5.9.2012 10:04, Martin Kosek napsal(a): We allowed IP addresses without network specification which lead to unexpected results when the zone was being created. We should rather strictly require the prefix/netmask specifying the IP network that the

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-05 Thread Martin Kosek
On 09/05/2012 12:22 PM, Petr Spacek wrote: > On 09/05/2012 11:30 AM, Jan Cholasta wrote: >> Dne 5.9.2012 10:04, Martin Kosek napsal(a): >>> We allowed IP addresses without network specification which lead >>> to unexpected results when the zone was being created. We should rather >>> strictly requi

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-05 Thread Jan Cholasta
Dne 5.9.2012 12:22, Petr Spacek napsal(a): On 09/05/2012 11:30 AM, Jan Cholasta wrote: Dne 5.9.2012 10:04, Martin Kosek napsal(a): We allowed IP addresses without network specification which lead to unexpected results when the zone was being created. We should rather strictly require the prefix

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-05 Thread Martin Kosek
On 09/05/2012 12:36 PM, Jan Cholasta wrote: > Dne 5.9.2012 12:22, Petr Spacek napsal(a): >> On 09/05/2012 11:30 AM, Jan Cholasta wrote: >>> Dne 5.9.2012 10:04, Martin Kosek napsal(a): We allowed IP addresses without network specification which lead to unexpected results when the zone was

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-05 Thread Adam Tkac
On Wed, Sep 05, 2012 at 12:48:22PM +0200, Martin Kosek wrote: > On 09/05/2012 12:36 PM, Jan Cholasta wrote: > > Dne 5.9.2012 12:22, Petr Spacek napsal(a): > >> On 09/05/2012 11:30 AM, Jan Cholasta wrote: > >>> Dne 5.9.2012 10:04, Martin Kosek napsal(a): > We allowed IP addresses without networ

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-05 Thread Jan Cholasta
Dne 5.9.2012 12:48, Martin Kosek napsal(a): On 09/05/2012 12:36 PM, Jan Cholasta wrote: Dne 5.9.2012 12:22, Petr Spacek napsal(a): On 09/05/2012 11:30 AM, Jan Cholasta wrote: Dne 5.9.2012 10:04, Martin Kosek napsal(a): We allowed IP addresses without network specification which lead to unexpe

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-05 Thread Adam Tkac
On Wed, Sep 05, 2012 at 01:02:35PM +0200, Jan Cholasta wrote: > Dne 5.9.2012 12:48, Martin Kosek napsal(a): > >On 09/05/2012 12:36 PM, Jan Cholasta wrote: > >>Dne 5.9.2012 12:22, Petr Spacek napsal(a): > >>>On 09/05/2012 11:30 AM, Jan Cholasta wrote: > Dne 5.9.2012 10:04, Martin Kosek napsal(a)

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-05 Thread Martin Kosek
On 09/05/2012 01:06 PM, Adam Tkac wrote: > On Wed, Sep 05, 2012 at 01:02:35PM +0200, Jan Cholasta wrote: >> Dne 5.9.2012 12:48, Martin Kosek napsal(a): >>> On 09/05/2012 12:36 PM, Jan Cholasta wrote: Dne 5.9.2012 12:22, Petr Spacek napsal(a): > On 09/05/2012 11:30 AM, Jan Cholasta wrote: >

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-05 Thread Petr Spacek
On 09/05/2012 01:18 PM, Martin Kosek wrote: >You are right, IPv6 networks could have default /64 prefix. However as I wrote >in different mail, I don't recommend to use default IPv4 prefix at all because >FreeIPA targets for company environments where /24 is not so common, not for >home environme

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-05 Thread Simo Sorce
On Wed, 2012-09-05 at 11:30 +0200, Jan Cholasta wrote: > Dne 5.9.2012 10:04, Martin Kosek napsal(a): > > We allowed IP addresses without network specification which lead > > to unexpected results when the zone was being created. We should rather > > strictly require the prefix/netmask specifying th

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-13 Thread Martin Kosek
On 09/05/2012 01:02 PM, Jan Cholasta wrote: > Dne 5.9.2012 12:48, Martin Kosek napsal(a): >> On 09/05/2012 12:36 PM, Jan Cholasta wrote: >>> Dne 5.9.2012 12:22, Petr Spacek napsal(a): On 09/05/2012 11:30 AM, Jan Cholasta wrote: > Dne 5.9.2012 10:04, Martin Kosek napsal(a): >> We allowe

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-17 Thread Rob Crittenden
Martin Kosek wrote: On 09/05/2012 01:02 PM, Jan Cholasta wrote: Dne 5.9.2012 12:48, Martin Kosek napsal(a): On 09/05/2012 12:36 PM, Jan Cholasta wrote: Dne 5.9.2012 12:22, Petr Spacek napsal(a): On 09/05/2012 11:30 AM, Jan Cholasta wrote: Dne 5.9.2012 10:04, Martin Kosek napsal(a): We allow

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-19 Thread Martin Kosek
On 09/17/2012 09:35 PM, Rob Crittenden wrote: > Martin Kosek wrote: >> On 09/05/2012 01:02 PM, Jan Cholasta wrote: >>> Dne 5.9.2012 12:48, Martin Kosek napsal(a): On 09/05/2012 12:36 PM, Jan Cholasta wrote: > Dne 5.9.2012 12:22, Petr Spacek napsal(a): >> On 09/05/2012 11:30 AM, Jan Cho

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-19 Thread Rob Crittenden
Martin Kosek wrote: On 09/17/2012 09:35 PM, Rob Crittenden wrote: Martin Kosek wrote: On 09/05/2012 01:02 PM, Jan Cholasta wrote: Dne 5.9.2012 12:48, Martin Kosek napsal(a): On 09/05/2012 12:36 PM, Jan Cholasta wrote: Dne 5.9.2012 12:22, Petr Spacek napsal(a): On 09/05/2012 11:30 AM, Jan Ch

Re: [Freeipa-devel] [PATCH] 302 Stricter IP network validator in dnszone-add command

2012-09-19 Thread Martin Kosek
On 09/19/2012 05:30 PM, Rob Crittenden wrote: > Martin Kosek wrote: >> On 09/17/2012 09:35 PM, Rob Crittenden wrote: >>> Martin Kosek wrote: On 09/05/2012 01:02 PM, Jan Cholasta wrote: > Dne 5.9.2012 12:48, Martin Kosek napsal(a): >> On 09/05/2012 12:36 PM, Jan Cholasta wrote: >>>