On 10.6.2014 01:52, Endi Sukma Dewata wrote:
On 6/9/2014 8:46 AM, Petr Vobornik wrote:
I've fixed issues #4, #2, #20 and #18. Commits in the branch, no rebase.
With these 4 changes we are ready for the push. I'll squash them, if
necessary.
You mean #11 instead of #2? The fixes are confirmed.
On 6/9/2014 8:46 AM, Petr Vobornik wrote:
I've fixed issues #4, #2, #20 and #18. Commits in the branch, no rebase.
With these 4 changes we are ready for the push. I'll squash them, if
necessary.
You mean #11 instead of #2? The fixes are confirmed.
2. If there's a login error, the logo and th
On 6.6.2014 20:35, Endi Sukma Dewata wrote:
On 6/6/2014 10:43 AM, Petr Vobornik wrote:
On 6.6.2014 15:45, Endi Sukma Dewata wrote:
On 6/5/2014 9:25 AM, Endi Sukma Dewata wrote:
ACK for patches #592-#628. I'll continue reviewing the rest.
ACK for patches #633-639, #642, #644, #652, and #653.
On 6/6/2014 10:43 AM, Petr Vobornik wrote:
On 6.6.2014 15:45, Endi Sukma Dewata wrote:
On 6/5/2014 9:25 AM, Endi Sukma Dewata wrote:
ACK for patches #592-#628. I'll continue reviewing the rest.
ACK for patches #633-639, #642, #644, #652, and #653. Patches #640 &
#641 have an issue (see #19 be
On 6.6.2014 15:45, Endi Sukma Dewata wrote:
On 6/5/2014 9:25 AM, Endi Sukma Dewata wrote:
ACK for patches #592-#628. I'll continue reviewing the rest.
ACK for patches #633-639, #642, #644, #652, and #653. Patches #640 &
#641 have an issue (see #19 below) that should be fixed before pushing.
Ot
On 6/5/2014 9:25 AM, Endi Sukma Dewata wrote:
ACK for patches #592-#628. I'll continue reviewing the rest.
ACK for patches #633-639, #642, #644, #652, and #653. Patches #640 &
#641 have an issue (see #19 below) that should be fixed before pushing.
Other issues are minor/unrelated/suggestions
ACK for patches #592-#628. I'll continue reviewing the rest.
There are some minor/unrelated issues I found while testing but they can
be addressed separately:
1. In the login page the message says "To login with username and
password, enter them in the fields below," but the fields are actual
On 26.5.2014 17:08, Petr Vobornik wrote:
On 19.5.2014 14:58, Petr Vobornik wrote:
On 12.5.2014 17:46, Misnyovszki Adam wrote:
Hi,
see my review notes below:
On Mon, 05 May 2014 18:41:13 +0200
Petr Vobornik wrote:
This patchset updates Bootstrap 2 based RCUE to Bootstrap 3 based
PatternFly (
On 19.5.2014 14:58, Petr Vobornik wrote:
On 12.5.2014 17:46, Misnyovszki Adam wrote:
Hi,
see my review notes below:
On Mon, 05 May 2014 18:41:13 +0200
Petr Vobornik wrote:
This patchset updates Bootstrap 2 based RCUE to Bootstrap 3 based
PatternFly (v0.2.4) according to plan described at:
h
On 12.5.2014 17:46, Misnyovszki Adam wrote:
Hi,
see my review notes below:
On Mon, 05 May 2014 18:41:13 +0200
Petr Vobornik wrote:
This patchset updates Bootstrap 2 based RCUE to Bootstrap 3 based
PatternFly (v0.2.4) according to plan described at:
http://www.redhat.com/archives/freeipa-deve
Hi,
see my review notes below:
On Mon, 05 May 2014 18:41:13 +0200
Petr Vobornik wrote:
> This patchset updates Bootstrap 2 based RCUE to Bootstrap 3 based
> PatternFly (v0.2.4) according to plan described at:
>
> http://www.redhat.com/archives/freeipa-devel/2014-April/msg00045.html
>
> The re
11 matches
Mail list logo
