Re: [Freeipa-devel] [PATCH] 736-740 webui: various minor fixes

2014-08-24 Thread Simo Sorce
On Fri, 2014-08-22 at 14:32 -0500, Endi Sukma Dewata wrote: > > If for some reason we decided to generate fingerprints in the UI, in > my opinion using WebCrypto will not pose any security problem or > mislead users into a false sense of security because the operation is > purely informational, it

Re: [Freeipa-devel] [PATCH] 736-740 webui: various minor fixes

2014-08-22 Thread Endi Sukma Dewata
On 8/22/2014 12:18 PM, Petr Vobornik wrote: On 22.8.2014 17:51, Simo Sorce wrote: On Fri, 2014-08-22 at 09:52 -0500, Endi Sukma Dewata wrote: On 8/21/2014 7:18 AM, Simo Sorce wrote: On Thu, 2014-08-21 at 14:11 +0200, Petr Vobornik wrote: On 13.8.2014 17:20, Endi Sukma Dewata wrote: 2. Can th

Re: [Freeipa-devel] [PATCH] 736-740 webui: various minor fixes

2014-08-22 Thread Petr Vobornik
On 22.8.2014 17:51, Simo Sorce wrote: On Fri, 2014-08-22 at 09:52 -0500, Endi Sukma Dewata wrote: On 8/21/2014 7:18 AM, Simo Sorce wrote: On Thu, 2014-08-21 at 14:11 +0200, Petr Vobornik wrote: On 13.8.2014 17:20, Endi Sukma Dewata wrote: 2. Can the UI parse the new key and display it the sam

Re: [Freeipa-devel] [PATCH] 736-740 webui: various minor fixes

2014-08-22 Thread Simo Sorce
On Fri, 2014-08-22 at 09:52 -0500, Endi Sukma Dewata wrote: > On 8/21/2014 7:18 AM, Simo Sorce wrote: > > On Thu, 2014-08-21 at 14:11 +0200, Petr Vobornik wrote: > >> On 13.8.2014 17:20, Endi Sukma Dewata wrote: > >>> 2. Can the UI parse the new key and display it the same way as other > >>> keys t

Re: [Freeipa-devel] [PATCH] 736-740 webui: various minor fixes

2014-08-22 Thread Endi Sukma Dewata
On 8/21/2014 7:18 AM, Simo Sorce wrote: On Thu, 2014-08-21 at 14:11 +0200, Petr Vobornik wrote: On 13.8.2014 17:20, Endi Sukma Dewata wrote: 2. Can the UI parse the new key and display it the same way as other keys that are already saved? That will make it more seamless. Would be nice, but is

Re: [Freeipa-devel] [PATCH] 736-740 webui: various minor fixes

2014-08-21 Thread Simo Sorce
On Thu, 2014-08-21 at 14:11 +0200, Petr Vobornik wrote: > > Would be nice, but is it worth the effort? We would have to > reimplement ipapython.ssh into JavaScript + pull in crypto.js or other > lib for sha1and sha256 functions since Web Cryptography API is still > only a draft [1]. I do not do t

Re: [Freeipa-devel] [PATCH] 736-740 webui: various minor fixes

2014-08-21 Thread Petr Vobornik
On 13.8.2014 17:20, Endi Sukma Dewata wrote: On 8/5/2014 6:43 AM, Petr Vobornik wrote: [PATCH] 736 webui: convert widget.less indentation to spaces ACK. [PATCH] 737 webui: improve rule table css - category radio line has line-height large enough to contain undo button -> content doesn't m

Re: [Freeipa-devel] [PATCH] 736-740 webui: various minor fixes

2014-08-13 Thread Endi Sukma Dewata
On 8/5/2014 6:43 AM, Petr Vobornik wrote: [PATCH] 736 webui: convert widget.less indentation to spaces ACK. [PATCH] 737 webui: improve rule table css - category radio line has line-height large enough to contain undo button -> content doesn't move several pixels on change - remove vertical

[Freeipa-devel] [PATCH] 736-740 webui: various minor fixes

2014-08-05 Thread Petr Vobornik
[PATCH] 736 webui: convert widget.less indentation to spaces [PATCH] 737 webui: improve rule table css - category radio line has line-height large enough to contain undo button -> content doesn't move several pixels on change - remove vertical padding from btns in table headers to maintain ab