Re: [Freeipa-devel] [PATCH] Splitting service principal into service name and hostname.

2010-09-10 Thread Adam Young
On 09/10/2010 12:49 PM, Endi Sukma Dewata wrote: Splitting service principal into service name and hostname. The EntityBuilder has been modified to obtain the pkey value by invoking getPKey(). This function can be overriden for different entities. The addOptionsFunction() has been renamed to ge

Re: [Freeipa-devel] [PATCH] Splitting service principal into service name and hostname.

2010-09-10 Thread Endi Sukma Dewata
- "Adam Young" wrote: > ACK, although > please add the following error check in add.js line 67ish > if (response.error){ > if (response.error.message){ > alert(response.error.message); > }else{ > alert("error adding entry"); > } > return; > } OK, fixed in the new attachment. Thanks! -- Endi

Re: [Freeipa-devel] [PATCH] Splitting service principal into service name and hostname.

2010-09-09 Thread Adam Young
On 09/09/2010 07:00 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! The EntityBuilder has been modified to obtain the pkey value by invoking getPKey(). This function can be overriden for different entities. The addOptionsFunction() has been renamed to getOptions() an

[Freeipa-devel] [PATCH] Splitting service principal into service name and hostname.

2010-09-09 Thread Endi Sukma Dewata
Hi, Please review the attached patch. Thanks! The EntityBuilder has been modified to obtain the pkey value by invoking getPKey(). This function can be overriden for different entities. The addOptionsFunction() has been renamed to getOptions() and it can be overriden for different entities. Each